baloghadamsoftware added a comment. In D81761#2097737 <https://reviews.llvm.org/D81761#2097737>, @Szelethus wrote:
> In D81761#2097561 <https://reviews.llvm.org/D81761#2097561>, @balazske wrote: > > > My observation is, if there is an example checker, it should be really > > "example" and not "test". (The "custom" is probably good to rename to > > "test" but not the "example".) (The names of these files look not good too: > > A **CheckerOptionHandling.cpp** contains an example checker, should be > > probably **CheckerOptionHandlingExample.cpp**). > > > That is indeed a very fair point. My rationale was that these examples are in > fact tested in the lit files, and my intention when writing them was to test > checker registration from plugins. +1 "example" should remain "example" or can be changed to "sample", but it is not a "test". Other parts of this patch seem to be OK for me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81761/new/ https://reviews.llvm.org/D81761 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
