[PATCH] D82085: [TRE] markTails marks call sites as tailcalls though some of them are not.

efriedma added a comment. All "tail" needs to mean is "this call does not reference the current function's stack." That's all, no more or less. The relevant documentation and APIs are a bit confusing. A "tail" marking is a prerequisite for tailcall optimization, but it's not really related to

[PATCH] D82029: [Coroutines] Ensure co_await promise.final_suspend() does not throw

lewissbaker added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:10521 +def err_coroutine_promise_final_suspend_requires_nothrow : Error< + "all code generated by co_await __promise.final_suspend() must not throw" +>; I'd perhaps w

[PATCH] D82085: [TRE] markTails marks call sites as tailcalls though some of them are not.

avl added a comment. > It makes sense to teach tail recursion elimination not to depend so heavily > on tail markings. But I don't think that implies we want to mess with the > markings themselves. Ok. Thus I need to drop part of this patch related to more strict tail marking, and continue wit

[clang] c45c161 - [PowerPC][Power10] Implement Parallel Bits Deposit/Extract Builtins in LLVM/Clang

Author: Amy Kwan Date: 2020-06-18T16:23:56-05:00 New Revision: c45c1611303b4609016fa69c1c987ede3bf92006 URL: https://github.com/llvm/llvm-project/commit/c45c1611303b4609016fa69c1c987ede3bf92006 DIFF: https://github.com/llvm/llvm-project/commit/c45c1611303b4609016fa69c1c987ede3bf92006.diff LOG:

[PATCH] D82029: [Coroutines] Ensure co_await promise.final_suspend() does not throw

lxfind marked an inline comment as done. lxfind added inline comments. Comment at: clang/test/SemaCXX/coroutine-final-suspend-noexcept.cpp:14 +struct coroutine_handle { + static coroutine_handle from_address(void *); // expected-note {{must be declared with 'noexcept'}} +}; ---

[PATCH] D80935: [PowerPC][Power10] Implement Parallel Bits Deposit/Extract Builtins in LLVM/Clang

This revision was automatically updated to reflect the committed changes. Closed by commit rGc45c1611303b: [PowerPC][Power10] Implement Parallel Bits Deposit/Extract Builtins in… (authored by amyk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80935

[PATCH] D74166: [AIX][Frontend] Static init implementation for AIX considering no priority

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast marked an inline comment as done. hubert.reinterpretcast added a comment. Thanks; LGTM with minor nit. Comment at: clang/lib/CodeGen/CodeGenModule.h:1060 + + /// Add a sterm finalizer to the C++ global clean

[clang] d8c9729 - [docs] Regenerate clang/docs/ClangCommandLineReference.rst

Author: Fangrui Song Date: 2020-06-18T14:52:39-07:00 New Revision: d8c9729216032e82adeb4965ae4e118c01f6b321 URL: https://github.com/llvm/llvm-project/commit/d8c9729216032e82adeb4965ae4e118c01f6b321 DIFF: https://github.com/llvm/llvm-project/commit/d8c9729216032e82adeb4965ae4e118c01f6b321.diff

[PATCH] D81923: [clang-tidy] Add modernize-use-ranges check.

njames93 updated this revision to Diff 271855. njames93 added a comment. Added `IncludeInserter` to include the `` header. Added support for reverse iteration controlled by config. Added support for begin/end calls via pointers. Made the begin/end call matcher more robust if other checks want to u

[PATCH] D82089: [clang-tidy] modernize-loop-convert reverse iteration support

njames93 updated this revision to Diff 271856. njames93 added a comment. - Change default c++20 include to `ranges` instead of `algorithm` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82089/new/ https://reviews.llvm.org/D82089 Files: clang-tool

[PATCH] D69088: [Lex] #pragma clang transform

Meinersbur added a comment. Herald added a subscriber: sstefan1. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69088/new/ https://reviews.llvm.org/D69088 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D82089: [clang-tidy] modernize-loop-convert reverse iteration support

njames93 added a comment. In D82089#2100802 , @Eugene.Zelenko wrote: > It'll be interesting to run improved check over LLVM code base. I haven't tried running it over llvm, but I have had success using it with clangd in my editor, every loop I've tried

[clang] ed1b556 - [NFC] Cleanup of EmitCXXGlobalInitFunc() and EmitCXXGlobalDtorFunc()

Author: Xiangling Liao Date: 2020-06-18T18:49:23-04:00 New Revision: ed1b556954eb2b1bb50db973860b7cf20494ce15 URL: https://github.com/llvm/llvm-project/commit/ed1b556954eb2b1bb50db973860b7cf20494ce15 DIFF: https://github.com/llvm/llvm-project/commit/ed1b556954eb2b1bb50db973860b7cf20494ce15.diff

[PATCH] D82130: [WebAssembly] Adding 64-bit versions of __stack_pointer and other globals

aardappel added a comment. This is a first iteration, probably needs more tests :) I was thinking of forking `userstack.ll` since it has most `__stack_pointer` tests, but I am not sure if it's that useful. Needs a test that uses the new wasm-ld flag. Opinions welcome. CHANGES SINCE LAST ACTIO

[PATCH] D82130: [WebAssembly] Adding 64-bit versions of __stack_pointer and other globals

aardappel updated this revision to Diff 271859. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82130/new/ https://reviews.llvm.org/D82130 Files: clang/lib/Driver/ToolChains/WebAssembly.cpp lld/wasm/Config.h lld/wasm/Driver.cpp lld/wasm/InputChunks.cpp lld/wasm/Options.td llvm/

[PATCH] D82130: [WebAssembly] Adding 64-bit versions of __stack_pointer and other globals

aardappel created this revision. aardappel added reviewers: sbc100, dschuff. Herald added subscribers: llvm-commits, cfe-commits, sunfish, aheejin, hiraditya, jgravelle-google. Herald added projects: clang, LLVM. aardappel updated this revision to Diff 271859. aardappel added a comment. This is a

[PATCH] D81816: [PowerPC] Add support for vector bool __int128 for Power10

saghir updated this revision to Diff 271860. saghir edited the summary of this revision. saghir added a comment. Updated comment to reflect the change in allowed types. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81816/new/ https://reviews.llvm.o

[PATCH] D81972: [NFC] Cleanup of EmitCXXGlobalInitFunc() and EmitCXXGlobalDtorFunc()

This revision was automatically updated to reflect the committed changes. Closed by commit rGed1b556954eb: [NFC] Cleanup of EmitCXXGlobalInitFunc() and EmitCXXGlobalDtorFunc() (authored by Xiangling_L). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D8

[clang] 3008609 - Hook up OpenBSD 64-bit PowerPC support

Author: Brad Smith Date: 2020-06-18T19:19:45-04:00 New Revision: 3008609d4509c3efc577c0ccbe9d80a8a2eef31a URL: https://github.com/llvm/llvm-project/commit/3008609d4509c3efc577c0ccbe9d80a8a2eef31a DIFF: https://github.com/llvm/llvm-project/commit/3008609d4509c3efc577c0ccbe9d80a8a2eef31a.diff LO

[PATCH] D76342: [OpenMP] Implement '#pragma omp tile'

Meinersbur added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76342/new/ https://reviews.llvm.org/D76342 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D81816: [PowerPC] Add support for vector bool __int128 for Power10

saghir updated this revision to Diff 271874. saghir added a reviewer: stefanp. saghir added a comment. Updated comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81816/new/ https://reviews.llvm.org/D81816 Files: clang/include/clang/Basic/Dia

[clang-tools-extra] 8b0df1c - [NFC] Refactor Registry loops to range for

Author: Nathan James Date: 2020-06-19T00:40:10+01:00 New Revision: 8b0df1c1a992d203212901c1139665261e0bbc1c URL: https://github.com/llvm/llvm-project/commit/8b0df1c1a992d203212901c1139665261e0bbc1c DIFF: https://github.com/llvm/llvm-project/commit/8b0df1c1a992d203212901c1139665261e0bbc1c.diff

[clang] 8b0df1c - [NFC] Refactor Registry loops to range for

Author: Nathan James Date: 2020-06-19T00:40:10+01:00 New Revision: 8b0df1c1a992d203212901c1139665261e0bbc1c URL: https://github.com/llvm/llvm-project/commit/8b0df1c1a992d203212901c1139665261e0bbc1c DIFF: https://github.com/llvm/llvm-project/commit/8b0df1c1a992d203212901c1139665261e0bbc1c.diff

[PATCH] D81168: Add support for DeclRefExpr in SyntaxTree, by generating IdExpressions

MaskRay added a comment. @eduucaldas Hi, you can drop `Reviewers:` `Subscribers:` `Tags:` and the text `Summary:` from the git commit with the following script: arcfilter () { arc amend git log -1 --pretty=%B | awk '/Reviewers:|Subscribers:/{p=1} /Reviewed By:|Differentia

[PATCH] D78190: Add Bfloat IR type

stuij marked an inline comment as done. stuij added inline comments. Comment at: llvm/include/llvm-c/Core.h:149 LLVMHalfTypeKind,/**< 16 bit floating point type */ + LLVMBFloatTypeKind, /**< 16 bit brain floating point type */ LLVMFloatTypeKind, /**< 32

[clang] 0f92096 - Revert "Hook up OpenBSD 64-bit PowerPC support"

Author: Brad Smith Date: 2020-06-18T20:05:39-04:00 New Revision: 0f92096c0a9aa97a2818a8cc8e23e0bfc5d3831f URL: https://github.com/llvm/llvm-project/commit/0f92096c0a9aa97a2818a8cc8e23e0bfc5d3831f DIFF: https://github.com/llvm/llvm-project/commit/0f92096c0a9aa97a2818a8cc8e23e0bfc5d3831f.diff LO

[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

nickdesaulniers added a comment. Ok, I think I have all feedback addresses locally. One issue I'm hitting is that I'm regressing clang/test/OpenMP/parallel_codegen.cpp. Specifically, it seems it has code like: template

[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

nickdesaulniers updated this revision to Diff 271884. nickdesaulniers added a comment. - rebase - make feature progression of debug-info-kind - fix docs (define, not declare) - add driver tests - use OptOutFFlag tablegen helper - rename helper to EmitAndRetainType - dont emit debug info for declar

[PATCH] D82130: [WebAssembly] Adding 64-bit versions of __stack_pointer and other globals

dschuff added a comment. Yeah I think a 64-bit version of userstack.ll makes sense. (a fork or a second set of CHECKs, whatever you think would be cleaner). There's also `stack-alignment.ll` which covers dynamic stack adjustment. Comment at: lld/wasm/Driver.cpp:385 +Stri

[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

nickdesaulniers updated this revision to Diff 271887. nickdesaulniers added a comment. - git clang-format HEAD~ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80242/new/ https://reviews.llvm.org/D80242 Files: clang/docs/ClangCommandLineReference.

[clang] c36b03e - The type of a reference to a non-type template parameter pack should

Author: Richard Smith Date: 2020-06-18T17:52:13-07:00 New Revision: c36b03e32556a966e584386ac7dbb110bc7e4bc5 URL: https://github.com/llvm/llvm-project/commit/c36b03e32556a966e584386ac7dbb110bc7e4bc5 DIFF: https://github.com/llvm/llvm-project/commit/c36b03e32556a966e584386ac7dbb110bc7e4bc5.diff

LLVM buildmaster will be updated and restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 8PM PST today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 9ca50e8 - [libTooling] Add parser for string representation of `RangeSelector`.

Author: Yitzhak Mandelbaum Date: 2020-06-19T01:11:29Z New Revision: 9ca50e887db7f903c04a90593d2beed8a96794f1 URL: https://github.com/llvm/llvm-project/commit/9ca50e887db7f903c04a90593d2beed8a96794f1 DIFF: https://github.com/llvm/llvm-project/commit/9ca50e887db7f903c04a90593d2beed8a96794f1.diff

[clang] 6f9fe31 - More test cleanup for c36b03e32556a966e584386ac7dbb110bc7e4bc5.

Author: Richard Smith Date: 2020-06-18T18:17:35-07:00 New Revision: 6f9fe31cff083c3bc93ffe9fa80346c1c594a359 URL: https://github.com/llvm/llvm-project/commit/6f9fe31cff083c3bc93ffe9fa80346c1c594a359 DIFF: https://github.com/llvm/llvm-project/commit/6f9fe31cff083c3bc93ffe9fa80346c1c594a359.diff

[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

dblaikie added inline comments. Comment at: clang/lib/CodeGen/CGDecl.cpp:103-118 + case Decl::CXXRecord: // struct/union/class X; [C++] +if (CGDebugInfo *DI = getDebugInfo()) + if (CGM.getCodeGenOpts().hasMaybeUnusedDebugInfo() && + cast(D).hasDefinition()) +

[PATCH] D82141: [sve][acle] Add SVE BFloat16 extensions.

fpetrogalli created this revision. fpetrogalli added reviewers: sdesmalen, ctetreau, efriedma, david-arm. Herald added subscribers: llvm-commits, cfe-commits, psnobl, rkruppe, hiraditya, kristof.beyls, tschuett. Herald added a reviewer: rengolin. Herald added projects: clang, LLVM. List of intrin

[PATCH] D65761: Add Windows Control Flow Guard checks (/guard:cf).

mehdi_amini added a comment. It seems like this pass was added in lib/Transforms but does not have any unit-tests (lit tests) provided. It isn't even linked into `opt`. As it is an LLVM IR pass it should be tested as such I believe. Can you provide tests for this? Repository: rG LLVM Github

[clang] 03b0831 - [AVR] Remove duplicate specification of lib directory

Author: Dylan McKay Date: 2020-06-19T17:35:09+12:00 New Revision: 03b0831144a9fe25aac81498b0a1dec82f4ec5df URL: https://github.com/llvm/llvm-project/commit/03b0831144a9fe25aac81498b0a1dec82f4ec5df DIFF: https://github.com/llvm/llvm-project/commit/03b0831144a9fe25aac81498b0a1dec82f4ec5df.diff L

[clang] aeaa09e - Revert "[AVR] Remove duplicate specification of lib directory"

Author: Dylan McKay Date: 2020-06-19T17:37:15+12:00 New Revision: aeaa09ec10ee41ef2469f4d69320d386d492bf23 URL: https://github.com/llvm/llvm-project/commit/aeaa09ec10ee41ef2469f4d69320d386d492bf23 DIFF: https://github.com/llvm/llvm-project/commit/aeaa09ec10ee41ef2469f4d69320d386d492bf23.diff L

[clang] 01741d6 - [AVR] Remove duplicate specification of lib directory

Author: Dylan McKay Date: 2020-06-19T17:39:18+12:00 New Revision: 01741d6dbec11c0a0c8e610f0033831735c78d1e URL: https://github.com/llvm/llvm-project/commit/01741d6dbec11c0a0c8e610f0033831735c78d1e DIFF: https://github.com/llvm/llvm-project/commit/01741d6dbec11c0a0c8e610f0033831735c78d1e.diff L

[PATCH] D77334: [AVR] Remove duplicate specification of lib directory

dylanmckay added a comment. Sorry, I lost track of this. Committed in 01741d6dbec11c0a0c8e610f0033831735c78d1e Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77334/new/ https://

[PATCH] D77334: [AVR] Remove duplicate specification of lib directory

This revision was automatically updated to reflect the committed changes. Closed by commit rG03b0831144a9: [AVR] Remove duplicate specification of lib directory (authored by dylanmckay). Changed prior to commit: https://reviews.llvm.org/D77334?vs=254606&id=271915#toc Repository: rG LLVM Gith

[PATCH] D78902: [Driver] Add output file to properties of Command

sepavloff updated this revision to Diff 271917. sepavloff added a comment. Rebased patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78902/new/ https://reviews.llvm.org/D78902 Files: clang/include/clang/Driver/Job.h clang/lib/Driver/Job.cpp

[PATCH] D78902: [Driver] Add output file to properties of Command

sepavloff updated this revision to Diff 271918. sepavloff added a comment. Clang-formatted the patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78902/new/ https://reviews.llvm.org/D78902 Files: clang/include/clang/Driver/Job.h clang/lib/Dri

[clang] c113b59 - [AArch64] Add clang command line support for -mharden-sls=

Author: Kristof Beyls Date: 2020-06-19T07:31:48+01:00 New Revision: c113b59ef52593818bcd207521fd490ba3deeaea URL: https://github.com/llvm/llvm-project/commit/c113b59ef52593818bcd207521fd490ba3deeaea DIFF: https://github.com/llvm/llvm-project/commit/c113b59ef52593818bcd207521fd490ba3deeaea.diff

[clang] 493d805 - [AST] Dump containsErrors bit for the Type.

Author: Haojian Wu Date: 2020-06-19T08:45:46+02:00 New Revision: 493d8059f3991e35c9d4dd1cb6cbeade426dc0ea URL: https://github.com/llvm/llvm-project/commit/493d8059f3991e35c9d4dd1cb6cbeade426dc0ea DIFF: https://github.com/llvm/llvm-project/commit/493d8059f3991e35c9d4dd1cb6cbeade426dc0ea.diff LO

[PATCH] D81407: [Analyzer][StreamChecker] Add note tags for file opening.

balazske added a comment. I do not understand fully this "globally". A new option should be added that affects all checkers that detect some kind of resource leak? And then implement that kind of report uniqueness in all checkers that detect resource leak. Other possible solution: Leave the cur

[PATCH] D81912: [AST] Dump containsErrors bit for the Type.

This revision was automatically updated to reflect the committed changes. hokein marked an inline comment as done. Closed by commit rG493d8059f399: [AST] Dump containsErrors bit for the Type. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D81404: [AArch64] Add clang command line support for -mharden-sls=

This revision was automatically updated to reflect the committed changes. Closed by commit rGc113b59ef525: [AArch64] Add clang command line support for -mharden-sls= (authored by kristof.beyls). Changed prior to commit: https://reviews.llvm.org/D81404?vs=269247&id=271925#toc Repository: rG L

<    1   2   3