nickdesaulniers added a comment.

Ok, I think I have all feedback addresses locally.  One issue I'm hitting is 
that I'm regressing clang/test/OpenMP/parallel_codegen.cpp.  Specifically, it 
seems it has code like:

  template <typename T>                                                         
                                                                                
                                                                                
                      
  int tmain(T argc) {                                                           
                                                                                
                                                                                
                      
    typedef double (*chunk_t)[argc[0][0]];
  ...

I'm not sure what type `chunk_t` is exactly, but my brain can't parse it.  
Function pointer that returns double (no parameter list?) array? WTF


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80242/new/

https://reviews.llvm.org/D80242



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to