[PATCH] D81600: [analyzer] SATest: Fix package versions for test dependencies

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Yes please! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81600/new/ https://reviews.llvm.org/D81600 __

[PATCH] D82092: [analyzer] Handle `\l` symbol in Windows specific file paths in exploded-graph-rewriter

NoQ added a comment. In D82092#2100973 , @vsavchenko wrote: > Additionally, I want to make a note that we are not really working hard on > keeping all the scripts and the analyzer itself to be fully functional on > Windows. Yup. See also D76768

[PATCH] D82092: [analyzer] Handle `\l` symbol in Windows specific file paths in exploded-graph-rewriter

NoQ added inline comments. Comment at: clang/utils/analyzer/exploded-graph-rewriter.py:383 +# when directory name starts with the letter `l`. +if sys.platform == 'win32': +# Find all `\l` (like `,\l`, `}\l`, `[\l`) except `\\l`, ---

[PATCH] D82092: [analyzer] Handle `\l` symbol in Windows specific file paths in exploded-graph-rewriter

NoQ added a comment. Nice catch! Comment at: clang/utils/analyzer/exploded-graph-rewriter.py:383 +# when directory name starts with the letter `l`. +if sys.platform == 'win32': +# Find all `\l` (like `,\l`, `}\l`, `[\l`) except `\\l`, ---

[PATCH] D74166: [AIX][Frontend] Static init implementation for AIX considering no priority

jasonliu added inline comments. Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:345 +// rarely. +Weights = nullptr; + } else if (Kind == GuardKind::VariableGuard && !D->isLocalVarDecl()) { Do we need to change/complicate the interface for this function, just

[clang-tools-extra] 850bb88 - [clang-tidy] RenamerClangTidy group redecls into 1 warning.

Author: Nathan James Date: 2020-06-18T15:50:16+01:00 New Revision: 850bb889a56ccf3252792c6d3db59542e94753ae URL: https://github.com/llvm/llvm-project/commit/850bb889a56ccf3252792c6d3db59542e94753ae DIFF: https://github.com/llvm/llvm-project/commit/850bb889a56ccf3252792c6d3db59542e94753ae.diff

[PATCH] D81571: [analyzer] SATest: Add initial docker infrastructure

vsavchenko marked 5 inline comments as done. vsavchenko added inline comments. Comment at: clang/utils/analyzer/Dockerfile:10 + +# newer CMake is required by LLVM +RUN wget -O - https://apt.kitware.com/keys/kitware-archive-latest.asc 2>/dev/null | gpg --dearmor - | tee /etc/apt/

[PATCH] D80833: [CodeView] Add full repro to LF_BUILDINFO record

aganea added a comment. Thanks for taking the time @hans, @amccarth! I've split this into several smaller patches, to ease bisect if needs be: rGa45409d8855a1e4538990507ef25e9b51c090193 - [Clang] Move clang::Job::printArg to

[PATCH] D82099: [AST][RecoveryAST] Populate error-bit from Type to Expr.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: clang. Looks like this is a fallout when we introduce the error-bit in Type. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D82099 Files: clang/include/clang/AST/DependenceFlags.h clan

[PATCH] D80833: [CodeView] Add full repro to LF_BUILDINFO record

thakis added a comment. Looks like this breaks tests on mac: http://45.33.8.238/mac/15751/step_10.txt Please take a look. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80833/new/ https://reviews.llvm.org/D80833 _

[PATCH] D81592: [analyzer] SATest: Add a set of initial projects for testing

vsavchenko marked an inline comment as done. vsavchenko added inline comments. Comment at: clang/utils/analyzer/projects/box2d/run_static_analyzer.cmd:1 +cmake . -DCMAKE_BUILD_TYPE=Release -Bbuild -GNinja +cmake --build build NoQ wrote: > Is there a flag to enabl

[PATCH] D79249: [NOT FOR REVIEW] Experimental support for zero-or-trap behavior foruninitialized variables.

jdoerfert added a comment. FWIW, I tried to solve something similar the other day. My solution sketch looked like this: https://godbolt.org/z/bRQPjd The idea would be that we teach DSE (and others) to remove the `llvm.undef.init` intrinsic if the location is overwritten. In the example above onl

[PATCH] D81598: [analyzer] SATest: Add an easy option to connect to docker for debugging

vsavchenko marked an inline comment as done. vsavchenko added inline comments. Comment at: clang/utils/analyzer/entrypoint.py:23 +while True: +sleep(3600) + NoQ wrote: > I request comments (: Yeah, I guess it can be quite confusing when you read only

[PATCH] D81601: [analyzer] SATest: Use logger in single-threaded mode as well

vsavchenko marked an inline comment as done. vsavchenko added inline comments. Comment at: clang/utils/analyzer/SATestBuild.py:650 Logger = logging.getLogger(test_info.project.name) LOCAL.stdout = StreamToLogger(Logger, logging.INFO) --

[PATCH] D79755: Implement constexpr BinaryOperator for vector types

erichkeane updated this revision to Diff 271713. erichkeane marked 9 inline comments as done. erichkeane added a comment. @AaronBallman's suggestions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79755/new/ https://reviews.llvm.org/D79755 Files: clang/lib/AST/ExprConstant.cpp clan

[PATCH] D80712: [SVE] Add checks for no warnings in SVE tests

thakis added inline comments. Comment at: clang/test/CodeGen/aarch64-sve-intrinsics/acle_sve_adda.c:3 // RUN: %clang_cc1 -D__ARM_FEATURE_SVE -DSVE_OVERLOADED_FORMS -triple aarch64-none-linux-gnu -target-feature +sve -fallow-half-arguments-and-returns -S -O1 -Werror -Wall -emit

[PATCH] D82059: [clang-tidy] RenamerClangTidy group redecls into 1 warning.

This revision was automatically updated to reflect the committed changes. Closed by commit rG850bb889a56c: [clang-tidy] RenamerClangTidy group redecls into 1 warning. (authored by njames93). Changed prior to commit: https://reviews.llvm.org/D82059?vs=271509&id=271722#toc Repository: rG LLVM

[PATCH] D82089: [clang-tidy] modernize-loop-convert reverse iteration support

njames93 updated this revision to Diff 271723. njames93 marked 4 inline comments as done. njames93 added a comment. Address reviewer comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82089/new/ https://reviews.llvm.org/D82089 Files: clang-

[PATCH] D80753: [clang-tidy] remove duplicate fixes of alias checkers

njames93 accepted this revision. njames93 added a comment. LG, I have nothing else to add here. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80753/new/ https://reviews.llvm.org/D80753 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] d9b8aad - [clang-tidy] Add --use-color command line option and UseColor option to control colors in diagnostics

Author: hyd-dev Date: 2020-06-18T16:16:14+01:00 New Revision: d9b8aada8288ca4aff4a1d70bf5eb4d579c79036 URL: https://github.com/llvm/llvm-project/commit/d9b8aada8288ca4aff4a1d70bf5eb4d579c79036 DIFF: https://github.com/llvm/llvm-project/commit/d9b8aada8288ca4aff4a1d70bf5eb4d579c79036.diff LOG:

[clang] b4c7a75 - Don't require shell in clang/test/CodeGen/aarch64-sve-intrinsics/acle_sve_adda.c

Author: Hans Wennborg Date: 2020-06-18T17:21:48+02:00 New Revision: b4c7a7542f482b4e1ac1d3936314fafd30b3b8db URL: https://github.com/llvm/llvm-project/commit/b4c7a7542f482b4e1ac1d3936314fafd30b3b8db DIFF: https://github.com/llvm/llvm-project/commit/b4c7a7542f482b4e1ac1d3936314fafd30b3b8db.diff

[PATCH] D27651: [clang-format] Even with AlignConsecutiveDeclarations, PointerAlignment: Right should keep *s and &s to the right

ambroyz added a comment. topic, please, don't die CHANGES SINCE LAST ACTION https://reviews.llvm.org/D27651/new/ https://reviews.llvm.org/D27651 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listin

[PATCH] D82103: [analyzer] Remove forbidden characters from a SourceLocation filename for a graph dump on Windows

ASDenysPetrov created this revision. ASDenysPetrov added reviewers: Charusso, NoQ. ASDenysPetrov added a project: clang. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Windows forbidden file path characters

[PATCH] D82102: [AST][RecoveryExpr] Populate the error-bit from template arguments to TemplateSepcializationType.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D82102 Files: clang/lib/AST/Type.cpp clang/test/SemaCXX/invalid-template-base-specifier.cpp Index: clang/test/SemaCXX/invalid-temp

[PATCH] D79477: [clang-tidy] Add --use-color command line option and UseColor option to control colors in diagnostics

This revision was automatically updated to reflect the committed changes. Closed by commit rGd9b8aada8288: [clang-tidy] Add --use-color command line option and UseColor option to control… (authored by hyd-dev, committed by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D81912: [AST] Dump containsErrors bit for the Type.

hokein updated this revision to Diff 271733. hokein added a comment. address comment: emit the error-bit with color. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81912/new/ https://reviews.llvm.org/D81912 Files: clang/lib/AST/JSONNodeDumper.cpp

[PATCH] D82081: [z/OS] Add binary format goff and operating system zos to the triple

tahonermann added a comment. @Kai, I'm afraid I won't be able to assist much in reviews of most z/OS related patches (due to lack of time and lack of expertise with various parts of z/OS), but please do copy me on anything related to source and execution character set encoding or conversions, h

[PATCH] D81311: [RFC] LangRef: Define byref parameter attribute

arsenm updated this revision to Diff 271732. arsenm retitled this revision from "[RFC] LangRef: Define inmem parameter attribute" to "[RFC] LangRef: Define byref parameter attribute". arsenm added a comment. Rename to byref. Specify more explicitly this is for the ABI, and should not be inferred

[libunwind] 2d865cc - unwind: EHABISectionIterator `operator!=`, constify `operator-`

Author: Saleem Abdulrasool Date: 2020-06-18T08:54:34-07:00 New Revision: 2d865ccbd8c47fe94af04a6cffd02c45a24e2ffb URL: https://github.com/llvm/llvm-project/commit/2d865ccbd8c47fe94af04a6cffd02c45a24e2ffb DIFF: https://github.com/llvm/llvm-project/commit/2d865ccbd8c47fe94af04a6cffd02c45a24e2ffb.

[clang] 1ec469c - [OPENMP50]Codegen for scan directives in parallel for regions.

Author: Alexey Bataev Date: 2020-06-18T11:56:55-04:00 New Revision: 1ec469cf4c20a0f80ab6507e3838cfcc3e4f9595 URL: https://github.com/llvm/llvm-project/commit/1ec469cf4c20a0f80ab6507e3838cfcc3e4f9595 DIFF: https://github.com/llvm/llvm-project/commit/1ec469cf4c20a0f80ab6507e3838cfcc3e4f9595.diff

[PATCH] D81311: [RFC] LangRef: Define byref parameter attribute

jdoerfert added a comment. LGTM, @rjmccall wdyt? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81311/new/ https://reviews.llvm.org/D81311 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinf

[PATCH] D81959: [HIP] Enable -amdgpu-internalize-symbols

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/lib/Driver/ToolChains/HIP.cpp:64-65 +"-shared", +"-mllvm", +"-amdgpu-internalize-symbols", +"-o

[PATCH] D81478: [OPENMP50]Codegen for scan directives in parallel for regions.

This revision was automatically updated to reflect the committed changes. Closed by commit rG1ec469cf4c20: [OPENMP50]Codegen for scan directives in parallel for regions. (authored by ABataev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81478/new/

[PATCH] D80833: [CodeView] Add full repro to LF_BUILDINFO record

aganea added a comment. In D80833#2101057 , @thakis wrote: > Looks like this breaks tests on mac: http://45.33.8.238/mac/15751/step_10.txt > > Please take a look. Checking now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[clang] 4971d0b - [OPENMP50]Allow nonmonotonic modifier for all schedule kinds.

Author: Alexey Bataev Date: 2020-06-18T12:30:50-04:00 New Revision: 4971d0b8ec6e8d3b9ea5980d96cf5812886671df URL: https://github.com/llvm/llvm-project/commit/4971d0b8ec6e8d3b9ea5980d96cf5812886671df DIFF: https://github.com/llvm/llvm-project/commit/4971d0b8ec6e8d3b9ea5980d96cf5812886671df.diff

[clang] 3e59dfc - [llvm][SveEmitter] Emit the bfloat version of `svld1ro`.

Author: Francesco Petrogalli Date: 2020-06-18T16:36:31Z New Revision: 3e59dfc301240ffb5e82bc43e05225d0d51d5cfa URL: https://github.com/llvm/llvm-project/commit/3e59dfc301240ffb5e82bc43e05225d0d51d5cfa DIFF: https://github.com/llvm/llvm-project/commit/3e59dfc301240ffb5e82bc43e05225d0d51d5cfa.dif

[PATCH] D81885: [Coroutines] Return false on error of buildSuspends

modocache requested changes to this revision. modocache added a comment. This revision now requires changes to proceed. I don't have a preference as to whether `Sema::ActOnCoroutineBodyStart` returns `true` or `false` to indicate failure, although I think returning `true` for failures is a bit o

[PATCH] D81304: [llvm][SveEmitter] Emit the bfloat version of `svld1ro`.

stuij accepted this revision. stuij added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81304/new/ https://reviews.llvm.org/D81304 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D78903: [Driver] Add option -fproc-stat-report

sepavloff added a comment. Thank you @aganea ! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78903/new/ https://reviews.llvm.org/D78903 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[PATCH] D81168: Add support for DeclRefExpr in SyntaxTree, by generating IdExpressions

eduucaldas updated this revision to Diff 271744. eduucaldas marked 12 inline comments as done. eduucaldas added a comment. Aswering comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81168/new/ https://reviews.llvm.org/D81168 Files: clang/in

[PATCH] D78190: Add Bfloat IR type

stuij marked an inline comment as done. stuij added inline comments. Comment at: llvm/include/llvm-c/Core.h:149 LLVMHalfTypeKind,/**< 16 bit floating point type */ + LLVMBFloatTypeKind, /**< 16 bit brain floating point type */ LLVMFloatTypeKind, /**< 32

[PATCH] D74166: [AIX][Frontend] Static init implementation for AIX considering no priority

Xiangling_L updated this revision to Diff 271747. Xiangling_L marked 3 inline comments as done. Xiangling_L added a comment. Removed a redundant header file; Addressed comments; CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74166/new/ https://reviews.llvm.org/D74166 Files: clang/incl

[PATCH] D80833: [CodeView] Add full repro to LF_BUILDINFO record

thakis added a comment. Failing on Windows too, actually: http://45.33.8.238/win/17931/step_10.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80833/new/ https://reviews.llvm.org/D80833 ___ cfe-commi

[PATCH] D81168: Add support for DeclRefExpr in SyntaxTree, by generating IdExpressions

eduucaldas marked 2 inline comments as done. eduucaldas added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Nodes.h:190 +return N->kind() == NodeKind::NameSpecifier; + } +}; eduucaldas wrote: > gribozavr2 wrote: > > Should there be getters

[PATCH] D74166: [AIX][Frontend] Static init implementation for AIX considering no priority

Xiangling_L added inline comments. Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:345 +// rarely. +Weights = nullptr; + } else if (Kind == GuardKind::VariableGuard && !D->isLocalVarDecl()) { jasonliu wrote: > Do we need to change/complicate the interface fo

[PATCH] D82026: [OPENMP50]Allow nonmonotonic modifier for all schedule kinds.

This revision was automatically updated to reflect the committed changes. Closed by commit rG4971d0b8ec6e: [OPENMP50]Allow nonmonotonic modifier for all schedule kinds. (authored by ABataev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82026/new/

[PATCH] D81304: [llvm][SveEmitter] Emit the bfloat version of `svld1ro`.

This revision was automatically updated to reflect the committed changes. Closed by commit rG3e59dfc30124: [llvm][SveEmitter] Emit the bfloat version of `svld1ro`. (authored by fpetrogalli). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81304/new/ h

[PATCH] D81672: [Driver] When forcing a crash call abort to get the correct diagnostic

john.brawn marked an inline comment as done. john.brawn added inline comments. Comment at: clang/tools/driver/driver.cpp:518 + CRC.DumpStackAndCleanupOnFailure = true; + CRC.RunSafely([&]() { abort(); }); } aganea wrote: > The only concern I have i

[clang] ead7a8b - [update_cc_test_checks.py] Correctly skip function definitions

Author: Alex Richardson Date: 2020-06-18T18:09:21+01:00 New Revision: ead7a8beccc18c2cbcde980d2f593267d63c5dc2 URL: https://github.com/llvm/llvm-project/commit/ead7a8beccc18c2cbcde980d2f593267d63c5dc2 DIFF: https://github.com/llvm/llvm-project/commit/ead7a8beccc18c2cbcde980d2f593267d63c5dc2.dif

[clang] 3ce0e92 - [update_cc_test_checks.py] Handle C++ methods

Author: Alex Richardson Date: 2020-06-18T18:09:21+01:00 New Revision: 3ce0e92f45f56fc1b93db35dec8c53dceb5c54a5 URL: https://github.com/llvm/llvm-project/commit/3ce0e92f45f56fc1b93db35dec8c53dceb5c54a5 DIFF: https://github.com/llvm/llvm-project/commit/3ce0e92f45f56fc1b93db35dec8c53dceb5c54a5.dif

[clang] ce82b8e - [HIP] Improve check patterns to avoid test failures in case string "opt",

Author: Hiroshi Yamauchi Date: 2020-06-18T10:14:31-07:00 New Revision: ce82b8e8af6d9e95e15624c4fb8af2faac68ff63 URL: https://github.com/llvm/llvm-project/commit/ce82b8e8af6d9e95e15624c4fb8af2faac68ff63 DIFF: https://github.com/llvm/llvm-project/commit/ce82b8e8af6d9e95e15624c4fb8af2faac68ff63.di

[PATCH] D81672: [Driver] When forcing a crash call abort to get the correct diagnostic

john.brawn updated this revision to Diff 271757. john.brawn edited the summary of this revision. john.brawn added a comment. Herald added subscribers: llvm-commits, hiraditya. Herald added a project: LLVM. Moved BugReportMsg printing into CrashRecoveryContext, and stopped printing of backtrace wh

[PATCH] D75229: [clang-tidy] Add signal-in-multithreaded-program check

abelkocsis marked an inline comment as done. abelkocsis added inline comments. Comment at: clang-tools-extra/clang-tidy/cert/CERTTidyModule.cpp:88 // C checkers // CON Eugene.Zelenko wrote: > Please use //check// here. Should I replace the `// C++ che

[PATCH] D81868: [libTooling] Add parser for string representation of `RangeSelector`.

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Tooling/Transformer/Parsing.cpp:169 + +// For consistency with matcher parser and C++ code, node id's are written as +// strings. However, w

[PATCH] D80301: [yaml][clang-tidy] Fix new line YAML serialization

DmitryPolukhin added a comment. @njames93 - friendly ping, could you please take another look. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80301/new/ https://reviews.llvm.org/D80301 ___ cfe-commits m

[PATCH] D81168: Add support for DeclRefExpr in SyntaxTree, by generating IdExpressions

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Tooling/Syntax/Nodes.cpp:182 + for (auto *C = firstChild(); C; C = C->nextSibling()) { +if (C->role() == syntax::NodeRole::NestedNameSp

[PATCH] D74166: [AIX][Frontend] Static init implementation for AIX considering no priority

jasonliu accepted this revision. jasonliu added a comment. This revision is now accepted and ready to land. LGTM. But I suggest to wait for @hubert.reinterpretcast to have another scan at this before landing. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74166/new/ https://reviews.llvm

[clang] 437cbad - [OPENMP]Fix PR46357: Do not allow types declarations in pragmas.

Author: Alexey Bataev Date: 2020-06-18T13:17:03-04:00 New Revision: 437cbad3b35c7cf0f49d2bcea0a521651113 URL: https://github.com/llvm/llvm-project/commit/437cbad3b35c7cf0f49d2bcea0a521651113 DIFF: https://github.com/llvm/llvm-project/commit/437cbad3b35c7cf0f49d2bcea0a521651113.diff

[PATCH] D75229: [clang-tidy] Add signal-in-multithreaded-program check

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/cert/CERTTidyModule.cpp:88 // C checkers // CON abelkocsis wrote: > Eugene.Zelenko wrote: > > Please use //check// here. > Should I replace the `// C++ checkers` comment to

[PATCH] D80914: [update_cc_test_checks.py] Handle C++ methods

This revision was automatically updated to reflect the committed changes. Closed by commit rG3ce0e92f45f5: [update_cc_test_checks.py] Handle C++ methods (authored by arichardson). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80914/new/ https://revi

[PATCH] D82046: [HIP] Improve check patterns to avoid test failures in case string "opt",etc. happens to be in the InstallDir path in the -### output.

This revision was automatically updated to reflect the committed changes. Closed by commit rGce82b8e8af6d: [HIP] Improve check patterns to avoid test failures in case string "opt", etc. (authored by yamauchi). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D80913: [update_cc_test_checks.py] Correctly skip function definitions

This revision was automatically updated to reflect the committed changes. Closed by commit rGead7a8beccc1: [update_cc_test_checks.py] Correctly skip function definitions (authored by arichardson). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80913/n

[PATCH] D82019: [OPENMP]Fix PR46357: Do not allow types declarations in pragmas.

This revision was automatically updated to reflect the committed changes. Closed by commit rG437cbad3b35c: [OPENMP]Fix PR46357: Do not allow types declarations in pragmas. (authored by ABataev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82019/new

[clang] 0357956 - [ARM][bfloat] Do not coerce bfloat arguments and returns to integers

Author: Ties Stuij Date: 2020-06-18T18:26:01+01:00 New Revision: 035795659b604246b873f659f8feed8084898247 URL: https://github.com/llvm/llvm-project/commit/035795659b604246b873f659f8feed8084898247 DIFF: https://github.com/llvm/llvm-project/commit/035795659b604246b873f659f8feed8084898247.diff LO

[clang] eed45b5 - [OPENMP][DOCS]Update status of supported constructs, NFC.

Author: Alexey Bataev Date: 2020-06-18T13:29:33-04:00 New Revision: eed45b5fa2b638360ebfde037d284b9dc69e54c0 URL: https://github.com/llvm/llvm-project/commit/eed45b5fa2b638360ebfde037d284b9dc69e54c0 DIFF: https://github.com/llvm/llvm-project/commit/eed45b5fa2b638360ebfde037d284b9dc69e54c0.diff

[PATCH] D81672: [Driver] When forcing a crash call abort to get the correct diagnostic

aganea added a comment. But that won't work when compiling & crashing with `-fno-integrated-cc1`, would it? (or if building with `cmake ... -DCLANG_SPAWN_CC1=1`). In that case, normal crashes (not -gen-reproducer) won't go through the `CrashRecoveryContext`. Try running: $ CCC_OVERRIDE_OPTION

[PATCH] D81868: [libTooling] Add parser for string representation of `RangeSelector`.

ymandel updated this revision to Diff 271770. ymandel marked 3 inline comments as done. ymandel added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81868/new/ https://reviews.llvm.org/D81868 Files: clang/include/clang

[PATCH] D81837: [ARM][bfloat] Removing lowering of bfloat arguments and returns from Clang's CodeGen

This revision was automatically updated to reflect the committed changes. Closed by commit rG035795659b60: [ARM][bfloat] Do not coerce bfloat arguments and returns to integers (authored by stuij). Changed prior to commit: https://reviews.llvm.org/D81837?vs=271130&id=271775#toc Repository: rG

[PATCH] D81311: [RFC] LangRef: Define byref parameter attribute

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. This LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81311/new/ https://reviews.llvm.org/D81311 ___ cfe-commits mailing list cfe

[PATCH] D82112: [RFC][BPF] Implement getUserCost() for BPFTargetTransformInfo

yonghong-song created this revision. yonghong-song added a reviewer: ast. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added projects: clang, LLVM. This patch tries to partially prevent speculative code motion for BPF. First, some use cases on why we want to prevent spec

[PATCH] D81885: [Coroutines] Return false on error of buildSuspends

lxfind abandoned this revision. lxfind added a comment. Makes sense. I will abandon this change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81885/new/ https://reviews.llvm.org/D81885 ___ cfe-commits

[PATCH] D81868: [libTooling] Add parser for string representation of `RangeSelector`.

ymandel updated this revision to Diff 271782. ymandel marked 3 inline comments as done. ymandel added a comment. removed Twine argument per clang-tidy warning. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81868/new/ https://reviews.llvm.org/D81868

[PATCH] D81868: [libTooling] Add parser for string representation of `RangeSelector`.

ymandel added a comment. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81868/new/ https://reviews.llvm.org/D81868 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D80935: [PowerPC][Power10] Implement Parallel Bits Deposit/Extract Builtins in LLVM/Clang

amyk marked an inline comment as done. amyk added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCScheduleP9.td:47 + let UnsupportedFeatures = [HasQPX, HasSPE, PrefixInstrs, PCRelativeMemops, + IsISA3_1]; lei wrote: > Are `P

[PATCH] D81282: [builtins] Move more float128-related helpers to GENERIC_TF_SOURCES list

atrosinenko added a comment. @samsonov Something strange happens with the compiler-rt tests: when this patch was initially uploaded, the tests were failed with seemingly unrelated failures: B59287 . Some tests are broken upstream, I concluded. Today I have reba

[PATCH] D77493: [clang-tidy] Add do-not-refer-atomic-twice check

gamesh411 added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/DoNotReferAtomicTwiceCheck.cpp:21 + Finder->addMatcher( + declRefExpr(hasType(hasUnqualifiedDesugaredType(atomicType())), + to(varDecl().bind("atomic")), I

[PATCH] D81168: Add support for DeclRefExpr in SyntaxTree, by generating IdExpressions

eduucaldas updated this revision to Diff 271784. eduucaldas added a comment. change if -> asserts Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81168/new/ https://reviews.llvm.org/D81168 Files: clang/include/clang/Tooling/Syntax/Nodes.h clang/

[PATCH] D80833: [CodeView] Add full repro to LF_BUILDINFO record

thakis added a comment. This is still broken; bots have been red for a few hours now. Can we revert and analyze async, to keep the bots green please? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80833/new/ https://reviews.llvm.org/D80833 _

[PATCH] D79796: Sketch support for generating CC1 command line from CompilerInvocation

dang updated this revision to Diff 271790. dang added a comment. Address the clang-tidy issues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79796/new/ https://reviews.llvm.org/D79796 Files: clang/include/clang/Driver/CC1Options.td clang/incl

[PATCH] D75229: [clang-tidy] Add signal-in-multithreaded-program check

abelkocsis updated this revision to Diff 271789. abelkocsis added a comment. Small comment fix Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75229/new/ https://reviews.llvm.org/D75229 Files: clang-tools-extra/clang-tidy/bugprone/BugproneTidyModul

[PATCH] D81678: Introduce partialinit attribute at call sites for stricter poison analysis

guiand added a comment. In an email conversation with @rsmith and @eugenis, they raised the issue that it's not necessarily wrong to pass aggregate types by value, even when some fields are uninit. A relevant excerpt from Richard: > In addition to the union case, there's another strange case f

[PATCH] D82115: [OPENMP50]Codegen for scan directives in parallel for simd regions.

ABataev created this revision. ABataev added a reviewer: jdoerfert. Herald added subscribers: sstefan1, guansong, yaxunl. Herald added a project: clang. Added codegen for scan directives in parallel for simd regions. Emits the code for the directive with inscan reductions. Original code: #pra

[PATCH] D80833: [CodeView] Add full repro to LF_BUILDINFO record

aganea added a comment. In D80833#2101636 , @thakis wrote: > This is still broken; bots have been red for a few hours now. Can we revert > and analyze async, to keep the bots green please? Yes I will revert, but I don't understand. All the tests pass he

[PATCH] D82029: [Coroutines] Ensure co_await promise.final_suspend() does not throw

lxfind updated this revision to Diff 271801. lxfind added a comment. Herald added a subscriber: arphaman. Address feedback and update failed tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82029/new/ https://reviews.llvm.org/D82029 Files: cl

[PATCH] D80833: [CodeView] Add full repro to LF_BUILDINFO record

thakis added a comment. Hm http://lab.llvm.org:8011/builders/clang-x64-windows-msvc/builds/16533 is happy so it's not broken on all Windows machines. Guess I'll take a look on what's going on. You can hold off on the revert for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D80981: [AST] Fix a crash on accessing a class without definition in constexpr function context.

rsmith added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:4320 +if (!RD->hasDefinition()) + return APValue(); APValue Struct(APValue::UninitStruct(), RD->getNumBases(), hokein wrote: > rsmith wrote: > > hokein wrote: > > > sammccall w

[clang] 1b2f6b4 - Add support for DeclRefExpr in SyntaxTree, by generating IdExpressions

Author: Eduardo Caldas Date: 2020-06-18T21:05:23+02:00 New Revision: 1b2f6b4a08ba74d965dcf7c9fee97d286c0250f8 URL: https://github.com/llvm/llvm-project/commit/1b2f6b4a08ba74d965dcf7c9fee97d286c0250f8 DIFF: https://github.com/llvm/llvm-project/commit/1b2f6b4a08ba74d965dcf7c9fee97d286c0250f8.diff

[PATCH] D80833: [CodeView] Add full repro to LF_BUILDINFO record

aganea added a comment. In D80833#2101690 , @thakis wrote: > Hm http://lab.llvm.org:8011/builders/clang-x64-windows-msvc/builds/16533 is > happy so it's not broken on all Windows machines. Guess I'll take a look on > what's going on. You can hold off on

[PATCH] D82118: [clang][module] Improve incomplete-umbrella warning

zixuw created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. - Upstream methods for action wrappers in generating modules; - Change the warning message for -Wincomplete-umbrella to report the location of the umbrella header; - Add a fix-it hint to include un

[PATCH] D82085: [TRE] markTails marks call sites as tailcalls though some of them are not.

avl added a comment. > It's OK to set "tail" on any call that satisfies these requirements (from > https://llvm.org/docs/LangRef.html#call-instruction): "Both markers [tail and > musttail] imply that the callee does not access allocas from the caller. The > tail marker additionally implies that

[PATCH] D81168: Add support for DeclRefExpr in SyntaxTree, by generating IdExpressions

This revision was automatically updated to reflect the committed changes. Closed by commit rG1b2f6b4a08ba: Add support for DeclRefExpr in SyntaxTree, by generating IdExpressions (authored by eduucaldas, committed by gribozavr). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[clang] 2ae0df5 - [CodeView] Revert 8374bf43634725dc02a262a77b5f940fca25938c and 403f9537924b8910ed4f741ed96c61f5e657915b

Author: Alexandre Ganea Date: 2020-06-18T16:18:46-04:00 New Revision: 2ae0df5be7408a79524743762b6c74953f31b805 URL: https://github.com/llvm/llvm-project/commit/2ae0df5be7408a79524743762b6c74953f31b805 DIFF: https://github.com/llvm/llvm-project/commit/2ae0df5be7408a79524743762b6c74953f31b805.dif

[clang] c830d51 - [HIP] Enable -amdgpu-internalize-symbols

Author: Yaxun (Sam) Liu Date: 2020-06-18T16:34:37-04:00 New Revision: c830d517b4e46abb617a80b3967b26546370c928 URL: https://github.com/llvm/llvm-project/commit/c830d517b4e46abb617a80b3967b26546370c928 DIFF: https://github.com/llvm/llvm-project/commit/c830d517b4e46abb617a80b3967b26546370c928.dif

[PATCH] D80833: [CodeView] Add full repro to LF_BUILDINFO record

aganea added a comment. Reverted in rG2ae0df5be7408a79524743762b6c74953f31b805 . I'll investigate the issue on my end. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80833/new/ h

[PATCH] D82122: [analyzer][Liveness][RFC][NFC] Propose to turn statement liveness into expression liveness

Szelethus created this revision. Szelethus added reviewers: xazax.hun, NoQ, vsavchenko, balazske, martong, baloghadamsoftware, dcoughlin. Szelethus added a project: clang. Herald added subscribers: cfe-commits, ASDenysPetrov, steakhal, Charusso, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.s

[PATCH] D80833: [CodeView] Add full repro to LF_BUILDINFO record

thakis added a comment. I took a look. It consistently fails for me on mac and on Windows in a `git bash` shell, but it passes in cmd with unxutils. Maybe this needs something like eac56724fd955af0f8521557cacc57a83f371649 ?

[PATCH] D82085: [TRE] markTails marks call sites as tailcalls though some of them are not.

laytonio added a comment. Relevant llvm-dev thread. Noncapture use of locals disabling TailRecursionElimination Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82085/new/ https://revie

[PATCH] D81959: [HIP] Enable -amdgpu-internalize-symbols

This revision was automatically updated to reflect the committed changes. Closed by commit rGc830d517b4e4: [HIP] Enable -amdgpu-internalize-symbols (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D819

[PATCH] D81466: [SveEmitter] Add builtins for struct loads/stores (ld2/ld3/etc)

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/CodeGen/CGBuiltin.cpp:7890 + Value *Predicate = EmitSVEPredicateCast(Ops[0], VTy); + Value *BasePtr= Builder.CreateBitCast(Ops[1], VecPtrTy);

[PATCH] D82126: [libTooling] Change `selection` stencil to handle some cases of text in macros.

ymandel created this revision. ymandel added a reviewer: gribozavr2. Herald added a project: clang. Currently, the `selection` stencil validates the selection before extracting the text. However, this means that any range inside a macro is rejected as an error. This patch changes the implementatio

<    1   2   3   >