Xiangling_L added inline comments.
================
Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:345
+ // rarely.
+ Weights = nullptr;
+ } else if (Kind == GuardKind::VariableGuard && !D->isLocalVarDecl()) {
----------------
jasonliu wrote:
> Do we need to change/complicate the interface for this function, just to do a
> call to Builder.CreateCondBr()?
> Could we call that function directly from where it's needed?
Sure, we can. Thank you for your suggestion. I was hoping to use one function
to synthesize the guarded init or destruct branch. But I think it seems better
if we wait for further more usage of guarded destruct branch to do so and not
complicate stuff in this patch.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74166/new/
https://reviews.llvm.org/D74166
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
