[PATCH] D62922: [WebAssembly] Implement "Reactor" mode

sunfish marked an inline comment as done. sunfish added inline comments. Comment at: clang/test/Driver/wasm-toolchain.c:116 +// CHECK-COMMAND: clang{{.*}}" "-cc1" {{.*}} "-o" "[[temp:[^"]*]]" +// CHECK-COMMAND: wasm-ld{{.*}}" "crt1.o" "[[temp]]" "-lc" "{{.*[/\\]}}libclang_rt.bui

[PATCH] D79719: [AIX] Implement AIX special alignment rule about double/long double

Xiangling_L updated this revision to Diff 268624. Xiangling_L marked 11 inline comments as done. Xiangling_L added a comment. Add `PreferredAlignment` and `PreferredNVAlignment` field; Adjust `-fdump-record-layouts` format for AIX; Update the testcase formatting; Repository: rG LLVM Github Mon

[PATCH] D79719: [AIX] Implement AIX special alignment rule about double/long double

Xiangling_L added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:2506 if (!Target->allowsLargerPreferedTypeAlignment()) return ABIAlign; jyknight wrote: > I think from here on down is currently X86-specific, even though it's not > phrased th

[PATCH] D79830: Add support of __builtin_expect_with_probability

davidxl added a comment. Can you add some tests at the LLVM side? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79830/new/ https://reviews.llvm.org/D79830 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[PATCH] D81203: clang-cl: accept -f[no-]data-sections and -f[no-]function-sections

thakis added a comment. The clang-cl spelling of this is /Gy and /Gw. If you want to use the gcc spelling, you can do that through the /clang: flag. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81203/new/ https://reviews.llvm.org/D81203 __

[PATCH] D81203: clang-cl: accept -f[no-]data-sections and -f[no-]function-sections

thakis requested changes to this revision. thakis added a comment. This revision now requires changes to proceed. In other words: The point of clang-cl is to use cl.exe flag spellings where they exist. So unless there's some good reason for adding this, I don't think we should add it. Reposito

[PATCH] D81192: [OPENMP]Fix PR45854: prevent code movement out of the critical region.

ABataev abandoned this revision. ABataev added a comment. In D81192#2074878 , @jdoerfert wrote: > In D81192#2074762 , @ABataev wrote: > > > In D81192#2074732 , @jdoerfert >

[PATCH] D79378: PR34581: Don't remove an 'if (p)' guarding a call to 'operator delete(p)' under -Oz.

rsmith added a comment. In D79378#2058753 , @dnsampaio wrote: > Hi @rsmith, > are you still looking into this? > cheers Sorry for the delay, I'll be getting back to this soon. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D80996: [AMDGPU][OpenMP] Fix duplicate copies of arguments in commands

pdhaliwal abandoned this revision. pdhaliwal marked an inline comment as done. pdhaliwal added inline comments. Comment at: clang/lib/Driver/ToolChains/HIP.cpp:389 - for (Arg *A : Args) { -DAL->append(A); + if (DeviceOffloadKind != Action::OFK_OpenMP) { +for (Arg *A :

[PATCH] D80979: [clang] Implement VectorType logic not operator.

junparser marked 2 inline comments as done. junparser added inline comments. Comment at: clang/test/CodeGen/vector-1.cpp:2 +// RUN: %clang_cc1 -emit-llvm %s -o - | FileCheck %s + +typedef __attribute__((__vector_size__(16))) float float4; erichkeane wrote: > I do

[PATCH] D69987: [RISCV] Assemble/Disassemble v-ext instructions.

HsiangKai marked an inline comment as done. HsiangKai added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVInstrFormats.td:56 +def NoConstraint : RISCVVConstraint<0>; +def WidenV : RISCVVConstraint<1>; +def WidenW : RISCVVConstraint<2>; evand

[clang] c57f8a3 - PR46209: properly determine whether a copy assignment operator is

Author: Richard Smith Date: 2020-06-04T19:19:01-07:00 New Revision: c57f8a3a20540fcf9fbf98c0a73f381ec32fce2a URL: https://github.com/llvm/llvm-project/commit/c57f8a3a20540fcf9fbf98c0a73f381ec32fce2a DIFF: https://github.com/llvm/llvm-project/commit/c57f8a3a20540fcf9fbf98c0a73f381ec32fce2a.diff

[clang] c13dd74 - Set the captures on a CXXRecordDecl representing a lambda closure type

Author: Richard Smith Date: 2020-06-04T19:19:01-07:00 New Revision: c13dd74e311d2ac70dd3ea663d800307d1aa5b6b URL: https://github.com/llvm/llvm-project/commit/c13dd74e311d2ac70dd3ea663d800307d1aa5b6b DIFF: https://github.com/llvm/llvm-project/commit/c13dd74e311d2ac70dd3ea663d800307d1aa5b6b.diff

[clang] e5158b5 - [Driver] Migrate some -f/-fno options to use OptInFFlag and OptOutFFlag

Author: Fangrui Song Date: 2020-06-04T19:33:14-07:00 New Revision: e5158b52730d323bb8cd2cba6dc6c89b90cba452 URL: https://github.com/llvm/llvm-project/commit/e5158b52730d323bb8cd2cba6dc6c89b90cba452 DIFF: https://github.com/llvm/llvm-project/commit/e5158b52730d323bb8cd2cba6dc6c89b90cba452.diff

[PATCH] D81188: [RISCV] Support experimental v extensions.

HsiangKai updated this revision to Diff 268642. HsiangKai added a comment. Address @MaskRay's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81188/new/ https://reviews.llvm.org/D81188 Files: clang/lib/Driver/ToolChains/Arch/RISCV.cpp

[PATCH] D78900: [HIP][AMDGPU] Enable structurizer workarounds

sameerds abandoned this revision. sameerds added a comment. Abandoned in favour of enabling the workarounds in the AMDGPU backend: https://reviews.llvm.org/D81211 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78900/new/ https://reviews.llvm.org/D7

[PATCH] D81213: [RISCV] Support experimental v extension v0.9.

HsiangKai created this revision. HsiangKai added reviewers: evandro, rogfer01, rkruppe. Herald added subscribers: cfe-commits, luismarques, apazos, sameer.abuasal, pzheng, s.egerton, lenary, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, edward-jones, zzheng, MaskRay, jrtc27

[PATCH] D79830: Add support of __builtin_expect_with_probability

LukeZhuang added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:1818-1819 +llvm::APFloat Probability = Eval.Val.getFloat(); +if (!(Probability >= llvm::APFloat(0.0) && + Probability <= llvm::APFloat(1.0))) { + Diag(ProbArg->getLocStart(), diag:

[PATCH] D81188: [RISCV] Support experimental v extensions.

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81188/new/ https://reviews.llvm.org/D81188

[PATCH] D80979: [clang] Implement VectorType logic not operator.

junparser updated this revision to Diff 268649. junparser added a comment. address the comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80979/new/ https://reviews.llvm.org/D80979 Files: clang/docs/LanguageExtensions.rst clang/lib/CodeGen/CGExprScalar.cpp clang/lib/Sema/Sema

[PATCH] D81222: [WebAssembly] Implement prototype SIMD rounding instructions

tlively created this revision. tlively added a reviewer: aheejin. Herald added subscribers: llvm-commits, cfe-commits, sunfish, hiraditya, jgravelle-google, sbc100, dschuff. Herald added projects: clang, LLVM. As specified in https://github.com/WebAssembly/simd/pull/232. These instructions are im

[PATCH] D80966: [codeview] Put !heapallocsite on calls to operator new

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. > but the operator declared at global scope returns void. void -> void pointer Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80966/new/ https

[PATCH] D80462: Fix floating point math function attributes definition.

michele.scandale updated this revision to Diff 268667. michele.scandale added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80462/new/ https://reviews.llvm.org/D80462 Files: clang/lib/CodeGen/CGCall.cpp clang/lib/CodeGen/CGEx

[PATCH] D81131: [DebugInfo] Fix assertion for extern void type

yonghong-song added a comment. Thanks, @dblaikie >> I think if we're going to support "const void" we should support "void" too >> & fix the verifier to allow this & make sure LLVM produces the correct debug >> info for it (which is probably a DW_TAG_variable without a DW_AT_type >> attribute

[PATCH] D81223: Size LTO (1/3): Standardizing the use of OptimizationLevel

rcorcs created this revision. rcorcs added a reviewer: hiraditya. rcorcs added projects: LLVM, lld. Herald added subscribers: cfe-commits, msifontes, jurahul, Kayjukh, frgossen, grosul1, Joonsoo, stephenneuendorffer, liufengdb, lucyrfox, mgester, arpith-jacob, nicolasvasilache, antiagainst, shauh

[PATCH] D79719: [AIX] Implement AIX special alignment rule about double/long double

efriedma added inline comments. Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:660 + /// with [[no_unique_attr]] Empty CXXRD invovled in the CXXRD. + int IsRealFirstMember; + Please explain here what the different values (-1, 0, 1, 2) mean. Or use an enum.

[clang] 78702de - [Driver] Migrate some -f/-fno options to use OptInFFlag and OptOutFFlag

Author: Fangrui Song Date: 2020-06-04T23:25:19-07:00 New Revision: 78702dec3bbc9eadf7c0469f2c54e5c105ffea78 URL: https://github.com/llvm/llvm-project/commit/78702dec3bbc9eadf7c0469f2c54e5c105ffea78 DIFF: https://github.com/llvm/llvm-project/commit/78702dec3bbc9eadf7c0469f2c54e5c105ffea78.diff

[clang] 70ad03d - Revert "Set the captures on a CXXRecordDecl representing a lambda closure type"

Author: Jonas Devlieghere Date: 2020-06-04T23:45:36-07:00 New Revision: 70ad03d93818532ef19f149f8ff89bcd8af80163 URL: https://github.com/llvm/llvm-project/commit/70ad03d93818532ef19f149f8ff89bcd8af80163 DIFF: https://github.com/llvm/llvm-project/commit/70ad03d93818532ef19f149f8ff89bcd8af80163.d

Re: [clang] c13dd74 - Set the captures on a CXXRecordDecl representing a lambda closure type

Hey Richard, It appears this broke the lldb bots: http://lab.llvm.org:8011/builders/lldb-x86_64-debian http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/20549/ It's hitting an assertion in llvm-project/clang/include/clang/AST/DeclCXX.h:887: Assertion `(data().DefaultedCopyAssignmentIsDel

[clang] df53f09 - Revert "PR46209: properly determine whether a copy assignment operator is"

Author: Jonas Devlieghere Date: 2020-06-04T23:45:36-07:00 New Revision: df53f09056b0f6a91029cae5f1cdc941c21b URL: https://github.com/llvm/llvm-project/commit/df53f09056b0f6a91029cae5f1cdc941c21b DIFF: https://github.com/llvm/llvm-project/commit/df53f09056b0f6a91029cae5f1cdc941c21b.d

[PATCH] D81223: Size LTO (1/3): Standardizing the use of OptimizationLevel

mehdi_amini added a comment. > This patch is the first in the sequence of three patches for supporting size > optimization with LTO. Can you start by describing the problem you're trying to solve and the overall approach, including the end-to-end user-interface? Repository: rG LLVM Github M

<    1   2   3