[PATCH] D81041: Use existing path sep style in clang::FileManager::FixupRelativePath

ctetreau abandoned this revision. ctetreau added a comment. After some further investigation, I have come to believe that the root cause of the issue I am seeing is on line 783 of clang/lib/Lex/HeaderSearch.cpp. A path is constructed using string concatenation (dir + '/' + file), which is obvio

[PATCH] D81115: [PowerPC] Do not check for non-Darwin in PowerPC target cpu handling

hubert.reinterpretcast added a comment. Calling it the "Darwin factor" gives it a certain je ne sais quoi. :) Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:298 +// each architecture. (except on AIX) if (TargetCPUName.empty()) { if (T.isOSAIX())

[PATCH] D81122: Reland: Use -fdebug-compilation-dir to form absolute paths in coverage mappings

keith created this revision. keith added reviewers: arphaman, vsk, rnk, cfe-commits, kastiglione. Herald added subscribers: llvm-commits, dexonsmith. Herald added projects: clang, LLVM. This reverts commit 62808631acceaa8b78f8ab9b407eb6b943ff5f77. This was previously reverted because llvm-cov's -

[PATCH] D79948: [OPENMP50]Codegen for inscan reductions in worksharing directives.

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. Thx for the explanation. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79948/new/ https://reviews.llvm.org/D79948 ___

[PATCH] D80730: [OPENMP50]Codegen for use_device_addr clauses.

jdoerfert added a subscriber: RaviNarayanaswamy. jdoerfert added a comment. I was hoping @dreachem and maybe @RaviNarayanaswamy would look at this. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:7630 +// OMPC_MAP_MODIFIER_last is used to identify data members used in

[PATCH] D59520: [WebAssembly] Address review comments on r352930

sunfish updated this revision to Diff 268329. sunfish added a comment. - Add tests for redeclaration behavior - Remove disabled tests (previously marked with FIXMEs) - Made the mismatch warning more informative. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D80941: [PowerPC][Power10] Implement Count Leading/Trailing Zeroes Builtins under bit Mask in LLVM/Clang

amyk updated this revision to Diff 268331. amyk retitled this revision from "[PowerPC][Power10] Implement Count Leading/Trailing Zeroes Builtins in LLVM/Clang" to "[PowerPC][Power10] Implement Count Leading/Trailing Zeroes Builtins under bit Mask in LLVM/Clang". amyk added a comment. Addressed r

[PATCH] D59520: [WebAssembly] Address review comments on r352930

sunfish marked 3 inline comments as done. sunfish added a comment. I apologize again for the major delay. I've now updated the patch and addressed all of your comments. Comment at: clang/lib/Sema/SemaDecl.cpp:2594-2597 + else if (const auto *IMA = dyn_cast(Attr)) +NewAttr

[PATCH] D76077: [ARM] Add __bf16 as new Bfloat16 C Type

stuij updated this revision to Diff 268335. stuij added a comment. Addressed review comments. Notably what to do in combination with -mfloat-abi=soft. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76077/new/ https://reviews.llvm.org/D76077 Files:

[PATCH] D79796: Sketch support for generating CC1 command line from CompilerInvocation

Bigcheese added inline comments. Comment at: clang/include/clang/Frontend/CompilerInvocation.h:248 + /// \returns - True if parsing was successful, false otherwise + bool parseSimpleArgs(const llvm::opt::ArgList &Args, + DiagnosticsEngine &Diags);

[PATCH] D80979: [clang] Implement VectorType logic not operator.

junparser added a comment. @erichkeane @aaron.ballman , kindly ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80979/new/ https://reviews.llvm.org/D80979 ___ cfe-commits mailing list cfe-comm

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

majnemer added inline comments. Comment at: clang/include/clang/AST/Stmt.h:1783 + + bool IsSideEntry() const { return SideEntry; } + void setSideEntry() { SideEntry = true; } I think this should be isSideEntry to be consistent. Comment at: cl

[clang] 049d860 - [CUDA][HIP] Fix constexpr variables for C++17

Author: Yaxun (Sam) Liu Date: 2020-06-03T21:56:52-04:00 New Revision: 049d860707ef22978b9379fee6dce38c66a22671 URL: https://github.com/llvm/llvm-project/commit/049d860707ef22978b9379fee6dce38c66a22671 DIFF: https://github.com/llvm/llvm-project/commit/049d860707ef22978b9379fee6dce38c66a22671.dif

[PATCH] D80979: [clang] Implement VectorType logic not operator.

erichkeane added a comment. Write some codegen tests please, I'd like to have a better idea of what you want ! to do here. Additionally, I'm not sure as to the limits you've placed on this patch. Please justifiy them.C Comment at: clang/lib/CodeGen/CGExprScalar.cpp:2746 +

[PATCH] D79237: [CUDA][HIP] Fix constexpr variables for C++17

This revision was automatically updated to reflect the committed changes. Closed by commit rG049d860707ef: [CUDA][HIP] Fix constexpr variables for C++17 (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D80996: [AMDGPU][OpenMP] Fix duplicate copies of arguments in commands

sameerds added inline comments. Comment at: clang/lib/Driver/ToolChains/HIP.cpp:389 - for (Arg *A : Args) { -DAL->append(A); + if (DeviceOffloadKind != Action::OFK_OpenMP) { +for (Arg *A : Args) { pdhaliwal wrote: > arsenm wrote: > > Needs a comment?

[PATCH] D80947: Add to the Coding Standard our that single-line bodies omit braces

hubert.reinterpretcast added inline comments. Comment at: llvm/docs/CodingStandards.rst:1576 + +When writing the body of an `if`, `else`, or loop statement, omit the braces to avoid +unnecessary and otherwise meaningless code. However, braces should be used Ther

[PATCH] D80979: [clang] Implement VectorType logic not operator.

junparser marked 3 inline comments as done. junparser added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:2746 + if (E->getType()->isVectorType() && + E->getType()->castAs()->getVectorKind() == + VectorType::GenericVector) { erich

[PATCH] D79411: [VE] Clang toolchain for VE

kaz7 added a comment. It looks fine to me but I'm not clang expert. Can anyone review this or introduce us reviewers? Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79411/new/ https://reviews.llvm.org/D79411 ___

Re: [PATCH] D31702: Append -w when LLVM_ENABLE_WARNINGS is Off.

Can we revert this? In our downstream project we were bitten by this: https://github.com/google/mlir-npcomp/commit/cd7258dbd48bd9254c6741cab2d3f4e36cbd3c84 It seems that now by default anybody that depends on LLVM with CMake will globally get a `-w` passed to their compiler. That doesn't seem lik

[PATCH] D80492: Avoid linking libdl unless needed

thieta added a comment. Thanks - I'll look into a fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80492/new/ https://reviews.llvm.org/D80492 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D80833: [CodeView] Add full repro to LF_BUILDINFO record

aganea marked 5 inline comments as done. aganea added a comment. In D80833#2071863 , @hans wrote: > In D80833#2071818 , @aganea wrote: > > > I didn't change the PWD/CWD stored in `LF_BUILDINFO`, it has already been

[PATCH] D80833: [CodeView] Add full repro to LF_BUILDINFO record

aganea updated this revision to Diff 268359. aganea added a comment. Herald added subscribers: jfb, dexonsmith. - Using `sys::flattenWindowsCommandLine` instead of previous quoting function, as suggested by @hans - Added Clang tests for `-fdebug-compilation-dir .` - Added LLD support for making a

[PATCH] D80979: [clang] Implement VectorType logic not operator.

junparser added a comment. This patch implement the logic not operation of vector type. it keeps same behavior as gcc does (only allows in C++). I'll update the wrong testcases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80979/new/ https://revi

[PATCH] D81131: [DebugInfo] Fix assertion for extern void type

yonghong-song created this revision. yonghong-song added a reviewer: dblaikie. yonghong-song added a project: debug-info. Herald added a project: clang. Herald added a subscriber: cfe-commits. Commit d77ae1552fc2 ("[DebugInfo]

[PATCH] D80979: [clang] Implement VectorType logic not operator.

junparser updated this revision to Diff 268366. junparser added a comment. address the comment. hi @erichkeane, most of the function in vector-1.cpp are copied from ext-vector.c with vector type changed to gcc vector type, they should emit same ir. I add test7 and test8 which test logic opera

[PATCH] D80979: [clang] Implement VectorType logic not operator.

junparser marked 2 inline comments as done. junparser added inline comments. Comment at: clang/test/CodeGen/vector-1.cpp:183 +// CHECK: @_Z5test7Dv4_j +int4 test7(uint4 V0) { + // CHECK: [[CMP0:%.*]] = icmp eq <4 x i32> [[V0:%.*]], zeroinitializer logic operatio

[PATCH] D81131: [DebugInfo] Fix assertion for extern void type

anakryiko accepted this revision. anakryiko added a comment. This revision is now accepted and ready to land. For my purposes, having extern var BTF only for `extern const void` is just fine. Not crashing Clang for `extern void` is great as well :) Repository: rG LLVM Github Monorepo CHANGES

[clang] 8d74de9 - [clang] Always allow including builtin headers in [no_undeclared_headers] modules.

Author: Martin Boehme Date: 2020-06-04T08:33:39+02:00 New Revision: 8d74de9de6d6cca552d7de7d0bfd36b6dd7d58dc URL: https://github.com/llvm/llvm-project/commit/8d74de9de6d6cca552d7de7d0bfd36b6dd7d58dc DIFF: https://github.com/llvm/llvm-project/commit/8d74de9de6d6cca552d7de7d0bfd36b6dd7d58dc.diff

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

tentzen marked 3 inline comments as done. tentzen added a comment. thank you David. will update and submit a new patch shortly. Comment at: clang/lib/CodeGen/CGException.cpp:603-609 + // For IsEHa catch(...) must handle HW exception + // Adjective = HT_IsStdDotDot (0

[PATCH] D63482: [clang-tidy] Fix the YAML created for checks like modernize-pass-by-value

yvvan added a comment. @DmitryPolukhin Sorry, I didn't have time recently. Thanks a lot for taking care! Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63482/new/ https://reviews.llvm.org/D63482 ___ cfe-commits mailin

<    1   2   3