majnemer added inline comments.
================
Comment at: clang/include/clang/AST/Stmt.h:1783
+
+ bool IsSideEntry() const { return SideEntry; }
+ void setSideEntry() { SideEntry = true; }
----------------
I think this should be isSideEntry to be consistent.
================
Comment at: clang/lib/CodeGen/CGException.cpp:603-609
+ // For IsEHa catch(...) must handle HW exception
+ // Adjective = HT_IsStdDotDot (0x40), only catch C++ exceptions
+ // Also mark scope with SehTryBegin
+ if (getLangOpts().EHAsynch) {
+ TypeInfo.Flags = 0;
+ EmitRuntimeCallOrInvoke(getSehTryBeginFn(CGM));
+ }
----------------
I think this logic should move into MicrosoftCXXABI::getCatchAllTypeInfo.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80344/new/
https://reviews.llvm.org/D80344
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
