[PATCH] D80366: [Analyzer] Add `getReturnValueUnderConstruction()` to `CallEvent`

baloghadamsoftware marked 4 inline comments as done. baloghadamsoftware added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/CallEvent.cpp:543 + + const StackFrameContext *StackFrame = Call.getCalleeStackFrame(BlockCount); + if (!StackFrame) NoQ wro

[PATCH] D80940: [clang-format] [PR46159] Linux kernel 'C' code uses 'try' as a variable name, allow clang-format to handle such cases

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM. For a second, I thought that you could simplify the code by removing this @try condition (and calling the function `FormatTokenLexer::tryTransformTryUsageForC()` only if `isCppOnly`

[PATCH] D81090: [AST][RecoveryExpr] Preserve the AST for invalid class constructions.

hokein updated this revision to Diff 268180. hokein added a comment. Avoid creating a recovery-expr when typo-correction fails, which will lead to a typoexpr being corrected twice and crashes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81090/new/

[PATCH] D80514: [clang-tidy] modernize-use-trailing-return-type support for C++20 concepts and decltype

bernhardmgruber added a comment. In D80514#2071202 , @njames93 wrote: > In D80514#2071056 , @bernhardmgruber > wrote: > > > Reuploaded diff in an attempt to trigger a CI build. > > > It's not working, Still no big

[PATCH] D81090: [AST][RecoveryExpr] Preserve the AST for invalid class constructions.

hokein added a comment. Tested with turning on `-frecovery-ast`, 3 failures, all of them are diagnostic improvements! FAIL: Clang :: SemaCXX/constant-expression-cxx11.cpp (10868 of 18440) TEST 'Clang :: SemaCXX/constant-expression-cxx11.cpp' FAILED

[PATCH] D81092: Add support for `nullptr` in SyntaxTrees

This revision was automatically updated to reflect the committed changes. Closed by commit rG007098d7e6b8: Add support for `nullptr` in SyntaxTrees (authored by eduucaldas, committed by gribozavr). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81092/

[PATCH] D81079: [clangd] Add std::move() to a return statement to please some compilers.

This revision was automatically updated to reflect the committed changes. Closed by commit rGa3220dffcb1d: [clangd] Add std::move() to a return statement to please some compilers. (authored by mboehme). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D8

[clang-tools-extra] 6780be4 - second attempt to fix build after add51e1

Author: Nathan James Date: 2020-06-03T15:16:36+01:00 New Revision: 6780be4c63e582466a35d7644c35e09ba85d4f67 URL: https://github.com/llvm/llvm-project/commit/6780be4c63e582466a35d7644c35e09ba85d4f67 DIFF: https://github.com/llvm/llvm-project/commit/6780be4c63e582466a35d7644c35e09ba85d4f67.diff

[PATCH] D81069: [clangd] Don't build diagnostics when preparing AST for a normal action.

sammccall updated this revision to Diff 268188. sammccall marked an inline comment as done. sammccall added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81069/new/ https://reviews.llvm.org/D81069 Files: clang-tools-e

[PATCH] D81069: [clangd] Don't build diagnostics when preparing AST for a normal action.

sammccall marked 8 inline comments as done. sammccall added a comment. > rarely happens anyway citation needed. While this is true today, it seems fairly likely that async preambles is going to flip the dominant AST reuse from diagnostics -> read to read -> diagnostics. This change would make

[PATCH] D80932: [SYCL] Make default address space a superset of OpenCL address spaces.

bader marked an inline comment as done. bader added a comment. In D80932#2068863 , @Anastasia wrote: > > Why? Can you explain what you are trying to achieve with this? I think @asavonic can provide more detailed answer, but IIRC we spent a lot time t

[PATCH] D77572: [clang-tidy] add new check readability-use-anyofallof

njames93 added a comment. In D77572#2071045 , @RKSimon wrote: > @mgehre Please can you take at the remaining buildbot failures here : > http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/68662 Pushed a fix for that too.

[PATCH] D81090: [AST][RecoveryExpr] Preserve the AST for invalid class constructions.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Awesome! > /workspace/llvm-project/clang/test/SemaCXX/cxx0x-initializer-constructor.cpp > Line 166: expected ';' after expression This is just a previously-uncaught typo in the test, yo

[PATCH] D78637: [OPENMP]Fix PR45383: type dependent array subscripts are diagnosed erroneously.

ABataev updated this revision to Diff 268196. ABataev added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78637/new/ https://reviews.llvm.org/D78637 Files: clang/lib/Sema/SemaOpenMP.cpp clang/test/OpenMP/task_ast_print.cpp

[clang] 36b8af1 - [SveEmitter] Add SVE ACLE for svld1ro.

Author: Francesco Petrogalli Date: 2020-06-03T14:44:07Z New Revision: 36b8af11d343911e05c919fc68d1352f49bc087c URL: https://github.com/llvm/llvm-project/commit/36b8af11d343911e05c919fc68d1352f49bc087c DIFF: https://github.com/llvm/llvm-project/commit/36b8af11d343911e05c919fc68d1352f49bc087c.dif

[clang] 04abbb3 - [HIP] Change default --gpu-max-threads-per-block value to 1024

Author: Yaxun (Sam) Liu Date: 2020-06-03T11:09:22-04:00 New Revision: 04abbb3a78186aa92809866b43217c32cba90b71 URL: https://github.com/llvm/llvm-project/commit/04abbb3a78186aa92809866b43217c32cba90b71 DIFF: https://github.com/llvm/llvm-project/commit/04abbb3a78186aa92809866b43217c32cba90b71.dif

[PATCH] D79830: Add support of __builtin_expect_with_probability

lebedev.ri added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:1818-1819 +llvm::APFloat Probability = Eval.Val.getFloat(); +if (!(Probability >= llvm::APFloat(0.0) || + Probability <= llvm::APFloat(1.0))) { + Diag(ProbArg->getLocStart(), diag:

[PATCH] D81098: [OpenMP] Upgrade default version of OpenMP to 5.0

saiislam created this revision. saiislam added reviewers: gregrodgers, jdoerfert. Herald added subscribers: cfe-commits, sstefan1, guansong, yaxunl. Herald added a project: clang. When -fopenmp option is specified then version 5.0 will be set as default. Repository: rG LLVM Github Monorepo ht

[PATCH] D80887: [clang-tidy] ignore builtin varargs from pro-type-vararg-check

njames93 marked an inline comment as done. njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeVarargCheck.cpp:39 +"__builtin_classify_type", +// "__builtin_va_start", +// "__builtin_stdarg_start", aaron.

[PATCH] D80950: [clang-format] [PR44542,38872] String << String always get a forced newline.

sammccall added a comment. (Oops, hit enter too soon here... will edit the rest in) Lack of tests is bad :-( This is http://github.com/llvm/llvm-project/commit/2603ee0dc6003 which dates back to clang-format early days, before there was good test coverage. Obviously we can add tests for the exi

[PATCH] D80740: [SveEmitter] Add SVE ACLE for svld1ro.

This revision was automatically updated to reflect the committed changes. Closed by commit rG36b8af11d343: [SveEmitter] Add SVE ACLE for svld1ro. (authored by fpetrogalli). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80740/new/ https://reviews.llv

[PATCH] D76795: [HIP] Change default --gpu-max-threads-per-block value to 1024

This revision was automatically updated to reflect the committed changes. yaxunl marked an inline comment as done. Closed by commit rG04abbb3a7818: [HIP] Change default --gpu-max-threads-per-block value to 1024 (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Mono

[PATCH] D80887: [clang-tidy] ignore builtin varargs from pro-type-vararg-check

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeVarargCheck.cpp:39 +"__builtin_classify_type", +// "__builtin_va_start", +// "__builtin_stdarg_start", njames93 wrote: > aaron.ballman wrote: > > I

[PATCH] D80950: [clang-format] [PR44542,38872] String << String always get a forced newline.

sammccall added a comment. IMO this *is* actually a good heuristic: `<<` between string literals indicates some intent to break, and when the stream is entirely literals the formatting is good. (@krasimir threw this into our regression testing, and where the formatting was different, it was alw

[PATCH] D81098: [OpenMP] Upgrade default version of OpenMP to 5.0

saiislam added a comment. Currently, following 75 lit-tests are failing. 1. Clang :: OpenMP/declare_reduction_codegen.c 2. Clang :: OpenMP/declare_reduction_codegen.cpp 3. Clang :: OpenMP/declare_target_messages.cpp 4. Clang :: OpenMP/declare_variant_implementation_vendor_codegen.cpp 5. Clang ::

[PATCH] D78374: [Analyzer][StreamChecker] Added evaluation of fread and fwrite.

balazske abandoned this revision. balazske added a comment. Yes, closing it. (Will change `StreamErrorState` probably to bitfield later.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78374/new/ https://reviews.llvm.org/D78374 __

[PATCH] D80833: [CodeView] Add full repro to LF_BUILDINFO record

amccarth added a comment. In D80833#2069874 , @thakis wrote: > The change description says something about PWD I believe that was a typo for CWD. > Please don't add code that stores absolute paths, but at the moment this > doesn't do that as far as I c

[PATCH] D81061: [Analyzer][VLASizeChecker] Fix problem with zero index assumption.

balazske marked 2 inline comments as done. balazske added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/VLASizeChecker.cpp:127-129 +// Despite the previous assumptions for non-zero and positiveness, +// this value might be zero or negative. +

[PATCH] D80730: [OPENMP50]Codegen for use_device_addr clauses.

ABataev updated this revision to Diff 268219. ABataev added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80730/new/ https://reviews.llvm.org/D80730 Files: clang/lib/AST/OpenMPClause.cpp clang/lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D81061: [Analyzer][VLASizeChecker] Fix problem with zero index assumption.

balazske updated this revision to Diff 268216. balazske added a comment. Improved assumption on array size. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81061/new/ https://reviews.llvm.org/D81061 Files: clang/lib/StaticAnalyzer/Checkers/VLASize

[PATCH] D81041: Use existing path sep style in clang::FileManager::FixupRelativePath

amccarth added a comment. Please make sure all of the clang VFS tests still pass before submitted this. VFS paths are inherently problematic with `llvm::sys::path` because they can legitimately be in a hybrid of Windows and Posix styles. Guessing the style from the first separator you see can

[clang] 7113271 - [analyzer] ObjCAutoreleaseWriteChecker: Support explicit autoreleasepools.

Author: Paul Pelzl Date: 2020-06-03T19:06:04+03:00 New Revision: 7113271528a4c6efc8b57f25ead28f65b5e48757 URL: https://github.com/llvm/llvm-project/commit/7113271528a4c6efc8b57f25ead28f65b5e48757 DIFF: https://github.com/llvm/llvm-project/commit/7113271528a4c6efc8b57f25ead28f65b5e48757.diff LO

[clang] e941921 - [analyzer] Add support for ObjCIndirectCopyRestoreExpr.

Author: Paul Pelzl Date: 2020-06-03T19:06:04+03:00 New Revision: e94192198f8a949c7880620b06e9ef85d87ad4b3 URL: https://github.com/llvm/llvm-project/commit/e94192198f8a949c7880620b06e9ef85d87ad4b3 DIFF: https://github.com/llvm/llvm-project/commit/e94192198f8a949c7880620b06e9ef85d87ad4b3.diff LO

cfe-commits@lists.llvm.org

miyuki added inline comments. Comment at: clang/test/CodeGen/aarch64-bf16-dotprod-intrinsics.c:2 +// RUN: %clang_cc1 -triple aarch64-arm-none-eabi \ +// RUN: -O2 -target-feature +neon -target-feature +bf16 \ +// RUN: -emit-llvm -o - %s | FileCheck %s Is it po

[PATCH] D81107: Make syntax tree test print the line number when it fails

gribozavr created this revision. gribozavr added a reviewer: hlopko. Herald added a project: clang. Herald added a subscriber: cfe-commits. The syntax tree test uses a helper function that executes all testing assertions. When an assertion fails, the only line number that gets printed to the log r

[PATCH] D79830: Add support of __builtin_expect_with_probability

LukeZhuang updated this revision to Diff 268226. LukeZhuang added a comment. **updated 06/03/2020**: (1) fix bug of range checking in SemaChecking CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79830/new/ https://reviews.llvm.org/D79830 Files: clang/include/clang/Basic/Builtins.def

[PATCH] D79830: Add support of __builtin_expect_with_probability

LukeZhuang marked 4 inline comments as done. LukeZhuang added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:1818-1819 +llvm::APFloat Probability = Eval.Val.getFloat(); +if (!(Probability >= llvm::APFloat(0.0) || + Probability <= llvm::APFloat(1.0))

[PATCH] D81071: [analyzer] Add initial support for ObjCIndirectCopyRestoreExpr.

This revision was automatically updated to reflect the committed changes. Closed by commit rGe94192198f8a: [analyzer] Add support for ObjCIndirectCopyRestoreExpr. (authored by Paul Pelzl , committed by dergachev.a). Herald added a project: clang. Herald added a subscriber: cfe-c

[PATCH] D81072: [analyzer] ObjCAutoreleaseWriteChecker: Support explicit autoreleasepools.

This revision was automatically updated to reflect the committed changes. Closed by commit rG7113271528a4: [analyzer] ObjCAutoreleaseWriteChecker: Support explicit autoreleasepools. (authored by Paul Pelzl , committed by dergachev.a). Herald added a project: clang. Herald added

[PATCH] D69825: [Clang][Driver] Re-use the calling process instead of creating a new process for the cc1 invocation

dim added a comment. In D69825#2070926 , @hans wrote: > In D69825#2063979 , @dim wrote: > > > FWIW, this change causes > > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=246630, see in particular > > https://bu

[PATCH] D80450: [CUDA][HIP] Fix implicit HD function resolution

tra added a comment. In D80450#2055463 , @tra wrote: > Is this patch supposed to be used with D79526 > or instead of it? ^^^ I don't think this has been answered. I would like to test this change before it lands. CHA

[PATCH] D79948: [OPENMP50]Codegen for inscan reductions in worksharing directives.

ABataev updated this revision to Diff 268242. ABataev added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79948/new/ https://reviews.llvm.org/D79948 Files: clang/include/clang/AST/OpenMPClause.h clang/include/clang/AST/Recurs

[clang] bee2c27 - [doc] Fix typo.

Author: Richard Smith Date: 2020-06-03T09:56:38-07:00 New Revision: bee2c2708f3e38261825439bc8b0fbe8b795854d URL: https://github.com/llvm/llvm-project/commit/bee2c2708f3e38261825439bc8b0fbe8b795854d DIFF: https://github.com/llvm/llvm-project/commit/bee2c2708f3e38261825439bc8b0fbe8b795854d.diff

[PATCH] D80743: (PR46111) Desugar Elaborated types in Deduction Guides.

mclow.lists added a comment. I've got nothing to say here. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80743/new/ https://reviews.llvm.org/D80743 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[PATCH] D81041: Use existing path sep style in clang::FileManager::FixupRelativePath

ctetreau added a comment. @amccarth The assert that I am getting is at line 1701 of VirtualFileSystem.cpp: assert(!isTraversalComponent(*Start) && !isTraversalComponent(From->getName()) && "Paths should not contain traversal components"); path is `C:/[path]/[to]/[build]

[PATCH] D79587: [CodeGen][SVE] Legalisation of extends with scalable types

kmclaughlin updated this revision to Diff 268246. kmclaughlin added a comment. - Use APInt::trunc to truncate the constant in performSVEAndCombine CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79587/new/ https://reviews.llvm.org/D79587 Files: llvm/include/llvm/CodeGen/ValueTypes.h

[PATCH] D80450: [CUDA][HIP] Fix implicit HD function resolution

yaxunl added a comment. In D80450#2071696 , @tra wrote: > In D80450#2055463 , @tra wrote: > > > Is this patch supposed to be used with D79526 > > or instead of it? > > > ^^^ I don'

[PATCH] D80681: [clang][SourceManager] cache Macro Expansions

nickdesaulniers added a comment. Bumping for review. Are there other trusted reviewers we could add the to review to help? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80681/new/ https://reviews.llvm.org/D80681 ___

[PATCH] D77572: [clang-tidy] add new check readability-use-anyofallof

mgehre added a comment. Sorry for breaking the build and thanks for the fixes! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77572/new/ https://reviews.llvm.org/D77572 ___ cfe-commits mailing list cfe-

[PATCH] D79237: [CUDA][HIP] Fix constexpr variables for C++17

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. Tested with tensorflow build. The patch- does not seem to break anything now. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79237/new/ https://reviews.llvm.org/D79237 ___

[clang] ba4afe6 - [AIX] Change the default target CPU to power4 for AIX on Power

Author: Steven Wan Date: 2020-06-03T13:50:26-04:00 New Revision: ba4afe6f7a8453b24ee0b664e40d157d15a54034 URL: https://github.com/llvm/llvm-project/commit/ba4afe6f7a8453b24ee0b664e40d157d15a54034 DIFF: https://github.com/llvm/llvm-project/commit/ba4afe6f7a8453b24ee0b664e40d157d15a54034.diff LO

[clang] 5f47865 - [doc] Fix use of ` where `` was intended in attribute docs.

Author: Richard Smith Date: 2020-06-03T10:52:55-07:00 New Revision: 5f478651eb31ac81acf9a521c3d44c5e1c4af49a URL: https://github.com/llvm/llvm-project/commit/5f478651eb31ac81acf9a521c3d44c5e1c4af49a DIFF: https://github.com/llvm/llvm-project/commit/5f478651eb31ac81acf9a521c3d44c5e1c4af49a.diff

[PATCH] D80940: [clang-format] [PR46159] Linux kernel 'C' code uses 'try' as a variable name, allow clang-format to handle such cases

MyDeveloperDay added a comment. In D80940#2071247 , @curdeius wrote: > LGTM. > > For a second, I thought that you could simplify the code by removing this > @try condition (and calling the function > `FormatTokenLexer::tryTransformTryUsageForC()` only if

[PATCH] D80950: [clang-format] [PR44542,38872] String << String always get a forced newline.

MyDeveloperDay added a comment. > IMO this *is* actually a good heuristic: `<<` between string literals > indicates some intent to break, and when the stream is entirely literals the > formatting is good. I take your point, how do you feel about an option even if the default was "BreakBetweenS

[PATCH] D80887: [clang-tidy] ignore builtin varargs from pro-type-vararg-check

njames93 updated this revision to Diff 268256. njames93 added a comment. - Detect va_list type VarDecls to warn on Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80887/new/ https://reviews.llvm.org/D80887 Files: clang-tools-extra/clang-tidy/cppco

[PATCH] D79744: clang: Add address space to indirect abi info and use it for kernels

rjmccall added a comment. In D79744#2069962 , @jdoerfert wrote: > In D79744#2069786 , @arsenm wrote: > > > In D79744#2069774 , @arsenm wrote: > > > > > I think this is conver

[PATCH] D79052: [clang codegen] Fix alignment of "Address" for incomplete array pointer.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79052/new/ https://reviews.llvm.org/D79052 ___

[PATCH] D80833: [CodeView] Add full repro to LF_BUILDINFO record

aganea marked an inline comment as done. aganea added a comment. I didn't change the PWD/CWD stored in `LF_BUILDINFO`, it has already been done by Reid a while ago: D53179 (it already stores absolute paths) However absolute paths are stored by design, if we wan

[PATCH] D80835: [AIX] Change the default target CPU to power4 for AIX on Power

This revision was automatically updated to reflect the committed changes. Closed by commit rGba4afe6f7a84: [AIX] Change the default target CPU to power4 for AIX on Power (authored by stevewan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80835/new/

[PATCH] D80833: [CodeView] Add full repro to LF_BUILDINFO record

hans added a comment. In D80833#2071818 , @aganea wrote: > I didn't change the PWD/CWD stored in `LF_BUILDINFO`, it has already been > done by Reid a while ago: D53179 (it > already stores absolute paths) That's surpri

[PATCH] D80804: [AMDGPU] Introduce Clang builtins to be mapped to AMDGCN atomic inc/dec intrinsics

saiislam added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80804/new/ https://reviews.llvm.org/D80804 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D80917: [OpenMP][AMDGCN] Support OpenMP offloading for AMDGCN architecture - Part 2

saiislam updated this revision to Diff 268264. saiislam added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. 1. Added wave32 as an additional alternate wave size. 2. Replaced long long with uint64_t and int with unsigned. 3. Removed unnecessary casts. 4. Moved Op

[PATCH] D80735: [OpenMP][NFC] Reuse OMPIRBuilder `struct ident_t` handling in Clang

jhuber6 added a comment. I'm just investigating migrating D80222 away from the static methods. When I try to just add an OpenMPIRBuilder type and initialize it I get failures on the tests. I'm just adding in the module as you have `CGOpenMPRuntime.h` llvm::

[PATCH] D80743: (PR46111) Desugar Elaborated types in Deduction Guides.

rsmith added inline comments. Comment at: clang/lib/Sema/SemaTemplate.cpp:1962-1964 + QualType TransformElaboratedType(TypeLocBuilder &TLB, ElaboratedTypeLoc TL) { +return TransformType(TLB, TL.getNamedTypeLoc()); + } Removing the qualifier seems like it mi

[PATCH] D80917: [OpenMP][AMDGCN] Support OpenMP offloading for AMDGCN architecture - Part 2

arsenm added inline comments. Comment at: clang/lib/Basic/Targets/AMDGPU.cpp:290 assert(DataLayout->getAllocaAddrSpace() == Private); + GridValues = &(llvm::GPU::AMDGPUGpuGridValues[0]); + LongGridValues = &(llvm::GPU::AMDGPUGpuLongGridValues[0]); Don't need

[PATCH] D80833: [CodeView] Add full repro to LF_BUILDINFO record

thakis added a comment. We don't store physical absolute paths in pdbs if you hold things right. Look for /pdbsourcepath: in http://blog.llvm.org/2019/11/deterministic-builds-with-clang-and-lld.html . rnk's change seems to store the main TU's dir as cwd, which likely either takes the dir from

[clang] 3a1b075 - Define __SPIR__ macro for spir/spir64 targets.

Author: Vyacheslav Zakharin Date: 2020-06-03T12:36:21-07:00 New Revision: 3a1b07506c1fc6e6aee528289341aa0d0d806814 URL: https://github.com/llvm/llvm-project/commit/3a1b07506c1fc6e6aee528289341aa0d0d806814 DIFF: https://github.com/llvm/llvm-project/commit/3a1b07506c1fc6e6aee528289341aa0d0d806814

[PATCH] D80936: [OPENMP]Fix PR46146: Do not consider globalized variables as NRVO candidates.

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM, thx! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80936/new/ https://reviews.llvm.org/D80936 ___

[PATCH] D78637: [OPENMP]Fix PR45383: type dependent array subscripts are diagnosed erroneously.

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78637/new/ https://reviews.llvm.org/D78637 _

[PATCH] D80730: [OPENMP50]Codegen for use_device_addr clauses.

jdoerfert added reviewers: kkwli0, dreachem. jdoerfert added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:7630 +// OMPC_MAP_MODIFIER_last is used to identify data members used in +// used_device_adddr clause. +bool IsMemberPointerOrAd

[PATCH] D80876: [clang] Default to windows response files when running on windows

sbc100 added a comment. In D80876#2070233 , @mstorsjo wrote: > In D80876#2069970 , @sbc100 wrote: > > > Do you know how gcc handles this case when running on mingw? > > > It uses the gnu/unix quoting style - so that

[PATCH] D80383: Add AST_SIGNATURE record to unhashed control block of PCM files

dexonsmith added a comment. In D80383#2068596 , @dang wrote: > I made the decision to make all relative offsets relative to the start of the > AST block rather than their own sub-block or a neighboring block, in order to > prevent adding complexity in `A

[PATCH] D80655: Define __SPIR__ macro for spir/spir64 targets.

This revision was automatically updated to reflect the committed changes. Closed by commit rG3a1b07506c1f: Define __SPIR__ macro for spir/spir64 targets. (authored by vzakhari). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES S

[clang] 6a0484f - [clang-format] [PR46159] Linux kernel 'C' code uses 'try' as a variable name, allow clang-format to handle such cases

Author: mydeveloperday Date: 2020-06-03T20:44:45+01:00 New Revision: 6a0484f04b628870fb7cd0757a72d73294ff5346 URL: https://github.com/llvm/llvm-project/commit/6a0484f04b628870fb7cd0757a72d73294ff5346 DIFF: https://github.com/llvm/llvm-project/commit/6a0484f04b628870fb7cd0757a72d73294ff5346.diff

[clang] 6de794e - [clang-format] [PR46157] Wrong spacing of negative literals with use of operator

Author: mydeveloperday Date: 2020-06-03T20:44:45+01:00 New Revision: 6de794e2074b8d0ceb6215f808fb788555fc683d URL: https://github.com/llvm/llvm-project/commit/6de794e2074b8d0ceb6215f808fb788555fc683d DIFF: https://github.com/llvm/llvm-project/commit/6de794e2074b8d0ceb6215f808fb788555fc683d.diff

[PATCH] D80932: [SYCL] Make default address space a superset of OpenCL address spaces.

Anastasia requested changes to this revision. Anastasia added a comment. This revision now requires changes to proceed. In D80932#2071321 , @bader wrote: > In D80932#2068863 , @Anastasia wrote: > > > > > > > > > Why

[PATCH] D81115: [PowerPC] Do not check for non-Darwin in PowerPC target cpu handling

stevewan created this revision. Herald added subscribers: cfe-commits, steven.zhang, shchenz, nemanjai. Herald added a project: clang. stevewan added reviewers: hubert.reinterpretcast, daltenty. Herald added a subscriber: wuzish. Since Darwin on PowerPC is no longer supported, we'll take the Darwi

[PATCH] D80897: [OpenMP] Initial support for std::complex in target regions

jdoerfert marked an inline comment as done. jdoerfert added inline comments. Comment at: clang/lib/Headers/__clang_cuda_complex_builtins.h:42 +#define _LOGBf _LOGBd +#else +#define _ISNANd isnan This will actually not work right now as we do not overload isinf/i

[PATCH] D80450: [CUDA][HIP] Fix implicit HD function resolution

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM. Combined with D79526 it appears to work for tensorflow build. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80450/new/ https://reviews.llvm.org/D804

[PATCH] D79781: [OpenCL] Add cl_khr_extended_subgroup extensions

Anastasia added a comment. In D79781#2070998 , @PiotrFusik wrote: > > Great! Thanks! Feel free to go ahead and commit this! > > Thanks. Can someone commit this for me, please? Also to 10.0 if possible? Ok, I can commit this. I am afraid the window for 10

[PATCH] D80835: [AIX] Change the default target CPU to power4 for AIX on Power

stevewan marked an inline comment as done. stevewan added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:301 +TargetCPUName = "pwr4"; + else if (!T.isOSDarwin()) { +if (T.getArch() == llvm::Triple::ppc64) hubert.reint

[PATCH] D80743: (PR46111) Desugar Elaborated types in Deduction Guides.

erichkeane marked an inline comment as done. erichkeane added inline comments. Comment at: clang/lib/Sema/SemaTemplate.cpp:1962-1964 + QualType TransformElaboratedType(TypeLocBuilder &TLB, ElaboratedTypeLoc TL) { +return TransformType(TLB, TL.getNamedTypeLoc()); + } ---

[PATCH] D80933: [clang-format] [PR46157] Wrong spacing of negative literals with use of operator

This revision was automatically updated to reflect the committed changes. Closed by commit rG6de794e2074b: [clang-format] [PR46157] Wrong spacing of negative literals with use of operator (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D80940: [clang-format] [PR46159] Linux kernel 'C' code uses 'try' as a variable name, allow clang-format to handle such cases

This revision was automatically updated to reflect the committed changes. Closed by commit rG6a0484f04b62: [clang-format] [PR46159] Linux kernel 'C' code uses 'try' as a variable name… (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[clang] 8bd7e41 - Replace separator in OpenMP variant name mangling.

Author: Lukas Sommer Date: 2020-06-03T16:36:32-04:00 New Revision: 8bd7e4188a096b063065aac70ce39129c479f124 URL: https://github.com/llvm/llvm-project/commit/8bd7e4188a096b063065aac70ce39129c479f124 DIFF: https://github.com/llvm/llvm-project/commit/8bd7e4188a096b063065aac70ce39129c479f124.diff

[PATCH] D81117: Fix path separator issue on Windows

ctetreau created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The following 3 tests fail on Windows: Clang :: ClangScanDeps/header_stat_before_open.m Clang :: ClangScanDeps/static-analyzer.c Clang :: ClangScanDeps/vfsoverlay.cpp The issue is that bad filen

[PATCH] D79948: [OPENMP50]Codegen for inscan reductions in worksharing directives.

jdoerfert added a comment. Looks good, puzzled about the one changed mentioned below. Comment at: clang/lib/Sema/SemaOpenMP.cpp:14900 } -continue; } Why would we continue after this error? Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D80439: Replace separator in OpenMP variant name mangling.

This revision was automatically updated to reflect the committed changes. Closed by commit rG8bd7e4188a09: Replace separator in OpenMP variant name mangling. (authored by LukasSommerTu, committed by tianshilei1992). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[clang-tools-extra] e636e6b - [clang-tidy]: Added modernize-replace-disallow-copy-and-assign-macro

Author: Konrad Kleine Date: 2020-06-03T16:56:03-04:00 New Revision: e636e6b79ac06b13059e46b49acb4d9de204c75b URL: https://github.com/llvm/llvm-project/commit/e636e6b79ac06b13059e46b49acb4d9de204c75b DIFF: https://github.com/llvm/llvm-project/commit/e636e6b79ac06b13059e46b49acb4d9de204c75b.diff

[clang] d496437 - [WebAssembly] Add support for -mexec-model=reactor

Author: Dan Gohman Date: 2020-06-03T14:02:47-07:00 New Revision: d496437a0bfd6d135343026cdb7b6a69cb6af536 URL: https://github.com/llvm/llvm-project/commit/d496437a0bfd6d135343026cdb7b6a69cb6af536 DIFF: https://github.com/llvm/llvm-project/commit/d496437a0bfd6d135343026cdb7b6a69cb6af536.diff LO

[clang] dd863cc - [X86] Separate X86_CPU_TYPE_COMPAT_WITH_ALIAS from X86_CPU_TYPE_COMPAT. NFC

Author: Craig Topper Date: 2020-06-03T14:13:12-07:00 New Revision: dd863ccae1346a44e4380fb17d22ae7041fee898 URL: https://github.com/llvm/llvm-project/commit/dd863ccae1346a44e4380fb17d22ae7041fee898 DIFF: https://github.com/llvm/llvm-project/commit/dd863ccae1346a44e4380fb17d22ae7041fee898.diff

[PATCH] D79948: [OPENMP50]Codegen for inscan reductions in worksharing directives.

ABataev marked an inline comment as done. ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:14900 } -continue; } jdoerfert wrote: > Why would we continue after this error? The function, that uses VLAs, might be proce

[PATCH] D80917: [OpenMP][AMDGCN] Support OpenMP offloading for AMDGCN architecture - Part 2

jdoerfert added inline comments. Comment at: clang/include/clang/Basic/TargetInfo.h:202 + const unsigned *GridValues; + const uint64_t *LongGridValues; I would recommend adding a descriptive comment, even though that seems not to be the norm here. Why do we

[PATCH] D80735: [OpenMP][NFC] Reuse OMPIRBuilder `struct ident_t` handling in Clang

jdoerfert added a comment. In D80735#2071897 , @jhuber6 wrote: > I'm just investigating migrating D80222 > away from the static methods. When I try to just add an OpenMPIRBuilder type > and initialize it I get failures o

[PATCH] D80492: Avoid linking libdl unless needed

lebedev.ri added a comment. FYI as reported on IRC, this likely breaks standalone build of clang standalone builds of clang are still supported right ? commit 0073c293a401774ac96b4b3d27f05e13f379f98e seems to break them, since HAVE_LIBDL is not defined (it requires config-ix include from llv

[PATCH] D79961: [PGO] Fix computation of fuction Hash

serge-sans-paille added a comment. In D79961#2065605 , @alanphipps wrote: > It looks like clang/test/Profile/Inputs/c-general.profdata.v5 is being read > as v6 rather than v5. Can you double check? Yep, I'll have a look. Repository: rG LLVM Github

[PATCH] D62922: [WebAssembly] Implement "Reactor" mode

This revision was automatically updated to reflect the committed changes. Closed by commit rGd496437a0bfd: [WebAssembly] Add support for -mexec-model=reactor (authored by sunfishcode). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62922/new/ https:/

[PATCH] D80531: [clang-tidy]: Added modernize-replace-disallow-copy-and-assign-macro

This revision was automatically updated to reflect the committed changes. Closed by commit rGe636e6b79ac0: [clang-tidy]: Added modernize-replace-disallow-copy-and-assign-macro (authored by kwk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80531/new

[PATCH] D80730: [OPENMP50]Codegen for use_device_addr clauses.

ABataev updated this revision to Diff 268299. ABataev added a comment. Rebase + fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80730/new/ https://reviews.llvm.org/D80730 Files: clang/lib/AST/OpenMPClause.cpp clang/lib/CodeGen/CGOpenMPRunt

[clang-tools-extra] 49cbe56 - [clangd] Fix forgotten propagation of AsnycPreamble flag

Author: Kadir Cetinkaya Date: 2020-06-03T23:56:49+02:00 New Revision: 49cbe56a657b91e612f8305e7f8f9119ffe84378 URL: https://github.com/llvm/llvm-project/commit/49cbe56a657b91e612f8305e7f8f9119ffe84378 DIFF: https://github.com/llvm/llvm-project/commit/49cbe56a657b91e612f8305e7f8f9119ffe84378.dif

<    1   2   3   >