[PATCH] D80851: [llvm][SveEmitter] SVE ACLE for quadword permute intrinsics.

2020-05-29 Thread Francesco Petrogalli via Phabricator via cfe-commits
fpetrogalli created this revision. fpetrogalli added reviewers: efriedma, sdesmalen, kmclaughlin. Herald added subscribers: cfe-commits, kristof.beyls, tschuett. Herald added a reviewer: rengolin. Herald added a project: clang. The following intrinsics have been added, guarded by the macro `__ARM_

[PATCH] D80840: [Clang][CGM] style cleanups NFC

2020-05-29 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers updated this revision to Diff 267399. nickdesaulniers added a comment. - add missed `{`, actually compile test and check all Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80840/new/ https://reviews.llvm.org/D80840 Files: clang/li

[PATCH] D80840: [Clang][CGM] style cleanups NFC

2020-05-29 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers marked an inline comment as done. nickdesaulniers added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:5374 case Decl::CXXRecord: -if (DebugInfo) { +if (CGDebugInfo *DI = getModuleDebugInfo()) if (auto *ES = D->getASTContext().g

[PATCH] D80315: Fix CC1 command line options mapping into fast-math flags.

2020-05-29 Thread Michele Scandale via Phabricator via cfe-commits
michele.scandale updated this revision to Diff 267401. michele.scandale added a comment. Revert last change about `-ffast-math` imply "fast" contraction mode by default in CC1. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80315/new/ https

[PATCH] D76791: [Matrix] Implement matrix index expressions ([][]).

2020-05-29 Thread Florian Hahn via Phabricator via cfe-commits
fhahn added a comment. In D76791#2063926 , @rjmccall wrote: > > Yes at the moment I think we want to limit element wise > > accesses/modifications to go through the access operator only, to guarantee > > we can rely on the vector forms in codegen. > > >

[PATCH] D80840: [Clang][CGM] style cleanups NFC

2020-05-29 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers updated this revision to Diff 267403. nickdesaulniers added a comment. - actually, braces were unnecessary Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80840/new/ https://reviews.llvm.org/D80840 Files: clang/lib/CodeGen/CodeGenM

[PATCH] D80840: [Clang][CGM] style cleanups NFC

2020-05-29 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers added a comment. I've learned the hard way not to commit code Friday >4pm. Will land Monday. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80840/new/ https://reviews.llvm.org/D80840 __

[clang] 03559c6 - [diagtool] Install diagtool when LLVM_INSTALL_TOOLCHAIN_ONLY is ON.

2020-05-29 Thread Volodymyr Sapsai via cfe-commits
Author: Volodymyr Sapsai Date: 2020-05-29T16:25:06-07:00 New Revision: 03559c684a9bfe4de142fa4a7d2ef1edf08a8ad3 URL: https://github.com/llvm/llvm-project/commit/03559c684a9bfe4de142fa4a7d2ef1edf08a8ad3 DIFF: https://github.com/llvm/llvm-project/commit/03559c684a9bfe4de142fa4a7d2ef1edf08a8ad3.di

[PATCH] D80828: [Clang][A32/T32][Linux] -O2 implies -fomit-frame-pointer

2020-05-29 Thread Stephen Hines via Phabricator via cfe-commits
srhines added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:560 // Don't use a frame pointer on linux if optimizing for certain targets. +case llvm::Triple::arm: +case llvm::Triple::armeb: For the new targets, we should only be c

[PATCH] D80770: [diagtool] Install diagtool when LLVM_INSTALL_TOOLCHAIN_ONLY is ON.

2020-05-29 Thread Volodymyr Sapsai via Phabricator via cfe-commits
vsapsai added a comment. Thanks for the review, Jonas! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80770/new/ https://reviews.llvm.org/D80770 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D80770: [diagtool] Install diagtool when LLVM_INSTALL_TOOLCHAIN_ONLY is ON.

2020-05-29 Thread Volodymyr Sapsai via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG03559c684a9b: [diagtool] Install diagtool when LLVM_INSTALL_TOOLCHAIN_ONLY is ON. (authored by vsapsai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80770/

[PATCH] D80828: [Clang][A32/T32][Linux] -O2 implies -fomit-frame-pointer

2020-05-29 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:560 // Don't use a frame pointer on linux if optimizing for certain targets. +case llvm::Triple::arm: +case llvm::Triple::armeb: srhines wrote: > For the new tar

[PATCH] D76791: [Matrix] Implement matrix index expressions ([][]).

2020-05-29 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. In D76791#2064434 , @fhahn wrote: > In D76791#2063926 , @rjmccall wrote: > > > > Yes at the moment I think we want to limit element wise > > > accesses/modifications to go through the acce

[PATCH] D60108: [os_log] Mark os_log_helper `nounwind`

2020-05-29 Thread Akira Hatanaka via Phabricator via cfe-commits
ahatanak added inline comments. Comment at: test/CodeGenObjCXX/os_log.mm:3 +// RUN: -fexceptions -fcxx-exceptions -O1 | FileCheck %s + +// Check that no EH cleanup is emitted around the call to __os_log_helper. Sorry for the late feedback. Can we pass `-O0` in

[PATCH] D80315: Fix CC1 command line options mapping into fast-math flags.

2020-05-29 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. Per a private discussion, it seems like the right thing to do here would be stop recognizing `-ffast-math` flag in cc1 and just put the driver in charge of all these individual flags. That may necessitate adding a `-fdefine-fast-math` cc1 option to control the `#defin

[PATCH] D80836: Support GCC [[gnu::attributes]] in C2x mode

2020-05-29 Thread Erich Keane via Phabricator via cfe-commits
erichkeane accepted this revision. erichkeane added a comment. In D80836#2064182 , @dblaikie wrote: > (sorry @erichkeane didn't mean to usurp your feedback by approving before it > was answered - @aaron.ballman do treat my approval as contingent on that

[PATCH] D80315: Fix CC1 command line options mapping into fast-math flags.

2020-05-29 Thread Michele Scandale via Phabricator via cfe-commits
michele.scandale added a comment. Thanks John. Would you be able to land this on my behalf? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80315/new/ https://reviews.llvm.org/D80315 ___ cfe-commits mai

[PATCH] D71687: Fix full loop unrolling initialization in new pass manager

2020-05-29 Thread Eric Christopher via Phabricator via cfe-commits
echristo updated this revision to Diff 267424. echristo marked an inline comment as done. echristo added a comment. Update and restructure some test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71687/new/ https://reviews.llvm.org/D71687 Fi

[PATCH] D71687: Fix full loop unrolling initialization in new pass manager

2020-05-29 Thread Eric Christopher via Phabricator via cfe-commits
echristo marked 7 inline comments as done. echristo added a comment. Done. New diff incoming. Comment at: clang/test/Misc/loop-opt-setup.c:12 +// Check br i1 to make sure that the loop is fully unrolled // CHECK-NOT: br i1 chandlerc wrote: > This is dead now

[PATCH] D71687: Fix full loop unrolling initialization in new pass manager

2020-05-29 Thread Chandler Carruth via Phabricator via cfe-commits
chandlerc accepted this revision. chandlerc added a comment. Cool, thanks and LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71687/new/ https://reviews.llvm.org/D71687 ___ cfe-commits mailing list

[clang] c554c5e - Fix full unrolling with new pass manager.

2020-05-29 Thread Eric Christopher via cfe-commits
Author: Eric Christopher Date: 2020-05-29T20:08:21-07:00 New Revision: c554c5e159aee43c5cd8236e077817e9f29dea78 URL: https://github.com/llvm/llvm-project/commit/c554c5e159aee43c5cd8236e077817e9f29dea78 DIFF: https://github.com/llvm/llvm-project/commit/c554c5e159aee43c5cd8236e077817e9f29dea78.di

[PATCH] D80858: [HIP] Support accessing static device variable in host code

2020-05-29 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl created this revision. yaxunl added reviewers: tra, rjmccall. nvcc supports accessing file-scope static device variables in host code by host APIs like cudaMemcpyToSymbol etc. HIP let users access device variables in host code by shadow variables. In host compilation, clang emits a shado

[PATCH] D80804: [AMDGPU] Introduce Clang builtins to be mapped to AMDGCN atomic inc/dec intrinsics

2020-05-29 Thread Sameer Sahasrabuddhe via Phabricator via cfe-commits
sameerds added a comment. In D80804#2063522 , @saiislam wrote: > In D80804#2063451 , @sameerds wrote: > > > Actually, the question really is about why inc/dec are needed as separate > > operations either as IR intr

[PATCH] D80804: [AMDGPU] Introduce Clang builtins to be mapped to AMDGCN atomic inc/dec intrinsics

2020-05-29 Thread Sameer Sahasrabuddhe via Phabricator via cfe-commits
sameerds accepted this revision. sameerds added a comment. LGTM, but please wait for approval from @arsenm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80804/new/ https://reviews.llvm.org/D80804 ___ c

<    1   2   3