rjmccall added a comment. Per a private discussion, it seems like the right thing to do here would be stop recognizing `-ffast-math` flag in cc1 and just put the driver in charge of all these individual flags. That may necessitate adding a `-fdefine-fast-math` cc1 option to control the `#define`, but the logic for that seems complex enough that it ought to be left to the driver.
Separately, we should consider making some more driver options imply `-ffp-contract=fast`. Fast contraction is the default behavior in GCC, and while Clang has chosen not to follow that precedent, it seems to be in keeping with the spirit of options like `-funsafe-math-optimizations` that they should broadly enable contraction if that policy isn't otherwise specified. Those sorts of changes should be kept separate from this kind of refactor, though. This is still approved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80315/new/ https://reviews.llvm.org/D80315 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
