[PATCH] D78442: Create a warning flag for 'warn_conv_*_not_used'

ASDenysPetrov added a comment. I suddenly discovered you unnoticed revision. I'd advise you to add more reviewers or subscribers here. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78442/new/ https://reviews.llvm.org/D78442 ___ cfe-commits

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

whisperity resigned from this revision. whisperity added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/CrossTU/CrossTranslationUnit.cpp:26 +#include "llvm/ADT/Triple.h" +#include "llvm/Option/ArgList.h" #include "llvm/Support/ErrorHandli

[clang] d20bf5a - [DebugInfo] Upgrade DISubrange to support Fortran dynamic arrays

Author: Alok Kumar Sharma Date: 2020-05-28T13:46:41+05:30 New Revision: d20bf5a7258d4b6a7f017a81b125275dac1aa166 URL: https://github.com/llvm/llvm-project/commit/d20bf5a7258d4b6a7f017a81b125275dac1aa166 DIFF: https://github.com/llvm/llvm-project/commit/d20bf5a7258d4b6a7f017a81b125275dac1aa166.d

[PATCH] D80023: [clang-tidy] Add abseil-string-find-str-contains checker.

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/abseil/StringFindStrContainsCheck.cpp:40-44 + // FIXME(tdl-g): These options are being parsed redundantly with the + // constructor because TransformerClangTidyCheck forces us to provide MakeRule + // b

[PATCH] D80697: [clang-tidy] Reworked TransformerClangTidyCheck to simplify usage of Options

njames93 created this revision. njames93 added reviewers: aaron.ballman, gribozavr2, alexfh. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. Changed `TransformerClangTidyCheck` to have a virtual method generate the rule. This has the advantages of making handling

[PATCH] D80293: [clangd] Run PreambleThread in async mode behind a flag

sammccall added inline comments. Comment at: clang-tools-extra/clangd/TUScheduler.cpp:1138 + if (!wait(Lock, RequestsCV, Timeout, +[&] { return Requests.empty() && !CurrentRequest; })) +return false; I'd consider pulling out an IsIdle lambda (che

[PATCH] D80668: [Clang][Sanitizers] Expect test failure on {arm,thumb}v7

glider added inline comments. Comment at: clang/test/CodeGen/sanitize-coverage.c:8 +// +// XFAIL: armv7, thumbv7 Is there a Bugzilla entry for this? Please add a link to the code and to the patch description. Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D80197: [DebugInfo] Upgrade DISubrange to support Fortran dynamic arrays

This revision was automatically updated to reflect the committed changes. Closed by commit rGd20bf5a7258d: [DebugInfo] Upgrade DISubrange to support Fortran dynamic arrays (authored by alok, committed by SouraVX). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prio

[PATCH] D80369: [DebugInfo][CallSites] Remove decl subprograms from 'retainedTypes:'

djtodoro added a comment. In D80369#2057866 , @dblaikie wrote: > Not sure I follow - why was it a problem that there was no DISubprogram at > all? Actually, since the DISubprograms from the retained types don't affect the final DWARF, it's not a proble

[PATCH] D80697: [clang-tidy] Reworked TransformerClangTidyCheck to simplify usage of Options

gribozavr2 added a reviewer: ymandel. gribozavr2 added a subscriber: ymandel. gribozavr2 added a comment. @ymandel owns transformers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80697/new/ https://reviews.llvm.org/D80697 __

[PATCH] D80685: [ASTMatchers] Add traversal-kind support to `DynTypedMatcher`

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/ASTMatchers/ASTMatchersInternal.cpp:234 +DynTypedMatcher::constructWithTraversalKind(DynTypedMatcher InnerMatcher, +

[PATCH] D80668: [Clang][Sanitizers] Expect test failure on {arm,thumb}v7

melver updated this revision to Diff 266773. melver added a comment. Add link to bug. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80668/new/ https://reviews.llvm.org/D80668 Files: clang/test/CodeGen/sanitize-coverage.c Index: clang/test/Code

[PATCH] D80369: [DebugInfo][CallSites] Remove decl subprograms from 'retainedTypes:'

djtodoro updated this revision to Diff 266776. djtodoro added a comment. -Tests clean up CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80369/new/ https://reviews.llvm.org/D80369 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/test/CodeGen/debug-info-extern-call.c clang/test/Module

[PATCH] D80699: [Analyzer][StreamChecker] Add check for pointer escape.

balazske created this revision. Herald added subscribers: cfe-commits, ASDenysPetrov, martong, Charusso, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a project: clang. After an escape

[PATCH] D80606: [libTooling] Fix Transformer to work with ambient traversal kinds

gribozavr2 accepted this revision. gribozavr2 added inline comments. Comment at: clang/lib/Tooling/Transformer/RewriteRule.cpp:154 +const RewriteRule &Rule, +ast_type_traits::TraversalKind DefaultTraversalKind) { // Map the cases into buckets of matchers -- one for eac

[clang] 69935d8 - [Clang][Sanitizers] Expect test failure on {arm, thumb}v7

Author: Marco Elver Date: 2020-05-28T11:33:32+02:00 New Revision: 69935d86aed1b691c5f33a2141f15cb3aaee1af6 URL: https://github.com/llvm/llvm-project/commit/69935d86aed1b691c5f33a2141f15cb3aaee1af6 DIFF: https://github.com/llvm/llvm-project/commit/69935d86aed1b691c5f33a2141f15cb3aaee1af6.diff L

[PATCH] D80117: [analyzer] Introduce reasoning about symbolic remainder operator

vsavchenko added a comment. Performance-wise, I've investigated huge slowdowns on `tmux` and `pytorch`. - `pytorch` build produces a lot of warnings and simply trashed my terminal. I guess one time it had more troubles with displaying all that than the other. Here is a table with new times:

[PATCH] D80668: [Clang][Sanitizers] Expect test failure on {arm,thumb}v7

This revision was automatically updated to reflect the committed changes. Closed by commit rG69935d86aed1: [Clang][Sanitizers] Expect test failure on {arm,thumb}v7 (authored by melver). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80668/new/ https:

[PATCH] D79411: [VE] Clang toolchain for VE

simoll added a comment. Ping. Anything i can do to get this reviewed? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79411/new/ https://reviews.llvm.org/D79411 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D80366: [Analyzer] Add `getReturnValueUnderConstruction()` to `CallEvent`

martong added inline comments. Comment at: clang/unittests/StaticAnalyzer/TestReturnValueUnderConstruction.cpp:24 +public: + void checkPostCall(const CallEvent &Call, CheckerContext &C) const { +if (!Call.getOriginExpr()) I assume this tests this call expre

[PATCH] D80704: Remove WrapperMatcherInterface

gribozavr created this revision. Herald added subscribers: cfe-commits, arichardson. Herald added a project: clang. gribozavr2 added a reviewer: ymandel. WrapperMatcherInterface is an abstraction over a member variable -- in other words, not much of an abstraction at all. I think it makes code har

[PATCH] D78990: [analyzer] Allow bindings of the CompoundLiteralRegion

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Great, thanks! Comment at: clang/unittests/StaticAnalyzer/StoreTest.cpp:66 -Store StInit = StMgr.getInitialStore(SFC).getStore(); -SVal Zero = SVB.makeZeroVal(ACtx.IntTy)

[PATCH] D80508: [AST] Fix the source range for TagDecl if there is no matched } brace.

sammccall added a comment. Argh I never submitted these comments, sorry. Comment at: clang/lib/AST/Decl.cpp:4129 SourceRange TagDecl::getSourceRange() const { - SourceLocation RBraceLoc = BraceRange.getEnd(); - SourceLocation E = RBraceLoc.isValid() ? RBraceLoc : getLocation

[PATCH] D79400: [CMAKE] Fix build failure when source directory is read only

pdhaliwal updated this revision to Diff 266794. pdhaliwal marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79400/new/ https://reviews.llvm.org/D79400 Files: llvm/cmake/modules/AddLLVM.cmake llvm/include/llvm/Suppor

[PATCH] D79117: [clang] [Darwin] Add reverse mappings for aarch64/aarch64_32 to darwin arch names

mstorsjo added a reviewer: rjmccall. mstorsjo added a comment. Adding some more Apple reviewers on this one - who can give it a look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79117/new/ https://reviews.llvm.org/D79117 __

[PATCH] D79400: [CMAKE] Fix build failure when source directory is read only

pdhaliwal added inline comments. Comment at: llvm/cmake/modules/AddLLVM.cmake:1945 + if (NOT touch_head_result EQUAL 0) +return() + endif() scott.linder wrote: > This seems to implement the behavior that when the log is not present a

[clang] d283fc4 - [DebugInfo] Use SplitTemplateClosers (foo >) in DWARF too

Author: Sam McCall Date: 2020-05-28T12:30:38+02:00 New Revision: d283fc4f9d07a5f3334fe682ccabfc16e8d2933b URL: https://github.com/llvm/llvm-project/commit/d283fc4f9d07a5f3334fe682ccabfc16e8d2933b DIFF: https://github.com/llvm/llvm-project/commit/d283fc4f9d07a5f3334fe682ccabfc16e8d2933b.diff LO

[PATCH] D80366: [Analyzer] Add `getReturnValueUnderConstruction()` to `CallEvent`

balazske added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/ExprEngineCXX.cpp:112 +Optional ExprEngine::retrieveFromConstructionContext( +ProgramStateRef State, const LocationContext *LCtx, baloghadamsoftware wrote: > baloghadamsoftware wrote:

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

MyDeveloperDay updated this revision to Diff 266799. MyDeveloperDay added a comment. Minor change for the simpler review comments before refactoring some of the more involved ones CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69764/new/ https://reviews.llvm.org/D69764 Files: clang/d

[PATCH] D80554: [DebugInfo] Use SplitTemplateClosers (foo >) in DWARF too

This revision was automatically updated to reflect the committed changes. Closed by commit rGd283fc4f9d07: [DebugInfo] Use SplitTemplateClosers (foo >) in DWARF too (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80554

[PATCH] D80117: [analyzer] Introduce reasoning about symbolic remainder operator

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Aha, so performance regressions on real code weren't real, that's a relief :) > I believe that as of now we can submit these modifications as is and explore > performance optimizations later if need

[clang] bd06c41 - [analyzer] Allow bindings of the CompoundLiteralRegion

Author: Valeriy Savchenko Date: 2020-05-28T14:11:57+03:00 New Revision: bd06c417e6c717cbe33b566d7bbaf27fb47e763a URL: https://github.com/llvm/llvm-project/commit/bd06c417e6c717cbe33b566d7bbaf27fb47e763a DIFF: https://github.com/llvm/llvm-project/commit/bd06c417e6c717cbe33b566d7bbaf27fb47e763a.d

[PATCH] D80197: [DebugInfo] Upgrade DISubrange to support Fortran dynamic arrays

thakis added a comment. This breaks check-llvm on Windows: http://45.33.8.238/win/16214/step_11.txt Please take a look and revert if it takes a while to investigate. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80197/new/ https://reviews.llvm.org

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

MyDeveloperDay marked an inline comment as done. MyDeveloperDay added inline comments. Comment at: clang/lib/Format/EastWestConstFixer.cpp:130 + +static void swapFourTokens(const SourceManager &SourceMgr, + tooling::Replacements &Fixes, ---

[PATCH] D78990: [analyzer] Allow bindings of the CompoundLiteralRegion

This revision was automatically updated to reflect the committed changes. Closed by commit rGbd06c417e6c7: [analyzer] Allow bindings of the CompoundLiteralRegion (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78990/new/ http

[clang-tools-extra] a56141b - [clangd] Highlight related control flow.

Author: Sam McCall Date: 2020-05-28T13:25:11+02:00 New Revision: a56141b8f9fea112c1ea078c974d91949b6e7a5c URL: https://github.com/llvm/llvm-project/commit/a56141b8f9fea112c1ea078c974d91949b6e7a5c DIFF: https://github.com/llvm/llvm-project/commit/a56141b8f9fea112c1ea078c974d91949b6e7a5c.diff LO

[PATCH] D80293: [clangd] Run PreambleThread in async mode behind a flag

kadircet marked 22 inline comments as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/TUScheduler.cpp:724 std::move(Req.WantDiags)); +// Set it after notifying ASTPeer about the preamble to prevent any races. +BuiltFi

[PATCH] D80366: [Analyzer] Add `getReturnValueUnderConstruction()` to `CallEvent`

martong added inline comments. Comment at: clang/unittests/StaticAnalyzer/TestReturnValueUnderConstruction.cpp:28 + +Optional RetVal = Call.getReturnValueUnderConstruction(0); +assert(RetVal); How do we know that `0` is the proper block count? CHANGES

[PATCH] D50078: clang-format: support aligned nested conditionals formatting

krasimir added a comment. In D50078#2053324 , @krasimir wrote: > I'm happy with this patch! > > We found a couple of rough edges: > > - alignment after `?:` and > - new formatting of `_ ? _ ? _ : _ : _` patterns is bad > > These are illustrated as exampl

[PATCH] D80293: [clangd] Run PreambleThread in async mode behind a flag

kadircet updated this revision to Diff 266814. kadircet marked 2 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80293/new/ https://reviews.llvm.org/D80293 Files: clang-tools-ex

[PATCH] D78454: [clangd] Highlight related control flow.

This revision was automatically updated to reflect the committed changes. sammccall marked an inline comment as done. Closed by commit rGa56141b8f9fe: [clangd] Highlight related control flow. (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D78454?vs=264734&id=266817#t

[clang] f9e94eb - [Clang] Enable _Complex __float128

Author: Nemanja Ivanovic Date: 2020-05-28T06:55:49-05:00 New Revision: f9e94eb8688d1fe1727360462e957fbbfb754e59 URL: https://github.com/llvm/llvm-project/commit/f9e94eb8688d1fe1727360462e957fbbfb754e59 DIFF: https://github.com/llvm/llvm-project/commit/f9e94eb8688d1fe1727360462e957fbbfb754e59.di

[PATCH] D75044: [AArch64] __builtin_return_address for PAuth.

danielkiss added a comment. Related ticket for gcc: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94891 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75044/new/ https://reviews.llvm.org/D75044 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D80374: [Clang] Enable KF and KC mode for [_Complex] __float128

nemanjai updated this revision to Diff 266820. nemanjai added a comment. Handled invalid uses of `KI` as there is no corresponding integer mode and added testing for it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80374/new/ https://reviews.llvm

[PATCH] D80531: [clang-tidy]: Added modernize-replace-disallow-copy-and-assign-macro

kwk added a comment. @njames93 and @Eugene.Zelenko do you guys think this patch is ready to be approved and land? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80531/new/ https://reviews.llvm.org/D80531 _

[PATCH] D77942: [Preamble] Invalidate preamble when missing headers become present.

sammccall added inline comments. Comment at: clang/lib/Frontend/PrecompiledPreamble.cpp:101 + + // We always receive FileNotFound followed by InclusionDirective. + // We want the former, so we're completely sure the file was missing. kadircet wrote: > is there

[PATCH] D80374: [Clang] Enable KF and KC mode for [_Complex] __float128

nemanjai marked 3 inline comments as done. nemanjai added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:3970 + DestWidth = 128; + break; case 'T': rjmccall wrote: > rjmccall wrote: > > Are there interactions with the other mode speci

[PATCH] D77942: [Preamble] Invalidate preamble when missing headers become present.

sammccall updated this revision to Diff 266822. sammccall marked 6 inline comments as done. sammccall added a comment. Finally address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77942/new/ https://reviews.llvm.org/D77942 Files: clang

[PATCH] D80533: [Clang] Enable _Complex __float

This revision was automatically updated to reflect the committed changes. Closed by commit rGf9e94eb8688d: [Clang] Enable _Complex __float128 (authored by nemanjai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80533/new/ https://reviews.llvm.org/D

[PATCH] D80492: Avoid linking libdl unless needed

thieta added a comment. @mstorsjo mind landing this for me as well? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80492/new/ https://reviews.llvm.org/D80492 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D80366: [Analyzer] Add `getReturnValueUnderConstruction()` to `CallEvent`

martong added a comment. In this version of the patch you are using `handleConstructionContext` to "retrieve" or read an SVal for the construction. However, it seems like that function was designed to store values in the GDM for individual construction context items. To mix a read-only function

[PATCH] D80366: [Analyzer] Add `getReturnValueUnderConstruction()` to `CallEvent`

martong added a comment. In D80366#2059765 , @martong wrote: > In this version of the patch you are using `handleConstructionContext` to > "retrieve" or read an SVal for the construction. However, it seems like that > function was designed to store value

[PATCH] D80685: [ASTMatchers] Add traversal-kind support to `DynTypedMatcher`

ymandel updated this revision to Diff 266828. ymandel marked 2 inline comments as done. ymandel added a comment. Herald added a subscriber: mgorny. updated per comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80685/new/ https://reviews.llvm.o

[PATCH] D80197: [DebugInfo] Upgrade DISubrange to support Fortran dynamic arrays

melver added inline comments. Comment at: llvm/lib/Bitcode/Writer/BitcodeWriter.cpp:1522 static uint64_t rotateSign(int64_t I) { uint64_t U = I; rotateSign() is no longer used in this file. If there are no plans to use it again, please remove it. Thanks!

[PATCH] D80197: [DebugInfo] Upgrade DISubrange to support Fortran dynamic arrays

alok marked an inline comment as done. alok added a comment. In D80197#2059591 , @thakis wrote: > This breaks check-llvm on Windows: http://45.33.8.238/win/16214/step_11.txt > > Please take a look and revert if it takes a while to investigate. Fixed in 7

[PATCH] D80685: [ASTMatchers] Add traversal-kind support to `DynTypedMatcher`

ymandel marked 2 inline comments as done. ymandel added inline comments. Comment at: clang/lib/ASTMatchers/ASTMatchersInternal.cpp:234 +DynTypedMatcher::constructWithTraversalKind(DynTypedMatcher InnerMatcher, +ast_type_traits::Traversa

[PATCH] D80117: [analyzer] Introduce reasoning about symbolic remainder operator

vsavchenko marked an inline comment as done. vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:506-507 + /// + /// where abs(Origin) is the maximal absolute value of any possible values + /// from Origin, and min(T) is

[PATCH] D80627: [clang-format] Create a python documentation tool to generate a summary of the clang-format status for the whole of the LLVM project

sylvestre.ledru added a comment. Well done! For Firefox, we decided to go ahead and reformat everything at once. I has been way easier this way. You should run flake8 & autopep8 on your python code. it isn't idomatic Python code (";" are useless on python for example) Commen

cfe-commits@lists.llvm.org

LukeGeeson created this revision. LukeGeeson added reviewers: fpetrogalli, SjoerdMeijer. Herald added subscribers: llvm-commits, cfe-commits, danielkiss, hiraditya, kristof.beyls. Herald added projects: clang, LLVM. LukeGeeson added a parent revision: D79869: [clang][BFloat] Add reinterpret cast

[PATCH] D80016: [analyzer] StdLibraryFunctionsChecker: Add support to lookup types

martong updated this revision to Diff 266834. martong marked an inline comment as done. martong added a comment. - Rebase to master Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80016/new/ https://reviews.llvm.org/D80016 Files: clang/lib/StaticA

[PATCH] D80606: [libTooling] Fix Transformer to work with ambient traversal kinds

ymandel updated this revision to Diff 266831. ymandel added a comment. updated per comments and after rebasing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80606/new/ https://reviews.llvm.org/D80606 Files: clang/include/clang/Tooling/Transforme

[PATCH] D80606: [libTooling] Fix Transformer to work with ambient traversal kinds

ymandel updated this revision to Diff 266835. ymandel marked 2 inline comments as done. ymandel added a comment. typo fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80606/new/ https://reviews.llvm.org/D80606 Files: clang/include/clang/Tooling

[PATCH] D80627: [clang-format] Create a python documentation tool to generate a summary of the clang-format status for the whole of the LLVM project

sylvestre.ledru added inline comments. Comment at: clang/docs/tools/generate_formatted_state.py:48 +if "/test/" in path: +print root +continue print xx is python 2 please use print(xx) Comment at: clang/docs/too

[PATCH] D80606: [libTooling] Fix Transformer to work with ambient traversal kinds

ymandel marked 3 inline comments as done. ymandel added inline comments. Comment at: clang/lib/Tooling/Transformer/RewriteRule.cpp:154 +const RewriteRule &Rule, +ast_type_traits::TraversalKind DefaultTraversalKind) { // Map the cases into buckets of matchers -- one for

[PATCH] D77942: [Preamble] Invalidate preamble when missing headers become present.

kadircet added a comment. mostly LG, sorry for not noticing regularfile check(or maybe forgetting a discussion ...) at previous revision Comment at: clang/lib/Frontend/PrecompiledPreamble.cpp:108 +// (We have some false negatives if PP recovered e.g. -> "foo") +if (Fi

[PATCH] D80704: Remove WrapperMatcherInterface

ymandel accepted this revision. ymandel added a comment. This revision is now accepted and ready to land. Yes, thank you! There are (IMO) too many layers of abstractions in this framework; this is a good step in the right direction. :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D80606: [libTooling] Fix Transformer to work with ambient traversal kinds

ymandel updated this revision to Diff 266837. ymandel added a comment. more typo fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80606/new/ https://reviews.llvm.org/D80606 Files: clang/include/clang/Tooling/Transformer/RewriteRule.h clang/

cfe-commits@lists.llvm.org

labrinea added inline comments. Comment at: clang/test/CodeGen/aarch64-bf16-ldst-intrinsics.c:36 +// CHECK32: ret <4 x bfloat> %vld1_lane + +bfloat16x8_t test_vld1q_lane_bf16(bfloat16_t const *ptr, bfloat16x8_t src) { CHECK-NEXT or CHECK-DAG are preferable for se

[PATCH] D76793: [Matrix] Implement + and - operators for MatrixType.

fhahn updated this revision to Diff 266842. fhahn marked 4 inline comments as done. fhahn added a comment. Use initialization step for all conversions (including for arithemtic types), add & call separate addMatrixBinaryArithmeticOverloads Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D80522: [Analyzer] [NFC] Parameter Regions -- Alternative Approach

baloghadamsoftware updated this revision to Diff 266851. baloghadamsoftware marked an inline comment as done. baloghadamsoftware added a comment. Updated according to the comments of @balazske. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80522/new/ https://reviews.llvm.org/D80522 Fil

[PATCH] D80522: [Analyzer] [NFC] Parameter Regions -- Alternative Approach

baloghadamsoftware marked 5 inline comments as done. baloghadamsoftware added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/MemRegion.h:917 assert(isa(sReg) || isa(sReg) || isa(sReg) || isa(sReg)); } balaz

[PATCH] D80522: [Analyzer] [NFC] Parameter Regions -- Alternative Approach

baloghadamsoftware marked an inline comment as done. baloghadamsoftware added a comment. > I will check tomorrow whether we could remove `DeclRegion` without too much > code duplication. It turns out that `DeclRegion` is used in 7 different checkers plus in `BugReporterVisitor`s. One typical us

[PATCH] D80627: [clang-format] Create a python documentation tool to generate a summary of the clang-format status for the whole of the LLVM project

MyDeveloperDay planned changes to this revision. MyDeveloperDay added a comment. I'm running through flake8... almost every line is changing ;-) ...let me update before wasting any more of your time. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80

[PATCH] D80669: [analyzer] LoopWidening: fix crash by avoiding aliased references invalidation

AbbasSabra added a comment. In D80669#2058824 , @NoQ wrote: > Fair! Thanks for the review! May you please take care of merging this one too? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80669/new/ https:

cfe-commits@lists.llvm.org

stuij requested changes to this revision. stuij added a comment. This revision now requires changes to proceed. We need testing for the backend code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80716/new/ https://reviews.llvm.org/D80716 __

[PATCH] D44823: [libcxx] Improving std::vector and std::deque perfomance

ldionne added inline comments. Comment at: libcxx/trunk/include/__split_buffer:201 __alloc_rr& __a = this->__alloc(); +pointer __to_be_end = this->__end_; do danlark wrote: > hiraditya wrote: > > danlark wrote: > > > lichray wrote: > > > > mclow.lis

[PATCH] D80197: [DebugInfo] Upgrade DISubrange to support Fortran dynamic arrays

alok marked 2 inline comments as done. alok added inline comments. Comment at: llvm/lib/Bitcode/Writer/BitcodeWriter.cpp:1522 static uint64_t rotateSign(int64_t I) { uint64_t U = I; melver wrote: > rotateSign() is no longer used in this file. If there are n

[PATCH] D75414: [clangd] Resolve driver symlinks, and look up unknown relative drivers in PATH.

sammccall marked 10 inline comments as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/CompileCommands.cpp:156 + llvm::SmallString<256> Resolved; + if (llvm::sys::fs::real_path(Driver, Resolved)) +return Driver.str(); kadircet wr

[PATCH] D80016: [analyzer] StdLibraryFunctionsChecker: Add support to lookup types

martong updated this revision to Diff 266858. martong marked 2 inline comments as done. martong added a comment. - Add `if (FileTy)` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80016/new/ https://reviews.llvm.org/D80016 Files: clang/lib/Static

[PATCH] D79711: [ARM] Add poly64_t on AArch32.

ostannard accepted this revision. ostannard added a comment. This revision is now accepted and ready to land. Ok, LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79711/new/ https://reviews.llvm.org/D79711

cfe-commits@lists.llvm.org

simon_tatham added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:10366 +auto Alignment = CGM.getNaturalPointeeTypeAlignment( +E->getArg(0)->IgnoreParenCasts()->getType()); Ops[0] = Builder.CreateBitCast(Ops[0], llvm::PointerType::getUnqual(VTy)); -

[PATCH] D80016: [analyzer] StdLibraryFunctionsChecker: Add support to lookup types

martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:747 + : *FilePtrTy) +: None; + balazske wrote: > martong wrote: > > balazske wrote: > > > The `Optional` can be le

[PATCH] D75414: [clangd] Resolve driver symlinks, and look up unknown relative drivers in PATH.

sammccall updated this revision to Diff 266861. sammccall marked an inline comment as done. sammccall added a comment. Handle -no-canonical-prefixes Make memoize map-like instead of functor-like Address other comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[clang] 6c2b7ee - Prevent test from failing in my home directory

Author: Sam McCall Date: 2020-05-28T16:14:49+02:00 New Revision: 6c2b7ee2f7fac7b683e343c2c383b7e67fadf9f8 URL: https://github.com/llvm/llvm-project/commit/6c2b7ee2f7fac7b683e343c2c383b7e67fadf9f8 DIFF: https://github.com/llvm/llvm-project/commit/6c2b7ee2f7fac7b683e343c2c383b7e67fadf9f8.diff LO

[PATCH] D80222: Replace Clang's createRuntimeFunction with the definitions in OMPKinds.def

jhuber6 marked an inline comment as done. jhuber6 added inline comments. Comment at: openmp/runtime/test/tasking/kmp_taskloop.c:100 th_counter[i] = 0; -#pragma omp parallel num_threads(N) +#pragma omp parallel // num_threads(N) { jhuber6 wro

[PATCH] D77942: [Preamble] Invalidate preamble when missing headers become present.

sammccall updated this revision to Diff 266868. sammccall marked 2 inline comments as done. sammccall added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77942/new/ https://reviews.llvm.org/D77942 Files: clang-tools-e

[PATCH] D78454: [clangd] Highlight related control flow.

russell.gallop added a comment. Hi Sam, It looks like this is causing a failure on the Windows PS4 buildbot: http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/32606 Please could you take a look? PS4 target disables RTTI, hence exceptions, by default so i

[PATCH] D77942: [Preamble] Invalidate preamble when missing headers become present.

sammccall marked 5 inline comments as done. sammccall added inline comments. Comment at: clang/lib/Frontend/PrecompiledPreamble.cpp:108 +// (We have some false negatives if PP recovered e.g. -> "foo") +if (File == nullptr) + return; kadircet wrote:

[PATCH] D80723: [PowerPC] Convert vec_splats functions to macros

vddvss created this revision. vddvss added reviewers: nemanjai, PowerPC. Herald added subscribers: cfe-commits, shchenz, kbarton. Herald added a project: clang. This commit converts the `vec_splats` functions in altivec.h to macros, solving an issue where `vec_splats` calls could not assign to va

[PATCH] D80366: [Analyzer] Add `getReturnValueUnderConstruction()` to `CallEvent`

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/ExprEngineCXX.cpp:112 +Optional ExprEngine::retrieveFromConstructionContext( +ProgramStateRef State, const LocationContext *LCtx, balazske wrote: > baloghadamsoftware wrote: > > baloghadam

[PATCH] D80627: [clang-format] Create a python documentation tool to generate a summary of the clang-format status for the whole of the LLVM project

MyDeveloperDay added a comment. I'm adding a summary table which shows LLVM only 44% of all LLVM cpp/h files are clang-formatted. ;-( F12020299: image.png CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80627/new/ https://reviews.llvm.org/D80627 _

[PATCH] D79434: [analyzer] Generalize bitwise AND rules for ranges

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Looks correct, thanks!! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79434/new/ https://reviews.llvm.org/D79434 __

[PATCH] D80117: [analyzer] Introduce reasoning about symbolic remainder operator

NoQ added a comment. In D80117#2059567 , @NoQ wrote: > > I believe that as of now we can submit these modifications as is and > > explore performance optimizations later if needed. > > I still encourage you to explore the tests we have from our previous a

[libclc] cf4d4e3 - libclc: Compile with -nostdlib

Author: Matt Arsenault Date: 2020-05-28T10:41:31-04:00 New Revision: cf4d4e366a2165f0e93948f166d76ae650aecc98 URL: https://github.com/llvm/llvm-project/commit/cf4d4e366a2165f0e93948f166d76ae650aecc98 DIFF: https://github.com/llvm/llvm-project/commit/cf4d4e366a2165f0e93948f166d76ae650aecc98.diff

Re: [PATCH] D78454: [clangd] Highlight related control flow.

On Thu, May 28, 2020 at 4:35 PM Russell Gallop via Phabricator < revi...@reviews.llvm.org> wrote: > russell.gallop added a comment. > > Hi Sam, > > It looks like this is causing a failure on the Windows PS4 buildbot: > http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-f

[PATCH] D74387: [OpenMP][SYCL] Improve diagnosing of unsupported types usage

Fznamznon updated this revision to Diff 266877. Fznamznon marked 2 inline comments as done. Fznamznon added a comment. Applied comments from Johannes. Fixed failing tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74387/new/ https://reviews.llv

[PATCH] D74387: [OpenMP][SYCL] Improve diagnosing of unsupported types usage

Fznamznon marked 2 inline comments as done. Fznamznon added inline comments. Comment at: clang/lib/Sema/Sema.cpp:1727 + + QualType Ty = D->getType(); + auto CheckType = [&](QualType Ty) { jdoerfert wrote: > Nit: Move below `CheckType` to avoid shadowing and con

[PATCH] D77658: [analyzer] StdLibraryFunctionsChecker: Add sanity checks for constraints

martong updated this revision to Diff 266879. martong marked an inline comment as done. martong added a comment. - Rebase to master Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77658/new/ https://reviews.llvm.org/D77658 Files: clang/lib/StaticA

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

MyDeveloperDay marked 3 inline comments as done. MyDeveloperDay added a comment. In D69764#2058801 , @curdeius wrote: > One last thought, how about making the config a bit more future-proof and > instead of `ConstPlacement` accept what was discussed some

[PATCH] D80574: [ExtVector] Support ExtVectorType conditional operator

Anastasia added inline comments. Comment at: clang/docs/LanguageExtensions.rst:481 =yes yes yes yes -:? [#]_ yes --yes -- +?: yes --yes

  1   2   3   >