[PATCH] D77474: [analyzer][MallocChecker] Make NewDeleteLeaks depend on DynamicMemoryModeling rather than NewDelete

This revision was automatically updated to reflect the committed changes. Closed by commit rGefd1a8e66eaa: [analyzer][MallocChecker] Make NewDeleteLeaks depend on DynamicMemoryModeling… (authored by Szelethus). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D80590: [WIP][OPENMP] Fix assertion error for using alignas with OpenMP directive

jdoerfert added a comment. > We can avoid the assertion failure by either removing alignas or OpenMP > directive in the above code. What OpenMP directive? > Haven't added test yet since I'm not sure in which file should I add the test. Let's go with something like `clang/test/OpenMP/sema_align

[PATCH] D80590: [WIP][OPENMP] Fix assertion error for using alignas with OpenMP directive

ABataev added a comment. In D80590#2055937 , @cchen wrote: > Haven't added test yet since I'm not sure in which file should I add the test. Where is the directive? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D79721: [Clang][AArch64] Capturing proper pointer alignment for Neon vld1 intrinsicts

plotfi added a comment. @efriedma I am also seeing a similar crash in the llvm-test-suite for llvm-test-suite/SingleSource/UnitTests/Vector/NEON/simple.c I will try and reduce the case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79721/new/ htt

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

MyDeveloperDay updated this revision to Diff 266358. MyDeveloperDay marked an inline comment as done. MyDeveloperDay added a comment. Fix issue when preprocessor #if/#else is present Rename the config file name to `ConstPlacement` change the command line option to be `--const-placement` Add Left/R

[PATCH] D60620: [HIP] Support target id by --offload-arch

tra added inline comments. Comment at: clang/lib/Driver/ToolChains/HIP.cpp:121-123 + auto Pos = SubArchName.find_first_of("+-"); + if (Pos != SubArchName.npos) +SubArchName = SubArchName.substr(0, Pos); yaxunl wrote: > tra wrote: > > Parsing should probably

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

MyDeveloperDay marked 8 inline comments as done. MyDeveloperDay added inline comments. Comment at: clang/lib/Format/EastWestConstFixer.cpp:139 + return (Tok->isSimpleTypeSpecifier() || + Tok->isOneOf(tok::kw_volatile, tok::kw_auto)); +} aaron.ballman wr

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

MyDeveloperDay updated this revision to Diff 266360. MyDeveloperDay added a comment. rebase with master CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69764/new/ https://reviews.llvm.org/D69764 Files: clang/docs/ClangFormatStyleOptions.rst clang/docs/ReleaseNotes.rst clang/include

[PATCH] D74387: [OpenMP][SYCL] Improve diagnosing of unsupported types usage

jdoerfert added a comment. In D74387#2053742 , @Fznamznon wrote: > Re-implemented diagnostic itself, now only usages of declarations > with unsupported types are diagnosed. > Generalized approach between OpenMP and SYCL. Great, thanks a lot! In D74387

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

rsmith added a comment. I'm uncomfortable about `clang-format` performing this transformation at all. Generally, clang-format only makes changes that are guaranteed to preserve the meaning of the source program, and does not make changes that are only heuristically likely to be semantics-preser

[PATCH] D80369: [DebugInfo][CallSites] Remove decl subprograms from 'retainedTypes:'

aprantl added a comment. There's a cute diagram of the interaction: https://github.com/apple/llvm-project/blob/1fda14a45e23c41ac661c20a248a7fa4b102230d/lldb/source/Symbol/SwiftASTContext.cpp#L3020 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80369/new/ https://reviews.llvm.org/D80369

[PATCH] D80590: [WIP][OPENMP] Fix assertion error for using alignas with OpenMP directive

cchen added a comment. In D80590#2056009 , @ABataev wrote: > In D80590#2055937 , @cchen wrote: > > > Haven't added test yet since I'm not sure in which file should I add the > > test. > > > Where is the directive?

[PATCH] D79721: [Clang][AArch64] Capturing proper pointer alignment for Neon vld1 intrinsicts

plotfi added a comment. After reducing the test case it looks the same as the bugzilla filing, running `clang --target=aarch64-unknown-linux-gnu -c` on the following does it: typedef signed char int8_t; typedef __attribute__((neon_vector_type(16))) int8_t int8x16_t; typedef struct int8x16x

[PATCH] D80369: [DebugInfo][CallSites] Remove decl subprograms from 'retainedTypes:'

aprantl added a comment. > How does this data get used for Swift code and ObjC interoperability? At the > moment I see no use of this IR metadata in LLVM. Does ObjC/Swift interop use > the DI IR over in the Swift compiler? Got a link to the code there? Are you saying the retained types are not

[PATCH] D80439: Replace separator in OpenMP variant name mangling.

jdoerfert added a comment. Changes looks good to me. We don't have tests that check the mangling, interesting (and my fault), should we add one? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80439/new/ https://reviews.llvm.org/D80439 _

[PATCH] D79721: [Clang][AArch64] Capturing proper pointer alignment for Neon vld1 intrinsicts

plotfi added a comment. Reduced crash case even further: void f() { signed char d[16]; __builtin_neon_vld1q_v(d, 32); } Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79721/new/ https://reviews.llvm.org/D79721 ___

[PATCH] D75938: [DO NOT MERGE] X86 Mitigate for Load Value Injection (LVI)--All Code

sconstab abandoned this revision. sconstab added a comment. Changes have been merged. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75938/new/ https://reviews.llvm.org/D75938 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[PATCH] D80450: [CUDA][HIP] Fix implicit HD function resolution

yaxunl updated this revision to Diff 266366. yaxunl added a comment. Fix test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80450/new/ https://reviews.llvm.org/D80450 Files: clang/lib/Sema/SemaOverload.cpp clang/test/SemaCUDA/function-overload.cu Index: clang/test/SemaCUDA/funct

[PATCH] D80590: [WIP][OPENMP] Fix assertion error for using alignas with OpenMP directive

cchen updated this revision to Diff 266370. cchen added a comment. Add test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80590/new/ https://reviews.llvm.org/D80590 Files: clang/lib/Sema/SemaOpenMP.cpp clang/test/OpenMP/sema_alignas.cpp Index

[PATCH] D79910: [x86][seses] Add clang flag; Use lvi-cfi with seses

sconstab added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/X86.cpp:200 +if (!Args.hasArg(options::OPT_mno_lvi_cfi)) { + Features.push_back("+lvi-cfi"); + LVIOpt = options::OPT_mlvi_cfi; Would it be better to add `FeatureLVIControlF

[PATCH] D80404: [OPENMP50]Initial support for use_device_addr clause.

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM, one nit below Comment at: clang/lib/Sema/SemaOpenMP.cpp:10179 Diag(StartLoc, diag::err_omp_no_clause_for_directive) -<< "'map' or 'use_device_ptr'" -

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

steveire added a comment. In D69764#2056104 , @rsmith wrote: > I'm uncomfortable about `clang-format` performing this transformation at all. > Generally, clang-format only makes changes that are guaranteed to preserve > the meaning of the source program,

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

tentzen updated this revision to Diff 266374. tentzen added a comment. update LangRef.rst for new intrinsics Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80344/new/ https://reviews.llvm.org/D80344 Files: clang/include/clang/AST/Stmt.h clang/i

[PATCH] D79675: [OpenMP][OMPBuilder] Adding Privatization Requirements to OMPIRBuilder

jdoerfert added a comment. In D79675#2051682 , @fghanim wrote: > > My goal is to save us time, during development, review, maintenance, and > > future extensions. I hope you know that. > > I am certain of that. However, I am starting to have doubts if my

[PATCH] D54408: [ASTMatchers] Add matchers available through casting to derived

steveire added a comment. @aaron.ballman I think we agreed in Belfast in November (after the most recent comment) to get this in as it is and not be as draconian about `auto`. Is anything blocking this? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54408/new/

[PATCH] D60620: [HIP] Support target id by --offload-arch

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/lib/Driver/ToolChains/HIP.cpp:121-123 + auto Pos = SubArchName.find_first_of("+-"); + if (Pos != SubArchName.npos) +SubArchName = SubArchName.substr(0, Pos); tra wrote:

[PATCH] D71739: [AssumeBundles] Use operand bundles to encode alignment assumptions

jdoerfert added a comment. I think the code looks good, we should make the test changes clearer, see below. Comment at: clang/test/CodeGen/align_value.cpp:7 double & z __attribute__((align_value(128 { }; -// CHECK: define void @_Z3fooPdS_Rd(double* align 64 %x, do

[PATCH] D77184: Make it possible for lit.site.cfg to contain relative paths, and use it for llvm and clang

vzakhari added a comment. Herald added a project: LLVM. It does not work on Windows (msbuild) for me, because `${pathlist_escaped}` contains paths like `%(build_mode)s/bin` (caused by `set_llvm_build_mode`). This seems to break something so that `python` process does not produce any output at

[clang] 97a133f - Temporarily Revert "[Clang][AArch64] Capturing proper pointer alignment for Neon vld1 intrinsicts"

Author: Eric Christopher Date: 2020-05-26T18:51:00-07:00 New Revision: 97a133f15724aa7ddf5d9b62dc9c0657a4efd115 URL: https://github.com/llvm/llvm-project/commit/97a133f15724aa7ddf5d9b62dc9c0657a4efd115 DIFF: https://github.com/llvm/llvm-project/commit/97a133f15724aa7ddf5d9b62dc9c0657a4efd115.di

[PATCH] D80412: Summary: [Lexer] Fix invalid suffix diagnostic for fixed-point literals

nagart added a comment. I don't have commit access. Could any one please help to commit this patch. Thanks in advance. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80412/new/ https://reviews.llvm.org/D80412

[PATCH] D79721: [Clang][AArch64] Capturing proper pointer alignment for Neon vld1 intrinsicts

plotfi added a subscriber: echristo. plotfi added a comment. @pratlucas please reland once the bugzilla issue is resolved and the testsuite builds for aarch64. Thanks @echristo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79721/new/ https://revie

[PATCH] D77184: Make it possible for lit.site.cfg to contain relative paths, and use it for llvm and clang

vzakhari added a comment. In D77184#2056306 , @vzakhari wrote: > It does not work on Windows (msbuild) for me, because `${pathlist_escaped}` > contains paths like `%(build_mode)s/bin` (caused by `set_llvm_build_mode`). > This seems to break something so

[PATCH] D80603: add isAtPosition narrowing matcher for parmVarDecl

oontvoo created this revision. Herald added subscribers: cfe-commits, danielkiss, kristof.beyls. Herald added a project: clang. oontvoo added reviewers: gribozavr, ymandel. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D80603 Files: clang/include/clang/ASTMatchers/ASTMatchers.

[PATCH] D80369: [DebugInfo][CallSites] Remove decl subprograms from 'retainedTypes:'

dblaikie added a comment. In D80369#2056094 , @aprantl wrote: > > How does this data get used for Swift code and ObjC interoperability? At > > the moment I see no use of this IR metadata in LLVM. Does ObjC/Swift > > interop use the DI IR over in the Swif

[PATCH] D80606: [libTooling][NFC] Demo bug introduced in D72534.

ymandel created this revision. ymandel added reviewers: hokein, gribozavr. Herald added a project: clang. DO NOT PUSH. This patch includes two new tests that demo a bug introduced into Transformer by https://reviews.llvm.org/D72534. This patch is intended only as a demonstration of the problem.

Re: [clang] c90e198 - Fix parsing of enum-base to follow C++11 rules.

> On May 20, 2020, at 5:53 PM, Richard Smith wrote: > > On Wed, 20 May 2020 at 16:30, Akira Hatanaka via cfe-commits > mailto:cfe-commits@lists.llvm.org>> wrote: > Hi Richard, > > It looks like this patch will reject the following code, which used to > compile fine: > > $ cat test.cpp > #inc

[PATCH] D60620: [HIP] Support target id by --offload-arch

yaxunl updated this revision to Diff 266410. yaxunl added a comment. Changed target id format to be like `gfx908:xnack+:sramecc-`. I tried to introduce --offload-target-id but found that is not good because: 1. it will cause redundant code since I have to handle these options separately in CUDA

[PATCH] D80603: add isAtPosition narrowing matcher for parmVarDecl

oontvoo added a comment. P.S: Please ignore the child revision ... accidentally committed it to the wrong branch. I've fixed the git branches locally but can't figure out how to tell phabricator ... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80

[clang] 6bbaa62 - [analyzer] Add support for IE of keyboard and mouse navigation in HTML report

Author: Denys Petrov Date: 2020-05-27T09:04:30+03:00 New Revision: 6bbaa62d26b6061c93eb62c82048c14014ab7bd7 URL: https://github.com/llvm/llvm-project/commit/6bbaa62d26b6061c93eb62c82048c14014ab7bd7 DIFF: https://github.com/llvm/llvm-project/commit/6bbaa62d26b6061c93eb62c82048c14014ab7bd7.diff

[PATCH] D80603: add isAtPosition narrowing matcher for parmVarDecl

gribozavr2 added a comment. Please run clang/docs/tools/dump_ast_matchers.py to update the docs. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:7022 + .matches(Node, Finder, Builder); +} + Could you move it closer to other parameter-related matc

[PATCH] D80444: [analyzer] Add support for IE of keyboard and mouse navigation in HTML report

This revision was automatically updated to reflect the committed changes. Closed by commit rG6bbaa62d26b6: [analyzer] Add support for IE of keyboard and mouse navigation in HTML report (authored by ASDenysPetrov). Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHAN

[PATCH] D80536: [clang-tidy][modernize-loop-convert] Make loop var type human readable

zinovy.nis added a comment. In D80536#2055500 , @njames93 wrote: > I'm having trouble with the reproduction of this - > https://godbolt.org/z/tsMfcj. > Aside from that this needs some test cases to demonstrate the patch is > indeed working Thanks. See

[PATCH] D80018: [Analyzer][StreamChecker] Added check for "indeterminate file position".

balazske updated this revision to Diff 266434. balazske added a comment. - Rebase - Some StreamState members are const and checked in constructor - Restructuring of some functions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80018/new/ https://re

<    1   2   3