zinovy.nis added a comment. In D80536#2055500 <https://reviews.llvm.org/D80536#2055500>, @njames93 wrote:
> I'm having trouble with the reproduction of this - > https://godbolt.org/z/tsMfcj. > Aside from that this needs some test cases to demonstrate the patch is > indeed working Thanks. Seems like the reproduction is c++-library dependent. Please look at https://godbolt.org/z/tbGG9b where I have manually "emulated" std::set. Or just change compiler to "clang-tidy (trunk) #1 with x86-64 clang (std::embed)" in your sample. I get the same result (as for my custom "class set") for std::set on 'master' on Windows 10. > Aside from that this needs some test cases to demonstrate the patch is indeed > working IMHO, for testing purposes it's enough to apply my change to 'structures.h' (int -> value_type) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80536/new/ https://reviews.llvm.org/D80536 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
