[PATCH] D79945: [Sema] Comparison of pointers to complete and incomplete types

2020-05-25 Thread Benson Chu via Phabricator via cfe-commits
pestctrl updated this revision to Diff 266086. pestctrl added a comment. Rebase on master? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79945/new/ https://reviews.llvm.org/D79945 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/l

[clang] 3a2df3b - [Clang][test] fix tests when using external assembler.

2020-05-25 Thread Yuanfang Chen via cfe-commits
Author: Yuanfang Chen Date: 2020-05-25T16:47:50-07:00 New Revision: 3a2df3bad07f7e5fc22538ad782e08ee55f29e41 URL: https://github.com/llvm/llvm-project/commit/3a2df3bad07f7e5fc22538ad782e08ee55f29e41 DIFF: https://github.com/llvm/llvm-project/commit/3a2df3bad07f7e5fc22538ad782e08ee55f29e41.diff

[PATCH] D74166: [AIX][Frontend] Static init implementation for AIX considering no priority

2020-05-25 Thread Xiangling Liao via Phabricator via cfe-commits
Xiangling_L updated this revision to Diff 266087. Xiangling_L added a comment. Adjust `mangleDynamicDestructor`; Add assertion and FIXME for getUniqueModuleId Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74166/new/ https://reviews.llvm.org/D74166

[PATCH] D80454: [Clang][test] fix tests when using external assembler

2020-05-25 Thread Yuanfang Chen via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG3a2df3bad07f: [Clang][test] fix tests when using external assembler. (authored by ychen). Changed prior to commit: https://reviews.llvm.org/D80454?vs=265792&id=266088#toc Repository: rG LLVM Github M

[clang] 9a8d7bd - [clang][test] fix tests for external assemblers

2020-05-25 Thread Yuanfang Chen via cfe-commits
Author: Yuanfang Chen Date: 2020-05-25T17:36:28-07:00 New Revision: 9a8d7bd77040a6497233ea10fd866ad9de8bf98c URL: https://github.com/llvm/llvm-project/commit/9a8d7bd77040a6497233ea10fd866ad9de8bf98c DIFF: https://github.com/llvm/llvm-project/commit/9a8d7bd77040a6497233ea10fd866ad9de8bf98c.diff

[PATCH] D80533: [Clang] Enable _Complex __float

2020-05-25 Thread Nemanja Ivanovic via Phabricator via cfe-commits
nemanjai created this revision. nemanjai added reviewers: rjmccall, rsmith, PowerPC. Herald added a subscriber: kbarton. Herald added a project: clang. When I added `__float128` a while ago, I neglected to add support for the complex variant of the type. This patch just adds that. Repository:

[PATCH] D80374: [Clang] Enable KF and KC mode for [_Complex] __float128

2020-05-25 Thread Nemanja Ivanovic via Phabricator via cfe-commits
nemanjai added a comment. The support for `_Complex __float128` in https://reviews.llvm.org/D80533 I will repurpose leave only the addition of the `KF/KC` modes in this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80374/new/ https://reviews

[PATCH] D80374: [Clang] Enable KF and KC mode for [_Complex] __float128

2020-05-25 Thread Nemanja Ivanovic via Phabricator via cfe-commits
nemanjai updated this revision to Diff 266092. nemanjai added a comment. Remove handling for explicit `_Complex __float128`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80374/new/ https://reviews.llvm.org/D80374 Files: clang/include/clang/AST/

[PATCH] D80409: [MS ABI] Add mangled type for auto template parameter whose argument kind is Integeral

2020-05-25 Thread Nico Weber via Phabricator via cfe-commits
thakis added inline comments. Comment at: clang/test/CodeGenCXX/mangle-ms-auto-templates.cpp:17 + AutoParmTemplate<0> auto_int; + // CHECK: call {{.*}} @"??0?$AutoParmTemplate@$H0A@@@QAE@XZ" + AutoParmTemplate auto_bool; Are you sure this is correct? MSVC prod

[clang] 9d55e4e - Make explicit -fno-semantic-interposition (in -fpic mode) infer dso_local

2020-05-25 Thread Fangrui Song via cfe-commits
Author: Fangrui Song Date: 2020-05-25T20:48:18-07:00 New Revision: 9d55e4ee1367b440bb8402ce3a33d5a8b99aee06 URL: https://github.com/llvm/llvm-project/commit/9d55e4ee1367b440bb8402ce3a33d5a8b99aee06 DIFF: https://github.com/llvm/llvm-project/commit/9d55e4ee1367b440bb8402ce3a33d5a8b99aee06.diff

[PATCH] D80020: [PowerPC] Add support for -mcpu=pwr10 in both clang and llvm

2020-05-25 Thread Amy Kwan via Phabricator via cfe-commits
amyk added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCTargetTransformInfo.cpp:653 // On P7, P8 or P9 we have a cache line size of 128. unsigned Directive = ST->getCPUDirective(); Should this comment be updated to include P10 as well? Reposi

[PATCH] D80296: [clangd] Don't traverse the AST within uninteresting files during indexing

2020-05-25 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet marked an inline comment as done. kadircet added inline comments. Comment at: clang/lib/Index/IndexingAction.cpp:142 +ShouldSkipFunctionBody = +[ShouldTraverseDecl(Opts.ShouldTraverseDecl)](const Decl *D) { + return !ShouldTraverseDecl(D); --

[PATCH] D80020: [PowerPC] Add support for -mcpu=pwr10 in both clang and llvm

2020-05-25 Thread Nemanja Ivanovic via Phabricator via cfe-commits
nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. LGTM aside from a couple of minor nits. Comment at: clang/lib/Basic/Targets/PPC.cpp:319 .Case("ppc64le", true) +.Case("pw

[PATCH] D80531: [clang-tidy]: Added modernize-replace-disallow-copy-and-assign-macro

2020-05-25 Thread Konrad Wilhelm Kleine via Phabricator via cfe-commits
kwk updated this revision to Diff 266100. kwk marked 8 inline comments as done. kwk added a comment. - Make ReplaceDisallowCopyAndAssignMacroCheck only work in C++11 and above - Remove unrelated changes from clang-tools-extra/docs/clang-tidy/checks/list.rst - documentation simplification - Move c

[PATCH] D80531: [clang-tidy]: Added modernize-replace-disallow-copy-and-assign-macro

2020-05-25 Thread Konrad Wilhelm Kleine via Phabricator via cfe-commits
kwk added a comment. @Eugene.Zelenko thank you for the review. I've fixed all places that you've mentioned. And have a question about one thing in particular. See inline. Do you by any chance know why `llvm-lit` keeps complaining when I use `[[@LINE-1]]` in my tests as so many other tests do?

[clang] d8e0ad9 - [clang][test] fix tests for external assemblers

2020-05-25 Thread Yuanfang Chen via cfe-commits
Author: Yuanfang Chen Date: 2020-05-25T22:14:05-07:00 New Revision: d8e0ad9620c6e626d753a3ae0da6c712e4d400d3 URL: https://github.com/llvm/llvm-project/commit/d8e0ad9620c6e626d753a3ae0da6c712e4d400d3 DIFF: https://github.com/llvm/llvm-project/commit/d8e0ad9620c6e626d753a3ae0da6c712e4d400d3.diff

[PATCH] D80531: [clang-tidy]: Added modernize-replace-disallow-copy-and-assign-macro

2020-05-25 Thread Konrad Wilhelm Kleine via Phabricator via cfe-commits
kwk updated this revision to Diff 266101. kwk added a comment. - Move comment about FinalizeWithSemicolon into code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80531/new/ https://reviews.llvm.org/D80531 Files: clang-tools-extra/clang-tidy/mode

[clang-tools-extra] eeedbd0 - [clangd] Make use of SourceOrder to find first initializer in DefineOutline

2020-05-25 Thread Kadir Cetinkaya via cfe-commits
Author: Kadir Cetinkaya Date: 2020-05-26T07:32:07+02:00 New Revision: eeedbd033612e105755156023bdeec2fba4eca21 URL: https://github.com/llvm/llvm-project/commit/eeedbd033612e105755156023bdeec2fba4eca21 DIFF: https://github.com/llvm/llvm-project/commit/eeedbd033612e105755156023bdeec2fba4eca21.dif

[clang-tools-extra] 34e39eb - [clangd] Change PreambleOnlyAction with content truncation

2020-05-25 Thread Kadir Cetinkaya via cfe-commits
Author: Kadir Cetinkaya Date: 2020-05-26T07:37:03+02:00 New Revision: 34e39eb2adc2b3f16c2c2c0607a904ee55705c01 URL: https://github.com/llvm/llvm-project/commit/34e39eb2adc2b3f16c2c2c0607a904ee55705c01 DIFF: https://github.com/llvm/llvm-project/commit/34e39eb2adc2b3f16c2c2c0607a904ee55705c01.dif

[PATCH] D80521: [clangd] Make use of SourceOrder to find first initializer in DefineOutline

2020-05-25 Thread Kadir Cetinkaya via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGeeedbd033612: [clangd] Make use of SourceOrder to find first initializer in DefineOutline (authored by kadircet). Changed prior to commit: https://reviews.llvm.org/D80521?vs=266027&id=266106#toc Reposi

[PATCH] D79426: [clangd] Change PreambleOnlyAction with content truncation

2020-05-25 Thread Kadir Cetinkaya via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG34e39eb2adc2: [clangd] Change PreambleOnlyAction with content truncation (authored by kadircet). Changed prior to commit: https://reviews.llvm.org/D79426?vs=262132&id=266107#toc Repository: rG LLVM G

[clang] 61f72dd - [FPEnv] Small fixes to implementation of flt.rounds

2020-05-25 Thread Serge Pavlov via cfe-commits
Author: Serge Pavlov Date: 2020-05-26T13:19:01+07:00 New Revision: 61f72dd8ace7c4bea1ae74d9734d2b02946b4898 URL: https://github.com/llvm/llvm-project/commit/61f72dd8ace7c4bea1ae74d9734d2b02946b4898 DIFF: https://github.com/llvm/llvm-project/commit/61f72dd8ace7c4bea1ae74d9734d2b02946b4898.diff

[PATCH] D80536: [clang-tidy][modernize-loop-convert] Make loop var type human readable

2020-05-25 Thread Zinovy Nis via Phabricator via cfe-commits
zinovy.nis created this revision. zinovy.nis added reviewers: angelgarcia, alexfh. zinovy.nis added a project: clang-tools-extra. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. zinovy.nis edited the summary of this revision. Without this patch for(std::set::ite

[PATCH] D79322: [FEnv] Small fixes to implementation of flt.rounds

2020-05-25 Thread Serge Pavlov via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG61f72dd8ace7: [FPEnv] Small fixes to implementation of flt.rounds (authored by sepavloff). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79322/new/ https://

<    1   2   3