kwk added a comment. @Eugene.Zelenko thank you for the review. I've fixed all places that you've mentioned. And have a question about one thing in particular. See inline.
Do you by any chance know why `llvm-lit` keeps complaining when I use `[[@LINE-1]]` in my tests as so many other tests do? ================ Comment at: clang-tools-extra/docs/clang-tidy/checks/modernize-replace-disallow-copy-and-assign-macro.rst:31 +* Notice that the migration example above leaves the ``private`` access + specification untouched. This opens room for improvement, yes I know. + ---------------- Eugene.Zelenko wrote: > modernize-use-equals-delete takes care about this. Yes `modernize-use-equals-delete` does, this but it only notifies about it. Do you want me to notify with `"deleted member function should be public"` as well? Shouldn't I maybe just recommend to run the `modernize-use-equals-delete` after running my check? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80531/new/ https://reviews.llvm.org/D80531 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
