[clang] 5d82cb3 - [clang-format] @lefticus just taught the world how to use [[unlikely]] but we forgot to teach clang-format

Author: mydeveloperday Date: 2020-05-19T16:50:24+01:00 New Revision: 5d82cb3c3a6af8d12b87bcbdc6abd3b7f4b01652 URL: https://github.com/llvm/llvm-project/commit/5d82cb3c3a6af8d12b87bcbdc6abd3b7f4b01652 DIFF: https://github.com/llvm/llvm-project/commit/5d82cb3c3a6af8d12b87bcbdc6abd3b7f4b01652.diff

Re: [clang-tools-extra] 9b88a19 - [clangd] Add CSV export for trace metrics

Hi Sam, This commit's tests are failing to compile on the PS4 Windows bot and our internal CI. Could you take a look? Just FYI, I may end up reverting this after an hour or so to unclog our CI. http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/32433 Than

[PATCH] D78129: Add Marvell ThunderX3T110 support

SjoerdMeijer added a comment. Best to ask the release manager. Today Tom Stellard posted a message to the llvm dev list with subject: [llvm-dev] LLVM 10.0.1-rc1 release update So best to reply to this(*) asap with your query if it's possible to get this onto the branch. (*) http://lists.llv

[PATCH] D79990: [clang-format] [PR45614] Incorrectly indents [[nodiscard]] attribute funtions after a macro without semicolon

This revision was automatically updated to reflect the committed changes. Closed by commit rG575c59cf6a32: [clang-format] [PR45614] Incorrectly indents [[nodiscard]] attribute funtions… (authored by MyDeveloperDay). Changed prior to commit: https://reviews.llvm.org/D79990?vs=264231&id=264942#to

[PATCH] D80144: [clang-format] @lefticus just taught the world how to use [[unlikely]] but we forgot to teach clang-format

This revision was automatically updated to reflect the committed changes. Closed by commit rG5d82cb3c3a6a: [clang-format] @lefticus just taught the world how to use [[unlikely]] but we… (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

Re: [clang-tools-extra] 9b88a19 - [clangd] Add CSV export for trace metrics

Sorry about that Matthew, I think 5bc0c8f009261425a should have fixed this (giving up on stringview entirely). It fixed the other windows based bots. If it's no good, please do revert if you can, I'll check on it shortly too. On Tue, May 19, 2020, 6:14 PM Voss, Matthew wrote: > Hi Sam, > > This

[PATCH] D78129: Add Marvell ThunderX3T110 support

wxz2020 added a comment. Thanks, Just sent Tom an email. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78129/new/ https://reviews.llvm.org/D78129 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D77542: [PowerPC] Treat 'Z' inline asm constraint as a true memory constraint

stefanp accepted this revision as: stefanp. stefanp added a comment. Other than the two missing `K`s in the test case as Amy pointed out LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77542/new/ https://reviews.llvm.org/D77542 _

[PATCH] D79437: [clang-tidy] Add fsetpos argument checker

DerWaschbar updated this revision to Diff 264949. DerWaschbar added a comment. Rebased Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79437/new/ https://reviews.llvm.org/D79437 Files: clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.cpp

[PATCH] D80221: [AST][RecoveryExpr] Make DeduceAutoType fail if the auto is deduced from recovery exprs.

hokein marked an inline comment as done. hokein added inline comments. Comment at: clang/test/AST/ast-dump-recovery.cpp:182 +// Verified that the generated call operator is invalid. +// CHECK: |-CXXMethodDecl {{.*}} invalid operator() 'auto () const -> auto' using Escape = declt

[PATCH] D80221: [AST][RecoveryExpr] Make DeduceAutoType fail if the auto is deduced from recovery exprs.

hokein created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. hokein updated this revision to Diff 264951. hokein added a comment. hokein marked an inline comment as done. hokein added a reviewer: sammccall. hokein added a subscriber: rsmith. small update

[PATCH] D80221: [AST][RecoveryExpr] Make DeduceAutoType fail if the auto is deduced from recovery exprs.

hokein updated this revision to Diff 264951. hokein added a comment. small update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80221/new/ https://reviews.llvm.org/D80221 Files: clang/lib/Sema/SemaStmt.cpp clang/lib/Sema/SemaTemplateDeduction.

[PATCH] D75791: [clang-format] Added new option IndentExternBlock

MyDeveloperDay added a comment. If you want me to land this for you, I'd feel more comfortable landing it if: a) We can land D80214: [clang-format] Set of unit test to begin to validate that we don't change defaults first b) The Mozilla team have tested the impa

Re: [clang-tools-extra] 9b88a19 - [clangd] Add CSV export for trace metrics

Looks good. Thanks! Matthew From: Sam McCall Sent: Tuesday, May 19, 2020 9:19 AM To: Voss, Matthew Cc: cfe-commits ; Sam McCall Subject: Re: [clang-tools-extra] 9b88a19 - [clangd] Add CSV export for trace metrics Sorry about that Matthew, I think 5bc0c8f009261

[clang] 81a73fd - Fix aux-target diagnostics for certain builtins

Author: Erich Keane Date: 2020-05-19T10:49:45-07:00 New Revision: 81a73fde5cea304d31294fd26c2f051f1685e97c URL: https://github.com/llvm/llvm-project/commit/81a73fde5cea304d31294fd26c2f051f1685e97c DIFF: https://github.com/llvm/llvm-project/commit/81a73fde5cea304d31294fd26c2f051f1685e97c.diff L

[PATCH] D80166: [CGCall] Annotate reference parameters with "align" attribute.

rjmccall added a comment. Herald added a subscriber: sstefan1. Hmm. It looks like we did reserve space for this in the great pointer-alignment-assumption detente ("RFC: Enforcing pointer type alignment in Clang" from early 2016, which I'm aware was never really a consensus position, but which

[PATCH] D80222: Replace Clang's createRuntimeFunction with the definitions in OMPKinds.def

jhuber6 created this revision. jhuber6 added a reviewer: jdoerfert. jhuber6 added projects: OpenMP, clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits, sstefan1. jhuber6 edited the summary of this revision. This patch changes Clang to generate runtime functions from the information

[PATCH] D79903: FastMathFlags.allowContract should be init from FPFeatures.allowFPContractAcrossStatement

michele.scandale added a comment. This looks good to me. @rjmccall do you have any more feedback? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79903/new/ https://reviews.llvm.org/D79903 ___ cfe-commit

[PATCH] D79525: [Sema] require -fcf-runtime-abi= for __NSConstantString

nickdesaulniers added a comment. clang::Codegen::DeferredDecls might be of interest here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79525/new/ https://reviews.llvm.org/D79525 ___ cfe-commits mailin

[PATCH] D80225: [Driver] Recognize -fuse-ld={bfd, gold, lld} but don't prepend "ld." or "ld64." for other values

MaskRay created this revision. MaskRay added reviewers: martell, rnk, sbc100, theraven. Herald added subscribers: cfe-commits, sunfish, aheejin. Herald added a project: clang. - https://gcc.gnu.org/bugzilla/show_bug.cgi?id=55470 added support for -fuse-ld=bfd to mean `ld.bfd` and -fuse-ld=gold to

[PATCH] D80166: [CGCall] Annotate reference parameters with "align" attribute.

efriedma marked 2 inline comments as done. efriedma added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:2116 +if (PTy->isObjectType()) { + if (unsigned Alignment = getContext().getTypeAlignIfKnown(PTy)) +RetAttrs.addAlignmentAttr( rjm

[PATCH] D79895: Add a new warning to warn when passing uninitialized variables as const reference parameters to a function

zequanwu marked an inline comment as done. zequanwu added inline comments. Comment at: clang/lib/Sema/AnalysisBasedWarnings.cpp:1518 UsesMap uses; + UsesMap constRefUses; rsmith wrote: > zequanwu wrote: > > rnk wrote: > > > If possible, it would be nice to

[PATCH] D79895: Add a new warning to warn when passing uninitialized variables as const reference parameters to a function

zequanwu updated this revision to Diff 264976. zequanwu marked 3 inline comments as done. zequanwu added a comment. Fix typo. Diagnose self-init warning if the self-init variable is used as const reference later. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79895/new/ https://reviews.

[PATCH] D79704: [Analyzer] [NFC] Parameter Regions

baloghadamsoftware updated this revision to Diff 264979. baloghadamsoftware added a comment. SVal explanation extended and tests added for it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79704/new/ https://reviews.llvm.org/D79704 Files: clang/include/clang/StaticAnalyzer/Checkers/S

[PATCH] D80172: Revert "Re-fix _lrotl/_lrotr to always take Long, no matter the platform."

Bigcheese added a comment. In D80172#2042946 , @rnk wrote: > I'd be fine going back to the behavior from before. > > > Without this behavior there is no intrinsic for 32 bit rotates on these > > platforms. > > Strictly speaking, there seems to be `__built

[PATCH] D79895: Add a new warning to warn when passing uninitialized variables as const reference parameters to a function

zequanwu marked an inline comment as done. zequanwu added a comment. In D79895#2042992 , @xbolva00 wrote: > Can you provide some compile time data with warning enabled/disabled? I compiled the test case with warning enabled and disabled. Since it is con

[PATCH] D80228: [clang-format] [PR33890] Add support for Microsoft C++/CLI non standard for each looping extension

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: krasimir, JakeMerdichAMD, mitchell-stellar. MyDeveloperDay added projects: clang, clang-format. https://bugs.llvm.org/show_bug.cgi?id=33890 This revision allow the microsoft `for each( in ...` nonstandard C++ extension whi

[PATCH] D79743: [clang][asm goto][slh] Warn if asm goto + SLH

jyu2 added a comment. This looks good to me. Could you also add a test to use this new DiagGroup (-Wno-slh-asm-goto)? Thanks. Jennifer Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79743/new/ https://reviews.llvm.org/D79743 _

[PATCH] D80023: [clang-tidy] Add abseil-string-find-str-contains checker.

tdl-g updated this revision to Diff 264986. tdl-g marked 16 inline comments as done. tdl-g added a comment. Addressed review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80023/new/ https://reviews.llvm.org/D80023 Files: clang-tools-ex

[PATCH] D80023: [clang-tidy] Add abseil-string-find-str-contains checker.

tdl-g added a comment. Thanks, all for the comments. I believe I've addressed all comments. Note that TransformerClangTidyCheck interacts awkwardly with StoreOptions; I have a FIXME to clean that up. Comment at: clang-tools-extra/clang-tidy/abseil/StringFindStrContainsChec

[PATCH] D80023: [clang-tidy] Add abseil-string-find-str-contains checker.

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:82 + + Finds s.find(...) == string::npos comparisons (for various string-like types) + and suggests replacing with absl::StrContains. Please use double back-ticks to highl

[PATCH] D50078: clang-format: support aligned nested conditionals formatting

MyDeveloperDay added a comment. https://bugs.llvm.org/show_bug.cgi?id=33896 shows an interesting use case (when using UseTab: Always) std::string CLogView::GetItemText(int item) const { return item == 1 ? "one" : item == 2 ? "two" : item == 3 ? "three" : it

[PATCH] D80023: [clang-tidy] Add abseil-string-find-str-contains checker.

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/abseil/StringFindStrContainsCheck.cpp:101-102 + +void StringFindStrContainsCheck::storeOptions( +ClangTidyOptions::OptionMap &Opts) { + Options.store(Opts, "StringLikeClasses", I don't

[PATCH] D80225: [Driver] Recognize -fuse-ld={bfd, gold, lld} but don't prepend "ld." or "ld64." for other values

MaskRay updated this revision to Diff 264995. MaskRay added a comment. Fix fuse-ld-windows.c (I don't have Windows (REQUIRES: system-windows), so I failed to catch the issue earlier) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80225/new/ https:/

[PATCH] D78760: Check a class doesn't have a dependent type before iterating over its base classes

ahatanak updated this revision to Diff 264992. ahatanak retitled this revision from "Check a class has a definition before iterating over its base classes" to "Check a class doesn't have a dependent type before iterating over its base classes". ahatanak edited the summary of this revision. Repos

[clang] 3181273 - [WebAssembly] Implement i64x2.mul and remove i8x16.mul

Author: Thomas Lively Date: 2020-05-19T12:50:44-07:00 New Revision: 3181273be73ac798c3d5b9081dd53d87a31c91b3 URL: https://github.com/llvm/llvm-project/commit/3181273be73ac798c3d5b9081dd53d87a31c91b3 DIFF: https://github.com/llvm/llvm-project/commit/3181273be73ac798c3d5b9081dd53d87a31c91b3.diff

[clang] e42e5e4 - [analyzer] Move apiModeling.StdCLibraryFunctionArgs to alpha.

Author: Artem Dergachev Date: 2020-05-19T23:05:49+03:00 New Revision: e42e5e4d0fc08fed673b453268606bc9fdf0a7d2 URL: https://github.com/llvm/llvm-project/commit/e42e5e4d0fc08fed673b453268606bc9fdf0a7d2 DIFF: https://github.com/llvm/llvm-project/commit/e42e5e4d0fc08fed673b453268606bc9fdf0a7d2.dif

[PATCH] D78155: [OpenMP] Use __OPENMP_NVPTX__ instead of _OPENMP in wrapper headers

jdoerfert added a comment. Herald added a subscriber: sstefan1. ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78155/new/ https://reviews.llvm.org/D78155 ___ cfe-commits mailing list cfe-commits

[PATCH] D80174: [WebAssembly] Implement i64x2.mul and remove i8x16.mul

tlively marked 2 inline comments as done. tlively added inline comments. Comment at: llvm/lib/Target/WebAssembly/WebAssemblyInstrSIMD.td:690 defm "" : SIMDBinary; } aheejin wrote: > Can we delete this now then? No, it is still used down in MIN_S and friends

[PATCH] D79675: [OpenMP][OMPBuilder] Adding Privatization Requirements to OMPIRBuilder

jdoerfert added a comment. Herald added a subscriber: sstefan1. What's the status? Can we split the target specific types stuff if this may take a while, other patches depend on that :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79675/new/ http

[PATCH] D80020: [PowerPC] Add support for -mcpu=pwr10 in both clang and llvm

stefanp added a comment. Most of my comments are related to the fact that we are now inserting P10 between P9 and Future and so a few things need to change for the Future code to sit on top of P10 now.

[PATCH] D80153: [AST] Mangle LambdaContextDecl for top level decl

zequanwu marked an inline comment as done. zequanwu added inline comments. Comment at: clang/lib/AST/MicrosoftMangle.cpp:950-952 // If the context of a closure type is an initializer for a class - // member (static or nonstatic), it is encoded in a qualified n

[PATCH] D80153: [AST] Mangle LambdaContextDecl for top level decl

zequanwu marked an inline comment as done. zequanwu added inline comments. Comment at: clang/lib/AST/MicrosoftMangle.cpp:950-952 // If the context of a closure type is an initializer for a class - // member (static or nonstatic), it is encoded in a qualified n

[PATCH] D80174: [WebAssembly] Implement i64x2.mul and remove i8x16.mul

This revision was automatically updated to reflect the committed changes. Closed by commit rG3181273be73a: [WebAssembly] Implement i64x2.mul and remove i8x16.mul (authored by tlively). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80174/new/ https:/

[PATCH] D80213: [analyzer] Move StdCLibraryFunctionArgs to alpha.

This revision was automatically updated to reflect the committed changes. Closed by commit rGe42e5e4d0fc0: [analyzer] Move apiModeling.StdCLibraryFunctionArgs to alpha. (authored by dergachev.a). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit: htt

[clang] 350dada - Give helpers internal linkage. NFC.

Author: Benjamin Kramer Date: 2020-05-19T22:16:37+02:00 New Revision: 350dadaa8ab3db34ff41d7291f43442c57719de3 URL: https://github.com/llvm/llvm-project/commit/350dadaa8ab3db34ff41d7291f43442c57719de3 DIFF: https://github.com/llvm/llvm-project/commit/350dadaa8ab3db34ff41d7291f43442c57719de3.dif

[clang] 74ef6a1 - Fix X86_64 complex-returns for regcall.

Author: Erich Keane Date: 2020-05-19T13:21:15-07:00 New Revision: 74ef6a11478abe5f0f3f817640508f0cf5d8de0c URL: https://github.com/llvm/llvm-project/commit/74ef6a11478abe5f0f3f817640508f0cf5d8de0c DIFF: https://github.com/llvm/llvm-project/commit/74ef6a11478abe5f0f3f817640508f0cf5d8de0c.diff L

[PATCH] D78155: [OpenMP] Use __OPENMP_NVPTX__ instead of _OPENMP in wrapper headers

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78155/new/ https://reviews.llvm.org/D78155 ___ cfe-

[PATCH] D75323: Support relative dest paths in headermap files

vsapsai added a comment. The issue with this change is that it claims to add functionality that exists already. I.e., the test is passing without the change. The confusing part might be that even if `DirectoryLookup::LookupFile` doesn't find a file for relative destination immediately, it updat

[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

jcelerier added a comment. Also hit by this issue - a lot more people are certainly going to have it as this has started landing in Linux distros. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66324/new/ https://reviews.llvm.org/D66324

[PATCH] D80237: [hip] Ensure pointer in struct argument has proper `addrspacecast`.

hliao created this revision. hliao added reviewers: arsenm, tra, rjmccall, yaxunl. Herald added subscribers: cfe-commits, kerbowa, nhaehnle, wdng, jvesely. Herald added a project: clang. - In last https://reviews.llvm.org/D69826, generic pointers in struct/array types are also replaced with globa

[PATCH] D80023: [clang-tidy] Add abseil-string-find-str-contains checker.

ymandel added a comment. Looks good, just some nits! Comment at: clang-tools-extra/clang-tidy/abseil/StringFindStrContainsCheck.cpp:48 + Options.get("StringLikeClasses", DefaultStringLikeClasses)); + const std::string AbseilStringsMatchHeader( + Options.get("Abs

[PATCH] D80239: [libTooling] In Transformer, allow atomic changes to span multiple files.

ymandel created this revision. ymandel added a reviewer: gribozavr. Herald added subscribers: jfb, mgrang. Herald added a project: clang. Currently, all changes returned by a single application of a rule must fit in one atomic change and therefore must apply to one file. However, there are pattern

[PATCH] D80225: [Driver] Recognize -fuse-ld={bfd, gold, lld} but don't prepend "ld." or "ld64." for other values

MaskRay updated this revision to Diff 265026. MaskRay added a comment. Fix fuse-ld-windows.c Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80225/new/ https://reviews.llvm.org/D80225 Files: clang/lib/Driver/ToolChain.cpp clang/test/Driver/Input

[clang] 6d2b75e - [clang-misexpect] Fixed typo which causes that --pgo-warn-misexpect option is not passed in the compiler invocation

Author: Dávid Bolvanský Date: 2020-05-19T23:12:08+02:00 New Revision: 6d2b75e0887ee87e247756c4d51733616bb2f356 URL: https://github.com/llvm/llvm-project/commit/6d2b75e0887ee87e247756c4d51733616bb2f356 DIFF: https://github.com/llvm/llvm-project/commit/6d2b75e0887ee87e247756c4d51733616bb2f356.dif

Re: [clang] 6d2b75e - [clang-misexpect] Fixed typo which causes that --pgo-warn-misexpect option is not passed in the compiler invocation

This breaks check-clang: http://45.33.8.238/linux/18098/step_7.txt Please take a look, and revert if it takes a while to fix. On Tue, May 19, 2020 at 5:12 PM Dávid Bolvanský via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: Dávid Bolvanský > Date: 2020-05-19T23:12:08+02:00 > New R

Re: [clang] 6d2b75e - [clang-misexpect] Fixed typo which causes that --pgo-warn-misexpect option is not passed in the compiler invocation

This seems to be missing a test On Wed, May 20, 2020 at 12:12 AM Dávid Bolvanský via cfe-commits wrote: > > > Author: Dávid Bolvanský > Date: 2020-05-19T23:12:08+02:00 > New Revision: 6d2b75e0887ee87e247756c4d51733616bb2f356 > > URL: > https://github.com/llvm/llvm-project/commit/6d2b75e0887ee87e

[PATCH] D80240: [OPENMP50]Initial codegen for 'affinity' clauses.

ABataev created this revision. ABataev added a reviewer: jdoerfert. Herald added subscribers: llvm-commits, sstefan1, guansong, yaxunl. Herald added projects: clang, LLVM. Added initial codegen for 'affinity' clauses on task directives. Emits next code: kmp_task_affinity_info_t affs[]; voi

<    1   2   3