[PATCH] D80200: [AST][RecoveryExpr] Fix an assertion crash on openMP.

sammccall added a subscriber: ABataev. sammccall added a comment. This seems vaguely reasonable to me, but I don't really know what an OpenMP capture is. @ABataev, @jdoerfert : Any thoughts or concerns here? Some context: an expression that contains errors can exist after certain types of sema/

[PATCH] D75791: [clang-format] Added new option IndentExternBlock

MarcusJohnson91 marked 4 inline comments as done. MarcusJohnson91 added inline comments. Comment at: clang/lib/Format/Format.cpp:714 case FormatStyle::BS_Mozilla: +Expanded.IndentExternBlock = FormatStyle::IEBS_AfterExternBlock; Expanded.BraceWrapping.AfterClass = tru

[PATCH] D78162: [CodeGen] Mark inline definitions of builtins as nobuiltin only if we plan to emit them.

melver added a comment. This seems to be causing problems for the Linux kernel with ASan instrumentation enabled: https://lkml.kernel.org/r/20200518180513.ga114...@google.com Still investigating if it's the kernel, KASAN, or Clang that's doing something wrong. Any pointers welcome. Many thank

[PATCH] D75791: [clang-format] Added new option IndentExternBlock

MarcusJohnson91 updated this revision to Diff 264839. MarcusJohnson91 added a comment. Ok, I've removed the inherited ones, and also removed the times I was setting a style when there wasn't one before. also I moved the `IEBS_AfterExternBlock` line to right underneath the `BraceWrapping.AfterEx

[PATCH] D79773: [clang-format] Improve clang-formats handling of concepts

MyDeveloperDay planned changes to this revision. MyDeveloperDay marked 4 inline comments as done. MyDeveloperDay added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:3499 return true; if (Right.Previous->ClosesTemplateDeclaration && Right.Previous

[PATCH] D75430: [analyzer][NFC] Introduce CXXDeallocatorCall, deploy it in MallocChecker

Szelethus added a comment. In D75430#2028456 , @NoQ wrote: > Sorry i'm not very responsive these days >.< No worries, thanks! ^-^ Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h:1052 +/// This is a call

[PATCH] D80202: [ASTMatchers] Performance optimization for memoization

njames93 created this revision. njames93 added a reviewer: klimek. Herald added a project: clang. Herald added a subscriber: cfe-commits. A simple optimization to avoid unnecessary copies of BoundNodesTreeBuilders when querying the cache for memoized matchers. This hasn't been benchmarked as I'm

[PATCH] D79921: [OPENMP] Fix mixture of omp and clang pragmas

hishiguro updated this revision to Diff 264836. hishiguro retitled this revision from "[OpenMP] Fix omp and clang pragmas" to "[OPENMP] Fix mixture of omp and clang pragmas". hishiguro added a comment. Herald added a reviewer: a.sidorin. I checked that your comments are correct. I modified the so

[PATCH] D77644: [clangd] Handle additional includes while parsing ASTs

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Sorry for the delay. I think this is good though I have a nagging feeling I don't understand all the implications yet :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D79930: [clangd] Add buildPreamble to TestTU

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/unittests/TestTU.h:71 ParsedAST build() const; + std::shared_ptr buildPreamble() const; ParseInputs inputs() const;

[PATCH] D80015: [Analyzer][StreamChecker] Added support for 'fread' and 'fwrite'.

balazske updated this revision to Diff 264843. balazske marked 5 inline comments as done. balazske added a comment. Renamed "Count" to "NMemb", fixed `operator !=`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80015/new/ https://reviews.llvm.org/D

[PATCH] D80200: [AST][RecoveryExpr] Fix an assertion crash on openMP.

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80200/new/ https://reviews.llvm.org/D80200 ___

[clang-tools-extra] 032727f - [clangd] Complete filenames after < / ".

Author: Sam McCall Date: 2020-05-19T13:32:26+02:00 New Revision: 032727f4f839a28ae449d2f38814857780c7453d URL: https://github.com/llvm/llvm-project/commit/032727f4f839a28ae449d2f38814857780c7453d DIFF: https://github.com/llvm/llvm-project/commit/032727f4f839a28ae449d2f38814857780c7453d.diff LO

[clang-tools-extra] 9b88a19 - [clangd] Add CSV export for trace metrics

Author: Sam McCall Date: 2020-05-19T13:35:31+02:00 New Revision: 9b88a190b42a03753b9c49ccea34514cb40ba4ab URL: https://github.com/llvm/llvm-project/commit/9b88a190b42a03753b9c49ccea34514cb40ba4ab DIFF: https://github.com/llvm/llvm-project/commit/9b88a190b42a03753b9c49ccea34514cb40ba4ab.diff LO

[PATCH] D75791: [clang-format] Added new option IndentExternBlock

MyDeveloperDay added a comment. > btw, in .BraceWrapping = {true, false); blocks, AfterExternBlock is the 9th > option, I checked the BraceWrapping enum. This will become clearer I hope when I land D79325: [clang-format] [PR42164] Add Option to Break before While

[PATCH] D79921: [OPENMP] Fix mixture of omp and clang pragmas

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:1735 + // If attributes are attached, push to the basic block with them. + const OMPExecutableDirective *OMPED = dyn_cast(&S); + const CapturedStmt *ICS = OMPED->getInnermostCapturedStmt(); -

[PATCH] D75791: [clang-format] Added new option IndentExternBlock

MyDeveloperDay added a comment. All this confusion over the defaults is because we don't have the unit tests to check the default of each style. If we had that we could have a before/after conversation more easily Nit: also please mark comments done once you have addressed them.

[PATCH] D78454: [clangd] Highlight related control flow.

adamcz accepted this revision. adamcz added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/XRefs.cpp:907 +// Highlight the loop keyword itself. +Result.push_back(P->ASTNode.getSourceRange().getBegin()); +

[PATCH] D75791: [clang-format] Added new option IndentExternBlock

MyDeveloperDay added a comment. Sorry to "go around the houses" but we'll get there in the end...I think we are close CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75791/new/ https://reviews.llvm.org/D75791 ___ cfe-commits mailing list cfe

[PATCH] D79773: [clang-format] Improve clang-formats handling of concepts

MyDeveloperDay updated this revision to Diff 264851. MyDeveloperDay added a comment. Move break before concept into correct clause Add `requires requires` test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79773/new/ https://reviews.llvm.org/D79773 Files: clang/docs/ClangFormatStyleO

[PATCH] D79992: [WIP][clangd] Patch PP directives to use stale preambles while building ASTs

sammccall added inline comments. Comment at: clang-tools-extra/clangd/Preamble.cpp:419 + if (DirectivesChanged) { +// We need to patch all the directives, since they are order dependent. e.g: +// #define BAR(X) NEW(X) // Newly introduced in Modified Hmm

[PATCH] D79678: [clangd] Add CSV export for trace metrics

This revision was automatically updated to reflect the committed changes. Closed by commit rG9b88a190b42a: [clangd] Add CSV export for trace metrics (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79678/new/ https://reviews.ll

[PATCH] D79456: [clangd] Complete filenames after < / ".

This revision was automatically updated to reflect the committed changes. sammccall marked an inline comment as done. Closed by commit rG032727f4f839: [clangd] Complete filenames after < / ". (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[clang-tools-extra] 61559d0 - [clangd] Squash GCC error with StringRef + gtest MatchesRegex()

Author: Sam McCall Date: 2020-05-19T13:58:23+02:00 New Revision: 61559d045868e3980deca6cf5d30ad8816951960 URL: https://github.com/llvm/llvm-project/commit/61559d045868e3980deca6cf5d30ad8816951960 DIFF: https://github.com/llvm/llvm-project/commit/61559d045868e3980deca6cf5d30ad8816951960.diff LO

[clang] 2e5e42d - [analyzer][MallocChecker] When modeling realloc-like functions, don't early return if the argument is symbolic

Author: Kirstóf Umann Date: 2020-05-19T13:59:29+02:00 New Revision: 2e5e42d4aeab98636346db558e89ab9b122c9dc3 URL: https://github.com/llvm/llvm-project/commit/2e5e42d4aeab98636346db558e89ab9b122c9dc3 DIFF: https://github.com/llvm/llvm-project/commit/2e5e42d4aeab98636346db558e89ab9b122c9dc3.diff

[clang-tools-extra] 6e99199 - Fix "not all control paths return a value" warning on MSVC builds.

Author: Simon Pilgrim Date: 2020-05-19T13:16:24+01:00 New Revision: 6e99199419d95f39ae9d8a11d8632caac7b405b4 URL: https://github.com/llvm/llvm-project/commit/6e99199419d95f39ae9d8a11d8632caac7b405b4 DIFF: https://github.com/llvm/llvm-project/commit/6e99199419d95f39ae9d8a11d8632caac7b405b4.diff

[PATCH] D79773: [clang-format] Improve clang-formats handling of concepts

miscco added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:2281 + if (FormatTok->Tok.is(tok::kw_requires)) +parseRequires(); +} I believe this should be `parseConstraintExpression` because that is the term of art in the standard. T

[PATCH] D79773: [clang-format] Improve clang-formats handling of concepts

miscco added a comment. You are missing to check the boolean in `CHECK_PARSE_BOOL` in FormatTest.cpp Comment at: clang/lib/Format/TokenAnnotator.cpp:1566 Current.Type = TT_TrailingReturnArrow; - +} else if (Current.is(tok::arrow) && Current.Previous && +

[PATCH] D80015: [Analyzer][StreamChecker] Added support for 'fread' and 'fwrite'.

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. This patch is great. LGTM! In D80015#2043263 , @balazske wrote: > If the unit of the change is adding `fread` and `fwrite` completely, the > war

[PATCH] D80117: [analyzer] Introduce reasoning about symbolic remainder operator

vsavchenko updated this revision to Diff 264863. vsavchenko added a comment. Fix code review remarks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80117/new/ https://reviews.llvm.org/D80117 Files: clang/lib/StaticAnalyzer/Core/RangeConstraintMa

[PATCH] D79415: [analyzer][MallocChecker] When modeling realloc-like functions, don't early return if the argument is symbolic

This revision was automatically updated to reflect the committed changes. Closed by commit rG2e5e42d4aeab: [analyzer][MallocChecker] When modeling realloc-like functions, don't early… (authored by Szelethus). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[clang] 2e499ee - [OPENMP50]Add initial support for 'affinity' clause.

Author: Alexey Bataev Date: 2020-05-19T08:19:09-04:00 New Revision: 2e499eee5884456f3dd068662ee1785f24bd88cc URL: https://github.com/llvm/llvm-project/commit/2e499eee5884456f3dd068662ee1785f24bd88cc DIFF: https://github.com/llvm/llvm-project/commit/2e499eee5884456f3dd068662ee1785f24bd88cc.diff

[PATCH] D72531: Set traversal explicitly where needed in tests

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/unittests/Tooling/StencilTest.cpp:63 ASTContext &Context = AstUnit->getASTContext(); - auto Matches = ast_matchers::match(wrapMatche

[PATCH] D80202: [ASTMatchers] Performance optimization for memoization

grandinj added inline comments. Comment at: clang/lib/ASTMatchers/ASTMatchFinder.cpp:78 + const BoundNodesTreeBuilder &BoundNodes; + const TraversalKind Traversal; + note that making fields const tends to disable various move optimisations, so better to mark t

[PATCH] D80171: [analyzer] LoopUnrolling: fix crash when a parameter is a loop counter

xazax.hun added inline comments. Comment at: clang/test/Analysis/loop-unrolling.cpp:503 + +void arg_as_loop_counter(int i) { + for (i = 0; i < 10; ++i) { nit: we usually use `arg` for actual arguments at the call site, and use `param` for formal parameters. The

[PATCH] D80171: [analyzer] LoopUnrolling: fix crash when a parameter is a loop counter

xazax.hun added reviewers: NoQ, vsavchenko. xazax.hun added a comment. Thanks for finding this bug! Adding some reviewers. I think it would be perfectly fine to unroll loops where the loop counter is a pass-by-value parameter. That should not be considered escaped. I think in case of parameters

[PATCH] D80117: [analyzer] Introduce reasoning about symbolic remainder operator

xazax.hun added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:633 + + // Check if LHS is 0. It's a special case when the result is guaranteed + // to be 0 no matter what RHS is (we put to the side the case when RHS is I

[PATCH] D80148: [OPENMP50]Add initial support for 'affinity' clause.

This revision was automatically updated to reflect the committed changes. Closed by commit rG2e499eee5884: [OPENMP50]Add initial support for 'affinity' clause. (authored by ABataev). Herald added a subscriber: sstefan1. Changed prior to commit: https://reviews.llvm.org/D80148?vs=264687&id=26487

[clang] 2395431 - [AST][RecoveryExpr] Fix an assertion crash on openMP.

Author: Haojian Wu Date: 2020-05-19T15:09:26+02:00 New Revision: 23954318f49f1b96cb5c4b76921bea4f7ac0d5f3 URL: https://github.com/llvm/llvm-project/commit/23954318f49f1b96cb5c4b76921bea4f7ac0d5f3 DIFF: https://github.com/llvm/llvm-project/commit/23954318f49f1b96cb5c4b76921bea4f7ac0d5f3.diff LO

[clang] 6f56599 - [AST] Fix the PrintQualifiedName for ObjC instance variable in class extension.

Author: Haojian Wu Date: 2020-05-19T15:17:36+02:00 New Revision: 6f56599c14af0a4b7a4d4b2c4f6ae44bc2754c0c URL: https://github.com/llvm/llvm-project/commit/6f56599c14af0a4b7a4d4b2c4f6ae44bc2754c0c DIFF: https://github.com/llvm/llvm-project/commit/6f56599c14af0a4b7a4d4b2c4f6ae44bc2754c0c.diff LO

[clang-tools-extra] 0320ce8 - [clangd] Add a flag to preserve type for recovery expression.

Author: Haojian Wu Date: 2020-05-19T15:21:57+02:00 New Revision: 0320ce8916a815d10a0449f5581e0f3ca7183922 URL: https://github.com/llvm/llvm-project/commit/0320ce8916a815d10a0449f5581e0f3ca7183922 DIFF: https://github.com/llvm/llvm-project/commit/0320ce8916a815d10a0449f5581e0f3ca7183922.diff LO

[PATCH] D79862: [clangd-remote] Replace YAML serialization with proper Protobuf messages

kbobyrev updated this revision to Diff 264873. kbobyrev marked 6 inline comments as done. kbobyrev added a comment. Address some comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79862/new/ https://reviews.llvm.org/D79862 Files: clang-tool

[PATCH] D79862: [clangd-remote] Replace YAML serialization with proper Protobuf messages

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/unittests/remote/CMakeLists.txt:2 +set(LLVM_LINK_COMPONENTS + Support + ) sammccall wrote: > Can we conditionally include these tests into the main ClangdTests, instead > of setting up anothe

[PATCH] D79773: [clang-format] Improve clang-formats handling of concepts

miscco added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:2314 + nextToken(); + if (FormatTok->Tok.is(tok::less)) { +while (!FormatTok->Tok.is(tok::greater)) { I guess you could use `parseBracedList(/*ContinueOnSemicolon

[PATCH] D79862: [clangd-remote] Replace YAML serialization with proper Protobuf messages

kbobyrev updated this revision to Diff 264874. kbobyrev marked 3 inline comments as done. kbobyrev added a comment. Move remote tests into all Clangd tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79862/new/ https://reviews.llvm.org/D79862 Fi

[PATCH] D79862: [clangd-remote] Replace YAML serialization with proper Protobuf messages

kbobyrev updated this revision to Diff 264877. kbobyrev added a comment. Move a comment to the line it corresponds to. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79862/new/ https://reviews.llvm.org/D79862 Files: clang-tools-extra/clangd/index

[PATCH] D79678: [clangd] Add CSV export for trace metrics

thakis added a comment. This broke tests on Windows: http://45.33.8.238/win/15539/step_9.txt Please take a look, and revert if it takes a while to investigate. (I'll note that the presubmit bot now has a win/msvc bot that failed compile and reported this on this review before it got merged: ht

[PATCH] D79862: [clangd-remote] Replace YAML serialization with proper Protobuf messages

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/unittests/remote/CMakeLists.txt:2 +set(LLVM_LINK_COMPONENTS + Support + ) kbobyrev wrote: > sammccall wrote: > > Can we conditionally include these tests into the main ClangdTests, instead >

[PATCH] D80171: [analyzer] LoopUnrolling: fix crash when a parameter is a loop counter

vsavchenko added a comment. Thanks for taking your time to find and resolve the bug. I agree that this solution seems a bit too harsh. Technically there is no difference between local variable declaration and a parameter declaration (if we are talking about value types as pointed out by @xazax.

[PATCH] D80200: [AST][RecoveryExpr] Fix an assertion crash on openMP.

This revision was automatically updated to reflect the committed changes. Closed by commit rG23954318f49f: [AST][RecoveryExpr] Fix an assertion crash on openMP. (authored by hokein). Herald added a subscriber: sstefan1. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D75791: [clang-format] Added new option IndentExternBlock

MarcusJohnson91 added a comment. In D75791#2043758 , @MyDeveloperDay wrote: > Sorry to "go around the houses" but we'll get there in the end...I think we > are close I think we're close too. Your other comment was interesting, about testing the styles

[PATCH] D75791: [clang-format] Added new option IndentExternBlock

MarcusJohnson91 marked 5 inline comments as done. MarcusJohnson91 added inline comments. Comment at: clang/lib/Format/Format.cpp:812 true, true}; + LLVMStyle.IndentExternBlock = FormatStyle::IEBS_AfterExternBlock; LLVMStyle.BreakAfterJavaFieldAn

[PATCH] D79576: [AST] Fix the PrintQualifiedName for ObjC instance variable in class extension.

This revision was automatically updated to reflect the committed changes. Closed by commit rG6f56599c14af: [AST] Fix the PrintQualifiedName for ObjC instance variable in class extension. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D80144: [clang-format] @lefticus just taught the world how to use [[unlikely]] but we forgot to teach clang-format

JakeMerdichAMD accepted this revision. JakeMerdichAMD added a comment. This revision is now accepted and ready to land. LGTM assuming CI tests pass. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80144/new/ https://reviews.llvm.org/D80144 __

[PATCH] D79938: [clangd] Add a flag to preserve type for recovery expression.

This revision was automatically updated to reflect the committed changes. Closed by commit rG0320ce8916a8: [clangd] Add a flag to preserve type for recovery expression. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79938/new/ h

[clang-tools-extra] fcf0764 - [AST] Fix an assertion violation in FieldDecl::getParent.

Author: Haojian Wu Date: 2020-05-19T15:35:04+02:00 New Revision: fcf0764998b45279cfdf4039c69aec2cd09051a5 URL: https://github.com/llvm/llvm-project/commit/fcf0764998b45279cfdf4039c69aec2cd09051a5 DIFF: https://github.com/llvm/llvm-project/commit/fcf0764998b45279cfdf4039c69aec2cd09051a5.diff LO

[clang] 500479d - [analyzer][DirectIvarAssignment] Turn DirectIvarAssignmentForAnnotatedFunctions into a checker option

Author: Kirstóf Umann Date: 2020-05-19T15:41:43+02:00 New Revision: 500479dba33ae03644313e34d10c013371b5215b URL: https://github.com/llvm/llvm-project/commit/500479dba33ae03644313e34d10c013371b5215b DIFF: https://github.com/llvm/llvm-project/commit/500479dba33ae03644313e34d10c013371b5215b.diff

[PATCH] D79992: [WIP][clangd] Patch PP directives to use stale preambles while building ASTs

kadircet marked 3 inline comments as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/Preamble.cpp:419 + if (DirectivesChanged) { +// We need to patch all the directives, since they are order dependent. e.g: +// #define BAR(X) NEW(X) // Newly i

[PATCH] D77474: [analyzer][MallocChecker] Make NewDeleteLeaks depend on DynamicMemoryModeling rather than NewDelete

Szelethus added a comment. Gentle ping :^) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77474/new/ https://reviews.llvm.org/D77474 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

[PATCH] D78121: [analyzer][DirectIvarAssignment] Turn DirectIvarAssignmentForAnnotatedFunctions into a checker option

thakis added a comment. Sorry, wrong link, I meant http://45.33.8.238/linux/18049/step_7.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78121/new/ https://reviews.llvm.org/D78121 ___ cfe-commits mai

[PATCH] D79627: [AST] Fix an assertion violation in FieldDecl::getParent.

This revision was automatically updated to reflect the committed changes. Closed by commit rGfcf0764998b4: [AST] Fix an assertion violation in FieldDecl::getParent. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79627/new/ https

[PATCH] D78121: [analyzer][DirectIvarAssignment] Turn DirectIvarAssignmentForAnnotatedFunctions into a checker option

thakis added a comment. Looks like this breaks check-clang: http://45.33.8.238/ Please take a look. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78121/new/ https://reviews.llvm.org/D78121 ___ cfe-com

[PATCH] D78121: [analyzer][DirectIvarAssignment] Turn DirectIvarAssignmentForAnnotatedFunctions into a checker option

This revision was automatically updated to reflect the committed changes. Closed by commit rG500479dba33a: [analyzer][DirectIvarAssignment] Turn DirectIvarAssignmentForAnnotatedFunctions… (authored by Szelethus). Changed prior to commit: https://reviews.llvm.org/D78121?vs=257369&id=264889#toc

[clang-tools-extra] 7ebf7d9 - [clangd] Delete regex assertion, breaking on windows too...

Author: Sam McCall Date: 2020-05-19T16:07:01+02:00 New Revision: 7ebf7d91e6132ba619f5b27895fc1b5f536a101b URL: https://github.com/llvm/llvm-project/commit/7ebf7d91e6132ba619f5b27895fc1b5f536a101b DIFF: https://github.com/llvm/llvm-project/commit/7ebf7d91e6132ba619f5b27895fc1b5f536a101b.diff LO

[clang] 6846aec - [analyzer] SATestBuild.py: Optionally override compiler

Author: Valeriy Savchenko Date: 2020-05-19T17:12:46+03:00 New Revision: 6846aec7313f81d6d8fd5190d6b49eba9f038a8e URL: https://github.com/llvm/llvm-project/commit/6846aec7313f81d6d8fd5190d6b49eba9f038a8e DIFF: https://github.com/llvm/llvm-project/commit/6846aec7313f81d6d8fd5190d6b49eba9f038a8e.d

[PATCH] D80211: [analyzer] SATestBuild.py: Optionally override compiler

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Ideally we should be able to control it on per-project basis(?) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80211/new/ https://reviews.llvm.org/D802

[PATCH] D80200: [AST][RecoveryExpr] Fix an assertion crash on openMP.

jdoerfert added a comment. Thx! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80200/new/ https://reviews.llvm.org/D80200 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D80211: [analyzer] SATestBuild.py: Optionally override compiler

vsavchenko added a comment. I agree, but I think we should refactor a bit how we process command line arguments before that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80211/new/ https://reviews.llvm.org/D80211 __

[PATCH] D79862: [clangd-remote] Replace YAML serialization with proper Protobuf messages

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks! Sorry about the hassle with the tests. Comment at: clang-tools-extra/clangd/unittests/remote/CMakeLists.txt:2 +set(LLVM_LINK_COMPONENTS + Support + )

[PATCH] D80211: [analyzer] SATestBuild.py: Optionally override compiler

vsavchenko created this revision. vsavchenko added a reviewer: NoQ. Herald added subscribers: cfe-commits, ASDenysPetrov, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. NoQ accepted this revision. NoQ adde

[PATCH] D75791: [clang-format] Added new option IndentExternBlock

MyDeveloperDay added a comment. This is what I was thinking about D80214: [clang-format] Set of unit test to begin to validate that we don't change defaults CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75791/new/ https://reviews.llvm.org/D75791 __

[PATCH] D80212: [clangd] Handle references for patched macros

kadircet created this revision. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Depends on D80198 . Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D80212 Files: clang

[PATCH] D80214: [clang-format] Set of unit test to begin to validate that we don't change defaults

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: MarcusJohnson91, krasimir, JakeMerdichAMD. MyDeveloperDay added projects: clang, clang-format. This revision is to complement D75791: [clang-format] Added new option IndentExternBlock so we can

[PATCH] D75791: [clang-format] Added new option IndentExternBlock

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. I think this LGTM now... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75791/new/ https://reviews.llvm.org/D75791 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D80211: [analyzer] SATestBuild.py: Optionally override compiler

This revision was automatically updated to reflect the committed changes. Closed by commit rG6846aec7313f: [analyzer] SATestBuild.py: Optionally override compiler (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80211/new/ htt

[clang-tools-extra] b0d9496 - [clangd] findExplicitReferences supports goto labels

Author: Sam McCall Date: 2020-05-19T16:50:35+02:00 New Revision: b0d94964da8cf6c24ece253fdfc7f9e8016afee9 URL: https://github.com/llvm/llvm-project/commit/b0d94964da8cf6c24ece253fdfc7f9e8016afee9 DIFF: https://github.com/llvm/llvm-project/commit/b0d94964da8cf6c24ece253fdfc7f9e8016afee9.diff LO

[clang-tools-extra] 5bc0c8f - [clangd] Avoid StringRef entirely with gmock

Author: Sam McCall Date: 2020-05-19T16:50:35+02:00 New Revision: 5bc0c8f009261425a25c1bb109f81b454c928bf5 URL: https://github.com/llvm/llvm-project/commit/5bc0c8f009261425a25c1bb109f81b454c928bf5 DIFF: https://github.com/llvm/llvm-project/commit/5bc0c8f009261425a25c1bb109f81b454c928bf5.diff LO

[clang] 268fa40 - [analyzer] Don't print the config count in debug.ConfigDumper

Author: Kirstóf Umann Date: 2020-05-19T16:51:14+02:00 New Revision: 268fa40daa151d3b4bff1df12b62e5dae94685d7 URL: https://github.com/llvm/llvm-project/commit/268fa40daa151d3b4bff1df12b62e5dae94685d7 DIFF: https://github.com/llvm/llvm-project/commit/268fa40daa151d3b4bff1df12b62e5dae94685d7.diff

[clang] 7f5d91d - [clang][AIX] Implement ABIInfo and TargetCodeGenInfo for AIX

Author: jasonliu Date: 2020-05-19T15:00:48Z New Revision: 7f5d91d3ffedf89823f36a5eba5ec586bc885545 URL: https://github.com/llvm/llvm-project/commit/7f5d91d3ffedf89823f36a5eba5ec586bc885545 DIFF: https://github.com/llvm/llvm-project/commit/7f5d91d3ffedf89823f36a5eba5ec586bc885545.diff LOG: [cla

[clang] e4e1080 - [analyzer][Nullability] Don't emit under the checker name NullabilityBase

Author: Kirstóf Umann Date: 2020-05-19T17:04:06+02:00 New Revision: e4e1080a5837e4a4f38c46b9974f2b2402bb021a URL: https://github.com/llvm/llvm-project/commit/e4e1080a5837e4a4f38c46b9974f2b2402bb021a DIFF: https://github.com/llvm/llvm-project/commit/e4e1080a5837e4a4f38c46b9974f2b2402bb021a.diff

[PATCH] D78121: [analyzer][DirectIvarAssignment] Turn DirectIvarAssignmentForAnnotatedFunctions into a checker option

Szelethus added a comment. Taking a look as I'm speaking! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78121/new/ https://reviews.llvm.org/D78121 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D78121: [analyzer][DirectIvarAssignment] Turn DirectIvarAssignmentForAnnotatedFunctions into a checker option

Szelethus added a comment. rG268fa40daa151d3b4bff1df12b62e5dae94685d7 should fix it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78121/new/ https://reviews.llvm.org/D78121

[PATCH] D75791: [clang-format] Added new option IndentExternBlock

MarcusJohnson91 updated this revision to Diff 264911. MarcusJohnson91 added a comment. Made the IndentExternBlockStyle enum comments a bit clearer, and regenerated the .rst file CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75791/new/ https://reviews.llvm.org/D75791 Files: clang/doc

[PATCH] D75791: [clang-format] Added new option IndentExternBlock

MarcusJohnson91 updated this revision to Diff 264909. MarcusJohnson91 added a comment. Just fixed the formatting of the ReleaseNotes.rst file, the extern blocks were slightly askew, and it might've made it a bit confusing CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75791/new/ https:/

[PATCH] D79862: [clangd-remote] Replace YAML serialization with proper Protobuf messages

kbobyrev added a comment. In D79862#2044073 , @sammccall wrote: > Thanks! Sorry about the hassle with the tests. No worries, I think it looks cleaner and simpler which is important. Thanks for the review! Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D75791: [clang-format] Added new option IndentExternBlock

MarcusJohnson91 updated this revision to Diff 264916. MarcusJohnson91 added a comment. Format.h: indented the ``AfterExternBlock: true`` example code snippet with 4 spaces like the Indent option so it's more visible and matches. I think it's perfect now. CHANGES SINCE LAST ACTION https://rev

[clang-tools-extra] c6b2b78 - [clangd-remote] Replace YAML serialization with proper Protobuf messages

Author: Kirill Bobyrev Date: 2020-05-19T17:07:38+02:00 New Revision: c6b2b784299b5b8c2081b4e7e76eeab80e9b81ee URL: https://github.com/llvm/llvm-project/commit/c6b2b784299b5b8c2081b4e7e76eeab80e9b81ee DIFF: https://github.com/llvm/llvm-project/commit/c6b2b784299b5b8c2081b4e7e76eeab80e9b81ee.diff

[PATCH] D78122: [analyzer][Nullability] Don't emit under the checker name NullabilityBase

This revision was automatically updated to reflect the committed changes. Closed by commit rGe4e1080a5837: [analyzer][Nullability] Don't emit under the checker name NullabilityBase (authored by Szelethus). Changed prior to commit: https://reviews.llvm.org/D78122?vs=257372&id=264921#toc Reposit

[PATCH] D80170: [clangd] findExplicitReferences supports goto labels

This revision was automatically updated to reflect the committed changes. Closed by commit rGb0d94964da8c: [clangd] findExplicitReferences supports goto labels (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80170/new/ https:/

[PATCH] D75791: [clang-format] Added new option IndentExternBlock

Abpostelnicu added a comment. Let's first see we don't break anything on `mozilla`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75791/new/ https://reviews.llvm.org/D75791 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[PATCH] D79035: [clang][AIX] Implement ABIInfo and TargetCodeGenInfo for AIX

This revision was automatically updated to reflect the committed changes. Closed by commit rG7f5d91d3ffed: [clang][AIX] Implement ABIInfo and TargetCodeGenInfo for AIX (authored by jasonliu). Changed prior to commit: https://reviews.llvm.org/D79035?vs=263864&id=264922#toc Repository: rG LLVM

[PATCH] D79862: [clangd-remote] Replace YAML serialization with proper Protobuf messages

This revision was automatically updated to reflect the committed changes. Closed by commit rGc6b2b784299b: [clangd-remote] Replace YAML serialization with proper Protobuf messages (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D74166: [AIX][Frontend] Static init implementation for AIX considering no priority

Xiangling_L updated this revision to Diff 264926. Xiangling_L marked an inline comment as done. Xiangling_L added a comment. Fix the linkage types; Adjust the formatting; Update the testcase; Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74166/new/

[clang] 6189dd0 - [clang-format] [PR45942] [[nodiscard]] causes && to be miss interpreted as BinaryOperators

Author: mydeveloperday Date: 2020-05-19T16:41:50+01:00 New Revision: 6189dd06ad4889dfbccf185f9d81e72fe9173a8a URL: https://github.com/llvm/llvm-project/commit/6189dd06ad4889dfbccf185f9d81e72fe9173a8a DIFF: https://github.com/llvm/llvm-project/commit/6189dd06ad4889dfbccf185f9d81e72fe9173a8a.diff

[PATCH] D78454: [clangd] Highlight related control flow.

sammccall marked 3 inline comments as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:907 +// Highlight the loop keyword itself. +Result.push_back(P->ASTNode.getSourceRange().getBegin()); +break; adamc

[PATCH] D78129: Add Marvell ThunderX3T110 support

wxz2020 added a comment. I have a question here. Our customers need the TX3 support urgently, they asked me to put this TX3 support to LLVM 10.0.1 and if there is 9.0.2 release planned, they also need it there. How can I do this? To put this checkin to LLVM 10.0.1 branch and 9.0.2 branch? Is

[PATCH] D80008: [clang-format] [PR45942] [[nodiscard]] causes && to be miss interpreted as BinaryOperators

This revision was automatically updated to reflect the committed changes. Closed by commit rG6189dd06ad48: [clang-format] [PR45942] [[nodiscard]] causes && to be miss interpreted as… (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D79905: [clang-format] [PR44476] Add space between template and attribute

This revision was automatically updated to reflect the committed changes. Closed by commit rG07740dd08b57: [clang-format] [PR44476] Add space between template and attribute (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7

[clang] 07740dd - [clang-format] [PR44476] Add space between template and attribute

Author: mydeveloperday Date: 2020-05-19T16:43:50+01:00 New Revision: 07740dd08b572af26d9fdeed2615f3a6996bee22 URL: https://github.com/llvm/llvm-project/commit/07740dd08b572af26d9fdeed2615f3a6996bee22 DIFF: https://github.com/llvm/llvm-project/commit/07740dd08b572af26d9fdeed2615f3a6996bee22.diff

[clang] 575c59c - [clang-format] [PR45614] Incorrectly indents [[nodiscard]] attribute funtions after a macro without semicolon

Author: mydeveloperday Date: 2020-05-19T16:47:38+01:00 New Revision: 575c59cf6a32889c5f1131af39e07bbdde27e8da URL: https://github.com/llvm/llvm-project/commit/575c59cf6a32889c5f1131af39e07bbdde27e8da DIFF: https://github.com/llvm/llvm-project/commit/575c59cf6a32889c5f1131af39e07bbdde27e8da.diff

<    1   2   3   >