sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land.
Thanks! Sorry about the hassle with the tests. ================ Comment at: clang-tools-extra/clangd/unittests/remote/CMakeLists.txt:2 +set(LLVM_LINK_COMPONENTS + Support + ) ---------------- kbobyrev wrote: > kbobyrev wrote: > > sammccall wrote: > > > Can we conditionally include these tests into the main ClangdTests, > > > instead of setting up another set of targets? > > I can do that, although I saw that XPC has their own set of tests if I am > > correct, so I thought this should be OK. > > > > Conditionally including tests into the main ClangdTests is not super easy > > because... CMake stuff. But I. can look into that. > Actually, nevermind, it looks pretty straightforward. Yeah we have to pay the cost of *some* cmake stuff either way, this looks like a bit less work. XPC... yeah, I wish there was less CMake stuff going on there. But in practice, the majority of maintenance in the two dirs has been disjoint sets of people, so it has its advantages to... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79862/new/ https://reviews.llvm.org/D79862 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
