[PATCH] D78969: [clang][OpenMP] Fix getNDSWDS for aarch64.

This revision was automatically updated to reflect the committed changes. Closed by commit rG4fa13a3dac1e: [clang][OpenMP] Fix getNDSWDS for aarch64. (authored by fpetrogalli). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78969/new/ https://reviews

[PATCH] D78118: [analyzer] StdLibraryFunctionsChecker: Add option to display loaded summaries

Szelethus added a comment. It would be nice to have a user-facing option that lists the functions this checker is **capable** of modeling in another patch :) Comment at: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td:299 + "DisplayLoadedSummaries", +

[PATCH] D78190: Add Bfloat IR type

stuij added a comment. In D78190#2018685 , @fpetrogalli wrote: > 1. Shouldn't we test also that the parser is happy with the following > expressions? Added. Thanks. > 2. Would it make sense to to split this patch into 2 separate patches? One > that de

[clang] 55b9b11 - Don't assert about missing profile info in createProfileWeightsForLoop

Author: Hans Wennborg Date: 2020-05-05T18:59:00+02:00 New Revision: 55b9b11fea3e18b6826c39842bc43877d9eb57fd URL: https://github.com/llvm/llvm-project/commit/55b9b11fea3e18b6826c39842bc43877d9eb57fd DIFF: https://github.com/llvm/llvm-project/commit/55b9b11fea3e18b6826c39842bc43877d9eb57fd.diff

[PATCH] D79354: [clang-format] [PR34574] Handle [[nodiscard]] attribute in class declaration

krasimir added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:2401 // The actual identifier can be a nested name specifier, and in macros // it is often token-pasted. while (FormatTok->isOneOf(tok::identifier, tok::coloncolon, tok::hashhash, --

[PATCH] D79354: [clang-format] [PR34574] Handle [[nodiscard]] attribute in class declaration

krasimir added a comment. I have an example where this goes wrong in ObjC (modulo indentation): struct Stuff stuff[] = {

[PATCH] D79417: Don't assert about missing profile info in createProfileWeightsForLoop

hans added a comment. In D79417#2020607 , @thakis wrote: > Could there be a test for this? Or is that difficult? I think it would be a bit of a pain, which is why I skipped it. It also wouldn't be a very interesting test, just "don't assert here", reall

[PATCH] D78660: [SemaObjC] Add a warning for dictionary literals with duplicate keys

rjmccall accepted this revision. rjmccall added a comment. Anyway, LGTM. Comment at: clang/lib/Sema/SemaExprObjC.cpp:948 +checkOneKey(IntegralKeys, Result.Val.getInt(), Loc); + } +} erik.pilkington wrote: > bendjones wrote: > > rjmccall wrote:

[PATCH] D79430: [analyzer] StdLibraryFunctionsChecker: Add LazyRanges to support type dependent Max

martong created this revision. martong added reviewers: Szelethus, NoQ, baloghadamsoftware, balazske, steakhal. Herald added subscribers: cfe-commits, ASDenysPetrov, Charusso, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, xazax.hun, whisperity. Herald added a projec

[PATCH] D79431: [analyzer] StdLibraryFunctionsChecker: Add better diagnostics

martong created this revision. martong added reviewers: Szelethus, NoQ, baloghadamsoftware, balazske, steakhal. Herald added subscribers: cfe-commits, ASDenysPetrov, Charusso, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, xazax.hun, whisperity. Herald added a projec

[PATCH] D79417: Don't assert about missing profile info in createProfileWeightsForLoop

thakis added a comment. Fair enough :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79417/new/ https://reviews.llvm.org/D79417 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

[PATCH] D78190: Add Bfloat IR type

stuij added a comment. So are we happy with the patch as it is? Anybody else wants to LGTM? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78190/new/ https://reviews.llvm.org/D78190 ___ cfe-commits mail

[PATCH] D78190: Add Bfloat IR type

stuij added a comment. In D78190#2020701 , @stuij wrote: > In D78190#2018685 , @fpetrogalli > wrote: > > > 3. Do you need those changes in the Hexagon and x86 backend? Could they be > > submitted separately, with

[PATCH] D79417: Don't assert about missing profile info in createProfileWeightsForLoop

This revision was automatically updated to reflect the committed changes. Closed by commit rG55b9b11fea3e: Don't assert about missing profile info in createProfileWeightsForLoop (authored by hans). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D79432: [analyzer] StdLibraryFunctionsChecker: Add summaries for libc

martong created this revision. martong added reviewers: Szelethus, NoQ, baloghadamsoftware, balazske, steakhal. Herald added subscribers: cfe-commits, ASDenysPetrov, Charusso, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, xazax.hun, whisperity. Herald added a projec

[PATCH] D79118: Implement _ExtInt ABI for all ABIs in Clang, enable type for ABIs

rjmccall added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:4938 +if (EIT->getNumBits() > 128) + return getNaturalAlignIndirect(Ty, /*ByVal=*/true); + erichkeane wrote: > rjmccall wrote: > > rjmccall wrote: > > > erichkeane wrote: > > >

[PATCH] D78827: Add support for #pragma clang fp reassociate(fast|off) -- floating point control of associative math transformations

rjmccall added a comment. The reason we call FP contraction "fast" instead of "on" when it's cross-statement is because "on" is supposed to be consistent with the C language rules, whereas "fast" is stronger. There's no analogous situation with reassociation; I don't think the C standard is li

[PATCH] D79433: [analyzer] StdLibraryFunctionsChecker: Add summaries for POSIX

martong created this revision. martong added reviewers: Szelethus, NoQ, baloghadamsoftware, balazske, steakhal. Herald added subscribers: cfe-commits, ASDenysPetrov, Charusso, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, xazax.hun, whisperity. Herald added a projec

[PATCH] D79434: [analyzer] Generalize bitwise AND rules for ranges

vsavchenko updated this revision to Diff 262158. vsavchenko added a comment. Add parent change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79434/new/ https://reviews.llvm.org/D79434 Files: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.c

[PATCH] D79434: [analyzer] Generalize bitwise AND rules for ranges

vsavchenko created this revision. vsavchenko added reviewers: NoQ, dcoughlin. vsavchenko added a project: clang. Herald added subscribers: cfe-commits, ASDenysPetrov, martong, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. vsavchenko up

[PATCH] D79395: [clang][codegen] Hoist parameter attribute setting in function prolog.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79395/new/ https://reviews.llvm.org/D79395 __

[PATCH] D79236: [docs] Regenerate DiagnosticsReference.rst

rsandifo-arm reclaimed this revision. rsandifo-arm added a comment. OK, thanks! Reclaiming and reopening the revision in that case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79236/new/ https://reviews.llvm.org/D79236 ___

[PATCH] D79336: [analyzer] Generalize bitwise OR rules for ranges

vsavchenko updated this revision to Diff 262163. vsavchenko added a comment. Fix few things here and there Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79336/new/ https://reviews.llvm.org/D79336 Files: clang/include/clang/StaticAnalyzer/Core/Pa

[PATCH] D79394: [clang][codegen] Refactor argument loading in function prolog. NFC.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Oh, yes, if `Fn->getArg(n)` is no longer an `O(n)` linked-list walk, then this seems like a great change. I see that that happened... slightly over three years ago. Hooray for legacies.

[PATCH] D79232: [analyzer] Refactor range inference for symbolic expressions

vsavchenko updated this revision to Diff 262170. vsavchenko added a comment. Add clarification on infeasible ranges in bitwise tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79232/new/ https://reviews.llvm.org/D79232 Files: clang/include/c

[clang] 8fc7a90 - Let normalize() for posix style convert backslash to slash unconditionally.

Author: Nico Weber Date: 2020-05-05T13:54:55-04:00 New Revision: 8fc7a907b93a8e9eef96e872f8f926db3ebfe9b6 URL: https://github.com/llvm/llvm-project/commit/8fc7a907b93a8e9eef96e872f8f926db3ebfe9b6 DIFF: https://github.com/llvm/llvm-project/commit/8fc7a907b93a8e9eef96e872f8f926db3ebfe9b6.diff LO

[PATCH] D79432: [analyzer] StdLibraryFunctionsChecker: Add summaries for libc

Szelethus added a comment. There a couple functional lines commented out, and we need more tests, so I take that the patch is a proof of concept for now? Because its pretty cool if so. :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79432/new/ h

[PATCH] D79336: [analyzer] Generalize bitwise OR rules for ranges

vsavchenko updated this revision to Diff 262171. vsavchenko added a comment. Fix clang-format issue Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79336/new/ https://reviews.llvm.org/D79336 Files: clang/include/clang/StaticAnalyzer/Core/PathSensi

[PATCH] D79434: [analyzer] Generalize bitwise AND rules for ranges

vsavchenko added a comment. Here is a little proof I've put together (using Z3): https://gist.github.com/SavchenkoValeriy/2355170159ce1febd27498c36ea22149 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79434/new/ https://reviews.llvm.org/D79434

[PATCH] D68049: Propeller: Clang options for basic block sections

tmsriram added a comment. @rsmith Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68049/new/ https://reviews.llvm.org/D68049 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[PATCH] D79431: [analyzer] StdLibraryFunctionsChecker: Add better diagnostics

Szelethus added a comment. Sure, this is an improvement because we display more information, but I'd argue that it isn't really a more readable warning message :) How about th argument to the call to - cannot be represented with a character - is a null pointer - ... , which violates the funct

[PATCH] D78827: Add support for #pragma clang fp reassociate(fast|off) -- floating point control of associative math transformations

scanon added a comment. > I don't think the C standard is likely to ever bless reassociative FP math > with an expression-local restriction. Steve, do you actually think that would > be a useful optimization mode? I think it's pretty unlikely that C would do this, as well. It is plausibly a us

[PATCH] D79265: Let normalize() for posix style convert backslash to slash unconditionally.

This revision was automatically updated to reflect the committed changes. Closed by commit rG8fc7a907b93a: Let normalize() for posix style convert backslash to slash unconditionally. (authored by thakis). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D79265?vs

[PATCH] D74668: [Clang][BPF] implement __builtin_btf_type_id() builtin function

anakryiko added a comment. In D74668#2020554 , @yonghong-song wrote: > In D74668#2019558 , @anakryiko wrote: > > > what's the use case for flag==0 (no relocation)? why using built-in at all > > in such case? Also

[PATCH] D77954: [CUDA][HIP] Fix host/device based overload resolution

tra added a comment. It appears that re-landed b46b1a916d44216f0c70de55ae2123eb9de69027 has created another compilation regression. I don't have a simple reproducer yet, so here's the error message for now: llvm_unstable/t

[PATCH] D79276: [FileCheck] Support comment directives

jdenny updated this revision to Diff 262185. jdenny added a comment. My last update accidentally included D79375 . This strips it back out. Sorry about that. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79276/new/ https://reviews.llvm.org/D79276 Fil

[PATCH] D79244: [Sema] Put existing warning under -Wexcess-initializers

rsandifo-arm added a comment. In D79244#2019027 , @efriedma wrote: > Should we stick ext_excess_initializers_in_char_array_initializer and > ext_initializer_string_for_char_array_too_long in the same warning group? Yeah, agree that would be better. Don

[PATCH] D78827: Add support for #pragma clang fp reassociate(fast|off) -- floating point control of associative math transformations

rjmccall added a comment. That makes sense, thanks. I think I'm comfortable using on/off for this, but it's definitely good to stop and consider, and you're absolutely right that it needs to be documented. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D72281: [Matrix] Add matrix type to Clang.

fhahn added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:3846 + New = new (*this, TypeAlignment) DependentSizedMatrixType( + *this, ElementTy, QualType(Canon, 0), RowExpr, ColumnExpr, AttrLoc); + } else { rjmccall wrote: > Some of this

[PATCH] D78374: [Analyzer][StreamChecker] Added evaluation of fread and fwrite.

Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:478 + + // FIXME: Check for stream in EOF state? + balazske wrote: > Szelethus wrote: > > Will that be the next patch? :D Eager to see it! > It may be too big change

[PATCH] D72281: [Matrix] Add matrix type to Clang.

fhahn updated this revision to Diff 262188. fhahn marked 9 inline comments as done. fhahn added a comment. Thanks for the extensive comments! They should be addressed: refactor dependent type construction, template argument deduction, adjust mangling. In D72281#2019417

[PATCH] D79244: [Sema] Put existing warning under -Wexcess-initializers

rsandifo-arm updated this revision to Diff 262189. rsandifo-arm added a comment. Put two other related warnings under the new option Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79244/new/ https://reviews.llvm.org/D79244 Files: clang/docs/Diagn

[clang] 873e279 - [SemaObjC] Add a warning for dictionary literals with duplicate keys

Author: Erik Pilkington Date: 2020-05-05T15:30:39-04:00 New Revision: 873e279095391df347b58ba4bab26dbfecab1262 URL: https://github.com/llvm/llvm-project/commit/873e279095391df347b58ba4bab26dbfecab1262 DIFF: https://github.com/llvm/llvm-project/commit/873e279095391df347b58ba4bab26dbfecab1262.dif

[clang] 86e50af - [AST] Print fixed enum type regardless of language mode

Author: Erik Pilkington Date: 2020-05-05T15:30:39-04:00 New Revision: 86e50af72d0a0f5cddd2cb487681709eda7934e8 URL: https://github.com/llvm/llvm-project/commit/86e50af72d0a0f5cddd2cb487681709eda7934e8 DIFF: https://github.com/llvm/llvm-project/commit/86e50af72d0a0f5cddd2cb487681709eda7934e8.dif

[clang] 276c8dd - [clang][codegen] Refactor argument loading in function prolog. NFC.

Author: Michael Liao Date: 2020-05-05T15:31:51-04:00 New Revision: 276c8dde0b58cfe29035448a27e16eff9fcf2a5a URL: https://github.com/llvm/llvm-project/commit/276c8dde0b58cfe29035448a27e16eff9fcf2a5a DIFF: https://github.com/llvm/llvm-project/commit/276c8dde0b58cfe29035448a27e16eff9fcf2a5a.diff

[clang] 9142c0b - [clang][codegen] Hoist parameter attribute setting in function prolog.

Author: Michael Liao Date: 2020-05-05T15:31:51-04:00 New Revision: 9142c0b46bfea13d9348ab3d1d706a10ad9e5c8e URL: https://github.com/llvm/llvm-project/commit/9142c0b46bfea13d9348ab3d1d706a10ad9e5c8e DIFF: https://github.com/llvm/llvm-project/commit/9142c0b46bfea13d9348ab3d1d706a10ad9e5c8e.diff

[PATCH] D79354: [clang-format] [PR34574] Handle [[nodiscard]] attribute in class declaration

MyDeveloperDay added a comment. In D79354#2020722 , @krasimir wrote: > I have an example where this goes wrong in ObjC (modulo indentation): > > I think we should try harder to detect the beginning of an attribute > specifier. I think there may be a helpe

[PATCH] D79244: [Sema] Put existing warning under -Wexcess-initializers

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79244/new/ https://reviews.llvm.org/D79244 ___

[PATCH] D79232: [analyzer] Refactor range inference for symbolic expressions

vsavchenko marked an inline comment as done. vsavchenko added inline comments. Comment at: clang/test/Analysis/constant-folding.c:127-128 + if (a > 10) { +clang_analyzer_eval((a & 1) <= 1); // expected-warning{{FALSE}} +clang_analyzer_eval((a & 1) > 1); // expected-warn

[PATCH] D79334: [clang-tidy]: Add cert-str34-c alias for bugprone-signed-char-misuse.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from some small nits with the documentation. Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone-signed-char-misuse.rst:117 + + When non-

[PATCH] D79395: [clang][codegen] Hoist parameter attribute setting in function prolog.

This revision was automatically updated to reflect the committed changes. Closed by commit rG9142c0b46bfe: [clang][codegen] Hoist parameter attribute setting in function prolog. (authored by hliao). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79395

[PATCH] D78660: [SemaObjC] Add a warning for dictionary literals with duplicate keys

This revision was automatically updated to reflect the committed changes. Closed by commit rG873e27909539: [SemaObjC] Add a warning for dictionary literals with duplicate keys (authored by erik.pilkington). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D79354: [clang-format] [PR34574] Handle [[nodiscard]] attribute in class declaration

krasimir added a comment. I'm not familiar with ObjC, but hope this helps: % cat ~/example.mm # left as-is by clang-format without D79354 (int)f : (int)arg { struct A as[] = {{a11, a12}, // {a21, a22}, // {nil, 0}}; retur

[PATCH] D79232: [analyzer] Refactor range inference for symbolic expressions

NoQ added inline comments. Comment at: clang/test/Analysis/constant-folding.c:127-128 + if (a > 10) { +clang_analyzer_eval((a & 1) <= 1); // expected-warning{{FALSE}} +clang_analyzer_eval((a & 1) > 1); // expected-warning{{FALSE}} + } vsavchenko wrote:

[PATCH] D79394: [clang][codegen] Refactor argument loading in function prolog. NFC.

This revision was automatically updated to reflect the committed changes. Closed by commit rG276c8dde0b58: [clang][codegen] Refactor argument loading in function prolog. NFC. (authored by hliao). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79394/ne

[PATCH] D79118: Implement _ExtInt ABI for all ABIs in Clang, enable type for ABIs

erichkeane updated this revision to Diff 262190. erichkeane added a comment. Revert PPC64 changes back to direct/indirect. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79118/new/ https://reviews.llvm.org/D79118 Files: clang/lib/Basic/Targets/AArch64.h clang/lib/Basic/Targets/AMDGP

[PATCH] D79118: Implement _ExtInt ABI for all ABIs in Clang, enable type for ABIs

erichkeane marked an inline comment as done. erichkeane added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:4938 +if (EIT->getNumBits() > 128) + return getNaturalAlignIndirect(Ty, /*ByVal=*/true); + rjmccall wrote: > erichkeane wrote: > >

[PATCH] D79419: [clang/clang-tools-extra] Fix BZ44437 - add_new_check.py does not work with Python 3

dsanders accepted this revision. dsanders added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79419/new/ https://reviews.llvm.org/D79419 ___

[PATCH] D79121: Add nomerge function attribute to clang

zequanwu marked an inline comment as done. zequanwu added inline comments. Comment at: clang/lib/Sema/SemaStmtAttr.cpp:178 +return true; + return llvm::any_of(S->children(), hasCallExpr); +} rsmith wrote: > This will recurse into too much (eg, the bodies of

[PATCH] D79440: Fix ForRangeCopyCheck not triggering on iterators returning elements by value in C++17.

flx created this revision. flx added a reviewer: gribozavr2. Herald added a project: clang. Herald added a subscriber: cfe-commits. The AST is different in C++17 in that there is no MaterializeTemporaryExpr for in the AST for a loop variable that is initialized from an iterator that returns its

[PATCH] D76066: [ARM][MachineOutliner] Add Machine Outliner support for ARM

yroux added a comment. In D76066#2014697 , @samparker wrote: > Thanks for adding the MVE changes, but I also still don't see any DSP tests, > i.e QADD, SADD16. hmm... I was wrong w/r to DSP instructions Q and GE flags handling, I don't get what I did i

[PATCH] D79357: [SveEmitter] Add builtins for svdup and svindex

sdesmalen marked 2 inline comments as done. sdesmalen added inline comments. Comment at: clang/include/clang/Basic/arm_sve.td:1050 def SVCOMPACT: SInst<"svcompact[_{d}]", "dPd", "ilUiUlfd", MergeNone, "aarch64_sve_compact">; -// SVDUP_LANE(to land in D78750)

[PATCH] D76066: [ARM][MachineOutliner] Add Machine Outliner support for ARM

yroux updated this revision to Diff 262205. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76066/new/ https://reviews.llvm.org/D76066 Files: clang/lib/Driver/ToolChains/Clang.cpp llvm/lib/Target/ARM/ARMBaseInstrInfo.cpp llvm/lib/Target/ARM/ARMB

[PATCH] D79357: [SveEmitter] Add builtins for svdup and svindex

efriedma added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:8047 +Value *PFalse = Constant::getNullValue(PTrue->getType()); +Value *Sel = Builder.CreateSelect(CmpNE, PTrue, PFalse); +return EmitSVEPredicateCast(Sel, cast(Ty)); sdesmale

[PATCH] D79445: [MSan] Pass MSan command line options under new pass manager

aeubanks created this revision. aeubanks added reviewers: nemanjai, vitalybuka, leonardchan. Herald added a project: clang. Herald added a subscriber: cfe-commits. Properly forward TrackOrigins and Recover user options to the MSan pass under the new pass manager. This makes the number of check-ms

[PATCH] D76066: [ARM][MachineOutliner] Add Machine Outliner support for ARM

efriedma added inline comments. Comment at: llvm/lib/Target/ARM/ARMBaseInstrInfo.cpp:5813 + // Don't touch the link register + if (MI.readsRegister(ARM::LR, TRI) || MI.modifiesRegister(ARM::LR, TRI)) +return outliner::InstrType::Illegal; yroux wrote: > efri

[PATCH] D78827: Add support for #pragma clang fp reassociate(on|off) -- floating point control of associative math transformations

mibintc updated this revision to Diff 262217. mibintc retitled this revision from "Add support for #pragma clang fp reassociate(fast|off) -- floating point control of associative math transformations" to "Add support for #pragma clang fp reassociate(on|off) -- floating point control of associati

[PATCH] D77954: [CUDA][HIP] Fix host/device based overload resolution

yaxunl added a comment. In D77954#2021026 , @tra wrote: > It appears that re-landed b46b1a916d44216f0c70de55ae2123eb9de69027 > has > created another compilation regression. I don't hav

[clang] bf6a26b - Revert D77954 -- it breaks Eigen & Tensorflow.

Author: Artem Belevich Date: 2020-05-05T14:07:31-07:00 New Revision: bf6a26b066382e0f41bf023c781d84061c542307 URL: https://github.com/llvm/llvm-project/commit/bf6a26b066382e0f41bf023c781d84061c542307 DIFF: https://github.com/llvm/llvm-project/commit/bf6a26b066382e0f41bf023c781d84061c542307.diff

[clang-tools-extra] 24b4965 - [clang/clang-tools-extra] Fix BZ44437 - add_new_check.py does not work with Python 3

Author: Konrad Kleine Date: 2020-05-05T17:22:50-04:00 New Revision: 24b4965ce65b14ead595dcc68add22ba37533207 URL: https://github.com/llvm/llvm-project/commit/24b4965ce65b14ead595dcc68add22ba37533207 DIFF: https://github.com/llvm/llvm-project/commit/24b4965ce65b14ead595dcc68add22ba37533207.diff

[PATCH] D79400: [CMAKE] Fix build failure when source directory is read only

scott.linder added a comment. Can you provide more context in the diff? Looking at the current `master` locally it seems like this patch changes the behavior of the `llvm_vcsrevision_h` target when `logs/HEAD` isn't found, such that it only depends on the generation script. I.e. if you configur

[PATCH] D79118: Implement _ExtInt ABI for all ABIs in Clang, enable type for ABIs

rjmccall added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:719 + !getContext().getTargetInfo().hasInt128Type())) + return getNaturalAlignIndirect(Ty); + erichkeane wrote: > rjmccall wrote: > > It's very weird for 64 and 128 to be sh

[PATCH] D77954: [CUDA][HIP] Fix host/device based overload resolution

tra added a comment. FYI, I've just reverted it in bf6a26b066382e0f41bf023c781d84061c542307 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77954/new/ https://reviews.llvm.org/D77

[PATCH] D79419: [clang/clang-tools-extra] Fix BZ44437 - add_new_check.py does not work with Python 3

kwk updated this revision to Diff 262226. kwk added a comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79419/new/ https://reviews.llvm.org/D79419 Files: clang-tools-extra/clang-tidy/add_new_check.py Index: clang-tools-extra/clang-tidy/add_

[PATCH] D79445: [MSan] Pass MSan command line options under new pass manager

leonardchan accepted this revision. leonardchan added a comment. This revision is now accepted and ready to land. In `addSanitizersAtO0`, could you make something similar to the `ASanPass` lambda for the MSan passes and also apply it when adding kernel MSan? Repository: rG LLVM Github Monorep

[PATCH] D79419: [clang/clang-tools-extra] Fix BZ44437 - add_new_check.py does not work with Python 3

This revision was automatically updated to reflect the committed changes. Closed by commit rG24b4965ce65b: [clang/clang-tools-extra] Fix BZ44437 - add_new_check.py does not work with… (authored by kwk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7

[PATCH] D77954: [CUDA][HIP] Fix host/device based overload resolution

tra added a comment. In D77954#2021299 , @yaxunl wrote: > I will put a workaround: In device compilation, in implicit `__device__ > __host__` callers, I will keep the old behavior, that is, implicit > `__device__ __host__` candidate has equal preference

[PATCH] D79232: [analyzer] Refactor range inference for symbolic expressions

vsavchenko marked an inline comment as done. vsavchenko added inline comments. Comment at: clang/test/Analysis/constant-folding.c:127-128 + if (a > 10) { +clang_analyzer_eval((a & 1) <= 1); // expected-warning{{FALSE}} +clang_analyzer_eval((a & 1) > 1); // expected-warn

[PATCH] D79449: [CUDA] Make NVVM builtins available with CUDA-11 & PTX6.5

tra updated this revision to Diff 262236. tra added a comment. Test that the builtins work all the way to sm_80/ptx65 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79449/new/ https://reviews.llvm.org/D79449 Files: clang/include/clang/Basic/Built

[PATCH] D79354: [clang-format] [PR34574] Handle [[nodiscard]] attribute in class declaration

MyDeveloperDay updated this revision to Diff 262231. MyDeveloperDay added a comment. Reduce false formatting CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79354/new/ https://reviews.llvm.org/D79354 Files: clang/lib/Format/UnwrappedLineParser.cpp clang/unittests/Format/FormatTest.cp

[PATCH] D79449: [CUDA] Make NVVM builtins available with CUDA-11 & PTX6.5

tra created this revision. tra added a reviewer: timshen. Herald added subscribers: sanjoy.google, bixia, yaxunl, jholewinski. Herald added a project: clang. tra updated this revision to Diff 262236. tra added a comment. Test that the builtins work all the way to sm_80/ptx65 Repository: rG LLV

[PATCH] D79448: [X86] Allow Yz inline assembly constraint to choose ymm0 or zmm0 when avx/avx512 are enabled and type is 256 or 512 bits

craig.topper created this revision. craig.topper added reviewers: RKSimon, spatel, rnk, echristo. Herald added a subscriber: hiraditya. Herald added a project: LLVM. gcc supports selecting ymm0/zmm0 for the Yz constraint when used with 256 or 512 bit vector types. Fixes PR45806 https://reviews

[clang] 67175d8 - [cmake] Allow std::filesystem tests in CrossWinToARMLinux.cmake

Author: Sergej Jaskiewicz Date: 2020-05-06T01:31:32+03:00 New Revision: 67175d8dc53b580bad439f85fda12623fa6993fa URL: https://github.com/llvm/llvm-project/commit/67175d8dc53b580bad439f85fda12623fa6993fa DIFF: https://github.com/llvm/llvm-project/commit/67175d8dc53b580bad439f85fda12623fa6993fa.d

[PATCH] D79449: [CUDA] Make NVVM builtins available with CUDA-11 & PTX6.5

tra updated this revision to Diff 262237. tra added a comment. Actually added sm_80 predicate. It's not used on any builtins yet, but it makes sense to add it right now along with ptx65. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79449/new/ http

[PATCH] D78607: [local-bounds] Ignore volatile operations

vitalybuka added a comment. done Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78607/new/ https://reviews.llvm.org/D78607 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D78607: [local-bounds] Ignore volatile operations

vitalybuka updated this revision to Diff 262239. vitalybuka added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. doc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78607/new/ https://reviews.llvm.org/D78607 Files:

[PATCH] D78607: [local-bounds] Ignore volatile operations

vitalybuka updated this revision to Diff 262240. vitalybuka added a comment. updated doc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78607/new/ https://reviews.llvm.org/D78607 Files: clang/docs/UndefinedBehaviorSanitizer.rst llvm/lib/Transfo

[clang] 844096b - [CUDA] Make NVVM builtins available with CUDA-11/PTX6.5

Author: Artem Belevich Date: 2020-05-05T15:43:32-07:00 New Revision: 844096b996a0b17d3f380af323614a5fe31b8a68 URL: https://github.com/llvm/llvm-project/commit/844096b996a0b17d3f380af323614a5fe31b8a68 DIFF: https://github.com/llvm/llvm-project/commit/844096b996a0b17d3f380af323614a5fe31b8a68.diff

[clang] b0eb7cd - Reapply "NFC: utils/perf-training: Python 3 compatibility for lit.cfg"

Author: Azharuddin Mohammed Date: 2020-05-05T15:56:23-07:00 New Revision: b0eb7cd2be849f0551e9b05a0cbf2d59d8c9f50d URL: https://github.com/llvm/llvm-project/commit/b0eb7cd2be849f0551e9b05a0cbf2d59d8c9f50d DIFF: https://github.com/llvm/llvm-project/commit/b0eb7cd2be849f0551e9b05a0cbf2d59d8c9f50d

[PATCH] D79035: [clang][AIX] Implement ABIInfo and TargetCodeGenInfo for AIX

jasonliu updated this revision to Diff 262250. jasonliu marked 12 inline comments as done. jasonliu added a comment. Rebase and address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79035/new/ https://reviews.llvm.org/D79035 Files: clang/lib/CodeGen/TargetInfo.cpp clang/l

[PATCH] D78573: [Clang][Sema] Capturing section type conflicts between #pragma clang section and section attributes

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Comment at: clang/include/clang/AST/ASTContext.h:3008 +/// Insertion operator for diagnostics. +inline const DiagnosticBuilder & +operator<<(const DiagnosticBuilder &DB, -

[PATCH] D79445: [MSan] Pass MSan command line options under new pass manager

aeubanks updated this revision to Diff 262248. aeubanks added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79445/new/ https://reviews.llvm.org/D79445 Files: clang/lib/CodeGen/BackendUtil.cpp Index: clang/lib

[PATCH] D79445: [MSan] Pass MSan command line options under new pass manager

aeubanks added a comment. In D79445#2021311 , @leonardchan wrote: > In `addSanitizersAtO0`, could you make something similar to the `ASanPass` > lambda for the MSan passes and also apply it when adding kernel MSan? It ends up calling an extra `MPM.addPa

[PATCH] D79035: [clang][AIX] Implement ABIInfo and TargetCodeGenInfo for AIX

jasonliu updated this revision to Diff 262252. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79035/new/ https://reviews.llvm.org/D79035 Files: clang/lib/CodeGen/TargetInfo.cpp clang/lib/Driver/ToolChains/Clang.cpp clang/test/CodeGen/aix-complex.c clang/test/CodeGen/aix-return.c

[PATCH] D79035: [clang][AIX] Implement ABIInfo and TargetCodeGenInfo for AIX

jasonliu added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:4368 + + return emitVoidPtrVAArg(CGF, VAListAddr, Ty, /*Indirect*/ false, TypeInfo, + SlotSize, /*AllowHigher*/ true); ZarkoCA wrote: > Is there a reason why In

[PATCH] D79449: [CUDA] Make NVVM builtins available with CUDA-11 & PTX6.5

This revision was automatically updated to reflect the committed changes. Closed by commit rG844096b996a0: [CUDA] Make NVVM builtins available with CUDA-11/PTX6.5 (authored by tra). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79449/new/ https://re

[PATCH] D74238: [clang] Improve diagnostic note for implicit conversion sequences that would work if more than one implicit user-defined conversion were allowed.

logan-5 abandoned this revision. logan-5 added a comment. @rsmith the intention is to only speculatively search one level deep (e.g. search for chains like A->B, B->C, but no deeper), which should cover most of the cases that are surprising to users. However, the implementation of this patch ha

[PATCH] D78607: [local-bounds] Ignore volatile operations

rsmith accepted this revision. rsmith added inline comments. This revision is now accepted and ready to land. Comment at: clang/docs/UndefinedBehaviorSanitizer.rst:175-177 - ``-fsanitize=undefined``: All of the checks listed above other than ``float-divide-by-zero``, ``

[PATCH] D79456: [clangd] Complete filenames after < / ".

sammccall created this revision. sammccall added a reviewer: adamcz. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Extract prefix filters to CodeComplete so it can be easily tested. Fixes https://github.com/c

[PATCH] D73307: Unique Names for Functions with Internal Linkage

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Sorry for the delay. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73307/new/ https://reviews.llvm.org/D73307 ___ cfe-commits mailing li

<    1   2   3   >