aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land.
LGTM aside from some small nits with the documentation. ================ Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone-signed-char-misuse.rst:117 + + When non-zero, the check will warn on ``signed char``/``unsigned char`` comparison + otherwise this use case is ignored. By default, this option is set to ``1``. ---------------- non-zero -> nonzero comparison -> comparisons, (with the plural and comma) ================ Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone-signed-char-misuse.rst:118 + When non-zero, the check will warn on ``signed char``/``unsigned char`` comparison + otherwise this use case is ignored. By default, this option is set to ``1``. ---------------- this use case is -> these comparisons are ================ Comment at: clang-tools-extra/docs/clang-tidy/checks/cert-str34-c.rst:6 +cert-str34-c +============== + ---------------- The underlining here looks too long. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79334/new/ https://reviews.llvm.org/D79334 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
