[PATCH] D77721: [ASTImporter] Add support for importing fixed point literals

vabridgers updated this revision to Diff 256133. vabridgers added a comment. Remove extraneous code :/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77721/new/ https://reviews.llvm.org/D77721 Files: clang/include/clang/AST/Expr.h clang/include

[PATCH] D77697: libc++: adjust modulemap for non-modular C

dexonsmith added a subscriber: Bigcheese. dexonsmith added a comment. In D77697#1969998 , @compnerd wrote: > @dexonsmith - yeah, sadly I dont think that there is a good way to audit that > - any change to the public headers can cause issues. Furthermore,

[PATCH] D77721: [ASTImporter] Add support for importing fixed point literals

vabridgers updated this revision to Diff 256131. vabridgers added a comment. Addressed comments from @balazske. Thanks for the tips and useful starting point from @martong Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77721/new/ https://reviews.llv

[PATCH] D77731: [OPENMP]Fix capturing of global variables in OpenMP regions.

ABataev marked an inline comment as done. ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:2117 +if (VD && !VD->hasLocalStorage() && DVarPrivate.CKind == OMPC_unknown && +(DSAStack->getDefaultDSA() != DSA_none || DVarTop.CKind == OMPC_shared))

[PATCH] D77697: libc++: adjust modulemap for non-modular C

Bigcheese added a comment. In D77697#1970586 , @dexonsmith wrote: > In D77697#1969998 , @compnerd wrote: > > > @dexonsmith - yeah, sadly I dont think that there is a good way to audit > > that - any change to the p

[PATCH] D77632: [TLI] Per-function fveclib for math library used for vectorization

wenlei added a comment. Thanks for taking a look and the suggestions, @tejohnson. Yeah, you're right about the potential conflict of attributes. Initially I thought even though we now allow this to be per-function, but since it comes from per-module switch, module level consistency can still be

[PATCH] D70366: Add new 'flatten' LLVM attribute to fix clang's 'flatten' function attribute

jdoerfert added a comment. In D70366#1970526 , @dexonsmith wrote: > In D70366#1970299 , @LevitatingLion > wrote: > > > Maybe we can add an additional string attribute when adding the noinline > > attribute to func

[PATCH] D77731: [OPENMP]Fix capturing of global variables in OpenMP regions.

jdoerfert accepted this revision. jdoerfert added a subscriber: atmnpatel. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang/lib/Sema/SemaOpenMP.cpp:2117 +if (VD && !VD->hasLocalStorage() && DVarPrivate.CKind == OMPC_unknown

[PATCH] D77374: Fix -fsanitize=array-bounds with comma operator

vitalybuka added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77374/new/ https://reviews.llvm.org/D77374 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D77766: [clangd] Set up machinery for gtests of ClangdLSPServer.

sammccall added a comment. It seems fairly likely that this is a big complicated thing we end up using for 1 or 2 tests that are too hard to test with lit but can't be tested at a lower level than ClangdLSPServer. Suggestions on how to make it more lightweight would be welcome! Repository: r

[PATCH] D77373: Add more -fsanitize=array-bounds tests

vitalybuka added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77373/new/ https://reviews.llvm.org/D77373 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D77766: [clangd] Set up machinery for gtests of ClangdLSPServer.

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov, mgorny. Herald added a project: clang. sammccall added a comment. It seems fairly likely that this is a big complicated thing we end

[PATCH] D77697: libc++: adjust modulemap for non-modular C

compnerd added a comment. I think that a `clang-pcm` like tool would be **incredible**. Working with modules is somewhat frustrating because there is no good supported way to see what the module structure that clang actually sees. But that goes well beyond an attempt to repair the NetBSD buil

[PATCH] D77571: [clang-tidy] Add check to find calls to NSInvocation methods under ARC that don't have proper object argument lifetimes.

stephanemoore accepted this revision. stephanemoore marked an inline comment as done. stephanemoore added inline comments. Comment at: clang-tools-extra/clang-tidy/objc/NSInvocationArgumentLifetimeCheck.cpp:49 + QT->getScalarTypeKind() == Type::STK_BlockPointer) && +

[PATCH] D77697: libc++: adjust modulemap for non-modular C

rsmith added a comment. In D77697#1968998 , @joerg wrote: > This fixes the module build of clang for me. Are you building with or without `-fmodules-local-submodule-visibility` (`cmake -DLLVM_ENABLE_LOCAL_SUBMODULE_VISIBILITY=ON`)? If you don't use that

[PATCH] D77683: [Docs] Make code review policy clearer about requested pre-commit reviews

mehdi_amini added a comment. I am still not sure what "if someone has asked for extra review of a specific area" refers to? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77683/new/ https://reviews.llvm.org/D77683 ___

[PATCH] D68049: Propeller: Clang options for basic block sections

tmsriram added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68049/new/ https://reviews.llvm.org/D68049 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D77244: [part 1] sancov/inline-bool-flag instrumentation.

vitalybuka added a comment. In D77244#1956930 , @pratyai wrote: > It looks like I broke the tests after the `i8 `-> `i1` switch. > > I think it's because of an existing bug. From > https://llvm.org/docs/LangRef.html > > > i1:8:8 - i1 is 8-bit (byte) align

[PATCH] D77244: [part 1] sancov/inline-bool-flag instrumentation.

vitalybuka added a comment. In D77244#1956805 , @pratyai wrote: > Undid the `arc lint` on autocomplete.c. > `arc lint` does not seem to have an option --style, but it's just one line > diff anyway. yep. it had --style LLVM by mistake. I guess it's fixe

[PATCH] D77731: [OPENMP]Fix capturing of global variables in OpenMP regions.

ABataev marked an inline comment as done. ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:2117 +if (VD && !VD->hasLocalStorage() && DVarPrivate.CKind == OMPC_unknown && +(DSAStack->getDefaultDSA() != DSA_none || DVarTop.CKind == OMPC_shared))

[PATCH] D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang

atmnpatel updated this revision to Diff 256152. atmnpatel added a comment. Addresses D77731 and fixes the comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75591/new/ https://reviews.llvm.org/D75591 Files:

[PATCH] D77244: [part 1] sancov/inline-bool-flag instrumentation.

vitalybuka added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/SanitizerCoverage.cpp:922 +auto Store = IRB.CreateStore(ConstantInt::getTrue(Int1Ty), FlagPtr); +Store->setAtomic(AtomicOrdering::NotAtomic); +Store->setAlignment(llvm::MaybeAlign(Functi

[PATCH] D76768: [analyzer] Added support of scan-build and exploded-graph-rewriter regression tests for Windows

thakis added a comment. Sorry for the slow reply. I repro'd this locally now, and here I see this error: ''' command stderr: === 'perl' is not recognized as an internal or external command, operable program or batch file. ''' perl wasn't required to run tests on Win for a long time

[PATCH] D77637: [part 2] sancov/inline-bool-flag clang flags.

vitalybuka accepted this revision. vitalybuka added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/Driver/fsanitize-coverage.c:114 +// RUN: %clang -target x86_64-linux-gnu -fsanitize-coverage=inline-8bit-counters,pc-table %s -### 2>&1 |

[PATCH] D77628: [Driver][X86] Add -mpad-max-prefix-size

LuoYuanke added a comment. > This looks like it requires more thorough discussions, doesn't it? We will > also need discussions with the binutils side. We requested a GCC compiler > driver option long ago but we do not reach a consensus > (https://gcc.gnu.org/legacy-ml/gcc/2020-01/msg00358.html

[PATCH] D77205: [X86] Add TSXLDTRK instructions.

tianqing added a comment. Can I just check it in after the rebase? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77205/new/ https://reviews.llvm.org/D77205 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[PATCH] D73307: Unique Names for Functions with Internal Linkage

tmsriram added a comment. We just noticed an issue with alias attribute and this option. Here is the code that exposes the problem: alias_global.c static int foo; extern int bar __attribute__((alias("foo"))) $ clang -c alias_global.c -funique-internal-linkage-names alias_global.c:4:31: error:

[PATCH] D77374: Fix -fsanitize=array-bounds with comma operator

rsmith added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:882-887 + while (const BinaryOperator *BO = dyn_cast(E)) { +if (!BO->isCommaOp()) + break; +E = BO->getRHS(); +E = E->IgnoreParens(); + } If we're going to further extend wh

[PATCH] D77728: [Driver][X86] Add an alias for -mpad-max-prefix-size

MaskRay added a comment. In D77728#1970912 , @skan wrote: > In D77728#1969788 , @MaskRay wrote: > > > > Make -malign-branch-prefix-size an alias for -mpad-max-prefix-size (For > > > GCC compatibility) > > > > I can

[PATCH] D77728: [Driver][X86] Add an alias for -mpad-max-prefix-size

skan added a comment. In D77728#1969788 , @MaskRay wrote: > > Make -malign-branch-prefix-size an alias for -mpad-max-prefix-size (For GCC > > compatibility) > > I cannot find a discussion on -mpad-max-prefix-size. Is it a planned GNU as > option or GCC d

[PATCH] D77628: [Driver][X86] Add -mpad-max-prefix-size

skan added a comment. In D77628#1969856 , @MaskRay wrote: > This looks like it requires more thorough discussions, doesn't it? We will > also need discussions with the binutils side. We requested a GCC compiler > driver option long ago but we do not re

[PATCH] D77341: [DomTree] Replace ChildrenGetter with GraphTraits over GraphDiff.

kuhar accepted this revision. kuhar added a comment. This revision is now accepted and ready to land. Looks good to me overall. I don't want to block it over the cosmetic issues like allocating the empty GD object. Comment at: llvm/include/llvm/Support/GenericDomTreeConstructi

[PATCH] D77628: [Driver][X86] Add -mpad-max-prefix-size

skan updated this revision to Diff 256164. skan added a comment. Remove the limit "max padding prefix size <=5" since MC doesn't have this limit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77628/new/ https://reviews.llvm.org/D77628 Files: cla

[PATCH] D77728: [Driver][X86] Add an alias for -mpad-max-prefix-size

skan added a comment. In D77728#1970922 , @MaskRay wrote: > In D77728#1970912 , @skan wrote: > > > In D77728#1969788 , @MaskRay wrote: > > > > > > Make -malign-branch-prefix-

[PATCH] D77244: [part 1] sancov/inline-bool-flag instrumentation.

pratyai updated this revision to Diff 256167. pratyai marked 2 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77244/new/ https://reviews.llvm.org/D77244 Files: llvm/include/llvm/Transforms/Instrumentation.h llvm/lib/Trans

[PATCH] D77244: [part 1] sancov/inline-bool-flag instrumentation.

pratyai added a comment. In D77244#1970820 , @vitalybuka wrote: > In D77244#1956930 , @pratyai wrote: > > > It looks like I broke the tests after the `i8 `-> `i1` switch. > > > > I think it's because of an existing

[PATCH] D77628: [Driver][X86] Add -mpad-max-prefix-size

MaskRay accepted this revision. MaskRay added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Driver/Options.td:2190 HelpText<"Specify the boundary's size to align branches">; -def malign_branch_prefix_size_EQ : Joined<["-"],

[PATCH] D77205: [X86] Add TSXLDTRK instructions.

tianqing updated this revision to Diff 256170. tianqing added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77205/new/ https://reviews.llvm.org/D77205 Files: clang/docs/ClangCommandLineReference.rst clang/include/clang/Basic/

[PATCH] D77772: [Clang] Expose RequiresNullTerminator in FileManager.

Bigcheese created this revision. Bigcheese added reviewers: dexonsmith, vsapsai, rdhindsa. Bigcheese added a project: clang. Herald added a subscriber: hiraditya. This is needed to fix the reason 0a2be46cfdb698fe (Modules: Invalidate out-of-date PCMs as they're discovered) and 5b44a4b07fc1d ([modu

[PATCH] D77774: [OpenMP] Allow to go first in C++-mode in target regions

jdoerfert created this revision. jdoerfert added a reviewer: hfinkel. Herald added subscribers: guansong, bollu, yaxunl. Herald added a project: clang. If we are in C++ mode and include (not ) first, we still need to make sure is read first. The problem otherwise is that we haven't seen the decl

[PATCH] D77244: [part 1] sancov/inline-bool-flag instrumentation.

pratyai updated this revision to Diff 256175. pratyai added a comment. oops; forgot that dropping the `alignment == 1 ? 1 : alignment / 8` bit off this diff wouldn't work with build. (running a --check-llvm, but it's a bit slow; if things break I'll update again) Repository: rG LLVM Github M

[PATCH] D77633: [Parser] Improve diagnostic and error recovery when C++ keywords are used as identifiers.

jdoerfert added a comment. This is cool, thx! One case I stumbled upon recently is: `void explicit() {}` Which results in these rather confusing messages: /tmp/test.cpp:1:14: warning: explicit(bool) is a C++20 extension [-Wc++20-extensions] void explicit() { } ^ /tmp/test.

[PATCH] D77205: [X86] Add TSXLDTRK instructions.

craig.topper accepted this revision. craig.topper added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77205/new/ https://reviews.llvm.org/D77205 ___ cfe-commits mailing list cfe-commits

[PATCH] D77637: [part 2] sancov/inline-bool-flag clang flags.

pratyai updated this revision to Diff 256178. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77637/new/ https://reviews.llvm.org/D77637 Files: clang/docs/SanitizerCoverage.rst clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Dri

[PATCH] D77637: [part 2] sancov/inline-bool-flag clang flags.

pratyai marked 2 inline comments as done. pratyai added inline comments. Comment at: clang/test/Driver/fsanitize-coverage.c:114 +// RUN: %clang -target x86_64-linux-gnu -fsanitize-coverage=inline-8bit-counters,pc-table %s -### 2>&1 | FileCheck %s --check-prefix=CHECK_PC_TABLE_F

[PATCH] D76932: [AIX] emit .extern and .weak directive linkage

hubert.reinterpretcast added inline comments. Comment at: llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp:403 switch (Linkage) { case GlobalValue::CommonLinkage: case GlobalValue::LinkOnceAnyLinkage: I have my doubts that `CommonLinkage` should produce `.weak

[PATCH] D77776: [Driver] Drop support for FreeBSD < 10

jbeich created this revision. jbeich added reviewers: clang, dim. Herald added subscribers: cfe-commits, fedor.sergeev, krytarowski, arichardson, emaste. Herald added a project: clang. Downstream may naively translate between DSL and LLVM target triple. If OS version is lost in the process then

[PATCH] D77717: [clang][index] index the missing LabelDecl in libindex.

kadircet added inline comments. Comment at: clang/lib/Index/IndexBody.cpp:152 +if (auto *LabelDecl = Label->getDecl()) + IndexCtx.handleReference(LabelDecl, Label->getIdentLoc(), Parent, + ParentDC, argh, looks like Recursiv

[PATCH] D77244: [part 1] sancov/inline-bool-flag instrumentation.

pratyai updated this revision to Diff 256182. pratyai added a comment. Adjusted the diff in the change (`align 1` is dropped from the llvm instruction of the CHECK). The reason is that it does not get set until setAlignment is explicitly called (ref: https://llvm.org/doxygen/Instructions_8cpp_s

[PATCH] D70366: Add new 'flatten' LLVM attribute to fix clang's 'flatten' function attribute

dexonsmith added a comment. In D70366#1970758 , @jdoerfert wrote: > In D70366#1970526 , @dexonsmith > wrote: > > > In D70366#1970299 , > > @LevitatingLion wrote: > > > > >

[clang] a3dc949 - [X86] Add TSXLDTRK instructions.

Author: WangTianQing Date: 2020-04-09T13:17:29+08:00 New Revision: a3dc9490004ce1601fb1bc67cf218b86a6fdf652 URL: https://github.com/llvm/llvm-project/commit/a3dc9490004ce1601fb1bc67cf218b86a6fdf652 DIFF: https://github.com/llvm/llvm-project/commit/a3dc9490004ce1601fb1bc67cf218b86a6fdf652.diff

[PATCH] D77205: [X86] Add TSXLDTRK instructions.

This revision was automatically updated to reflect the committed changes. Closed by commit rGa3dc9490004c: [X86] Add TSXLDTRK instructions. (authored by tianqing, committed by xiangzhangllvm). Changed prior to commit: https://reviews.llvm.org/D77205?vs=256170&id=256189#toc Repository: rG LLV

[PATCH] D77244: [part 1] sancov/inline-bool-flag instrumentation.

This revision was automatically updated to reflect the committed changes. Closed by commit rGe8d1c6529b95: [SanitizerCoverage] sancov/inline-bool-flag instrumentation. (authored by pratyai, committed by vitalybuka). Changed prior to commit: https://reviews.llvm.org/D77244?vs=256182&id=256190#to

[PATCH] D77777: [nvptx] Add `nvvm.texsurf.handle` internalizer.

hliao created this revision. hliao added a reviewer: tra. Herald added subscribers: cfe-commits, hiraditya, mgorny, jholewinski. Herald added a project: clang. - Replace them with the internal version, i.e. `nvvm.texsurf.handle.internal` just before the instruction selector. - Teach clang codegen

[PATCH] D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang

lebedev.ri resigned from this revision. lebedev.ri added a comment. This revision is now accepted and ready to land. No further comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75591/new/ https://reviews.llvm.org/D75591 __

[PATCH] D77229: [Analyzer][WIP] Avoid handling of LazyCompundVals in IteratorModeling

baloghadamsoftware added a comment. In D77229#1969524 , @NoQ wrote: > In D77229#1969455 , > @baloghadamsoftware wrote: > > > The problem is that the `CFGElement` for function `iterator begin() { > > return iterato

[PATCH] D77705: [Driver] Forward pass plugin arguments to gold

ddcc added a comment. Originally, I tried forwarding the `-Xclang -load` arguments, but couldn't access the `options::OPT_plugin` arguments from the argument list. I'm not familiar with tablegen and argument processing, there was some issue with the group not being available causing the argumen

[PATCH] D77637: [SanitizerCoverage] Add -fsanitize-coverage=inline-bool-flag

vitalybuka added a comment. With this patch check-fuzzer does not work FAIL: libFuzzer :: value-profile-load.test (63806 of 66139) TEST 'libFuzzer :: value-profile-load.test' FAILED Script: -- : 'RUN: at line 2'; /us

[clang] c7ff5b3 - [FPEnv] Use single enum to represent rounding mode

Author: Serge Pavlov Date: 2020-04-09T13:26:47+07:00 New Revision: c7ff5b38f27f812dcd6e2e8732208a39232dc284 URL: https://github.com/llvm/llvm-project/commit/c7ff5b38f27f812dcd6e2e8732208a39232dc284 DIFF: https://github.com/llvm/llvm-project/commit/c7ff5b38f27f812dcd6e2e8732208a39232dc284.diff

[PATCH] D76066: [ARM][MachineOutliner] Add Machine Outliner support for ARM

samparker added inline comments. Comment at: llvm/lib/Target/ARM/ARMTargetMachine.cpp:553 addPass(createARMConstantIslandPass()); - addPass(createARMLowOverheadLoopsPass()); + if (!MachineOutlinerEnabled) +addPass(createARMLowOverheadLoopsPass()); yroux

<    1   2   3