kadircet added inline comments.
================
Comment at: clang/lib/Index/IndexBody.cpp:152
+ if (auto *LabelDecl = Label->getDecl())
+ IndexCtx.handleReference(LabelDecl, Label->getIdentLoc(), Parent,
+ ParentDC,
----------------
argh, looks like RecursiveASTVisitor doesn't traverse LabelDecl inside the
LabelStmt. So feel free to fix that in RAV or call
`IndexCtx.handleDecl(LabelDecl)` in here with a fixme. (hopefully nothing much
should break with the former though)
================
Comment at: clang/unittests/Index/IndexTests.cpp:349
+ EXPECT_THAT(Index->Symbols,
+ Contains(AllOf(QName("label"), HasRole(SymbolRole::Reference),
+ WrittenAt(Position(3, 5)))));
----------------
i believe we should see the "definition/declaration" of `label` rather than a
reference
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77717/new/
https://reviews.llvm.org/D77717
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
