[PATCH] D77633: [Parser] Improve diagnostic and error recovery when C++ keywords are used as identifiers.

hokein marked 2 inline comments as done. hokein added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:6872 + // Recovery if a keyword is used as an identifier. + if (Tok.getIdentifierInfo() && sammccall wrote: > As I understand it, we're tr

[PATCH] D77633: [Parser] Improve diagnostic and error recovery when C++ keywords are used as identifiers.

hokein updated this revision to Diff 255908. hokein marked an inline comment as done. hokein added a comment. address review comments - refine the diagnostic messages - add more testcases - more restrict to the diagnosed case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[clang-tools-extra] 2a6eedb - [clangd] Destroy context before resetting CurrentReq

Author: Kadir Cetinkaya Date: 2020-04-08T09:57:55+02:00 New Revision: 2a6eedbb51fd612d3386b0379938036b17511ae0 URL: https://github.com/llvm/llvm-project/commit/2a6eedbb51fd612d3386b0379938036b17511ae0 DIFF: https://github.com/llvm/llvm-project/commit/2a6eedbb51fd612d3386b0379938036b17511ae0.dif

[clang-tools-extra] 130dbf6 - [clangd] Fix broken assertion

Author: Kadir Cetinkaya Date: 2020-04-08T09:57:55+02:00 New Revision: 130dbf63ff12271be9451e259447c5fab768dce6 URL: https://github.com/llvm/llvm-project/commit/130dbf63ff12271be9451e259447c5fab768dce6 DIFF: https://github.com/llvm/llvm-project/commit/130dbf63ff12271be9451e259447c5fab768dce6.dif

[PATCH] D77669: [clangd] Update TUStatus to handle async PreambleThread

kadircet added inline comments. Comment at: clang-tools-extra/clangd/unittests/TUSchedulerTests.cpp:849 + auto Opts = ClangdServer::optsForTest(); + Opts.AsyncThreadsCount = 0; + ClangdServer Server(CDB, FS, Opts, &CaptureTUStatus); sammccall wrote: > This see

[PATCH] D77669: [clangd] Update TUStatus to handle async PreambleThread

kadircet updated this revision to Diff 255914. kadircet marked 4 inline comments as done. kadircet added a comment. - Assert on the execution order instead with simplifications. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77669/new/ https://revie

[PATCH] D76768: [analyzer] Added support of scan-build and exploded-graph-rewriter regression tests for Windows

ASDenysPetrov added a comment. > If the source was checked out incorrectly then most likely everything would > have been broken, not just our test. I'd rather suspect write permissions or > something, but then again, a lot of tests create directories and then write > into them. Dunno. No, I me

[PATCH] D77664: [clangd] Fix broken assertion

This revision was automatically updated to reflect the committed changes. Closed by commit rG130dbf63ff12: [clangd] Fix broken assertion (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77664/new/ https://reviews.llvm.org/D77664

[PATCH] D77683: [Docs] Make code review policy clearer about requested pre-commit reviews

jhenderson added a comment. My impression is that you shouldn't be making changes in code you are not already familiar with without a review, even if the fix seems fairly obvious (it's surprising how often an "obvious" fix isn't actually the right thing to do). I'd have assumed this was covered

[PATCH] D77671: [clangd] Destroy context before resetting CurrentReq

This revision was automatically updated to reflect the committed changes. Closed by commit rG2a6eedbb51fd: [clangd] Destroy context before resetting CurrentReq (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77671/new/ https://

[PATCH] D77680: [clang-tidy] misc-unused-parameters: Don't remove parameter from lambda

njames93 added a comment. Outright disabling for lambdas probably isn't the ideal solution, however it's at least a good stepping stone til a better solution can be found. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77680/new/ https://reviews.ll

[PATCH] D77229: [Analyzer][WIP] Avoid handling of LazyCompundVals in IteratorModeling

baloghadamsoftware updated this revision to Diff 255922. baloghadamsoftware added a comment. Next attempt. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77229/new/ https://reviews.llvm.org/D77229 Files: clang/include/clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h clang/include

[PATCH] D77229: [Analyzer][WIP] Avoid handling of LazyCompundVals in IteratorModeling

baloghadamsoftware marked an inline comment as done. baloghadamsoftware added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/ExprEngineCXX.cpp:231-235 +if (dyn_cast_or_null(LCtx->getParentMap().getParent(E))) { + MemRegionManager &MRMgr = getSValBuil

[PATCH] D77715: [clangd] Add missing GoToStmt in FindTarget.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. so that go-to-def on label can work. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D77715

[PATCH] D77683: [Docs] Make code review policy clearer about requested pre-commit reviews

rengolin added a comment. +1 to Chris, Mehdi and John comments. I think I get the idea, but the text is certainly not conveying that, for me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77683/new/ https://reviews.llvm.org/D77683 _

[clang] 11bd3e5 - [Analyzer][StreamChecker] Introduction of stream error handling.

Author: Balázs Kéri Date: 2020-04-08T11:30:19+02:00 New Revision: 11bd3e5c6549a4983be454ccfbeb16e88c9532db URL: https://github.com/llvm/llvm-project/commit/11bd3e5c6549a4983be454ccfbeb16e88c9532db DIFF: https://github.com/llvm/llvm-project/commit/11bd3e5c6549a4983be454ccfbeb16e88c9532db.diff L

[PATCH] D76066: [ARM][MachineOutliner] Add Machine Outliner support for ARM

samparker added a comment. Hi Yvan, Thanks for adding the tests, I've added a few concerns and questions. Comment at: llvm/lib/Target/ARM/ARMBaseInstrInfo.cpp:5606 + // candidates. + auto CantGuaranteeValueAcrossCall = [&TRI](outliner::Candidate &C) { +// If the unsafe r

[PATCH] D75682: [Analyzer][StreamChecker] Introduction of stream error handling.

This revision was automatically updated to reflect the committed changes. Closed by commit rG11bd3e5c6549: [Analyzer][StreamChecker] Introduction of stream error handling. (authored by balazske). Changed prior to commit: https://reviews.llvm.org/D75682?vs=255906&id=255935#toc Repository: rG

[PATCH] D77658: [analyzer] StdLibraryFunctionsChecker: Add sanity checks for constraints

balazske added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:116 +/// Do sanity check on the constraint. +virtual bool validate(const FunctionDecl *) const { return true; } ArgNo getArgNo() const { return ArgN; } --

[PATCH] D77697: libc++: adjust modulemap for non-modular C

joerg added a comment. This fixes the module build of clang for me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77697/new/ https://reviews.llvm.org/D77697 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D77682: [clang-format] Always break line after enum opening brace

MyDeveloperDay added a comment. Did you try: BreakBeforeBraces: Custom BraceWrapping: AfterEnum: true with AfterEnum:true $ clang-format enum.cpp enum { A, }; enum { B, C, D }; enum { E }; with AfterEnum:false $ clang-format enum.cpp e

[PATCH] D77645: [clangd] Support dexp -c "some command"

kbobyrev accepted this revision. kbobyrev added a comment. This revision is now accepted and ready to land. LGTM with a couple of nits Comment at: clang-tools-extra/clangd/index/dex/dexp/Dexp.cpp:85 llvm::cl::ValueDisallowed, llvm::cl::cat(llvm::cl::GeneralCategory)}; +

[PATCH] D77540: [PATCH] [ARM]: Armv8.6-a Matrix Mul Asm and Intrinsics Support

DavidSpickett added inline comments. Comment at: clang/lib/Basic/Targets/AArch64.cpp:284 + if (HasMatMul) +Builder.defineMacro("__ARM_FEATURE_MATMUL_INT8", "1"); + I don't see specific tests for this #define Comment at: clang/lib/Basic/Tar

[PATCH] D77682: [clang-format] Always break line after enum opening brace

MyDeveloperDay added a comment. I think what is interesting is BreakBeforeBraces: Custom BraceWrapping: AfterEnum: false gets messed up completely by the `,` and that IS a bug in my view $ clang-format enum.cpp enum { A, }; enum { B, C, D }; enum { B, C,

[PATCH] D77379: [FPEnv] Use single enum to represent rounding mode

sepavloff updated this revision to Diff 255949. sepavloff added a comment. Updated patch - Fixed comment, - Mention "round.tonearestaway" in documentation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77379/new/ https://reviews.llvm.org/D77379 F

[PATCH] D77379: [FPEnv] Use single enum to represent rounding mode

sepavloff marked an inline comment as done. sepavloff added inline comments. Comment at: llvm/include/llvm/ADT/FloatingPointMode.h:26 +/// assigned to the rounding modes must agree with the values used by FLT_ROUNDS +/// (C11, 5.2.4.2.2p8). +enum class RoundingMode : int8_t { --

[PATCH] D77656: [clangd] Fix a crash bug in AddUsing tweak around template handling.

adamcz marked an inline comment as done. adamcz added a comment. Can you submit this? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77656/new/ https://reviews.llvm.org/D77656 ___ cfe-commits ma

[PATCH] D77656: [clangd] Fix a crash bug in AddUsing tweak around template handling.

adamcz updated this revision to Diff 255950. adamcz added a comment. review comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77656/new/ https://reviews.llvm.org/D77656 Files: clang-tools-extra/clangd/refactor/tweaks/AddUsing.cpp clang-too

[PATCH] D77419: [libTooling] Simplify the representation of Transformer's RewriteRules.

gribozavr2 accepted this revision. gribozavr2 marked an inline comment as done. gribozavr2 added inline comments. Comment at: clang/include/clang/Tooling/Transformer/RewriteRule.h:44 +/// of `EditList`. +using EditList = MatchConsumer>; + ymandel wrote: > griboza

[PATCH] D77628: [Driver][X86] Add -mpad-max-prefix-size

skan updated this revision to Diff 255953. skan added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77628/new/ https://reviews.llvm.org/D77628 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains/Clang.cpp

[PATCH] D77385: [clangd] Add index export to dexp

kbobyrev added a comment. > Typical use is to read RIFF data to dump to YAML for inspection of indexed > data. The YAML (de)serialization has also been extended to aid in this regard. Just curious: what is the typical usecase for YAML index inspection? Maybe if there is something missing in Dex

[clang-tools-extra] c1a00b8 - [clangd] show layout info when hovering on a class/field definition.

Author: Sam McCall Date: 2020-04-08T13:41:51+02:00 New Revision: c1a00b89add8f4f9658f631a4fa2cb8a068eef57 URL: https://github.com/llvm/llvm-project/commit/c1a00b89add8f4f9658f631a4fa2cb8a068eef57 DIFF: https://github.com/llvm/llvm-project/commit/c1a00b89add8f4f9658f631a4fa2cb8a068eef57.diff LO

[PATCH] D77701: [Sema] refactor static functions into private methods NFC

aaron.ballman added a reviewer: rsmith. aaron.ballman added a comment. OTOH, this is reasonable, NFC, and I tend to agree about it being a code smell. OTOH, this makes parsing Sema.h that much slower and adds even more text for us to wade through in that header file. Given that the approaches ar

[PATCH] D77633: [Parser] Improve diagnostic and error recovery when C++ keywords are used as identifiers.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. This is fairly visible, but seems reasonably safe to me. Let's see if anyone complains :-) Comment at: clang/test/Parser/cxx-keyword-identifiers.cpp:16 +int foo5(int x

[PATCH] D77717: [clang][index] index the missing LabelDecl in libindex.

hokein created this revision. hokein added a reviewer: kadircet. Herald added a subscriber: arphaman. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D77717 Files: clang/lib/Index/IndexBody.cpp clang/unittests/Index/IndexTests.cpp Index: clang/

[PATCH] D77355: [clangd] show layout info when hovering on a class/field definition.

This revision was automatically updated to reflect the committed changes. Closed by commit rGc1a00b89add8: [clangd] show layout info when hovering on a class/field definition. (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D77355?vs=254786&id=255964#toc Repository:

[clang-tools-extra] cca10be - [clangd] Fix a crash bug in AddUsing tweak around template handling.

Author: Adam Czachorowski Date: 2020-04-08T13:59:47+02:00 New Revision: cca10be3f60dd30055acc70d117649f889da779d URL: https://github.com/llvm/llvm-project/commit/cca10be3f60dd30055acc70d117649f889da779d DIFF: https://github.com/llvm/llvm-project/commit/cca10be3f60dd30055acc70d117649f889da779d.d

[clang-tools-extra] 49268a6 - [clangd] Support dexp -c "some command"

Author: Sam McCall Date: 2020-04-08T14:02:49+02:00 New Revision: 49268a678c2f0233f71363b0988d4b159496b036 URL: https://github.com/llvm/llvm-project/commit/49268a678c2f0233f71363b0988d4b159496b036 DIFF: https://github.com/llvm/llvm-project/commit/49268a678c2f0233f71363b0988d4b159496b036.diff LO

[clang-tools-extra] a533b03 - [clangd] Add missing GoToStmt in FindTarget.

Author: Haojian Wu Date: 2020-04-08T14:19:52+02:00 New Revision: a533b03028fad4555e53b803197980735ccd68f9 URL: https://github.com/llvm/llvm-project/commit/a533b03028fad4555e53b803197980735ccd68f9 DIFF: https://github.com/llvm/llvm-project/commit/a533b03028fad4555e53b803197980735ccd68f9.diff LO

[PATCH] D73182: [CodeGen] Emit IR for fixed-point multiplication and division.

ebevhan updated this revision to Diff 255970. ebevhan added a comment. Rebased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73182/new/ https://reviews.llvm.org/D73182 Files: clang/lib/CodeGen/CGExprScalar.cpp clang/test/Frontend/fixed_point_

[PATCH] D77645: [clangd] Support dexp -c "some command"

sammccall marked 4 inline comments as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/index/dex/dexp/Dexp.cpp:100 +// must do this before opts are destroyed +auto Cleanup = llvm::make_scope_exit(llvm::cl::ResetCommandLineParser); if (Help.

[PATCH] D77385: [clangd] Add index export to dexp

sammccall added inline comments. Comment at: clang-tools-extra/clangd/index/dex/dexp/Dexp.cpp:322 + // Make Export command option(s) available on command line. + // That allows for convenient (piping/redirecting) a dump non-interactively + // without passing through REPL.

[PATCH] D73183: [CodeGen] Emit IR for fixed-point unary operators.

ebevhan updated this revision to Diff 255971. ebevhan added a comment. Rebased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73183/new/ https://reviews.llvm.org/D73183 Files: clang/lib/CodeGen/CGExprScalar.cpp clang/test/Frontend/fixed_point_

[PATCH] D73186: [AST] Add fixed-point multiplication constant evaluation.

ebevhan updated this revision to Diff 255976. ebevhan added a comment. Rebased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73186/new/ https://reviews.llvm.org/D73186 Files: clang/include/clang/Basic/FixedPoint.h clang/lib/AST/ExprConstant.c

[PATCH] D73184: [CodeGen] Emit IR for compound assignment with fixed-point operands.

ebevhan updated this revision to Diff 255972. ebevhan added a comment. Rebased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73184/new/ https://reviews.llvm.org/D73184 Files: clang/lib/CodeGen/CGExprScalar.cpp clang/lib/Sema/SemaExpr.cpp cl

[PATCH] D73257: [AST] Compress the FixedPointSemantics type better.

ebevhan updated this revision to Diff 255974. ebevhan added a comment. Rebased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73257/new/ https://reviews.llvm.org/D73257 Files: clang/include/clang/Basic/FixedPoint.h Index: clang/include/clang/B

[PATCH] D73185: [AST] Add fixed-point subtraction constant evaluation.

ebevhan updated this revision to Diff 255975. ebevhan added a comment. Rebased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73185/new/ https://reviews.llvm.org/D73185 Files: clang/include/clang/Basic/FixedPoint.h clang/lib/AST/ExprConstant.c

[PATCH] D73187: [AST] Add fixed-point division constant evaluation.

ebevhan updated this revision to Diff 255977. ebevhan added a comment. Rebased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73187/new/ https://reviews.llvm.org/D73187 Files: clang/include/clang/Basic/FixedPoint.h clang/lib/AST/ExprConstant.c

[PATCH] D73188: [AST] Improve overflow diagnostics for fixed-point constant evaluation.

ebevhan updated this revision to Diff 255978. ebevhan added a comment. Rebased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73188/new/ https://reviews.llvm.org/D73188 Files: clang/include/clang/Basic/DiagnosticASTKinds.td clang/lib/AST/ExprC

[PATCH] D77628: [Driver][X86] Add -mpad-max-prefix-size

LuoYuanke accepted this revision. LuoYuanke added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77628/new/ https://reviews.llvm.org/D77628 _

[PATCH] D77721: [ASTImporter] Add support for importing fixed point literals

vabridgers added a comment. Landing this change depends on https://reviews.llvm.org/D57226 to be pushed. Please review for now, and I'll be sure to push this only after https://reviews.llvm.org/D57226 is pushed. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D57226: [Fixed Point] [AST] Add an AST serialization code for fixed-point literals.

vabridgers added a comment. https://reviews.llvm.org/D77721 depends on this serialization change for fixed point literals. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57226/new/ https://reviews.llvm.org/D57226 ___

[PATCH] D77722: [analyzer] Do not report NSError null dereference for _Nonnull params

vsavchenko created this revision. vsavchenko added reviewers: NoQ, dcoughlin. Herald added subscribers: cfe-commits, ASDenysPetrov, martong, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, JDevlieghere, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. We

[PATCH] D73189: [AST] Fix certain consteval assignment and comma operator issues with fixed-point types.

ebevhan updated this revision to Diff 255979. ebevhan added a comment. Rebased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73189/new/ https://reviews.llvm.org/D73189 Files: clang/lib/AST/ExprConstant.cpp clang/test/Frontend/fixed_point_cras

[PATCH] D77680: [clang-tidy] misc-unused-parameters: Don't remove parameter from lambda

mgehre added a comment. In D77680#1968860 , @njames93 wrote: > Outright disabling for lambdas probably isn't the ideal solution, however > it's at least a good stepping stone til a better solution can be found. I fully agree! Repository: rG LLVM Git

[PATCH] D77721: [ASTImporter] Add support for importing fixed point literals

vabridgers created this revision. vabridgers added reviewers: martong, leonardchan, ebevhan. Herald added subscribers: cfe-commits, teemperor, rnkovacs. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: clang. vabridgers added a comment. Landing this chan

[PATCH] D77645: [clangd] Support dexp -c "some command"

This revision was automatically updated to reflect the committed changes. Closed by commit rG49268a678c2f: [clangd] Support dexp -c "some command" (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D77645?vs=255660&id=255986#toc Repository: rG LLVM Github Monorepo CH

[PATCH] D77656: [clangd] Fix a crash bug in AddUsing tweak around template handling.

This revision was automatically updated to reflect the committed changes. Closed by commit rGcca10be3f60d: [clangd] Fix a crash bug in AddUsing tweak around template handling. (authored by adamcz, committed by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D77715: [clangd] Add missing GoToStmt in FindTarget.

This revision was automatically updated to reflect the committed changes. Closed by commit rGa533b03028fa: [clangd] Add missing GoToStmt in FindTarget. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77715/new/ https://reviews.ll

[clang] 0b9922e - [CodeGen] Emit IR for fixed-point multiplication and division.

Author: Bevin Hansson Date: 2020-04-08T14:33:04+02:00 New Revision: 0b9922e67a0b5520d76c293e9aef13a7ad4f3a8d URL: https://github.com/llvm/llvm-project/commit/0b9922e67a0b5520d76c293e9aef13a7ad4f3a8d DIFF: https://github.com/llvm/llvm-project/commit/0b9922e67a0b5520d76c293e9aef13a7ad4f3a8d.diff

[clang] d5d0d8e - [AST] Compress the FixedPointSemantics type better.

Author: Bevin Hansson Date: 2020-04-08T14:33:04+02:00 New Revision: d5d0d8eb7d094f8270721662882c0094fc4fdc29 URL: https://github.com/llvm/llvm-project/commit/d5d0d8eb7d094f8270721662882c0094fc4fdc29 DIFF: https://github.com/llvm/llvm-project/commit/d5d0d8eb7d094f8270721662882c0094fc4fdc29.diff

[clang] 39baaab - [CodeGen] Emit IR for fixed-point unary operators.

Author: Bevin Hansson Date: 2020-04-08T14:33:04+02:00 New Revision: 39baaabf6de4cfcbb942434084298a3f9acf5f89 URL: https://github.com/llvm/llvm-project/commit/39baaabf6de4cfcbb942434084298a3f9acf5f89 DIFF: https://github.com/llvm/llvm-project/commit/39baaabf6de4cfcbb942434084298a3f9acf5f89.diff

[clang] 313461f - [CodeGen] Emit IR for compound assignment with fixed-point operands.

Author: Bevin Hansson Date: 2020-04-08T14:33:04+02:00 New Revision: 313461f6d8f91ac8abf2fa06e17b92127b050f06 URL: https://github.com/llvm/llvm-project/commit/313461f6d8f91ac8abf2fa06e17b92127b050f06 DIFF: https://github.com/llvm/llvm-project/commit/313461f6d8f91ac8abf2fa06e17b92127b050f06.diff

[clang] 5e5d366 - [libTooling] Simplify the representation of Transformer's RewriteRules.

Author: Yitzhak Mandelbaum Date: 2020-04-08T08:45:41-04:00 New Revision: 5e5d36671833e186e847e74bb5ed0c559625b906 URL: https://github.com/llvm/llvm-project/commit/5e5d36671833e186e847e74bb5ed0c559625b906 DIFF: https://github.com/llvm/llvm-project/commit/5e5d36671833e186e847e74bb5ed0c559625b906.

[PATCH] D77633: [Parser] Improve diagnostic and error recovery when C++ keywords are used as identifiers.

hokein updated this revision to Diff 255988. hokein marked an inline comment as done. hokein added a comment. add FIXME. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77633/new/ https://reviews.llvm.org/D77633 Files: clang/include/clang/Basic/Di

[PATCH] D77722: [analyzer] Do not report NSError null dereference for _Nonnull params

vsavchenko added a comment. Hi everyone! I'm thinking about adding support for `__attribute((nonnull))__` as well, but it should be handled a bit differently. That annotation is for parameters and not for types, so the corresponding constraints should be generated only when entering the functio

[PATCH] D77419: [libTooling] Simplify the representation of Transformer's RewriteRules.

ymandel marked 2 inline comments as done. ymandel added a comment. Thanks for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77419/new/ https://reviews.llvm.org/D77419 ___ cfe-commits mailin

[PATCH] D75851: [Analyzer][StreamChecker] Added evaluation of fseek.

Szelethus marked an inline comment as done. Szelethus added a comment. In D75851#1933538 , @balazske wrote: > Simplified code. I can tell! The patch is amazing, the code practically reads itself aloud. I have some inlines but nothing major, the high lev

[PATCH] D77641: [analyzer] StdLibraryFunctionsChecker: Associate summaries to FunctionDecls

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. LGTM! Its always a joy to see you do C++. I suspect your change made compiler errors a bit nicer as well, so you don't get one giant "Well, this huge single argument doesn't look mat

[PATCH] D77722: [analyzer] Do not report NSError null dereference for _Nonnull params

vsavchenko updated this revision to Diff 255993. vsavchenko added a comment. Fix formatting issues in the test file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77722/new/ https://reviews.llvm.org/D77722 Files: clang/lib/StaticAnalyzer/Checkers

[PATCH] D73184: [CodeGen] Emit IR for compound assignment with fixed-point operands.

This revision was automatically updated to reflect the committed changes. Closed by commit rG313461f6d8f9: [CodeGen] Emit IR for compound assignment with fixed-point operands. (authored by ebevhan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73184

[PATCH] D73182: [CodeGen] Emit IR for fixed-point multiplication and division.

This revision was automatically updated to reflect the committed changes. Closed by commit rG0b9922e67a0b: [CodeGen] Emit IR for fixed-point multiplication and division. (authored by ebevhan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73182/new/

[PATCH] D77419: [libTooling] Simplify the representation of Transformer's RewriteRules.

This revision was automatically updated to reflect the committed changes. Closed by commit rG5e5d36671833: [libTooling] Simplify the representation of Transformer's RewriteRules. (authored by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77

[PATCH] D73257: [AST] Compress the FixedPointSemantics type better.

This revision was automatically updated to reflect the committed changes. Closed by commit rGd5d0d8eb7d09: [AST] Compress the FixedPointSemantics type better. (authored by ebevhan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73257/new/ https://re

[PATCH] D73183: [CodeGen] Emit IR for fixed-point unary operators.

This revision was automatically updated to reflect the committed changes. Closed by commit rG39baaabf6de4: [CodeGen] Emit IR for fixed-point unary operators. (authored by ebevhan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73183/new/ https://rev

[clang] 625acd8 - [Parser] Improve diagnostic and error recovery when C++ keywords are used as identifiers.

Author: Haojian Wu Date: 2020-04-08T15:15:33+02:00 New Revision: 625acd8f6847a156b236b8f11b4b02b11cac3766 URL: https://github.com/llvm/llvm-project/commit/625acd8f6847a156b236b8f11b4b02b11cac3766 DIFF: https://github.com/llvm/llvm-project/commit/625acd8f6847a156b236b8f11b4b02b11cac3766.diff LO

[PATCH] D77641: [analyzer] StdLibraryFunctionsChecker: Associate summaries to FunctionDecls

Szelethus added a comment. Also, if you gave a bit of time for anyone else to have a say, that might be nice. :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77641/new/ https://reviews.llvm.org/D77641 __

[PATCH] D77721: [ASTImporter] Add support for importing fixed point literals

balazske added inline comments. Comment at: clang/unittests/AST/ASTImporterTest.cpp:1000 + hasDescendant(fixedPointLiteral(); +} + See test `ImportFloatinglLiteralExpr` for a better implementation of this test. The new test could be inc

[PATCH] D77722: [analyzer] Do not report NSError null dereference for _Nonnull params

vsavchenko marked 2 inline comments as done. vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/NullabilityChecker.cpp:521 + // Annotations that we want to consider make sense only for types. + auto Region = dyn_cast_or_null(Location.getAsRegion());

[PATCH] D77722: [analyzer] Do not report NSError null dereference for _Nonnull params

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. > `NonnullParamChecker` Yup, looks like that's actually the one that deals with `__attribute__((nonnull))`, as opposed to `_Nonnull`. Comment at: clang/lib/StaticAnalyzer/Checker

[PATCH] D77717: [clang][index] index the missing LabelDecl in libindex.

hokein updated this revision to Diff 256001. hokein added a comment. Herald added subscribers: usaxena95, jkorous. add a clangd xref test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77717/new/ https://reviews.llvm.org/D77717 Files: clang-tool

[PATCH] D77722: [analyzer] Do not report NSError null dereference for _Nonnull params

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/NullabilityChecker.cpp:521 + // Annotations that we want to consider make sense only for types. + auto Region = dyn_cast_or_null(Location.getAsRegion()); + if (!Region) vsavchenko wrote:

[PATCH] D77633: [Parser] Improve diagnostic and error recovery when C++ keywords are used as identifiers.

This revision was automatically updated to reflect the committed changes. Closed by commit rG625acd8f6847: [Parser] Improve diagnostic and error recovery when C++ keywords are used as… (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D75677: [Analyzer] Only add iterator note tags to the operations of the affected iterators

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/IteratorModeling.cpp:541-542 +BR.markInteresting(It1); +if (const auto &LCV1 = It1.getAs()) { + BR.markInteresting(LCV1->getRegion()); +} baloghadamsoftware

[PATCH] D77540: [PATCH] [ARM]: Armv8.6-a Matrix Mul Asm and Intrinsics Support

LukeGeeson added inline comments. Comment at: clang/lib/Basic/Targets/AArch64.h:39 bool HasTME; + unsigned HasMatMul; DavidSpickett wrote: > Why is this feature a number for AArch64, does >1 mean something? It seems this was an artifact from how this is han

[PATCH] D77722: [analyzer] Do not report NSError null dereference for _Nonnull params

Szelethus added a comment. In D77722#1969261 , @vsavchenko wrote: > Hi everyone! > I'm thinking about adding support for `__attribute((nonnull))__` as well, > but it should be handled a bit differently. That annotation is for parameters > and not for ty

[PATCH] D75677: [Analyzer] Only add iterator note tags to the operations of the affected iterators

baloghadamsoftware marked an inline comment as done. baloghadamsoftware added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/IteratorModeling.cpp:541-542 +BR.markInteresting(It1); +if (const auto &LCV1 = It1.getAs()) { + BR.markInteresting

[PATCH] D77721: [ASTImporter] Add support for importing fixed point literals

vabridgers added a comment. @balazske, Thank you for the comments. I'll address and repost the review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77721/new/ https://reviews.llvm.org/D77721 ___ cfe-c

[PATCH] D77697: libc++: adjust modulemap for non-modular C

ldionne added a comment. In D77697#1968998 , @joerg wrote: > This fixes the module build of clang for me. @joerg When did it start failing for you? And what part of it did? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D77722: [analyzer] Do not report NSError null dereference for _Nonnull params

vsavchenko added a comment. In D77722#1969391 , @Szelethus wrote: > In D77722#1969261 , @vsavchenko > wrote: > > > Hi everyone! > > I'm thinking about adding support for `__attribute((nonnull))__` as well, > > bu

[PATCH] D77393: [X86] Fix implicit sign conversion warnings in X86 headers.

probinson added a comment. It looks like you're not actually interested in the compiled output, but just whether warnings occurred; in that case you'd be better off with `-verify -fsyntax-only` and `// expected-no-diagnostics`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77393/new/

[PATCH] D77641: [analyzer] StdLibraryFunctionsChecker: Associate summaries to FunctionDecls

NoQ added a comment. So you only do the lookup in the global scope? What about `namespace std`? Do you also plan to support class methods by looking up the class first and then looking up the method in the class? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D77722: [analyzer] Do not report NSError null dereference for _Nonnull params

vsavchenko updated this revision to Diff 256009. vsavchenko added a comment. Fix review remarks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77722/new/ https://reviews.llvm.org/D77722 Files: clang/lib/StaticAnalyzer/Checkers/NullabilityChecker.

[PATCH] D77305: [Analyzer][VLASize] Support multi-dimensional arrays.

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. LGTM, thanks! I'm not terribly knowledgable about VLAs, if someone else would gave a green light it would be even better. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D77728: [Driver][X86] Add an alias for -mpad-max-prefix-size

skan created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. skan added a parent revision: D77628: [Driver][X86] Add -mpad-max-prefix-size. Make -malign-branch-prefix-size an alias for -mpad-max-prefix-size (For GCC compatibility) Repository: rG LLVM Githu

[PATCH] D77717: [clang][index] index the missing LabelDecl in libindex.

kadircet added a comment. we should also be handling `LabelDecl`s in clang/lib/Index/IndexDecl.cpp Comment at: clang/lib/Index/IndexBody.cpp:145 +if (auto *LabelDecl = Goto->getLabel()) + IndexCtx.handleReference(LabelDecl, Goto->getLabelLoc(), Parent, ParentDC, +

[PATCH] D77229: [Analyzer][WIP] Avoid handling of LazyCompundVals in IteratorModeling

baloghadamsoftware added a comment. Another showstopper: the test `container_modeling.cpp` passed with analyzer option `container-inlining=false`. However it faild with `container-inlining=true -DINLINE=1`. The problem is that the `CFGElement` for function `iterator begin() { return iterator(_s

[clang] e4ca64f - [Fixed Point] Add triples to test cases.

Author: Bevin Hansson Date: 2020-04-08T16:31:36+02:00 New Revision: e4ca64f1ae8a3743a9bea4926e1e7889c5b02525 URL: https://github.com/llvm/llvm-project/commit/e4ca64f1ae8a3743a9bea4926e1e7889c5b02525 DIFF: https://github.com/llvm/llvm-project/commit/e4ca64f1ae8a3743a9bea4926e1e7889c5b02525.diff

[PATCH] D77680: [clang-tidy] misc-unused-parameters: Don't remove parameter from lambda

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM as a temporary workaround until we find a better solution. (I just noticed that we don't need a similar fix for blocks because this check doesn't seem to support blocks: htt

[PATCH] D75851: [Analyzer][StreamChecker] Added evaluation of fseek.

balazske marked an inline comment as done. balazske added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:103-110 + /// Return if the specified error kind is possible on the stream in the + /// current state. + /// This depends on the stored `L

  1   2   3   >