[PATCH] D77244: sancov/inline-bool-flag feature + tests + docs.

vitalybuka added inline comments. Comment at: clang/test/Driver/autocomplete.c:49 +// RUN: %clang --autocomplete=-fno-sanitize-coverage=,f | FileCheck %s +// -check-prefix=FNOSANICOVER FNOSANICOVER: func RUN: %clang +// --autocomplete=-fno-sanitize-coverage= | FileCheck %s --

[PATCH] D76725: [clangd] Build ASTs only with fresh preambles or after building a new preamble

kadircet updated this revision to Diff 254439. kadircet marked 31 inline comments as done. kadircet added a comment. - Update comments and re-order functions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76725/new/ https://reviews.llvm.org/D76725

[PATCH] D75034: [clang-format] use spaces for alignment with UT_ForContinuationAndIndentation

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. This LGTM, thank you Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75034/new/ https://reviews.llvm.org/D75034 ___

[PATCH] D77112: [OpenMP][NFCI] Move OpenMP clause information to `lib/Frontend/OpenMP`

jdoerfert added a comment. Herald added a subscriber: yaxunl. NOTE: I mixed this one up with the follow up that was approved already (D77113 ) and committed it. If it turns out to be problematic we revert but I'll leave it for now as there was a positive review

[PATCH] D77112: [OpenMP][NFCI] Move OpenMP clause information to `lib/Frontend/OpenMP`

jdoerfert added a comment. Reverted in 1858f4b50dd35c28b377ba5dbc572fed43a5d38a as some uses need fixing, didn't build clang-tidy locally apparently. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D77290: [OpenMP] Specialize OpenMP calls after template instantiation

jdoerfert created this revision. jdoerfert added reviewers: kiranchandramohan, ABataev, RaviNarayanaswamy, gtbercea, grokos, sdmitriev, JonChesterfield, hfinkel, fghanim, aaron.ballman. Herald added subscribers: guansong, bollu, yaxunl. Herald added a project: clang. jdoerfert removed a parent rev

[clang-tools-extra] b420065 - [clangd] Fix an assertion crash in ReferenceFinder.

Author: Haojian Wu Date: 2020-04-02T09:29:20+02:00 New Revision: b42006596905bea7bef54759ba3a5d1a7dd418fa URL: https://github.com/llvm/llvm-project/commit/b42006596905bea7bef54759ba3a5d1a7dd418fa DIFF: https://github.com/llvm/llvm-project/commit/b42006596905bea7bef54759ba3a5d1a7dd418fa.diff LO

[PATCH] D75791: [clang-format] Added new option IndentExternBlock

MyDeveloperDay added a comment. I have no concerns with this patch other than the consideration of the defaults. My concern is whatever our choice we will generate churn on existing code where the .clang-format file has AfterExternBlock = true (or its true in inbuilt BasedOnStyle type) https:

[PATCH] D77063: [WIP][clangd] Dont block for preamble builds

kadircet updated this revision to Diff 254442. kadircet added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77063/new/ https://reviews.llvm.org/D77063 Files: clang-tools-extra/clangd/TUScheduler.cpp clang-tools-extra/clangd

[PATCH] D77222: [clangd] Fix an assertion crash in ReferenceFinder.

This revision was automatically updated to reflect the committed changes. Closed by commit rGb42006596905: [clangd] Fix an assertion crash in ReferenceFinder. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77222/new/ https://rev

[PATCH] D76725: [clangd] Build ASTs only with fresh preambles or after building a new preamble

kadircet added a comment. preambleReady part is a little bit different than you've described, it looks more like: ASTWorker::preambleReady(): enqueue({ if(preamble!=lastPreamble) { lastPreamble = preamble cache.get(); // force next read to use this preamble } build as

[clang] d08fadd - [X86] Add SERIALIZE instruction.

Author: WangTianQing Date: 2020-04-02T16:19:23+08:00 New Revision: d08fadd6628a061bca66d37d6e0de2c51249ad22 URL: https://github.com/llvm/llvm-project/commit/d08fadd6628a061bca66d37d6e0de2c51249ad22 DIFF: https://github.com/llvm/llvm-project/commit/d08fadd6628a061bca66d37d6e0de2c51249ad22.diff

[clang] 7314aea - [clang] Move branch-protection from CodeGenOptions to LangOptions

Author: Daniel Kiss Date: 2020-04-02T10:31:52+02:00 New Revision: 7314aea5a42d33f9f5af5d158d8892e88072764e URL: https://github.com/llvm/llvm-project/commit/7314aea5a42d33f9f5af5d158d8892e88072764e DIFF: https://github.com/llvm/llvm-project/commit/7314aea5a42d33f9f5af5d158d8892e88072764e.diff L

[PATCH] D75034: [clang-format] use spaces for alignment with UT_ForContinuationAndIndentation

fickert added a comment. Great, thank you! I do not have push access to the repository, so someone else would need to commit this for me: Maximilian Fickert Should I add the fix for the test cases missing the tab configuration (see my last inline comment: https://reviews.llvm.org/D75034#inli

[PATCH] D71129: [ARM][CMSE] Implement CMSE attributes

chill added a comment. In D71129#1956137 , @snidertm wrote: > Have you already committed support for CMSE attributes to the LLVM backend? > Or is that on the way? The last two CMSE patches are under review: https://reviews.llvm.org/D76518 Repository:

[PATCH] D77131: [clang] Move branch-protection from CodeGenOptions to LangOptions

This revision was automatically updated to reflect the committed changes. Closed by commit rG7314aea5a42d: [clang] Move branch-protection from CodeGenOptions to LangOptions (authored by danielkiss). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7713

[PATCH] D77193: [X86] Add SERIALIZE instruction.

This revision was automatically updated to reflect the committed changes. Closed by commit rGd08fadd6628a: [X86] Add SERIALIZE instruction. (authored by tianqing, committed by xiangzhangllvm). Changed prior to commit: https://reviews.llvm.org/D77193?vs=254114&id=254447#toc Repository: rG LLV

[PATCH] D76818: [clang-tidy] Add check llvmlibc-implementation-in-namespace.

njames93 added a comment. This check needs a store Options override method as it reading options from a configuration. Check other checks to see how this is done. Comment at: clang-tools-extra/clang-tidy/llvmlibc/ImplementationInNamespaceCheck.h:35 +private: + std::string Re

[PATCH] D71129: [ARM][CMSE] Implement CMSE attributes

chill marked 4 inline comments as done. chill added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:1882 + if (FI.isCmseNSCall()) +FuncAttrs.addAttribute("cmse_nonsecure_call"); + snidertm wrote: > Just curious … Does the LLVM backend have a way to

[PATCH] D77221: [AVR] Rework MCU family detection to support more AVR MCUs

vlastik updated this revision to Diff 254456. vlastik added a comment. Fix regression introduced by patch Failed unit tests: - Clang.Driver::avr-link-mcu-family-unimplemented.c - Clang.Misc::target-invalid-cpu-note.c CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77221/new/ https://rev

[PATCH] D77244: sancov/inline-bool-flag feature + tests + docs.

pratyai updated this revision to Diff 254461. pratyai added a comment. Undid the `arc lint` on autocomplete.c. `arc lint` does not seem to have an option --style, but it's just one line diff anyway. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D772

[PATCH] D77225: [clangd] Support textDocument/semanticTokens/edits

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. this is neat, and the new semantic highlighting protocol is much nicer than the old one. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:1245 +static void increment

[PATCH] D77244: sancov/inline-bool-flag feature + tests + docs.

pratyai updated this revision to Diff 254462. pratyai added a comment. Did the same for fsanitize-coverage.c. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77244/new/ https://reviews.llvm.org/D77244 Files: clang/docs/SanitizerCoverage.rst clan

[PATCH] D77244: sancov/inline-bool-flag feature + tests + docs.

pratyai updated this revision to Diff 254470. pratyai added a comment. And missed a space. Sorry, I'm just not very familiar with this kind of test, and cannot spot the mistakes before going to the web UI. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D77244: sancov/inline-bool-flag feature + tests + docs.

pratyai updated this revision to Diff 254468. pratyai added a comment. fsanitize-coverage.c undo was incorrect the first time :( Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77244/new/ https://reviews.llvm.org/D77244 Files: clang/docs/Sanitizer

[clang] 37ced5a - [clang][AARCH64] Add __ARM_FEATURE_{PAC, BTI}_DEFAULT defines

Author: Daniel Kiss Date: 2020-04-02T12:54:21+02:00 New Revision: 37ced5a571066c11548c672f354c6091f5903991 URL: https://github.com/llvm/llvm-project/commit/37ced5a571066c11548c672f354c6091f5903991 DIFF: https://github.com/llvm/llvm-project/commit/37ced5a571066c11548c672f354c6091f5903991.diff L

[clang] e6cb4b6 - [Clang][CodeGen] Fixing mismatch between memory layout and const expressions for oversized bitfields

Author: Lucas Prates Date: 2020-04-02T11:55:20+01:00 New Revision: e6cb4b659af9f9c1a4c179093b187e7ad7cc5770 URL: https://github.com/llvm/llvm-project/commit/e6cb4b659af9f9c1a4c179093b187e7ad7cc5770 DIFF: https://github.com/llvm/llvm-project/commit/e6cb4b659af9f9c1a4c179093b187e7ad7cc5770.diff

[PATCH] D74183: [IRGen] Add an alignment attribute to underaligned sret parameters

hgreving added a comment. In D74183#1942262 , @nikic wrote: > In D74183#1941741 , @efriedma wrote: > > > If it's just tramp3d-v4, I'm not that concerned... but that's a weird > > result. On x86 in particular, alig

[PATCH] D77249: [MSan] Pass command line options to MSan with new pass manager

nemanjai created this revision. nemanjai added reviewers: eugenis, vitalybuka, philip.pfaffe, leonardchan, PowerPC. Herald added projects: clang, Sanitizers. Herald added subscribers: Sanitizers, cfe-commits. There are a number of test cases that fail when clang is built to use NPM by default. T

[PATCH] D77249: [MSan] Pass command line options to MSan with new pass manager

vitalybuka added inline comments. Comment at: compiler-rt/test/msan/chained_origin_empty_stack_npm.cpp:4 +// this test. +// RUN: %clangxx_msan -fsanitize-memory-track-origins=2 \ +// RUN: -fexperimental-new-pass-manager -O3 %s -o %t && \ Why not to add RUN: s

[PATCH] D77249: [MSan] Pass command line options to MSan with new pass manager

nemanjai marked an inline comment as done. nemanjai added inline comments. Comment at: compiler-rt/test/msan/chained_origin_empty_stack_npm.cpp:4 +// this test. +// RUN: %clangxx_msan -fsanitize-memory-track-origins=2 \ +// RUN: -fexperimental-new-pass-manager -O3 %s -o %t &&

[PATCH] D77249: [MSan] Pass command line options to MSan with new pass manager

nemanjai marked an inline comment as done. nemanjai added inline comments. Comment at: compiler-rt/test/msan/chained_origin_empty_stack_npm.cpp:4 +// this test. +// RUN: %clangxx_msan -fsanitize-memory-track-origins=2 \ +// RUN: -fexperimental-new-pass-manager -O3 %s -o %t &&

[PATCH] D77244: sancov/inline-bool-flag feature + tests + docs.

pratyai added a comment. It looks like I broke the tests after the `i8 `-> `i1` switch. I think it's because of an existing bug. From https://llvm.org/docs/LangRef.html > i1:8:8 - i1 is 8-bit (byte) aligned OTOH, in `SanitizerCoverage.cpp`, we have in `CreateFunctionLocalArrayInSection()`:

[PATCH] D77134: [clang][AARCH64] Add __ARM_FEATURE_{PAC, BTI}_DEFAULT defines

This revision was automatically updated to reflect the committed changes. Closed by commit rG37ced5a57106: [clang][AARCH64] Add __ARM_FEATURE_{PAC, BTI}_DEFAULT defines (authored by danielkiss). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77134/ne

[PATCH] D76929: [AArch64][SVE] Add SVE intrinsic for LD1RQ

andwar added a comment. Cheers for working on this @kmclaughlin ! Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:1407 case AArch64ISD::PTRUE: return "AArch64ISD::PTRUE"; + case AArch64ISD::LD1RQ: return "AArch64ISD::LD1RQ"; case AArch

[PATCH] D77048: [Clang][CodeGen] Fixing mismatch between memory layout and const expressions for oversized bitfields

This revision was automatically updated to reflect the committed changes. Closed by commit rGe6cb4b659af9: [Clang][CodeGen] Fixing mismatch between memory layout and const expressions… (authored by pratlucas). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D77150: [Analyzer] New Option for ContainerModeling: AggressiveEraseModeling

Szelethus added a comment. Some tests would be appreciated, It really helps me understand whats going on. Comment at: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td:620-624 + "AggressiveEraseModeling", + "Enables exploration of the pas

[PATCH] D77150: [Analyzer] New Option for ContainerModeling: AggressiveEraseModeling

Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/ContainerModeling.cpp:692-699 + std::tie(StateEnd, StateNotEnd) = State->assume(*RetEnd); + if (StateEnd) { +C.addTransition(StateEnd); + } + if (StateNo

[PATCH] D76510: [analyzer] Change the default output type to PD_TEXT_MINIMAL in the frontend, error if an output loc is missing for PathDiagConsumers that need it

Szelethus marked an inline comment as done. Szelethus added a comment. Lets highlight then that this change affects the analyzer in **frontend** mode, not in the **driver** configuration. I might make a patch for that too, btw. @NoQ, were you able to check whether **this** change could break any

[clang] 9da6a40 - [OpenCL] Add sub-group builtin functions

Author: Sven van Haastregt Date: 2020-04-02T13:18:56+01:00 New Revision: 9da6a40e0999523f8bdabfdab875890770eb9b3a URL: https://github.com/llvm/llvm-project/commit/9da6a40e0999523f8bdabfdab875890770eb9b3a DIFF: https://github.com/llvm/llvm-project/commit/9da6a40e0999523f8bdabfdab875890770eb9b3a.

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

sepavloff added inline comments. Comment at: clang/include/clang/Basic/LangOptions.h:394 + return true; + } + erichkeane wrote: > rjmccall wrote: > > erichkeane wrote: > > > rjmccall wrote: > > > > rjmccall wrote: > > > > > erichkeane wrote: > > > > > > rjmc

[clang] 13a1504 - [OPENMP50]Add initial support for OpenMP 5.0 iterator.

Author: Alexey Bataev Date: 2020-04-02T08:28:15-04:00 New Revision: 13a1504ffb9a9a4f82dc1b60d9e8cbb173c7d030 URL: https://github.com/llvm/llvm-project/commit/13a1504ffb9a9a4f82dc1b60d9e8cbb173c7d030 DIFF: https://github.com/llvm/llvm-project/commit/13a1504ffb9a9a4f82dc1b60d9e8cbb173c7d030.diff

[PATCH] D76790: [analyzer] StdLibraryFunctionsChecker: fix bug with arg constraints

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. Yup, looks great, sorry for the slack! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76790/new/ https://reviews.llvm.org/D76790 ___

[PATCH] D77125: [Analyzer] Model return values of container insert and delete operations

martong added a comment. In D77125#1955245 , @baloghadamsoftware wrote: > In D77125#1952769 , @martong wrote: > > > It seems like we could model here `emplace` and `emplace_after` exactly the > > same way we do wi

[PATCH] D76612: [Matrix] Add draft specification for matrix support in Clang.

fhahn updated this revision to Diff 254505. fhahn added a comment. Update arithmetic conversion rules after recent discussion on cfe-dev. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76612/new/ https://reviews.llvm.org/D76612 Files: clang/docs/

[PATCH] D77074: [FPEnv][AArch64] Platform-specific builtin constrained FP enablement

kpn marked an inline comment as done. kpn added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:8486-8492 + return Builder.CreateConstrainedFPCall( + F, + {EmitScalarExpr(E->getArg(1)), EmitScalarExpr(E->getArg(2)), Ops[0]}); +} else { +

[PATCH] D77244: sancov/inline-bool-flag feature + tests + docs.

pratyai updated this revision to Diff 254509. pratyai added a comment. Added the alignment for i1 as a special case. Also the inline-bool-flag.ll test had to be changed with it. PTAL if I am missing something; I did not expect it to be much diffrerent than inline-8bit-counters.ll, but evidently

[PATCH] D77244: sancov/inline-bool-flag feature + tests + docs.

pratyai updated this revision to Diff 254508. pratyai added a comment. Added the alignment for i1 as a special case. Also the inline-bool-flag.ll test had to be changed with it. PTAL if I am missing something; I did not expect it to be much diffrerent than inline-8bit-counters.ll, but evidently

[PATCH] D75181: [AArch64] Handle BTI/PAC in case of generated functions.

danielkiss marked an inline comment as done. danielkiss added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:5149-5152 + if (BPI.BranchTargetEnforcement) +Fn->addFnAttr("branch-target-enforcement", "true"); + else +Fn->addF

[PATCH] D77305: [Analyzer][VLASize] Support multi-dimensional arrays.

balazske created this revision. Herald added subscribers: cfe-commits, ASDenysPetrov, martong, Charusso, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a project: clang. Check the size

[clang] 54d0a55 - Fix several typos in the attribute documentation.

Author: Aaron Ballman Date: 2020-04-02T10:31:39-04:00 New Revision: 54d0a55d7fb9b5269c637a41f73be7bf385570d6 URL: https://github.com/llvm/llvm-project/commit/54d0a55d7fb9b5269c637a41f73be7bf385570d6 DIFF: https://github.com/llvm/llvm-project/commit/54d0a55d7fb9b5269c637a41f73be7bf385570d6.diff

[PATCH] D76932: [AIX] emit .extern and .weak directive linkage

jasonliu added inline comments. Comment at: llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp:1486 // Emit visibility info for declarations for (const Function &F : M) { Comment should change to something similar to: `Emit linkage(XCOFF) and visibility info for

[PATCH] D76125: [clangd] Decouple preambleworker from astworker, NFCI

kadircet updated this revision to Diff 254516. kadircet added a comment. - Start preambleworker in sync mode instead of blocking Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76125/new/ https://reviews.llvm.org/D76125 Files: clang-tools-extra/cl

[PATCH] D76304: [clangd] Update TUStatus api to accommodate preamble thread

kadircet updated this revision to Diff 254519. kadircet added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76304/new/ https://reviews.llvm.org/D76304 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp clang-tools-extra/cl

[PATCH] D59321: AMDGPU: Teach toolchain to link rocm device libs

hliao added a comment. In D59321#1955646 , @arsenm wrote: > In D59321#1955405 , @hliao wrote: > > > Do we have a better way to avoid adding those empty bitcode files? > > > No, we need the files to exist for tests.

[PATCH] D76725: [clangd] Build ASTs only with fresh preambles or after building a new preamble

kadircet updated this revision to Diff 254520. kadircet added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76725/new/ https://reviews.llvm.org/D76725 Files: clang-tools-extra/clangd/Preamble.cpp clang-tools-extra/clangd/Pr

[clang-tools-extra] da8eda1 - [clangd] Get rid of redundant make_uniques

Author: Kadir Cetinkaya Date: 2020-04-02T16:52:13+02:00 New Revision: da8eda1ab1ae97115f9ed170216ed89b69662578 URL: https://github.com/llvm/llvm-project/commit/da8eda1ab1ae97115f9ed170216ed89b69662578 DIFF: https://github.com/llvm/llvm-project/commit/da8eda1ab1ae97115f9ed170216ed89b69662578.dif

[clang] 1525232 - [analyzer] StdLibraryFunctionsChecker: fix bug with arg constraints

Author: Gabor Marton Date: 2020-04-02T17:00:11+02:00 New Revision: 1525232e276153e325a49372894ae52ed07351a5 URL: https://github.com/llvm/llvm-project/commit/1525232e276153e325a49372894ae52ed07351a5 DIFF: https://github.com/llvm/llvm-project/commit/1525232e276153e325a49372894ae52ed07351a5.diff

[PATCH] D77309: [clangd] Get rid of ASTWorker::getCurrentFileInputs

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, javed.absar, ilya-biryukov. Herald added a project: clang. kadircet added a parent revision: D76725: [clangd] Build ASTs only with fresh preambles or

[PATCH] D77041: [AST] Fix a crash on invalid constexpr Ctorinitializer when building RecoveryExpr.

hokein updated this revision to Diff 254525. hokein added a comment. remove accident change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77041/new/ https://reviews.llvm.org/D77041 Files: clang/lib/AST/ExprConstant.cpp clang/test/SemaCXX/inva

[PATCH] D76932: [AIX] emit .extern and .weak directive linkage

jasonliu added inline comments. Comment at: llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp:407 case GlobalValue::WeakAnyLinkage: case GlobalValue::WeakODRLinkage: if (MAI->hasWeakDefDirective()) { Could we verify if these Linkage should also always emit .w

[PATCH] D77311: clang-format: [JS] detect C++ keywords.

mprobst created this revision. mprobst added a reviewer: krasimir. Herald added subscribers: cfe-commits, jfb. Herald added a project: clang. C++ defines a number of keywords that are regular identifiers in JavaScript, e.g. `concept`: const concept = 1; // legit JS This change expands the exis

[PATCH] D76790: [analyzer] StdLibraryFunctionsChecker: fix bug with arg constraints

This revision was automatically updated to reflect the committed changes. Closed by commit rG1525232e2761: [analyzer] StdLibraryFunctionsChecker: fix bug with arg constraints (authored by martong). Changed prior to commit: https://reviews.llvm.org/D76790?vs=253595&id=254530#toc Repository: r

[clang-tools-extra] 24bb2d1 - [clangd] Add a tweak for adding "using" statement.

Author: Adam Czachorowski Date: 2020-04-02T17:37:38+02:00 New Revision: 24bb2d1e776897c3a93856d2ca76decb4cfd0562 URL: https://github.com/llvm/llvm-project/commit/24bb2d1e776897c3a93856d2ca76decb4cfd0562 DIFF: https://github.com/llvm/llvm-project/commit/24bb2d1e776897c3a93856d2ca76decb4cfd0562.d

[clang-tools-extra] fc83010 - [clangd] Don't send semanticHighlights to clients that support semanticTokens.

Author: Sam McCall Date: 2020-04-02T17:38:02+02:00 New Revision: fc830106e15553fcca3fc80066fe5a988e16dfec URL: https://github.com/llvm/llvm-project/commit/fc830106e15553fcca3fc80066fe5a988e16dfec DIFF: https://github.com/llvm/llvm-project/commit/fc830106e15553fcca3fc80066fe5a988e16dfec.diff LO

[PATCH] D77313: [AST] Allow VectorTypes of 1-256 elements, and powers of two up to 2**31.

sammccall created this revision. sammccall added reviewers: hokein, rjmccall, erichkeane. Herald added a project: clang. Herald added a subscriber: cfe-commits. This used to be 1-2043 elements, and recently regressed to a limit of 1023. The new behavior is an almost-superset of GCC, which accepts

[PATCH] D77311: clang-format: [JS] detect C++ keywords.

jfb added a comment. Some of these are technically "future reserved keywords": https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Lexical_grammar#Keywords Wouldn't it be better to list all of JS's keywords at this point? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

aykevl added a comment. I have the same issue as @wenju. The second time I call `ExecuteCompilerInvocation` it will give the error above, leading me to believe some memory isn't properly cleared. Note: the `--pgo-warn-misexpect` option is not passed in the compiler invocation. Repository:

[clang-tools-extra] 9e3063e - [clangd] Support textDocument/semanticTokens/edits

Author: Sam McCall Date: 2020-04-02T17:38:29+02:00 New Revision: 9e3063eaceec5054684a77acf5281772df2a7f73 URL: https://github.com/llvm/llvm-project/commit/9e3063eaceec5054684a77acf5281772df2a7f73 DIFF: https://github.com/llvm/llvm-project/commit/9e3063eaceec5054684a77acf5281772df2a7f73.diff LO

[PATCH] D76432: [clangd] Add a tweak for adding "using" statement.

This revision was automatically updated to reflect the committed changes. Closed by commit rG24bb2d1e7768: [clangd] Add a tweak for adding "using" statement. (authored by adamcz, committed by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D77225: [clangd] Support textDocument/semanticTokens/edits

This revision was automatically updated to reflect the committed changes. Closed by commit rG9e3063eaceec: [clangd] Support textDocument/semanticTokens/edits (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D77225?vs=254226&id=254536#toc Repository: rG LLVM Github M

[PATCH] D77206: [clangd] Don't send semanticHighlights to clients that support semanticTokens.

This revision was automatically updated to reflect the committed changes. Closed by commit rGfc830106e155: [clangd] Don't send semanticHighlights to clients that support semanticTokens. (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D77240: [CUDA] Add missing cmath overloads

jdoerfert added a comment. I just noticed those as well. I forgot to put the new definitions into the forward declare header. Will do it in a second. The OpenMP math overlay doesn't have one so I forgot :( Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D77028: [NFC] Refactor DeferredDiagsEmitter and skip redundant visit

yaxunl added inline comments. Comment at: clang/lib/Sema/Sema.cpp:1508 void checkFunc(SourceLocation Loc, FunctionDecl *FD) { +auto DiagsCountIt = DiagsCount.find(FD); FunctionDecl *Caller = UseStack.empty() ? nullptr : UseStack.back(); rjmccall wrote

[PATCH] D76679: [SveEmitter] Add more immediate operand checks.

SjoerdMeijer accepted this revision. SjoerdMeijer added a comment. This revision is now accepted and ready to land. I think the float16 discussion is an interesting one, but doesn't necessarily need to be done here. I am asking some questions offline, but if we ever come to a different opinion o

[PATCH] D77028: [NFC] Refactor DeferredDiagsEmitter and skip redundant visit

yaxunl updated this revision to Diff 254537. yaxunl marked 2 inline comments as done. yaxunl added a comment. Herald added a reviewer: jdoerfert. added comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77028/new/ https://reviews.llvm.org/D77028 Files: clang/include/clang/Sema/Se

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

rjmccall added inline comments. Comment at: clang/include/clang/Basic/LangOptions.h:394 + return true; + } + sepavloff wrote: > erichkeane wrote: > > rjmccall wrote: > > > erichkeane wrote: > > > > rjmccall wrote: > > > > > rjmccall wrote: > > > > > > erichk

[PATCH] D76140: [InlineFunction] update attributes during inlining

reames accepted this revision. reames added a comment. This revision is now accepted and ready to land. LGTM again, with minor change. p.s. Sorry for missing the functional issue the first time. All of the test changes should have made the issue obvious, but despite reading the LangRef descrip

[PATCH] D75917: Expose llvm fence instruction as clang intrinsic

b-sumner added a comment. Please go ahead and update to a string for the scope. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75917/new/ https://reviews.llvm.org/D75917 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

xbolva00 added a comment. Fix is easy, can you commit it as obvious? Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66324/new/ https://reviews.llvm.org/D66324 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D75788: [OpenMP] Provide math functions in OpenMP device code via OpenMP variants

ye-luo accepted this revision. ye-luo added a comment. This revision is now accepted and ready to land. Good work. I verified that PR42798 and PR42799 are fixed by this. Tests are completed on Ubuntu 18.04. Clang now becomes usable for application developers. There are still issues on RHEL that o

[PATCH] D75184: [clang-tidy] Optional inheritance of file configs from parent directories 

DmitryPolukhin added a comment. @alexfh friendly ping I implemented solution with priorities to resolve your concerns about `get()` vs `getLocalOrGlobal()` Could you please take another look to this diff? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D77240: [CUDA] Add missing cmath overloads

tra added a comment. In D77240#1957386 , @jdoerfert wrote: > I just noticed those as well. I forgot to put the new definitions into the > forward declare header. Will do it in a second. The OpenMP math overlay > doesn't have one so I forgot :( I'm not

[PATCH] D76594: [clang][AST] Support AST files larger than 512M

DmitryPolukhin added a comment. @rsmith, @dexonsmith, @jdoerfert could you please take a look to this diff? If you think that there are other reviewers who might have more context AST persistence, please add them. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D77028: [NFC] Refactor DeferredDiagsEmitter and skip redundant visit

rjmccall added inline comments. Comment at: clang/lib/Sema/Sema.cpp:1508 void checkFunc(SourceLocation Loc, FunctionDecl *FD) { +auto DiagsCountIt = DiagsCount.find(FD); FunctionDecl *Caller = UseStack.empty() ? nullptr : UseStack.back(); yaxunl wrote

[PATCH] D77240: [CUDA] Add missing cmath overloads

jdoerfert abandoned this revision. jdoerfert added a comment. In D77240#1957468 , @tra wrote: > In D77240#1957386 , @jdoerfert wrote: > > > I just noticed those as well. I forgot to put the new definitions into the

[PATCH] D77085: [clang-tidy] Added support for validating configuration options

njames93 updated this revision to Diff 254552. njames93 added a comment. - Small refactor Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77085/new/ https://reviews.llvm.org/D77085 Files: clang-tools-extra/clang-tidy/ClangTidyCheck.cpp clang-too

[PATCH] D76140: [InlineFunction] update attributes during inlining

anna added a comment. In D76140#1957416 , @reames wrote: > LGTM again, with minor change. will update it. > p.s. Sorry for missing the functional issue the first time. All of the test > changes should have made the issue obvious, but despite reading t

[PATCH] D77311: clang-format: [JS] detect C++ keywords.

krasimir added a comment. In D77311#1957367 , @jfb wrote: > Some of these are technically "future reserved keywords": > https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Lexical_grammar#Keywords > > Wouldn't it be better to list all of JS'

[PATCH] D77054: [AArch64][SVE] Add SVE intrinsics for saturating add & subtract

kmclaughlin updated this revision to Diff 254558. kmclaughlin added a comment. Added patterns to AArch64SVEInstrInfo.td to support llvm.[s|u]add & llvm.[s|u]sub again, which was removed by my previous patch CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77054/new/ https://reviews.llvm.o

[PATCH] D70555: [coroutines] Don't build promise init with no args

modocache added a comment. Of course, your approval is very welcome! 😄 I'll go ahead and land this today, thanks for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70555/new/ https://reviews.llvm.org/D70555 __

[PATCH] D75788: [OpenMP] Provide math functions in OpenMP device code via OpenMP variants

ye-luo added a comment. My RHEL issue was caused by a CPLUS_INCLUDE_PATH environment variable. So this is feature not a bug. After removing it, everything works smoothly for me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75788/new/ https://revi

[libunwind] 71fbd6e - Exit unwinding early when at the top of the stack and additional info won't be found.

Author: Sterling Augustine Date: 2020-04-02T10:52:25-07:00 New Revision: 71fbd6e40632f437049215904c28ad9d63cff4bc URL: https://github.com/llvm/llvm-project/commit/71fbd6e40632f437049215904c28ad9d63cff4bc DIFF: https://github.com/llvm/llvm-project/commit/71fbd6e40632f437049215904c28ad9d63cff4bc.

[clang] fb80b6b - Make it possible for lit.site.cfg to contain relative paths, and use it for llvm and clang

Author: Nico Weber Date: 2020-04-02T13:53:16-04:00 New Revision: fb80b6b2d58c476747a3206bd4371b787108591b URL: https://github.com/llvm/llvm-project/commit/fb80b6b2d58c476747a3206bd4371b787108591b DIFF: https://github.com/llvm/llvm-project/commit/fb80b6b2d58c476747a3206bd4371b787108591b.diff LO

[PATCH] D77313: [AST] Allow VectorTypes of 1-256 elements, and powers of two up to 2**31.

efriedma added a comment. I think I would rather just pay the extra 8 bytes per VectorType, and expand this to support all vector types supported by LLVM. It's not like we allocate enough VectorTypes for it to matter, anyway. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D77257: Clean up usages of asserting vector getters in Type

ctetreau updated this revision to Diff 254570. ctetreau added a comment. Note that this is NFC Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77257/new/ https://reviews.llvm.org/D77257 Files: clang/lib/CodeGen/CGAtomic.cpp clang/lib/CodeGen/CGB

[PATCH] D77184: Make it possible for lit.site.cfg to contain relative paths, and use it for llvm and clang

This revision was automatically updated to reflect the committed changes. Closed by commit rGfb80b6b2d58c: Make it possible for lit.site.cfg to contain relative paths, and use it for… (authored by thakis). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to com

[PATCH] D76140: [InlineFunction] update attributes during inlining

This revision was automatically updated to reflect the committed changes. Closed by commit rGbf7a16a76871: [InlineFunction] Update valid return attributes at callsite within callee body (authored by anna). Changed prior to commit: https://reviews.llvm.org/D76140?vs=254222&id=254573#toc Reposit

[PATCH] D72959: Relative VTables ABI on Fuchsia

mcgrathr added inline comments. Comment at: libcxxabi/src/private_typeinfo.cpp:617 // Get (dynamic_ptr, dynamic_type) from static_ptr +#ifndef __Fuchsia__ void **vtable = *static_cast(static_ptr); ldionne wrote: > Please introduce a macro that generical

[PATCH] D72872: [ObjC generics] Fix not inheriting type bounds in categories/extensions.

erik.pilkington accepted this revision. erik.pilkington added a comment. This revision is now accepted and ready to land. LGTM, sorry for the delay in reviewing this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72872/new/ https://reviews.llvm.org

  1   2   >