[clang] 7339fca - Revert "Convert a reachable llvm_unreachable into an assert."

Author: Aaron Ballman Date: 2020-03-24T16:06:14-04:00 New Revision: 7339fca25facb566e969b6ce01f23ac96499d574 URL: https://github.com/llvm/llvm-project/commit/7339fca25facb566e969b6ce01f23ac96499d574 DIFF: https://github.com/llvm/llvm-project/commit/7339fca25facb566e969b6ce01f23ac96499d574.diff

Re: [clang] 4a0267e - Convert a reachable llvm_unreachable into an assert.

Thank you for the discussion on IRC about this topic. For reference, this generated https://reviews.llvm.org/D76721 to clarify the documentation. I've also reverted the change in this thread in commit 7339fca25facb566e969b6ce01f23ac96499d574, so we're back to llvm_unreachable in this case. ~Aaron

[PATCH] D76130: [PPC][AIX] Implement variadic function handling in LowerFormalArguments_AIX

jasonliu added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:7091 + +static const MCPhysReg Gpr_32[] = {PPC::R3, PPC::R4, PPC::R5, PPC::R6, + PPC::R7, PPC::R8, PPC::R9, PPC::R10}; I'd prefer us

[PATCH] D75034: [clang-format] use spaces for alignment with UT_ForContinuationAndIndentation

fickert added a comment. In D75034#1938626 , @MyDeveloperDay wrote: > is there overlap here D76197: clang-format: Use block indentation for braced > initializations I think these changes are unrelated. CHANGES SINCE

[PATCH] D76679: [SveEmitter] Add more immediate operand checks.

SjoerdMeijer added inline comments. Comment at: clang/test/CodeGen/aarch64-sve-intrinsics/negative/acle_sve_ext.c:1 +// RUN: %clang_cc1 -triple aarch64-none-linux-gnu -target-feature +sve -fallow-half-arguments-and-returns -fsyntax-only -verify -D__ARM_FEATURE_SVE %s + -

[PATCH] D76678: [SveEmitter] Add range checks for immediates and predicate patterns.

SjoerdMeijer added a comment. Did a first scan, looks very reasonable, just some first nits/questions inlined. Comment at: clang/include/clang/Basic/arm_sve.td:153 +} +def ImmCheckPredicatePattern: ImmCheckType<0>; // 0..31 +def ImmCheck1_16: ImmCheckType<1

[PATCH] D76360: [PPC][AIX] Emit correct Vaarg for 32BIT-AIX in clang

jasonliu added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:4205 -CharUnits PPC32_SVR4_ABIInfo::getParamTypeAlignment(QualType Ty) const { +CharUnits PowerPC32ABIInfo::getParamTypeAlignment(QualType Ty) const { // Complex types are passed just like their ele

[PATCH] D76606: [clang-tidy] Warn on invalid "case" configurations for readability-identifier-naming

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp:149-151 +auto CaseOptionName = (Name + "Case").str(); +auto CaseValue = Options.get(CaseOptionName, ""); +auto const caseOptional = fromString(CaseValu

[PATCH] D74183: [IRGen] Add an alignment attribute to underaligned sret parameters

nikic added a comment. For the record, this change caused an 1.5% compile-time regression on tramp3d-v4 (http://llvm-compile-time-tracker.com/compare.php?from=43a6d285bfead762ac472a6e62beedc9f88bce89&to=de98cf92e301ab559a7417f1eca5cfa53624c9e1&stat=instructions). As there was also a 0.9% increa

[clang] 4f4e687 - [test][clang][driver] Add required features.

Author: Michael Liao Date: 2020-03-24T17:08:21-04:00 New Revision: 4f4e68799fd55c7023e685161de6f6bb1ada16d5 URL: https://github.com/llvm/llvm-project/commit/4f4e68799fd55c7023e685161de6f6bb1ada16d5 DIFF: https://github.com/llvm/llvm-project/commit/4f4e68799fd55c7023e685161de6f6bb1ada16d5.diff

[PATCH] D76678: [SveEmitter] Add range checks for immediates and predicate patterns.

efriedma added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:7571 + else if (Builtin->LLVMIntrinsic != 0) { +llvm::Type* OverloadedTy = getSVEType(TypeFlags); + I'm not sure why you need a second way to convert SVE types separate from Convert

[clang] 3f1defa - [clang codegen] Clean up handling of vectors with trivial-auto-var-init.

Author: Eli Friedman Date: 2020-03-24T14:34:40-07:00 New Revision: 3f1defa6e2dfdea2a5980083de2b04068f640023 URL: https://github.com/llvm/llvm-project/commit/3f1defa6e2dfdea2a5980083de2b04068f640023 DIFF: https://github.com/llvm/llvm-project/commit/3f1defa6e2dfdea2a5980083de2b04068f640023.diff

Re: [clang] 4a0267e - Convert a reachable llvm_unreachable into an assert.

Thanks again for talking it through & the documentation update - it's a great reference point to keep in mind for future reviews, etc. On Tue, Mar 24, 2020 at 1:08 PM Aaron Ballman wrote: > Thank you for the discussion on IRC about this topic. For reference, > this generated https://reviews.llvm

[PATCH] D75661: Remove SequentialType from the type heirarchy.

efriedma updated this revision to Diff 252432. efriedma edited the summary of this revision. efriedma added a comment. Rebased. (CGDecl.cpp changes landed separately.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75661/new/ https://reviews.llvm.or

[PATCH] D76606: [clang-tidy] Warn on invalid "case" configurations for readability-identifier-naming

njames93 marked 3 inline comments as done. njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp:149-151 +auto CaseOptionName = (Name + "Case").str(); +auto CaseValue = Options.get(CaseOptionName, ""); +auto co

[PATCH] D76528: [clang codegen] Clean up handling of vectors with trivial-auto-var-init.

This revision was automatically updated to reflect the committed changes. Closed by commit rG3f1defa6e2df: [clang codegen] Clean up handling of vectors with trivial-auto-var-init. (authored by efriedma). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D76360: [PPC][AIX] Emit correct Vaarg for 32BIT-AIX in clang

sfertile added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:4205 -CharUnits PPC32_SVR4_ABIInfo::getParamTypeAlignment(QualType Ty) const { +CharUnits PowerPC32ABIInfo::getParamTypeAlignment(QualType Ty) const { // Complex types are passed just like their ele

[PATCH] D75779: [OpenMP] `omp begin/end declare variant` - part 2, sema (+"CG")

hfinkel added inline comments. Comment at: clang/include/clang/Basic/DiagnosticParseKinds.td:1253 +: Error<"expected '#pragma omp begin declare variant' to match this stray " +"`#pragma omp end delcare variant`">; def err_omp_declare_target_unexpected_clause: Err

[PATCH] D76062: [PATCH] [ARM] ARMv8.6-a command-line + BFloat16 Asm Support

stuij added a comment. after back-and-forth with Sjoerd, added sve and bf16+sve driver tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76062/new/ https://reviews.llvm.org/D76062 ___ cfe-commits mai

[PATCH] D76062: [PATCH] [ARM] ARMv8.6-a command-line + BFloat16 Asm Support

stuij updated this revision to Diff 252443. stuij added a comment. adding sve and bf16+sve driver tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76062/new/ https://reviews.llvm.org/D76062 Files: clang/lib/Basic/Targets/AArch64.cpp clang/l

[PATCH] D76690: [AST][SVE] Treat built-in SVE types as POD

rsandifo-arm marked an inline comment as done. rsandifo-arm added inline comments. Comment at: clang/lib/AST/Type.cpp:2515 + if (BaseTy->isSizelessBuiltinType()) +return true; + efriedma wrote: > Can you rearrange this so isSizelessBuiltinType() is at the bo

[PATCH] D76693: [Sema][SVE] Allow ?: to select between SVE types in C

rsandifo-arm added a comment. In D76693#1939866 , @efriedma wrote: > Do we want to allow stuff like `x ? (svint8_t)0 : (signed char)0` `(svint8_t)0` is invalid as thing stand. The intention is for the types to be opaque and only used via intrinsics, ra

[PATCH] D76694: [Sema][SVE] Allow casting SVE types to themselves in C

rsandifo-arm added a comment. In D76694#1939863 , @efriedma wrote: > Is it not legal to cast an SVE type to any type other than itself? Not in normal length-agnostic mode. Instead we provide reinterpret intrinsics for type changes that are supposed to

[PATCH] D76725: [clangd] Build ASTs only with fresh preambles or after building a new preamble

sammccall added a comment. So I think we need a careful description of the new model somewhere. Not so much on specific changes/constraints parts of the code operate under, but what it's trying to do. My best understanding is: - In general, read requests are processed in order by the ASTWorker

[PATCH] D31130: B32239 clang-tidy should not warn about array to pointer decay on system macros

brenoguim added a comment. Hey, I'm back. I actually kind of forgot about this. Unfortunately I cannot to continue the patch soon. How do I grant you full rights on this patch? If just saying here is enough, there you go, anyone can take it and change it. If there is more bureaucracy to it, jus

[PATCH] D31130: B32239 clang-tidy should not warn about array to pointer decay on system macros

brenoguim added a comment. Oh, and if I remember correctly, the reason for this patch was to avoid exactly the github issue mentioned here. I'm embarrassed I didn't explain that anywhere :( CHANGES SINCE LAST ACTION https://reviews.llvm.org/D31130/new/ https://reviews.llvm.org/D31130 ___

[PATCH] D76741: [clangd] Support multiple cursors in selectionRange.

sammccall created this revision. sammccall added a reviewer: usaxena95. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. One change: because there's no way to signal failure individually for each cursor, we now "succeed" wi

[clang] dca920a - Allow remapping Clang module include paths

Author: Adrian Prantl Date: 2020-03-24T17:14:27-07:00 New Revision: dca920a904c27f4c86e909ef2e4e343d48168cca URL: https://github.com/llvm/llvm-project/commit/dca920a904c27f4c86e909ef2e4e343d48168cca DIFF: https://github.com/llvm/llvm-project/commit/dca920a904c27f4c86e909ef2e4e343d48168cca.diff

[PATCH] D76385: Allow remapping Clang module include paths

This revision was automatically updated to reflect the committed changes. Closed by commit rGdca920a904c2: Allow remapping Clang module include paths (authored by aprantl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[clang] c025235 - Revert "Allow remapping Clang module include paths"

Author: Adrian Prantl Date: 2020-03-24T17:57:34-07:00 New Revision: c025235e962e2cec58e47a572eac3f88a55f3a1e URL: https://github.com/llvm/llvm-project/commit/c025235e962e2cec58e47a572eac3f88a55f3a1e DIFF: https://github.com/llvm/llvm-project/commit/c025235e962e2cec58e47a572eac3f88a55f3a1e.diff

[PATCH] D75791: [clang-format] Added new option IndentExternBlock

MarcusJohnson91 marked an inline comment as done. MarcusJohnson91 added a comment. Restored all the test function names to foo(). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75791/new/ https://reviews.llvm.org/D75791 ___ cfe-commits maili

[PATCH] D75791: [clang-format] Added new option IndentExternBlock

MarcusJohnson91 added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:31 +class FormatTest +: public ::testing::Test { // FormatTest is a Fixture, data is reused protected: MyDeveloperDay wrote: > is this comment necessary? Removed the com

[PATCH] D76385: Allow remapping Clang module include paths

aprantl added a comment. Herald added a subscriber: ormris. I had to revert this because it unexpectedly broke the "expr -- @import Module" test in LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76385/new/ https://reviews.llvm.org/D76385 _

[PATCH] D75791: [clang-format] Added new option IndentExternBlock

MarcusJohnson91 updated this revision to Diff 252466. MarcusJohnson91 marked 4 inline comments as done. MarcusJohnson91 added a comment. Implemented @MyDeveloperDay's suggestion to simplify the if/else statements. Removed all the test changes except one: That's because the BraceWrapping.AfterExt

[PATCH] D76385: Allow remapping Clang module include paths

aprantl added a comment. I'll update this with either a fix in clang or a patch to lldb once I figured out what happened. http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/13054/testReport/junit/lldb-api/lang_cpp_modules-import/TestCXXModulesImport_py/ Repository: rG LLVM Github Monor

[PATCH] D76365: [cuda][hip] Add CUDA builtin surface/texture reference support.

hliao updated this revision to Diff 252468. hliao marked an inline comment as done. hliao added a comment. Add Sema checks on CUDA device builtin surface/texture attributes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76365/new/ https://reviews.l

[PATCH] D76211: OpenMP Metadirective with user defined condition

alokmishra.besu updated this revision to Diff 252472. alokmishra.besu marked an inline comment as not done. alokmishra.besu added a comment. Updated the test files Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76211/new/ https://reviews.llvm.org/D7

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

mibintc updated this revision to Diff 252469. mibintc added a comment. I think this addresses all the feedback from @rjmccall Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76384/new/ https://reviews.llvm.org/D76384 Files: clang/include/clang/AST

[PATCH] D76365: [cuda][hip] Add CUDA builtin surface/texture reference support.

hliao marked 6 inline comments as done. hliao added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:701-713 + if (getLangOpts().CUDAIsDevice) { +// As CUDA builtin surface/texture types are replaced, skip generating TBAA +// access info. +if (AccessT

[PATCH] D76744: [clang-tidy] Add check to ensure llvm-libc implementations are defined in correct namespace.

PaulkaToast created this revision. PaulkaToast added a project: clang-tools-extra. Herald added subscribers: cfe-commits, MaskRay, xazax.hun, mgorny. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D76744 Files: clang-tools-extra/clang-tidy/llvmlib

[PATCH] D76694: [Sema][SVE] Allow casting SVE types to themselves in C

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. Okay, then LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76694/new/ https://reviews.llvm.org/D76694 ___

[PATCH] D76693: [Sema][SVE] Allow ?: to select between SVE types in C

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76693/new/ https://reviews.llvm.org/D76693 ___

[PATCH] D76744: [clang-tidy] Add check to ensure llvm-libc implementations are defined in correct namespace.

sivachandra added a comment. Instead of this narrow check, what we really want is a check to ensure that all implementation detail resides in the namespace `__llvm_libc`. Anything outside would be special and requiring a `NOLINT...` for them is reasonable. Have you considered such an approach?

[PATCH] D75779: [OpenMP] `omp begin/end declare variant` - part 2, sema (+"CG")

jdoerfert added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:5396 + IdentifierInfo &VariangtII = Context.Idents.get( + (D.getIdentifier()->getName() + "." + DVScope.NameSuffix).str()); + D.SetIdentifier(&VariangtII, D.getBeginLoc()); hfinkel

[PATCH] D76342: [OpenMP] Implement '#pragma omp tile'

Meinersbur added a comment. ping Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76342/new/ https://reviews.llvm.org/D76342 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman

[PATCH] D76653: [clang] Allow -DDEFAULT_SYSROOT to be a relative path

phosek added a comment. Is this patch up to date? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76653/new/ https://reviews.llvm.org/D76653 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

<    1   2