rsandifo-arm marked an inline comment as done. rsandifo-arm added inline comments.
================ Comment at: clang/lib/AST/Type.cpp:2515 + if (BaseTy->isSizelessBuiltinType()) + return true; + ---------------- efriedma wrote: > Can you rearrange this so isSizelessBuiltinType() is at the bottom? It > should be rare. (Assuming it doesn't need to be before the > isIncompleteType() check.) I should have mentioned that, but yeah: the call is placed here so that it continues to work when/if IsCompleteType returns true for these types. (I have a patch for that, similar to D76221, but I don't know whether it will be acceptable.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76690/new/ https://reviews.llvm.org/D76690 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
