[PATCH] D76229: [clang-tidy] Added PlacementNewStorageCheck

f00kat added a comment. In D76229#1925948 , @lebedev.ri wrote: > In D76229#1925371 , @f00kat wrote: > > > In D76229#1925360 , @lebedev.ri > > wrote: > > > > > This seems to

[PATCH] D75687: [clangd] Only minimally escape text when rendering to markdown.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Comment at: clang-tools-extra/clangd/FormattedString.cpp:150 +// Not a delimiter if surrounded by space. +return !SpaceSurrounds(); + case '-': //

[PATCH] D75446: [clang][Syntax] Handle macro arguments in spelledForExpanded

kadircet added a comment. In D75446#1924496 , @sammccall wrote: > I think per offline discussion, this was going to have some additional docs > clarifying the contracts of this function, and maybe extra tests? > > The conclusion IIRC was that this functio

[PATCH] D74918: Add method to TargetInfo to get CPU cache line size

kristof.beyls added a comment. In D74918#1923151 , @zoecarver wrote: > There are a lot of different ways we could implement the feature. We may want > to only enable it when `-march=native`, or maybe only in the unstable ABI, > and maybe we want to suppo

[PATCH] D75851: [Analyzer][StreamChecker] Added evaluation of fseek.

balazske marked an inline comment as done. balazske added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:470 - // Make the return value accordingly to the error. - State = State->assume(RetVal, (SS->*IsOfError)()); - assert(State && "Return

[clang] d3d8442 - Fix the buildbot error.

Author: Haojian Wu Date: 2020-03-17T09:49:43+01:00 New Revision: d3d844212fc96fb70f77431f0e6a70e0603b0a39 URL: https://github.com/llvm/llvm-project/commit/d3d844212fc96fb70f77431f0e6a70e0603b0a39 DIFF: https://github.com/llvm/llvm-project/commit/d3d844212fc96fb70f77431f0e6a70e0603b0a39.diff LO

[PATCH] D75034: [clang-format] use spaces for alignment with UT_ForContinuationAndIndentation

fickert added a comment. From the original commit, it does seem that this behavior was desired. However, from the name of the option and description in the documentation ("Use tabs only for line continuation and indentation"), I would expect it to use tabs only for indentation and continuation,

[PATCH] D75443: [AST] Unpack FPFeatures bits to BinaryOperator, NFC.

hokein abandoned this revision. hokein added a comment. woo, looks like the `IsOMPStructuredBlock` bit in `Stmt` was removed in https://reviews.llvm.org/rGd5edcb90643104d6911da5c0ff44c4f33fff992f, we can use the bit for `error`, so this patch is not needed anymore. Repository: rG LLVM Github

[PATCH] D73638: [AST] Move dependence computations into a separate file

dnsampaio added inline comments. Comment at: clang/lib/AST/ComputeDependence.cpp:607 + auto D = toExprDependence(E->getType()->getDependence()); + for (auto *E : E->arguments()) +D |= E->getDependence() & ~ExprDependence::Type; I'm impressed this even compi

[PATCH] D76125: [clangd] Decouple preambleworker from astworker, NFCI

kadircet updated this revision to Diff 250705. kadircet marked 2 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76125/new/ https://reviews.llvm.org/D76125 Files: clang-tools-ex

[PATCH] D76125: [clangd] Decouple preambleworker from astworker, NFCI

kadircet marked 16 inline comments as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/TUScheduler.cpp:218 +PreambleRequested.wait(Lock, [this] { return PreambleReq || Done; }); +// No request means we are done. +if (!PreambleReq)

[PATCH] D73638: [AST] Move dependence computations into a separate file

hokein marked an inline comment as done. hokein added inline comments. Comment at: clang/lib/AST/ComputeDependence.cpp:607 + auto D = toExprDependence(E->getType()->getDependence()); + for (auto *E : E->arguments()) +D |= E->getDependence() & ~ExprDependence::Type;

[PATCH] D76272: Fix memtag test.

akuegel created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. akuegel added a reviewer: bkramer. bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. Right, we don't have names for values in release builds

[PATCH] D65591: [AST] Add a flag indicating if any subexpression had errors

hokein updated this revision to Diff 250708. hokein added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65591/new/ https://reviews.llvm.org/D65591 Files: clang/include/clang/AST/ASTDumperUtils.h clang/include/clang/AST/Depend

[PATCH] D75514: [Analyzer] Only add container note tags to the operations of the affected container

baloghadamsoftware marked an inline comment as done. baloghadamsoftware added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/ContainerModeling.cpp:726 +<< Text; +return std::string(Out.str()); + }); NoQ wrote: > I suspect

[PATCH] D76272: Fix memtag test.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. Right, we don't have names for values in release builds. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76272/new/ https://reviews.llvm.org/D76

[clang] 5156e38 - Fix memtag test.

Author: Adrian Kuegel Date: 2020-03-17T11:06:32+01:00 New Revision: 5156e38eb1d3d0ef5bce1fc8491a05f3cfca0f89 URL: https://github.com/llvm/llvm-project/commit/5156e38eb1d3d0ef5bce1fc8491a05f3cfca0f89 DIFF: https://github.com/llvm/llvm-project/commit/5156e38eb1d3d0ef5bce1fc8491a05f3cfca0f89.diff

[PATCH] D76272: Fix memtag test.

This revision was automatically updated to reflect the committed changes. Closed by commit rG5156e38eb1d3: Fix memtag test. (authored by akuegel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76272/new/ https://reviews.llvm.org/D76272 Files: clan

[clang] af64948 - [SVE][Inline-Asm] Add constraints for SVE ACLE types

Author: Kerry McLaughlin Date: 2020-03-17T11:04:19Z New Revision: af64948e2a050d1ef3b7fd314ed07b2a2fe402a5 URL: https://github.com/llvm/llvm-project/commit/af64948e2a050d1ef3b7fd314ed07b2a2fe402a5 DIFF: https://github.com/llvm/llvm-project/commit/af64948e2a050d1ef3b7fd314ed07b2a2fe402a5.diff L

[PATCH] D71746: Fix the "TypeError: a bytes-like object is required, not 'str'" in exploded-graph-rewriter.py on Python 3.5+

germyrinn added a comment. Herald added a subscriber: Charusso. Python makes a clear distinction between bytes and strings . Bytes objects contain raw data — a sequence of octets — whereas strings are Unicode sequences . Conversion between these two types is explicit: you encode a string to get

[PATCH] D76229: [clang-tidy] Added PlacementNewStorageCheck

NoQ added a reviewer: martong. NoQ added a comment. Herald added a subscriber: rnkovacs. First of all, the static analyzer doesn't warn on everything at once; it stops the analysis after a fatal error (such as UB) is found, so it doesn't explore the execution path further. This is the reason why

[PATCH] D76084: [Sema][SVE] Reject subscripts on pointers to sizeless types

This revision was automatically updated to reflect the committed changes. Closed by commit rG010005f0774e: [Sema][SVE] Reject subscripts on pointers to sizeless types (authored by rsandifo-arm). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76084/new

[clang] 010005f - [Sema][SVE] Reject subscripts on pointers to sizeless types

Author: Richard Sandiford Date: 2020-03-17T11:24:57Z New Revision: 010005f0774e13475c321f78b89bdc79eb78d5a5 URL: https://github.com/llvm/llvm-project/commit/010005f0774e13475c321f78b89bdc79eb78d5a5 DIFF: https://github.com/llvm/llvm-project/commit/010005f0774e13475c321f78b89bdc79eb78d5a5.diff

[PATCH] D75690: [SVE][Inline-Asm] Add constraints for SVE ACLE types

This revision was automatically updated to reflect the committed changes. Closed by commit rGaf64948e2a05: [SVE][Inline-Asm] Add constraints for SVE ACLE types (authored by kmclaughlin). Changed prior to commit: https://reviews.llvm.org/D75690?vs=249092&id=250720#toc Repository: rG LLVM Gith

[clang] 94489f3 - [Sema][SVE] Reject arithmetic on pointers to sizeless types

Author: Richard Sandiford Date: 2020-03-17T11:35:20Z New Revision: 94489f35a7f8e16d7fd553ddf96023cb78a2afbb URL: https://github.com/llvm/llvm-project/commit/94489f35a7f8e16d7fd553ddf96023cb78a2afbb DIFF: https://github.com/llvm/llvm-project/commit/94489f35a7f8e16d7fd553ddf96023cb78a2afbb.diff

[clang] 0947296 - [Sema][SVE] Reject sizeless types in exception specs

Author: Richard Sandiford Date: 2020-03-17T11:39:03Z New Revision: 0947296902075aaa240d78f66aa0708f825ffb35 URL: https://github.com/llvm/llvm-project/commit/0947296902075aaa240d78f66aa0708f825ffb35 DIFF: https://github.com/llvm/llvm-project/commit/0947296902075aaa240d78f66aa0708f825ffb35.diff

[clang] c47f971 - [Sema][SVE] Don't allow sizeless objects to be thrown

Author: Richard Sandiford Date: 2020-03-17T11:52:37Z New Revision: c47f971694be0159ffddfee8a75ae515eba91439 URL: https://github.com/llvm/llvm-project/commit/c47f971694be0159ffddfee8a75ae515eba91439 DIFF: https://github.com/llvm/llvm-project/commit/c47f971694be0159ffddfee8a75ae515eba91439.diff

[clang] 72ffb16 - [Sema][SVE] Don't allow sizeless types to be caught

Author: Richard Sandiford Date: 2020-03-17T12:00:16Z New Revision: 72ffb16b4cde972dd3b0b5db98d1702fdcccbc6f URL: https://github.com/llvm/llvm-project/commit/72ffb16b4cde972dd3b0b5db98d1702fdcccbc6f DIFF: https://github.com/llvm/llvm-project/commit/72ffb16b4cde972dd3b0b5db98d1702fdcccbc6f.diff

[PATCH] D73245: Depend stddef.h to provide max_align_t for C++11 and provide better fallback in

krytarowski added inline comments. Comment at: libcxx/include/new:240 return __align > __STDCPP_DEFAULT_NEW_ALIGNMENT__; +#elif defined(_LIBCPP_CXX03_LANG) + return __align > alignment_of<__libcpp_max_align_t>::value; ldionne wrote: > joerg wrote: > > ldionne

[PATCH] D76090: [Sema][SVE] Don't allow sizeless types to be caught

This revision was automatically updated to reflect the committed changes. Closed by commit rG72ffb16b4cde: [Sema][SVE] Don't allow sizeless types to be caught (authored by rsandifo-arm). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76090/new/ https

[PATCH] D74615: [Analyzer] Add visitor to track iterator invalidation

baloghadamsoftware added a comment. In D74615#1923710 , @NoQ wrote: > In D74615#1917289 , @Szelethus wrote: > > > You may have explained it in the summary, and I didn't get it, but why > > isn't putting a `NoteTag`

[PATCH] D76088: [Sema][SVE] Don't allow sizeless objects to be thrown

This revision was automatically updated to reflect the committed changes. Closed by commit rGc47f971694be: [Sema][SVE] Don't allow sizeless objects to be thrown (authored by rsandifo-arm). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76088/new/ htt

[PATCH] D76087: [Sema][SVE] Reject sizeless types in exception specs

This revision was automatically updated to reflect the committed changes. Closed by commit rG094729690207: [Sema][SVE] Reject sizeless types in exception specs (authored by rsandifo-arm). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76087/new/ http

[PATCH] D76086: [Sema][SVE] Reject arithmetic on pointers to sizeless types

This revision was automatically updated to reflect the committed changes. Closed by commit rG94489f35a7f8: [Sema][SVE] Reject arithmetic on pointers to sizeless types (authored by rsandifo-arm). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76086/new

[clang] 4add249 - [AVR] Add support for the -mdouble=x flag

Author: Ayke van Laethem Date: 2020-03-17T13:21:03+01:00 New Revision: 4add24920550beeaed15b24e6427154a58b02e50 URL: https://github.com/llvm/llvm-project/commit/4add24920550beeaed15b24e6427154a58b02e50 DIFF: https://github.com/llvm/llvm-project/commit/4add24920550beeaed15b24e6427154a58b02e50.di

[clang] 506406c - [Sema][SVE] Reject "new" with sizeless types

Author: Richard Sandiford Date: 2020-03-17T12:23:46Z New Revision: 506406c4d59267497d4ac358b49e32b4d2f72119 URL: https://github.com/llvm/llvm-project/commit/506406c4d59267497d4ac358b49e32b4d2f72119 DIFF: https://github.com/llvm/llvm-project/commit/506406c4d59267497d4ac358b49e32b4d2f72119.diff

[clang] c6b8484 - [analyzer] StdLibraryFunctionsChecker refactor w/ inheritance

Author: Gabor Marton Date: 2020-03-17T13:25:32+01:00 New Revision: c6b8484e855bffb0a7da487cd715cef774a46fb1 URL: https://github.com/llvm/llvm-project/commit/c6b8484e855bffb0a7da487cd715cef774a46fb1 DIFF: https://github.com/llvm/llvm-project/commit/c6b8484e855bffb0a7da487cd715cef774a46fb1.diff

[PATCH] D74973: [analyzer] StdLibraryFunctionsChecker refactor w/ inheritance

martong updated this revision to Diff 250732. martong marked 3 inline comments as done. martong added a comment. - Rebase to master - Add comments to ValueConstraint - Add virtual dtor - Add comments to ValueConstraintPtr Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D75687: [clangd] Only minimally escape text when rendering to markdown.

sammccall marked an inline comment as done. sammccall added a comment. Filed https://github.com/google/llvm-premerge-checks/issues/147 for the spurious unit test failure. Comment at: clang-tools-extra/clangd/FormattedString.cpp:150 +// Not a delimiter if surrounded by spac

[PATCH] D75687: [clangd] Only minimally escape text when rendering to markdown.

sammccall updated this revision to Diff 250730. sammccall added a comment. Fix '_' rules. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75687/new/ https://reviews.llvm.org/D75687 Files: clang-tools-extra/clangd/FormattedString.cpp clang-tools-

[PATCH] D76181: [AVR] Add support for the -mdouble=x flag

This revision was automatically updated to reflect the committed changes. Closed by commit rG4add24920550: [AVR] Add support for the -mdouble=x flag (authored by aykevl). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76181/new/ https://reviews.llvm.

[PATCH] D74973: [analyzer] StdLibraryFunctionsChecker refactor w/ inheritance

martong marked 12 inline comments as done. martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:88 typedef uint32_t ArgNo; - static const ArgNo Ret = std::numeric_limits::max(); + static const ArgNo Ret; + --

[PATCH] D76218: [Sema][SVE] Reject "new" with sizeless types

This revision was automatically updated to reflect the committed changes. Closed by commit rG506406c4d592: [Sema][SVE] Reject "new" with sizeless types (authored by rsandifo-arm). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76218/new/ https://revi

[PATCH] D74973: [analyzer] StdLibraryFunctionsChecker refactor w/ inheritance

This revision was automatically updated to reflect the committed changes. Closed by commit rGc6b8484e855b: [analyzer] StdLibraryFunctionsChecker refactor w/ inheritance (authored by martong). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74973/new/

[clang] 4ece6f0 - [Sema][SVE] Reject "delete" with sizeless types

Author: Richard Sandiford Date: 2020-03-17T12:45:00Z New Revision: 4ece6f051bd088fb8d4862bedf590f4f9d86cd17 URL: https://github.com/llvm/llvm-project/commit/4ece6f051bd088fb8d4862bedf590f4f9d86cd17 DIFF: https://github.com/llvm/llvm-project/commit/4ece6f051bd088fb8d4862bedf590f4f9d86cd17.diff

[clang] 211ba00 - [OpenCL] Add pipe and kernel enqueuing builtins

Author: Sven van Haastregt Date: 2020-03-17T13:15:32Z New Revision: 211ba00ce00ff3feb9b1f52ece712e370c184015 URL: https://github.com/llvm/llvm-project/commit/211ba00ce00ff3feb9b1f52ece712e370c184015 DIFF: https://github.com/llvm/llvm-project/commit/211ba00ce00ff3feb9b1f52ece712e370c184015.diff

[PATCH] D76219: [Sema][SVE] Reject "delete" with sizeless types

This revision was automatically updated to reflect the committed changes. Closed by commit rG4ece6f051bd0: [Sema][SVE] Reject "delete" with sizeless types (authored by rsandifo-arm). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76219/new/ https://r

[PATCH] D75579: Replace MCTargetOptionsCommandFlags.inc and CommandFlags.inc by runtime-registration

This revision was automatically updated to reflect the committed changes. Closed by commit rGac1d23ed7de0: Replace MCTargetOptionsCommandFlags.inc and CommandFlags.inc by runtime… (authored by serge-sans-paille). Changed prior to commit: https://reviews.llvm.org/D75579?vs=250631&id=250747#toc

[clang] 0f0564b - [OPENMP50]Initial support for detach clause in task directive.

Author: Alexey Bataev Date: 2020-03-17T09:19:03-04:00 New Revision: 0f0564bb9a3ca4527eb2333eba34643e05c315ca URL: https://github.com/llvm/llvm-project/commit/0f0564bb9a3ca4527eb2333eba34643e05c315ca DIFF: https://github.com/llvm/llvm-project/commit/0f0564bb9a3ca4527eb2333eba34643e05c315ca.diff

[PATCH] D76130: [PPC][AIX] Implement variadic function handling in LowerFormalArguments_AIX in 32-bit mode.

ZarkoCA updated this revision to Diff 250749. ZarkoCA added a comment. - Removed 64BIT support varargs. - Added a fatal error for 64bit varargs on AIX. - Removed 64bit testcases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76130/new/ https://revie

[PATCH] D76229: [clang-tidy] Added PlacementNewStorageCheck

f00kat added a comment. NoQ, I don`t want to say that existing static alalyzer is bad written or something. I just noticed that it does not yet support arrays and alignment. Anyway thank you for your detailed feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[clang] acf6e41 - Purge unused diagnostics. NFC.

Author: Benjamin Kramer Date: 2020-03-17T15:17:10+01:00 New Revision: acf6e4190f401d8da5ab0ff5e350db3c8fb18dfe URL: https://github.com/llvm/llvm-project/commit/acf6e4190f401d8da5ab0ff5e350db3c8fb18dfe DIFF: https://github.com/llvm/llvm-project/commit/acf6e4190f401d8da5ab0ff5e350db3c8fb18dfe.dif

[PATCH] D76283: [IRBuilder] Use preferred target type for len argument of memory intrinsic functions

kschwarz created this revision. kschwarz added reviewers: rjmccall, gchatelet, aemerson. Herald added subscribers: cfe-commits, jfb. Herald added a project: clang. The IR builder hard-coded the type of the `len` argument of the memory function instrinsics to i64 for several builder functions. Du

[PATCH] D69330: [AST] Add RecoveryExpr to retain expressions on semantic errors

hokein updated this revision to Diff 250765. hokein added a comment. Herald added a subscriber: martong. - rebase to master, fix more broken tests - preferType in CodeCompletTest - openMP diagnostics target_update_from_messages.cpp, target_update_to_messages.cpp - RecoveryExpression RValue =>

[PATCH] D76283: [IRBuilder] Use preferred target type for len argument of memory intrinsic functions

lebedev.ri added a comment. So what happens if i manually create such IR, or create such IR without using IRBuilder? It will again compile fine via SelectionDAG and will be miscompiled via GlobalISel, correct? Don't you then want to harden `-verify` to barf on such mismatch, too? Repository:

[PATCH] D74541: [Analyzer] Use note tags to track iterator increments and decrements

baloghadamsoftware marked an inline comment as done. baloghadamsoftware added inline comments. Herald added a subscriber: DenisDvlp. Comment at: clang/lib/StaticAnalyzer/Checkers/IteratorModeling.cpp:489-490 +StringRef ChangeText = + ((Op == OO_Plus || Op == OO_PlusEqual

[PATCH] D75169: [ARM] Enforcing calling convention for half-precision FP arguments and returns for big-endian AArch32

pratlucas added a comment. Hi @rjmccall, I agree those kind of tweaks do not look good. The issue here, though, is that argument coercion currently ignores the target's endian information when performing coercion through memory. This happens for any type that requires memory coercion, so unfortu

[PATCH] D73891: [RISCV] Support experimental/unratified extensions

simoncook updated this revision to Diff 250770. simoncook added a comment. - Update to match latest dependencies - Handle adding "experimental-" to SubtargetFeatures for experimental features Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73891/new/

[PATCH] D71553: [RISCV] Add Clang frontend support for Bitmanip extension

simoncook updated this revision to Diff 250771. simoncook added a comment. Herald added a subscriber: evandro. Rebase on new dependencies Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71553/new/ https://reviews.llvm.org/D71553 Files: clang/lib/B

[PATCH] D76130: [PPC][AIX] Implement variadic function handling in LowerFormalArguments_AIX in 32-bit mode.

ZarkoCA updated this revision to Diff 250772. ZarkoCA added a comment. Removed unrelated changes in aix-cc-abi.ll CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76130/new/ https://reviews.llvm.org/D76130 Files: clang/lib/Basic/Targets/PPC.h clang/lib/CodeGen/TargetInfo.cpp clang/t

[PATCH] D76229: [clang-tidy] Added PlacementNewStorageCheck

NoQ added a comment. Sure np, was just curious^^ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76229/new/ https://reviews.llvm.org/D76229 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[PATCH] D75687: [clangd] Only minimally escape text when rendering to markdown.

kadircet added a comment. thanks, still LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75687/new/ https://reviews.llvm.org/D75687 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

[clang] 60963fa - [HIP] Let clang recognize .hip extension

Author: Yaxun (Sam) Liu Date: 2020-03-17T11:22:55-04:00 New Revision: 60963fa630126f5a4554088e85ddaf8fff286cef URL: https://github.com/llvm/llvm-project/commit/60963fa630126f5a4554088e85ddaf8fff286cef DIFF: https://github.com/llvm/llvm-project/commit/60963fa630126f5a4554088e85ddaf8fff286cef.dif

[PATCH] D76287: [analysis][analyzer] Introduce the skeleton of a reaching definitions calculator

Szelethus created this revision. Szelethus added reviewers: NoQ, xazax.hun, martong, whisperity, rnkovacs, dcoughlin, baloghadamsoftware. Szelethus added a project: clang. Herald added subscribers: cfe-commits, DenisDvlp, steakhal, Charusso, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidor

[PATCH] D71553: [RISCV] Add Clang frontend support for Bitmanip extension

MaskRay added inline comments. Comment at: clang/lib/Basic/Targets/RISCV.cpp:129 + + if (HasB) { +Builder.defineMacro("__riscv_bitmanip"); delete `{}` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71553/new/

[PATCH] D74973: [analyzer] StdLibraryFunctionsChecker refactor w/ inheritance

Szelethus added a comment. Please have my post-commit approval :^) Nice work! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74973/new/ https://reviews.llvm.org/D74973 ___ cfe-commits mailing list cfe-c

[PATCH] D76289: [NFC][Attr TableGen] Emit Spelling Enum for Attr types if there >1

erichkeane created this revision. erichkeane added reviewers: aaron.ballman, rnk. Discovered in a downstream, it is often useful to have slightly different semantics for an attribute based on its namespace, however our spelling infrastructure doesn't consider namespace when deciding to elide the e

[PATCH] D75682: [Analyzer][StreamChecker] Introduction of stream error handling.

Szelethus added a comment. Rght I think I finally get it. You don't want to state split on `feof()` and `ferror()`, but rather on the stream operations! This is why you only want to tell the analyzer what the return value of these functions are going to be, because the state of the stream s

[PATCH] D76039: [HIP] Let clang recognize .hip extension

This revision was automatically updated to reflect the committed changes. Closed by commit rG60963fa63012: [HIP] Let clang recognize .hip extension (authored by yaxunl). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D76039?vs=249816&id=250790#toc Repository:

[PATCH] D76283: [IRBuilder] Use preferred target type for len argument of memory intrinsic functions

kschwarz added a comment. Correct, it will still miscompile even with this change. I see two options: either 1) extend GlobalISel to select to the appropriate type, or 2) declare this as illegal LLVM IR in the first place. 1. will introduce an implicit truncation of the i64 argument (same as Se

[PATCH] D76125: [clangd] Decouple preambleworker from astworker, NFCI

sammccall added a comment. This basically looks good, just nits (mostly about comments, sorry I can't help myself). I think the only real outstanding thing is TUStatus, which we're still discussing offline. Since this patch is intended to be NFC, I see two paths consistent with the spirit of t

[PATCH] D76125: [clangd] Decouple preambleworker from astworker, NFCI

sammccall added a comment. In D76125#1926773 , @sammccall wrote: > I think the only real outstanding thing is TUStatus, which we're still > discussing offline. Since this patch is intended to be NFC, I see two paths > consistent with the spirit of that

[PATCH] D76291: [Support] Fix formatted_raw_ostream for UTF-8

ostannard created this revision. ostannard added reviewers: MaskRay, thakis, hoyFB, benlangmuir. Herald added subscribers: cfe-commits, dexonsmith, hiraditya. Herald added a project: clang. - The getLine and getColumn functions need to update the position, or they will return stale data for buffe

[clang-tools-extra] 704cd4d - [clangd] Only minimally escape text when rendering to markdown.

Author: Sam McCall Date: 2020-03-17T17:10:20+01:00 New Revision: 704cd4d5d0754904361823588f203369c309deca URL: https://github.com/llvm/llvm-project/commit/704cd4d5d0754904361823588f203369c309deca DIFF: https://github.com/llvm/llvm-project/commit/704cd4d5d0754904361823588f203369c309deca.diff LO

[clang] 08ab8c9 - [NFC] Add UsedDeclVisitor

Author: Yaxun (Sam) Liu Date: 2020-03-17T12:12:40-04:00 New Revision: 08ab8c9af4dd27cb306b449edc9a9c50ed11194a URL: https://github.com/llvm/llvm-project/commit/08ab8c9af4dd27cb306b449edc9a9c50ed11194a DIFF: https://github.com/llvm/llvm-project/commit/08ab8c9af4dd27cb306b449edc9a9c50ed11194a.dif

[PATCH] D76289: [NFC][Attr TableGen] Emit Spelling Enum for Attr types if there >1

rnk added inline comments. Comment at: clang/utils/TableGen/ClangAttrEmitter.cpp:2333 -if (!ElideSpelling) - SpellingEnum = CreateSemanticSpellings(Spellings, SemanticToSyntacticMap); -if (Header) I had to call this function during both header and c

[PATCH] D76289: [NFC][Attr TableGen] Emit Spelling Enum for Attr types if there >1

aaron.ballman added a comment. I cannot think of a way to add test coverage for this change, can you? Comment at: clang/utils/TableGen/ClangAttrEmitter.cpp:2332 +if (Header && Spellings.size() > 1) + OS << CreateSemanticSpellings(Spellings, SemanticToSyntacticMap);

[PATCH] D76229: [clang-tidy] Added PlacementNewStorageCheck

Charusso added a comment. In D76229#1925363 , @f00kat wrote: > In D76229#1925268 , @aaron.ballman > wrote: > > > Have you considered making this a static analyzer check as opposed to a > > clang-tidy check? I thin

[PATCH] D75687: [clangd] Only minimally escape text when rendering to markdown.

This revision was automatically updated to reflect the committed changes. Closed by commit rG704cd4d5d075: [clangd] Only minimally escape text when rendering to markdown. (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75687/ne

[PATCH] D76262: [NFC] Add UsedDeclVisitor

This revision was automatically updated to reflect the committed changes. Closed by commit rG08ab8c9af4dd: [NFC] Add UsedDeclVisitor (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76262/new/ https:/

[PATCH] D76295: Use 64 bit integers for bit offsets inside AST file

DmitryPolukhin created this revision. DmitryPolukhin added a project: clang. Herald added subscribers: usaxena95, kadircet, ilya-biryukov. This diff is for discussion how to address problem with large preamble file. 32 bit offsets can be used for PCH/preamble files below 512M. This diff fixes cra

[PATCH] D75175: [CallSiteInfo] Enable the call site info only for -g + optimizations

vsk added a comment. Sorry for the delay here. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:793 Opts.EnableDebugEntryValues = Args.hasArg(OPT_femit_debug_entry_values); +Opts.EmitCallSiteInfo = true; + } djtodoro wrote: > vsk wrote: > > I don

[PATCH] D75682: [Analyzer][StreamChecker] Introduction of stream error handling.

balazske added a comment. In D75682#1926732 , @Szelethus wrote: > Rght I think I finally get it. You don't want to state split on `feof()` > and `ferror()`, but rather on the stream operations! Yes the split is at the operations. I did not think eve

[PATCH] D76296: [ARM,CDE] Implement GPR CDE intrinsics

miyuki created this revision. miyuki added reviewers: simon_tatham, MarkMurrayARM, dmgreen, ostannard. Herald added subscribers: cfe-commits, danielkiss, hiraditya, kristof.beyls. Herald added a project: clang. miyuki added a parent revision: D76298: [ARM,CDE] Implement CDE S and D-register intrin

[PATCH] D76297: [clang][AArch64] readd support for 'p' inline asm constraint

nickdesaulniers created this revision. nickdesaulniers added a reviewer: eli.friedman. Herald added subscribers: cfe-commits, kristof.beyls. Herald added a project: clang. nickdesaulniers marked an inline comment as done. sdesmalen accepted this revision. sdesmalen added a comment. This revision is

[PATCH] D71920: [AST] Refactor propagation of dependency bits. NFC

AlexeySachkov added inline comments. Comment at: clang/include/clang/AST/Type.h:1827-1830 +if (Dependent) + Deps |= TypeDependence::Dependent | TypeDependence::Instantiation; +if (InstantiationDependent) + Deps |= TypeDependence::Instantiation;

[PATCH] D76297: [clang][AArch64] readd support for 'p' inline asm constraint

sdesmalen accepted this revision. sdesmalen added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/lib/Basic/Targets/AArch64.h:97 Constraint += 2; break; } nit: does this need a `default: break`? Repositor

[PATCH] D76283: [IRBuilder] Use preferred target type for len argument of memory intrinsic functions

lebedev.ri added a comment. llvm-dev might be a better place for that question, wider coverage. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76283/new/ https://reviews.llvm.org/D76283 ___ cfe-commits

[PATCH] D75682: [Analyzer][StreamChecker] Introduction of stream error handling.

balazske added a comment. Herald added a subscriber: DenisDvlp. In D75682#1926732 , @Szelethus wrote: > How about untracked streams? What if we call `feof()` on a stream we got from > a parameter, wouldn't that suggest that the stream is probably non-null

[PATCH] D76298: [ARM,CDE] Implement CDE S and D-register intrinsics

miyuki created this revision. miyuki added reviewers: simon_tatham, MarkMurrayARM, ostannard, dmgreen. Herald added subscribers: cfe-commits, danielkiss, hiraditya, kristof.beyls. Herald added a project: clang. miyuki added a child revision: D76296: [ARM,CDE] Implement GPR CDE intrinsics. miyuki re

[PATCH] D76297: [clang][AArch64] readd support for 'p' inline asm constraint

nickdesaulniers marked an inline comment as done. nickdesaulniers added inline comments. Comment at: clang/lib/Basic/Targets/AArch64.h:98 break; -default: - R = std::string(1, *Constraint); - break; } +return TargetInfo::convertConstraint(Constraint)

[PATCH] D76297: [clang][AArch64] readd support for 'p' inline asm constraint

nickdesaulniers updated this revision to Diff 250812. nickdesaulniers added a comment. - fix 'U' case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76297/new/ https://reviews.llvm.org/D76297 Files: clang/lib/Basic/Targets/AArch64.h clang/test/

[PATCH] D76299: [ARM,CDE] Implement CDE unpredicated Q-register intrinsics

miyuki created this revision. miyuki added reviewers: simon_tatham, MarkMurrayARM, dmgreen, ostannard. Herald added subscribers: cfe-commits, danielkiss, hiraditya, kristof.beyls. Herald added a project: clang. miyuki added a parent revision: D76298: [ARM,CDE] Implement CDE S and D-register intrin

[PATCH] D75169: [ARM] Enforcing calling convention for half-precision FP arguments and returns for big-endian AArch32

rjmccall added a comment. In D75169#1926545 , @pratlucas wrote: > Hi @rjmccall, > I agree those kind of tweaks do not look good. The issue here, though, is > that argument coercion currently ignores the target's endian information when > performing coer

[PATCH] D74361: [Clang] Undef attribute for global variables

JonChesterfield added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74361/new/ https://reviews.llvm.org/D74361 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[PATCH] D76283: [IRBuilder] Use preferred target type for len argument of memory intrinsic functions

rjmccall added a comment. I guess the logical rule would be that the bit-width of the size has to match the minimum of the bit-widths of the address spaces used with the intrinsic. (Note that `llvm.memcpy` etc. can take pointers into two different address spaces, potentially of different width

[PATCH] D59214: [clang][OpeMP] Model OpenMP structured-block in AST (PR40563)

sammccall added a comment. In D59214#1919183 , @lebedev.ri wrote: > d5edcb90643104d6911da5c0ff44c4f33fff992f > , > looking forward to seeing better error recovery. Thanks very much fo

[PATCH] D73898: [analyzer] StdLibraryFunctionsChecker: Add argument constraints

martong marked 16 inline comments as done. martong added inline comments. Herald added a subscriber: DenisDvlp. Comment at: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td:296 +def StdCLibraryFunctionArgsChecker : Checker<"StdCLibraryFunctionArgs">, + HelpText<"Check con

[PATCH] D73898: [analyzer] StdLibraryFunctionsChecker: Add argument constraints

martong updated this revision to Diff 250820. martong marked 4 inline comments as done. martong removed a subscriber: DenisDvlp. martong added a comment. - Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73898/new/ https://rev

[PATCH] D76300: [ARM,CDE] Implement CDE vreinterpret intrinsics

miyuki created this revision. miyuki added reviewers: simon_tatham, MarkMurrayARM, dmgreen, ostannard. Herald added subscribers: cfe-commits, danielkiss, kristof.beyls. Herald added a project: clang. miyuki added a parent revision: D76299: [ARM,CDE] Implement CDE unpredicated Q-register intrinsics

  1   2   3   >