baloghadamsoftware marked an inline comment as done.
baloghadamsoftware added inline comments.
================
Comment at: clang/lib/StaticAnalyzer/Checkers/ContainerModeling.cpp:726
+ << Text;
+ return std::string(Out.str());
+ });
----------------
NoQ wrote:
> I suspect you can remove the explicit conversion to `std::string` given that
> you've specified the return type explicitly.
Theoretically yes, because `llvm::StringRef` has a conversion operator for
`std::string`. However, when compiling I get a compilation error:
```
error: could not convert `Out.llvm::raw_svector_ostream::str()` from
`llvm::StringRef` to `std::__cxx11::string {aka
std::__cxx11::basic_string<char>}`
```
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75514/new/
https://reviews.llvm.org/D75514
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
