[PATCH] D76096: [clang] allow const structs to be constant expressions in initializer lists

nickdesaulniers marked an inline comment as done and an inline comment as not done. nickdesaulniers added a comment. In D76096#1920477 , @efriedma wrote: > But that's probably a larger project than you really want to mess with. Maybe with some coaching;

[PATCH] D73245: Depend stddef.h to provide max_align_t for C++11 and provide better fallback in

ldionne added inline comments. Comment at: libcxx/include/new:240 return __align > __STDCPP_DEFAULT_NEW_ALIGNMENT__; +#elif defined(_LIBCPP_CXX03_LANG) + return __align > alignment_of<__libcpp_max_align_t>::value; So, IIUC what you're saying, `__STDCPP_DEFAUL

[PATCH] D76083: [clang-tidy] Expand the list of functions in bugprone-unused-return-value

njames93 added a comment. Please upload diffs with full context. If you are using `git diff` to generate the patch, pass the flag `-U99` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76083/new/ https://reviews.llvm.org/D76083 __

[PATCH] D76103: [clangd] Extend findTarget()'s dependent name heuristic to handle enumerators

sammccall added a comment. Thanks! Just a couple of Qs... Comment at: clang-tools-extra/clangd/FindTarget.cpp:105 + if (auto *ET = T->getAs()) { +LookupInDecl = ET->getDecl(); + } else { Is this the bit that "breaks" the dependence? getDecl() works even i

[clang] 461566b - Add a test triple to avoid failure under MS ABI.

Author: Richard Smith Date: 2020-03-12T16:44:09-07:00 New Revision: 461566b0465c57793c70b0daff87f071d9e5906a URL: https://github.com/llvm/llvm-project/commit/461566b0465c57793c70b0daff87f071d9e5906a DIFF: https://github.com/llvm/llvm-project/commit/461566b0465c57793c70b0daff87f071d9e5906a.diff

[PATCH] D76096: [clang] allow const structs to be constant expressions in initializer lists

efriedma added inline comments. Comment at: clang/lib/AST/Expr.cpp:3164 + const QualType &QT = cast(this)->getDecl()->getType(); + if (QT->isStructureType() && QT.isConstQualified()) +return true; nickdesaulniers wrote: > efriedma wrote: > > nic

[PATCH] D76096: [clang] allow const structs to be constant expressions in initializer lists

efriedma added a comment. I think the code that disables constant evaluation for C is just https://github.com/llvm/llvm-project/blob/dcaf13a4048df3dad55f1a28cde7cefc99ccc057/clang/lib/AST/ExprConstant.cpp#L13918 and https://github.com/llvm/llvm-project/blob/dcaf13a4048df3dad55f1a28cde7cefc99ccc

[PATCH] D75911: [clang-tidy] Added hasAnyListedName matcher

alexfh added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/Matchers.h:53-55 +ast_matchers::internal::Matcher +hasAnyListedName(std::vector Names); + We could change all checks to use the other overload and drop this one (and the utils::options:

[PATCH] D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang

fghanim added a comment. Done with `private` `firstprivate` `copyin` - working on modifying the clang test, and fixing some bugs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75591/new/ https://reviews.llvm.org/D75591 _

[PATCH] D75529: [analyzer] Limit UCharMax to min of max uchar or max int

vabridgers updated this revision to Diff 250109. vabridgers marked 2 inline comments as not done. vabridgers added a comment. fix pre merge checkswq Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75529/new/ https://reviews.llvm.org/D75529 Files:

[PATCH] D35732: Update system_error tests for more platforms.

This revision was automatically updated to reflect the committed changes. Closed by commit rGa9740ff1585a: Update system_error tests for more platforms. (authored by danalbert). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D35732/new/ https://review

[PATCH] D75529: [analyzer] Limit UCharMax to min of max uchar or max int

vabridgers marked 6 inline comments as done. vabridgers added a comment. I believe all comments have been addressed. Please let me know if there's anything else required. Thanks Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:519 + // architecture

[libunwind] 3758b85 - Only run frameheader_cache_test.pass.cpp on x86_64.

Author: Sterling Augustine Date: 2020-03-12T18:14:22-07:00 New Revision: 3758b858ef3b39b3081bf9a567ead8bc69c9a208 URL: https://github.com/llvm/llvm-project/commit/3758b858ef3b39b3081bf9a567ead8bc69c9a208 DIFF: https://github.com/llvm/llvm-project/commit/3758b858ef3b39b3081bf9a567ead8bc69c9a208.

[PATCH] D76099: [Clang][Driver] In -fintegrated-cc1 mode, avoid crashing on exit after a compiler crash

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm The timer linked list is an interesting complication. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76099/new/ https://reviews.llvm.org/D76099

[PATCH] D75723: [X86] Enable intrinsics _BitScan*

skan abandoned this revision. skan added a comment. Reconsidered the advice of @rnk , we can use `-fms-extensions` to supported _BitScan* on linux. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75723/new/ https://reviews.llvm.org/D75723 ___

[PATCH] D75169: [ARM] Enforcing calling convention for half-precision FP arguments and returns for big-endian AArch32

lattner resigned from this revision. lattner added a comment. I'm not a qualified reviewer for this at this point. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75169/new/ https://reviews.llvm.org/D75169 _

[PATCH] D57497: [RISCV] Passing small data limitation value to RISCV backend

shiva0217 added a comment. In D57497#1920097 , @apazos wrote: > Thanks Shiva, I res-ynced and rebuilt the patch. It is working fine. > > I see there is a msmall-data-threshold flag used by Mips and Hexagon, and now > we are adding a new flag msmall-data-l

[PATCH] D76100: Debug Info: Store the SDK in the DICompileUnit.

JDevlieghere added a comment. Looks good to me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76100/new/ https://reviews.llvm.org/D76100 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo

[Diffusion] rG825235c140e7: Revert "[Sema] Use the canonical type in function isVector"

ahatanak added a comment. In rG825235c140e7747f686bd7902cb0f9af77590841#909794 , @SjoerdMeijer wrote: > > I'm still not sure why __fp16, which is a storage-only type, is used for > > the element type of float16x4_t if

[PATCH] D72282: [clang-tidy] Add `bugprone-unintended-adl`

logan-5 updated this revision to Diff 250130. logan-5 marked 3 inline comments as done. logan-5 added a comment. The check now suggests fixes for concrete (i.e. non-template) uses of ADL. Re-enabled the check for macros, and eliminated some false positives with arrays of dependent size. The chec

[PATCH] D75010: [OpenMP] Adding InaccessibleMemOnly and InaccessibleMemOrArgMemOnly for runtime calls.

jdoerfert added a comment. I always thought there was a test for this, turns out I never committed it. Since I did now (1c9c23d60ea7656174ad3d76293c2a90dd25e24f ) you need to rebase and adjust it, sorry. Com

<    1   2   3