[PATCH] D74961: [clangd] Make global rename file limit adjustable

kbobyrev abandoned this revision. kbobyrev added a comment. In D74961#1886479 , @hokein wrote: > oops, I should have synced with you first (the task was assigned to me in the > Tuesday meeting), I have https://reviews.llvm.org/D74834 which is under > rev

[PATCH] D75022: clang-format: Extend AllowShortLoopsOnASingleLine to do ... while loops.

DaanDeMeyer updated this revision to Diff 246150. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75022/new/ https://reviews.llvm.org/D75022 Files: clang/lib/Format/UnwrappedLineFormatter.cpp Index: clang/lib/Format/UnwrappedLineFormatter.cpp ===

[PATCH] D75034: [clang-format] use spaces for alignment with UT_ForContinuationAndIndentation

fickert created this revision. fickert added reviewers: clang-format, MyDeveloperDay, krasimir. fickert added projects: clang-format, clang-tools-extra. Herald added a project: clang. Herald added a subscriber: cfe-commits. Use spaces instead of tabs for alignment with UT_ForContinuationAndIndenta

[PATCH] D75034: [clang-format] use spaces for alignment with UT_ForContinuationAndIndentation

fickert added a comment. I added an `IsAligned` flag to `ParenState` and `Change` to track if an indent was created for alignment. I adapted the corresponding test cases where alignments were previously done with tabs, including a test case where leading whitespace in a comment is interpreted a

[PATCH] D74953: [profile] Don't dump counters when forking and don't reset when calling exec** functions

This revision was automatically updated to reflect the committed changes. Closed by commit rG8f46269f0c1c: [profile] Don't dump counters when forking and don't reset when calling exec**… (authored by Calixte Denizet ). Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D52136: [clang-tidy] Add modernize-concat-nested-namespaces check

Abpostelnicu added inline comments. Comment at: clang-tidy/modernize/ConcatNestedNamespacesCheck.cpp:88 + + if (!Sources.isInMainFile(ND.getBeginLoc())) +return; This breaks the usage of this checker in an unified build scenario since the main file for the

[PATCH] D75006: Wrap lines for C# property accessors

jbcoe updated this revision to Diff 246170. jbcoe added a comment. Handle C# access modifier `internal `. Fix typo in test for expression-bodied get/set methods. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75006/new/ https://reviews.llvm.org/D75006 Files: clang/lib/Format/Unwrappe

[PATCH] D74833: [AArch64][SVE] Add intrinsics for SVE2 cryptographic instructions

This revision was automatically updated to reflect the committed changes. Closed by commit rGf2ff153401fa: [AArch64][SVE] Add intrinsics for SVE2 cryptographic instructions (authored by kmclaughlin). Changed prior to commit: https://reviews.llvm.org/D74833?vs=245393&id=246171#toc Repository:

[PATCH] D75038: [ARM,MVE] Remove 64-bit variants of vbrsrq* intrinsics

miyuki created this revision. miyuki added reviewers: simon_tatham, dmgreen, MarkMurrayARM, ostannard. Herald added subscribers: cfe-commits, kristof.beyls. Herald added a project: clang. According to the ACLE the vbrsrq* intrinsics don't accept vectors with 64-bit elements (and neither does the c

[PATCH] D75038: [ARM,MVE] Remove 64-bit variants of vbrsrq* intrinsics

simon_tatham accepted this revision. simon_tatham added a comment. This revision is now accepted and ready to land. ... and we weren't //testing// the accidental 64-bit builtins (or else we'd have spotted the problem!), so no tests need to be changed. LGTM. Repository: rG LLVM Github Monorepo

[PATCH] D75006: Wrap lines for C# property accessors

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. This LGTM, thank you for the patch CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75006/new/ https://reviews.llvm.org/D75006

[PATCH] D75034: [clang-format] use spaces for alignment with UT_ForContinuationAndIndentation

MyDeveloperDay added a comment. If you are changing unit tests then I'm nervous, imagine if this many tests change what the impact is on a large code base. I think we need to understand more about why you are making this change and why you think its ok to change/remove existing tests which ass

[PATCH] D75022: clang-format: Extend AllowShortLoopsOnASingleLine to do ... while loops.

MyDeveloperDay added a comment. You need to add unit tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75022/new/ https://reviews.llvm.org/D75022 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailm

[PATCH] D75034: [clang-format] use spaces for alignment with UT_ForContinuationAndIndentation

MyDeveloperDay added a comment. you need to add any diff as a full context diff (normally by adding -U 999) to the diff command Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75034/new/ https://reviews.llvm.org/D75034 __

[PATCH] D75034: [clang-format] use spaces for alignment with UT_ForContinuationAndIndentation

fickert updated this revision to Diff 246176. fickert marked an inline comment as done. fickert added a comment. uploaded full context diff CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75034/new/ https://reviews.llvm.org/D75034 Files: clang/lib/Format/BreakableToken.cpp clang/lib/

[PATCH] D75034: [clang-format] use spaces for alignment with UT_ForContinuationAndIndentation

fickert added a comment. I understand the caution around changing the unit tests. The tests I modified assumed that alignment would be made with mixed tabs and spaces, which is arguably not the expected behavior with `UT_ForContinuationAndIndentation` (see https://bugs.llvm.org/show_bug.cgi?id=

[clang] 12fed51 - [ARM, MVE] Remove 64-bit variants of vbrsrq* intrinsics

Author: Mikhail Maltsev Date: 2020-02-24T12:49:20Z New Revision: 12fed51c0807b0727f9eecdd3dcf774a82fa7ecd URL: https://github.com/llvm/llvm-project/commit/12fed51c0807b0727f9eecdd3dcf774a82fa7ecd DIFF: https://github.com/llvm/llvm-project/commit/12fed51c0807b0727f9eecdd3dcf774a82fa7ecd.diff LO

[PATCH] D74954: Add a basic tiling pass for parallel loops

bkramer updated this revision to Diff 246167. bkramer added a comment. Herald added a subscriber: wuzish. Herald added a reviewer: mclow.lists. - WTF phab? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74954/new/ https://reviews.llvm.org/D74954 Fi

[PATCH] D74954: Add a basic tiling pass for parallel loops

bkramer updated this revision to Diff 246166. bkramer marked 4 inline comments as done. bkramer added a comment. Herald added subscribers: libc-commits, libcxx-commits, lldb-commits, Sanitizers, cfe-commits, bader, kerbowa, csigg, usaxena95, jdoerfert, ormris, jsji, kadircet, rupprecht, jfb, arph

[PATCH] D75040: [ASTMatchers] Adds a matcher called `hasAnyOperatorName`

njames93 created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. njames93 edited the summary of this revision. njames93 added reviewers: aaron.ballman, gribozavr2. Acts on `BinaryOperator` and `UnaryOperator` and functions the same as `anyOf(hasOperatorName(.

[PATCH] D75038: [ARM,MVE] Remove 64-bit variants of vbrsrq* intrinsics

This revision was automatically updated to reflect the committed changes. Closed by commit rG12fed51c0807: [ARM,MVE] Remove 64-bit variants of vbrsrq* intrinsics (authored by miyuki). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75038/new/ https://

[PATCH] D74643: [Parse] Fix `TryParsePtrOperatorSeq`.

aaron.ballman accepted this revision. aaron.ballman added a comment. Thank you for the new tests and drive-by fix for `_Atomic`! LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74643/new/ https://reviews.llvm.org/D74643 __

[PATCH] D75041: [WIP][clang-tidy] Approximate implicit conversion issues for the 'cppcoreguidelines-avoid-adjacent-arguments-of-same-type' check

whisperity created this revision. whisperity added a project: clang-tools-extra. Herald added subscribers: cfe-commits, martong, gamesh411, Szelethus, dkrupp, rnkovacs, kbarton, xazax.hun, nemanjai. Herald added a project: clang. whisperity added a parent revision: D69560: [clang-tidy] Add 'cppco

[clang] bd5b220 - Fix TryParsePtrOperatorSeq.

Author: Michele Scandale Date: 2020-02-24T08:08:47-05:00 New Revision: bd5b22070b6984d89c13b6cf38c3e54fc98ce291 URL: https://github.com/llvm/llvm-project/commit/bd5b22070b6984d89c13b6cf38c3e54fc98ce291 DIFF: https://github.com/llvm/llvm-project/commit/bd5b22070b6984d89c13b6cf38c3e54fc98ce291.di

[PATCH] D74643: [Parse] Fix `TryParsePtrOperatorSeq`.

aaron.ballman closed this revision. aaron.ballman added a comment. Thank you for the patch -- I've commit on your behalf in bd5b22070b6984d89c13b6cf38c3e54fc98ce291 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D75044: [AArch64] __builtin_extract_return_addr for PAuth.

danielkiss created this revision. danielkiss added reviewers: ostannard, asl. Herald added subscribers: llvm-commits, cfe-commits, jdoerfert, hiraditya, kristof.beyls. Herald added projects: clang, LLVM. This change adds the support for __builtin_extract_return_addr for ARMv8.3A Pointer Authentic

[PATCH] D75045: [analyzer] Improved check of `fgetc` in StreamChecker.

balazske created this revision. Herald added subscribers: cfe-commits, martong, Charusso, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a project: clang. A warning is produced if the `

[PATCH] D75040: [ASTMatchers] Adds a matcher called `hasAnyOperatorName`

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/ASTMatchers/ASTMatchersInternal.h:1870 +std::is_same::value, +"unsupported class for matcher")

[PATCH] D75040: [ASTMatchers] Adds a matcher called `hasAnyOperatorName`

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM Comment at: clang/include/clang/ASTMatchers/ASTMatchersInternal.h:1880-1884 +for (const std::string &Name : Names) { + if (Name == OpName) +return true; +} +return false;

[PATCH] D75040: [ASTMatchers] Adds a matcher called `hasAnyOperatorName`

gribozavr2 added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:4772 +/// +/// FIXME: Tweak to improve docs generated +extern const internal::VariadicFunctionhttps://reviews.llvm.org/D75040/new/ https://reviews.llvm.org/D75040 _

[PATCH] D74720: [ASTImporter] Improved variable template redecl chain handling.

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74720/new/ https://reviews.llvm.org/D74720

[PATCH] D71018: [ASTImporter] Improved import of TypeSourceInfo (TypeLoc)

martong added a comment. @shafik Ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71018/new/ https://reviews.llvm.org/D71018 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[PATCH] D75046: [docs] dump_ast_matchers strips internal::(Bindable)?Matcher from Result_type

njames93 created this revision. njames93 added reviewers: joerg, gribozavr2, aaron.ballman. Herald added a project: clang. Herald added a subscriber: cfe-commits. Remove `internal::Matcher` and `internal::BindableMatcher` from Result Type when dumping AST Matchers Repository: rG LLVM Github M

[PATCH] D75034: [clang-format] use spaces for alignment with UT_ForContinuationAndIndentation

MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:10293 Tab)); - EXPECT_EQ("/*\n" -"\t a\t\tcomment\n" Sorry this isn't clear to be which test this is a duplicate of, as this is an examp

[PATCH] D75040: [ASTMatchers] Adds a matcher called `hasAnyOperatorName`

njames93 updated this revision to Diff 246190. njames93 marked an inline comment as done. njames93 edited the summary of this revision. njames93 added a comment. - Address nits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75040/new/ https://review

[PATCH] D75040: [ASTMatchers] Adds a matcher called `hasAnyOperatorName`

njames93 marked an inline comment as done. njames93 added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchersInternal.h:1870 +std::is_same::value, +"unsupported class for matcher"); + static_assert(std::is_same>::value, --

[PATCH] D75047: Add Control Flow Guard in Clang release notes.

ajpaverd created this revision. ajpaverd added a reviewer: hans. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D75047 Files: clang/docs/ReleaseNotes.rst Index: clang/docs/ReleaseNotes.rst

[PATCH] D75034: [clang-format] use spaces for alignment with UT_ForContinuationAndIndentation

MyDeveloperDay added subscribers: djasper, klimek. MyDeveloperDay added a comment. > Is this intentional, or is it an oversight? This is the key question, which I'm not sure how we can answer without the help of the original authors @djasper and @klimek For example I can't understand with the e

[PATCH] D74941: [OpenMP] `omp begin/end declare variant` - part 1, parsing

JonChesterfield added a subscriber: gregrodgers. JonChesterfield added a comment. Thanks! Splitting this out of D71179 , which I think ultimately reached consensus, makes the diff much easier to read. Subscribing Greg, as I think this is a path to removing a lot

[PATCH] D75034: [clang-format] use spaces for alignment with UT_ForContinuationAndIndentation

fickert marked an inline comment as done. fickert added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:10293 Tab)); - EXPECT_EQ("/*\n" -"\t a\t\tcomment\n" MyDeveloperDay wrote: > Sorry this isn't clear to

[PATCH] D75040: [ASTMatchers] Adds a matcher called `hasAnyOperatorName`

njames93 marked an inline comment as done. njames93 added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:4772 +/// +/// FIXME: Tweak to improve docs generated +extern const internal::VariadicFunction Any specific things you would like to improve? The f

[PATCH] D73898: [analyzer] StdLibraryFunctionsChecker: Add argument constraints

martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:418 +if (FailureSt && !SuccessSt) { + C.addTransition(FailureSt); + if (ExplodedNode *N = C.generateErrorNode(FailureSt)) balazske wrote: > I

[PATCH] D74734: [AArch64][SVE] Add the SVE dupq_lane intrinsic

This revision was automatically updated to reflect the committed changes. kmclaughlin marked an inline comment as done. Closed by commit rGf87f23c81cae: [AArch64][SVE] Add the SVE dupq_lane intrinsic (authored by kmclaughlin). Changed prior to commit: https://reviews.llvm.org/D74734?vs=245012&i

[PATCH] D74734: [AArch64][SVE] Add the SVE dupq_lane intrinsic

kmclaughlin marked 4 inline comments as done. kmclaughlin added a comment. Thanks for taking a look at this, @sdesmalen! Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:7496 + auto CIdx = dyn_cast(Idx128); + if (CIdx && (CIdx->getZExtValue() <= 3)) { +auto CI

[PATCH] D73898: [analyzer] StdLibraryFunctionsChecker: Add argument constraints

martong updated this revision to Diff 246193. martong marked 7 inline comments as done. martong added a comment. - Use StringRef for Msg - Remove superfluous addTransition Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73898/new/ https://reviews.llv

[PATCH] D74463: [clang-tidy] Add new check avoid-adjacent-unrelated-parameters-of-the-same-type

vingeldal added a comment. > - how do we either not warn on this by default or how does the user tell us > to not warn on it (without requiring them to jump through hoops like changing > the types of the arguments)? -I'v used comments in the source code to tell the tool to ignore cases that I'v

[PATCH] D75034: [clang-format] use spaces for alignment with UT_ForContinuationAndIndentation

fickert added a comment. In D75034#1889107 , @MyDeveloperDay wrote: > > Is this intentional, or is it an oversight? > > This is the key question, which I'm not sure how we can answer without the > help of the original authors @djasper and @klimek > > For

[PATCH] D74463: [clang-tidy] Add new check avoid-adjacent-unrelated-parameters-of-the-same-type

vingeldal added a comment. In D74463#1889157 , @vingeldal wrote: > > - how do we either not warn on this by default or how does the user tell us > > to not warn on it (without requiring them to jump through hoops like > > changing the types of the argume

[PATCH] D74973: [analyzer] StdLibraryFunctionsChecker refactor w/ inheritance

martong added a comment. > Is really more kind of constraint needed than range constraint? Yes, there are other constraints I am planning to implement: - Size requirements E.g.: asctime_s(char *buf, rsize_t bufsz, const struct tm *time_ptr); `buf` size must be at least `bufsz`. - Not-null - Not

[PATCH] D74463: [clang-tidy] Add new check avoid-adjacent-unrelated-parameters-of-the-same-type

vingeldal added a comment. Discovered duplication: https://reviews.llvm.org/D69560 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74463/new/ https://reviews.llvm.org/D74463 ___ cfe-commits mailing list

[PATCH] D75048: [ASTImporter] Improved import of AlignedAttr.

balazske created this revision. Herald added subscribers: cfe-commits, martong, teemperor, gamesh411, Szelethus, dkrupp. Herald added a reviewer: martong. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: clang. It is not enough to clone the attributes a

[PATCH] D73967: Implement _ExtInt as an extended int type specifier.

erichkeane updated this revision to Diff 246198. erichkeane added a subscriber: lattner. erichkeane added a comment. Update language extensions to document calling convention impact. This patch should now be completely up to date based on the comments here and from cfe-dev, particularly those by

[PATCH] D74463: [clang-tidy] Add new check avoid-adjacent-unrelated-parameters-of-the-same-type

aaron.ballman added a comment. In D74463#1889187 , @vingeldal wrote: > In D74463#1889157 , @vingeldal wrote: > > > > - how do we either not warn on this by default or how does the user tell > > > us to not warn on

[clang] c8dadac - add release notes for ffp-model and ffp-exception-behavior

Author: Melanie Blower Date: 2020-02-24T06:42:05-08:00 New Revision: c8dadac228b7dd3a71d5fc25489d1b884a2b0f5e URL: https://github.com/llvm/llvm-project/commit/c8dadac228b7dd3a71d5fc25489d1b884a2b0f5e DIFF: https://github.com/llvm/llvm-project/commit/c8dadac228b7dd3a71d5fc25489d1b884a2b0f5e.diff

[PATCH] D74463: [clang-tidy] Add new check avoid-adjacent-unrelated-parameters-of-the-same-type

vingeldal abandoned this revision. vingeldal added a comment. Will proceed with instead contributing however I can to the more mature patch https://reviews.llvm.org/D69560 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74463/new/ https://reviews.ll

[PATCH] D75045: [analyzer] Improved check of `fgetc` in StreamChecker.

martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:356 +State = State->set( +StreamSym, StreamState{SS->K, false, SS->ShouldCallFerror}); + } Maybe adding a comment like `false /*Feof*/` could make this mor

[PATCH] D69560: [clang-tidy] Add 'cppcoreguidelines-avoid-adjacent-arguments-of-same-type' check

vingeldal added a comment. Nice! Do you have any numbers on the amount of false positives this check produces, or the ratio of false and true positives? I recently started work on this check myself but didn't get very far before I discovered this patch and abandoned mine. Before abandoning I got

[PATCH] D75045: [analyzer] Improved check of `fgetc` in StreamChecker.

Szelethus requested changes to this revision. Szelethus added a comment. This revision now requires changes to proceed. I'm a bit confused as to what this patch aims to do. Once again, I'd kindly ask you to discuss for a bit before updating this patch. --- The rule states that after reaching `E

[PATCH] D74973: [analyzer] StdLibraryFunctionsChecker refactor w/ inheritance

Szelethus added a comment. FYI I've been seeing your patches to this checker and I will respond to them, but I need to do some learning on my own before having the confidence to accept or request changes. Working on it! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D75040: [ASTMatchers] Adds a matcher called `hasAnyOperatorName`

njames93 requested review of this revision. njames93 marked 3 inline comments as done. njames93 added a comment. I have fixed up the docs to be more in line with other matchers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75040/new/ https://review

[PATCH] D75040: [ASTMatchers] Adds a matcher called `hasAnyOperatorName`

njames93 updated this revision to Diff 246203. njames93 added a comment. - Improved docs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75040/new/ https://reviews.llvm.org/D75040 Files: clang/docs/LibASTMatchersReference.html clang/docs/tools/d

[clang] 8bee52b - [AIX][Frontend] C++ ABI customizations for AIX boilerplate

Author: Xiangling Liao Date: 2020-02-24T10:26:51-05:00 New Revision: 8bee52bdb54a51ccfe1eb6c6ed5077132c2950a1 URL: https://github.com/llvm/llvm-project/commit/8bee52bdb54a51ccfe1eb6c6ed5077132c2950a1 DIFF: https://github.com/llvm/llvm-project/commit/8bee52bdb54a51ccfe1eb6c6ed5077132c2950a1.diff

[PATCH] D73285: [OpenMP][OMPIRBuilder][BugFix] Handle Unreachable Finalization blocks in `parallel` generation

fghanim abandoned this revision. fghanim added a comment. The bug this revision attempted to fix has been resolved as part of patch D74562 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73285/new/ https://reviews.l

[PATCH] D71227: [cuda][hip] Fix function overload resolution in the global initiailizer.

hliao updated this revision to Diff 246204. hliao added a comment. Rebase to the trunk. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71227/new/ https://reviews.llvm.org/D71227 Files: clang/include/clang/Sema/Sema.h clang/lib/Parse/ParseDecl.c

[PATCH] D74015: [AIX][Frontend] C++ ABI customizations for AIX boilerplate

This revision was automatically updated to reflect the committed changes. Closed by commit rG8bee52bdb54a: [AIX][Frontend] C++ ABI customizations for AIX boilerplate (authored by Xiangling_L). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74015/new/

[PATCH] D72035: [analyzer][NFC] Use CallEvent checker callback in GenericTaintChecker

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. Herald added a subscriber: martong. Wow. Its a joy to see you do C++. LGTM. Are you planning to introduce `CallDescriptionMap` at one point? :) Comment at: clang/lib/S

[clang] d66d25f - [OpenMP] Refactor the analysis in checkMapClauseBaseExpression using StmtVisitor class.

Author: cchen Date: 2020-02-24T10:30:41-05:00 New Revision: d66d25f83824e2d72e06bf0813cc9e9e564dd74c URL: https://github.com/llvm/llvm-project/commit/d66d25f83824e2d72e06bf0813cc9e9e564dd74c DIFF: https://github.com/llvm/llvm-project/commit/d66d25f83824e2d72e06bf0813cc9e9e564dd74c.diff LOG: [O

[PATCH] D75053: [clangd] Disable ExtractVariable for C

kadircet created this revision. kadircet added a reviewer: usaxena95. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Currently extract variable doesn't spell the type explicitly and just uses an `auto` instead, which is not availab

[PATCH] D69746: [analyzer] FixItHint: Apply and test hints with the Clang-Tidy's script

Charusso added a comment. Thanks for the reviews! Are we good to go? Comment at: clang/lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp:112 void enableFixitsAsRemarks() { FixitsAsRemarks = true; } + void enableFixItApplication() { ApplyFixIts = true; } al

[PATCH] D69746: [analyzer] FixItHint: Apply and test hints with the Clang-Tidy's script

Charusso updated this revision to Diff 246209. Charusso marked 4 inline comments as done. Charusso retitled this revision from "[analyzer] FixItHint: Apply and test hints with the Clang Tidy's script" to "[analyzer] FixItHint: Apply and test hints with the Clang-Tidy's script". Charusso added a c

[PATCH] D74970: [OpenMP] Refactor the analysis in checkMapClauseBaseExpression using StmtVisitor class.

This revision was automatically updated to reflect the committed changes. Closed by commit rGd66d25f83824: [OpenMP] Refactor the analysis in checkMapClauseBaseExpression using… (authored by cchen, committed by ABataev). Changed prior to commit: https://reviews.llvm.org/D74970?vs=245995&id=24621

[PATCH] D71524: [analyzer] Support tainted objects in GenericTaintChecker

Szelethus requested changes to this revision. Szelethus added a reviewer: steakhal. Szelethus added a comment. This revision now requires changes to proceed. This patch is really cool, but I still feel anxious a bit about duplicating so much functionality, especially since we're working very hard

[PATCH] D74131: [analyzer][taint] Add isTainted debug expression inspection check

Szelethus added a reviewer: boga95. Szelethus added a comment. In D74131#1884372 , @steakhal wrote: > If this patch is good to go, could someone commit it? > I don't have commit access (yet). I think you can apply for a commit access, you have a history

[PATCH] D74973: [analyzer] StdLibraryFunctionsChecker refactor w/ inheritance

martong added a comment. In D74973#1889273 , @Szelethus wrote: > FYI I've been seeing your patches to this checker and I will respond to them, > but I need to do some learning on my own before having the confidence to > accept or request changes. Working

[PATCH] D75056: [ARM][AArch64] Default to -fno-common

SjoerdMeijer created this revision. Herald added a subscriber: kristof.beyls. This patch proposes to default to `-fno-common` for the Arm targets because this has performance and code-size benefits. Additionally, GCC now also defaults to this, so we would be behaving the same as GCC: commit

[PATCH] D74878: [remark][diagnostics] [codegen] Fix PR44896

xur added a comment. Gentle ping. Is the newest patch ok? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74878/new/ https://reviews.llvm.org/D74878 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailma

[PATCH] D75057: Syndicate, test and fix base64 implementation

serge-sans-paille created this revision. serge-sans-paille added reviewers: jvikstrom, george.karpenkov. Herald added subscribers: llvm-commits, Sanitizers, cfe-commits, usaxena95, kadircet, arphaman, jkorous, mgorny. Herald added projects: clang, Sanitizers, LLVM. As an answer to https://github.

[PATCH] D74878: [remark][diagnostics] [codegen] Fix PR44896

jeroen.dobbelaere added a comment. Will this also give a warning when passing a .ll file to a release clang, without explicitly passing the '-fdiscard-value-names' ? Is this what we want it to be ? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74878/new/ https://reviews.llvm.org/D748

[PATCH] D75057: Syndicate, test and fix base64 implementation

lebedev.ri requested changes to this revision. lebedev.ri added inline comments. This revision now requires changes to proceed. Comment at: compiler-rt/lib/fuzzer/FuzzerUtil.cpp:14-16 + +#include "llvm/Support/Base64.h" + I don't believe we can do this. libfuzzer

[PATCH] D74470: Seperated DIBasicType DIFlags to DIBTFlags.

aprantl added a comment. Thank you this looks very good! Just a few questions inline. Comment at: llvm/lib/AsmParser/LLParser.cpp:4171 +template <> +bool LLParser::ParseMDField(LocTy Loc, StringRef Name, DIBTFlagField &Result) { + Chirag wrote: > Chirag wrote:

[PATCH] D73462: [dwarf-5] Support DebugInfo for Defaulted parameters for C++ templates

aprantl added a comment. LGTM Comment at: llvm/unittests/IR/MetadataTest.cpp:2106 + auto *N = + DITemplateValueParameter::get(Context, Tag, Name, Type, false, Value); EXPECT_EQ(Tag, N->getTag()); For consistency, let's assign "false" to `bool Defaulted

[PATCH] D69560: [clang-tidy] Add 'cppcoreguidelines-avoid-adjacent-arguments-of-same-type' check

whisperity marked an inline comment as done. whisperity added a comment. I'd rather not call them //false positive// because the definition of `false positive` is ugly and mushy with regards to this check. This check attempts to enforce an interface rule, whether you(r project) wants to adhere t

[PATCH] D69560: [clang-tidy] Add 'cppcoreguidelines-avoid-adjacent-arguments-of-same-type' check

whisperity added a comment. In D74463#1888270 , @aaron.ballman wrote: > I am also concerned about the false positives from this check because I don't > think there's going to be an easy heuristic for determining whether two > identifiers are "related" t

[PATCH] D74760: [Analyzer] Fix for iterator modeling and checkers: handle negative numbers correctly

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. This patch is a good testament to how well those debug functions turned out. LGTM. Comment at: clang/lib/StaticAnalyzer/Checkers/Iterator.cpp:203 auto &SVB = State-

[PATCH] D73898: [analyzer] StdLibraryFunctionsChecker: Add argument constraints

martong updated this revision to Diff 246229. martong added a comment. Rebase on top of https://reviews.llvm.org/D74973 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73898/new/ https://reviews.llvm.org/D73898 Files: clang/include/clang/StaticAna

[PATCH] D69662: [Checkers] Avoid using evalCall in StreamChecker.

Szelethus added a comment. Herald added a subscriber: martong. In D69662#1744479 , @NoQ wrote: > In D69662#1736601 , @balazske wrote: > > > Anyway the checks that do not use BindExpr (all except the open functions)

[PATCH] D75061: [RISCV] Fix sysroot tests without GCC on RISC-V hosts with GCC

luismarques created this revision. luismarques added reviewers: edward-jones, lenary. Herald added subscribers: cfe-commits, evandro, apazos, sameer.abuasal, pzheng, s.egerton, Jim, benna, psnobl, jocewei, PkmX, rkruppe, the_o, brucehoult, MartinMosbeck, rogfer01, zzheng, jrtc27, shiva0217, kito-

[PATCH] D71524: [analyzer] Support tainted objects in GenericTaintChecker

boga95 marked 6 inline comments as done. boga95 added a comment. @steakhal's revision is on the top of this. Changing the order will only cause unnecessary work on both sides. Comment at: clang/lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp:103-132 struct FunctionData

[PATCH] D71524: [analyzer] Support tainted objects in GenericTaintChecker

Szelethus added a comment. In D71524#1889566 , @boga95 wrote: > @steakhal's revision is on the top of this. Changing the order will only > cause unnecessary work on both sides. He recently rebased on top of master. I'm no fan of creating unnecessary wor

[PATCH] D75006: [clang-format] Wrap lines for C# property accessors

jbcoe updated this revision to Diff 246235. jbcoe added a comment. This revision is now accepted and ready to land. Simplify logic for merging property accessors CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75006/new/ https://reviews.llvm.org/D75006 Files: clang/lib/Format/Unwrapped

[PATCH] D74878: [remark][diagnostics] [codegen] Fix PR44896

serge-sans-paille added a comment. In D74878#1889460 , @jeroen.dobbelaere wrote: > Will this also give a warning when passing a .ll file to a release clang, > without explicitly passing the '-fdiscard-value-names' ? Is this what we > want it to be ?

[PATCH] D75063: [analyzer] StdLibraryFunctionsChecker: Add NotNull Arg Constraint

martong created this revision. martong added reviewers: NoQ, Szelethus, balazske, gamesh411, baloghadamsoftware, steakhal. Herald added subscribers: cfe-commits, Charusso, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, xazax.hun, whisperity. Herald added a project: clang. marto

[PATCH] D74973: [analyzer] StdLibraryFunctionsChecker refactor w/ inheritance

martong marked an inline comment as done. martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:93 +ValueConstraint(ArgNo ArgN) : ArgN(ArgN) {} +virtual ProgramStateRef apply(ProgramStateRef State, const CallEvent &Cal

[PATCH] D74973: [analyzer] StdLibraryFunctionsChecker refactor w/ inheritance

martong added a comment. @balazske See https://reviews.llvm.org/D75063 about the simple independent implementation of the NotNull constraint. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74973/new/ https://reviews.llvm.org/D74973 _

[PATCH] D75057: Syndicate, test and fix base64 implementation

serge-sans-paille updated this revision to Diff 246240. serge-sans-paille added a comment. Restore duplication, fix the bug in two separate locations. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75057/new/ https://reviews.llvm.org/D75057 Files:

[PATCH] D73898: [analyzer] StdLibraryFunctionsChecker: Add argument constraints

martong marked an inline comment as done. martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:152 +break; + default: +llvm_unreachable("Unknown RangeConstraint kind!"); This `default` br

[PATCH] D75057: Syndicate, test and fix base64 implementation

serge-sans-paille updated this revision to Diff 246243. serge-sans-paille added a comment. Fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75057/new/ https://reviews.llvm.org/D75057 Files: clang-tools-extra/clangd/SemanticHighlighting.cpp

[PATCH] D75022: clang-format: Extend AllowShortLoopsOnASingleLine to do ... while loops.

DaanDeMeyer updated this revision to Diff 246244. DaanDeMeyer added a comment. Added unit tests and fixed the case where stuff follows the do statement (like a comment). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75022/new/ https://reviews.llvm.org/D75022 Files: lib/Format/Unwrap

[PATCH] D75057: Syndicate, test and fix base64 implementation

serge-sans-paille removed a reviewer: lebedev.ri. serge-sans-paille added a comment. As a side note, pre-reserving the buffer size gives interesting speedup, see http://quick-bench.com/Lp6OwO2etW1YEmJayVWn3U8JDiY Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D75057: Syndicate, test and fix base64 implementation

serge-sans-paille updated this revision to Diff 246248. serge-sans-paille added a comment. Other copy/paste typo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75057/new/ https://reviews.llvm.org/D75057 Files: clang-tools-extra/clangd/SemanticHi

  1   2   >