vingeldal added a comment. Nice! Do you have any numbers on the amount of false positives this check produces, or the ratio of false and true positives? I recently started work on this check myself but didn't get very far before I discovered this patch and abandoned mine. Before abandoning I got some feedback though; there were concerns that there would be way to many false positives.
There were requests both to add heuristics to minimize false positives, as I see you have done nicely, and to provide some data as to how the check performs with regard to false positives. ================ Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/AdjacentArgumentsOfSameTypeCheck.cpp:474 +// Default to 3 so the users don't get a warning for every possible thing. +static const unsigned DefaultMinLength = 3; + ---------------- Am I getting this right, is this the number of consecutive arguments of the same type which is required for this check to print a diagnostic? If so: why not set the default value to 2? -I think that's what a user who just read the C++ Core Guidelines would expect. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69560/new/ https://reviews.llvm.org/D69560 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
