[PATCH] D74806: [analyzer] NFCi: Refactor CStringChecker: use strongly typed internal API

steakhal created this revision. steakhal added reviewers: NoQ, baloghadamsoftware, Szelethus. steakhal added a project: clang. Herald added subscribers: cfe-commits, martong, Charusso, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, xazax.hun, whisperity. Herald added a reviewer:

[clang] ea789f8 - Remove unused option that gcc ignored

Author: Jim Lin Date: 2020-02-19T08:36:07+08:00 New Revision: ea789f819f26a1b003a1bf07466fc9fa2fe558ec URL: https://github.com/llvm/llvm-project/commit/ea789f819f26a1b003a1bf07466fc9fa2fe558ec DIFF: https://github.com/llvm/llvm-project/commit/ea789f819f26a1b003a1bf07466fc9fa2fe558ec.diff LOG:

[PATCH] D72825: Remove unused option that gcc ignored

This revision was automatically updated to reflect the committed changes. Closed by commit rGea789f819f26: Remove unused option that gcc ignored (authored by Jim). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72825/new/ https://reviews.llvm.org/D72

[PATCH] D74790: [Sema][CodeComplete] Handle symlinks for include code completion

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks! I can't see this being a performance problem (famous last words...) Comment at: clang/lib/Sema/SemaCodeComplete.cpp:8780 + + // We need to manually resolve

[PATCH] D74807: Add cl_khr_mipmap_image_writes as supported to AMDGPU

yaxunl created this revision. yaxunl added a reviewer: b-sumner. Herald added subscribers: kerbowa, t-tye, tpr, dstuttard, nhaehnle, wdng, jvesely, kzhuravl. https://reviews.llvm.org/D74807 Files: clang/lib/Basic/Targets/AMDGPU.h Index: clang/lib/Basic/Targets/AMDGPU.h ==

[PATCH] D72231: [Sema] Adds the pointer-to-int-cast diagnostic

rjmccall added a comment. In D72231#1881797 , @nickdesaulniers wrote: > In D72231#1881784 , @rjmccall wrote: > > > In D72231#1881760 , > > @nickdesaulniers wrote: > > > > >

[PATCH] D73649: [CodeComplete] Member completion for concept-constrained types.

sammccall marked 3 inline comments as done. sammccall added inline comments. Comment at: clang/lib/Sema/CodeCompleteConsumer.cpp:592 } +for (const FixItHint &FixIt : Results[I].FixIts) { + const SourceLocation BLoc = FixIt.RemoveRange.getBegin(); (T

[clang] 492d4a9 - [NFC] Update the testcase clang_f_opts.c for the removed options

Author: Jim Lin Date: 2020-02-19T09:28:41+08:00 New Revision: 492d4a992d88516da471b60ecd9a37ea80dbf9a4 URL: https://github.com/llvm/llvm-project/commit/492d4a992d88516da471b60ecd9a37ea80dbf9a4 DIFF: https://github.com/llvm/llvm-project/commit/492d4a992d88516da471b60ecd9a37ea80dbf9a4.diff LOG:

[PATCH] D72231: [Sema] Adds the pointer-to-int-cast diagnostic

nickdesaulniers added a comment. In D72231#1881855 , @rjmccall wrote: > No, I understand the pattern, but they must have already done some sort of > pass over the code to make it warning-clean when they're working with a > smaller integer type. Or do th

[clang-tools-extra] 28728bf - Fix a signed/unsigned warning promoted to error.

Author: Eric Christopher Date: 2020-02-18T17:49:22-08:00 New Revision: 28728bf06f556dc8be5bc1fa77129906ba68 URL: https://github.com/llvm/llvm-project/commit/28728bf06f556dc8be5bc1fa77129906ba68 DIFF: https://github.com/llvm/llvm-project/commit/28728bf06f556dc8be5bc1fa77129906ba68.di

[PATCH] D74811: [Driver] Escape the program path for -frecord-command-line

ravi-ramaseshan created this revision. ravi-ramaseshan added reviewers: scott.linder, rjmccall. Herald added a project: clang. Similar to the rest of the command line that is recorded, the program path must also have spaces and backslashes escaped. Without this parsing the recorded command line be

[clang] 061f3a5 - P0593R6: Pseudo-destructor expressions end object lifetimes.

Author: Richard Smith Date: 2020-02-18T18:41:03-08:00 New Revision: 061f3a50dd824f1eb2394d0f699f3f2ee374b21a URL: https://github.com/llvm/llvm-project/commit/061f3a50dd824f1eb2394d0f699f3f2ee374b21a DIFF: https://github.com/llvm/llvm-project/commit/061f3a50dd824f1eb2394d0f699f3f2ee374b21a.diff

[PATCH] D73242: [WPD/LowerTypeTests] Delay lowering/removal of type tests until after ICP

aganea added a comment. There seems to be still an issue with this patch, when linking the LLVM unit tests on a two-stage build, it ends with: FAILED: tools/clang/unittests/StaticAnalyzer/StaticAnalysisTests.exe cmd.exe /C "cd . && "C:\Program Files\CMake\bin\cmake.exe" -E vs_link_exe --int

[PATCH] D74812: [Sema] Teach -Warm-interrupt-safety about func ptrs

jroelofs created this revision. jroelofs added reviewers: efriedma, weimingz, EricWF. Herald added subscribers: cfe-commits, kristof.beyls. Herald added a project: clang. Fixes: https://bugs.llvm.org/show_bug.cgi?id=35527 https://bugs.llvm.org/show_bug.cgi?id=35528 Repository: rG LLVM Git

[PATCH] D74812: [Sema] Teach -Warm-interrupt-safety about func ptrs

jroelofs marked an inline comment as done. jroelofs added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:5931 + if (Caller->hasAttr()) { +const Decl *CalleeDecl = FDecl; +if (const auto *UO = dyn_cast(Fn->IgnoreParens())) { This fee

[PATCH] D72231: [Sema] Adds the pointer-to-int-cast diagnostic

nathanchance added a comment. In D72231#1881855 , @rjmccall wrote: > In D72231#1881797 , @nickdesaulniers > wrote: > > > In D72231#1881784 , @rjmccall > > wrote: > > > > >

[PATCH] D69868: Allow "callbr" to return non-void values

void added a comment. It's been almost a month since the last comments on this review. If you need more time, please comment here. Otherwise, I will submit this with the current approvals by the end of the week. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D69868: Allow "callbr" to return non-void values

jdoerfert added a comment. In D69868#1881985 , @void wrote: > It's been almost a month since the last comments on this review. If you need > more time, please comment here. Otherwise, I will submit this with the > current approvals by the end of the week

[clang] 048239e - [Coroutines][6/6] Clang schedules new passes

Author: Brian Gesiak Date: 2020-02-19T01:03:28-05:00 New Revision: 048239e46e490d441f21f3e26073ec38f19e8a10 URL: https://github.com/llvm/llvm-project/commit/048239e46e490d441f21f3e26073ec38f19e8a10 DIFF: https://github.com/llvm/llvm-project/commit/048239e46e490d441f21f3e26073ec38f19e8a10.diff

[PATCH] D71903: [Coroutines][6/6] Clang schedules new passes

This revision was automatically updated to reflect the committed changes. Closed by commit rG048239e46e49: [Coroutines][6/6] Clang schedules new passes (authored by modocache). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71903/new/ https://reviews

[PATCH] D74757: Fix compiler extension in standalone mode

serge-sans-paille updated this revision to Diff 245327. serge-sans-paille added a comment. Take @Meinersbur review into account. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74757/new/ https://reviews.llvm.org/D74757 Files: clang/CMakeLists.txt

[PATCH] D74813: [RFC] Add hash of block contents to function block names

alexbdv created this revision. alexbdv added reviewers: MaskRay, vsk, JonasToth, ruiu. Herald added a project: clang. Herald added a subscriber: cfe-commits. Function blocks don't have a name specified in source code. Currently their symbol name is based on the parent function's name and an index

[PATCH] D74814: IR printing for single function with the new pass manager.

hoyFB created this revision. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added projects: clang, LLVM. hoyFB added a reviewer: wenlei. hoyFB added a subscriber: wenlei. The IR printing always prints out all functions in a module with the new pass manager, even with -filt

[PATCH] D74606: [clangd] Add add commit characters to the server capabilities

kbobyrev updated this revision to Diff 245331. kbobyrev added a comment. Add pipe and single quote to commit characters. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74606/new/ https://reviews.llvm.org/D74606 Files: clang-tools-extra/clangd/Cla

[clang-tools-extra] 2a095ff - [clangd] Add add commit characters to the server capabilities

Author: Kirill Bobyrev Date: 2020-02-19T08:32:00+01:00 New Revision: 2a095ff6f5028b7612dae50358a2f6939b6cdc9f URL: https://github.com/llvm/llvm-project/commit/2a095ff6f5028b7612dae50358a2f6939b6cdc9f DIFF: https://github.com/llvm/llvm-project/commit/2a095ff6f5028b7612dae50358a2f6939b6cdc9f.diff

[PATCH] D74606: [clangd] Add add commit characters to the server capabilities

This revision was automatically updated to reflect the committed changes. Closed by commit rG2a095ff6f502: [clangd] Add add commit characters to the server capabilities (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74606/new/

[PATCH] D74564: libclang: Add static build support for Windows

yvvan accepted this revision. yvvan added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/include/clang-c/Platform.h:31 +#elif defined(CINDEX_EXPORTS) + #define CINDEX_LINKAGE __attribute__((visibility("default"))) +#endif cr

[PATCH] D74732: [ARM,CDE] Cosmetic changes, additonal driver tests

SjoerdMeijer accepted this revision. SjoerdMeijer added a comment. This revision is now accepted and ready to land. Cheers, LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74732/new/ https://reviews.llvm.org/D74732 ___

[PATCH] D73846: make sure to not warn about unused macros from -D

llunak added a comment. Ping.. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73846/new/ https://reviews.llvm.org/D73846 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D69585: PerformPendingInstatiations() already in the PCH

llunak added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69585/new/ https://reviews.llvm.org/D69585 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 90dc78b - [ARM, MVE] Add intrinsics for abs, neg and not operations.

Author: Simon Tatham Date: 2020-02-18T09:34:50Z New Revision: 90dc78bc62784faaa55afb0320cf3c2187d80ac6 URL: https://github.com/llvm/llvm-project/commit/90dc78bc62784faaa55afb0320cf3c2187d80ac6 DIFF: https://github.com/llvm/llvm-project/commit/90dc78bc62784faaa55afb0320cf3c2187d80ac6.diff LOG:

[clang] b6236e9 - [ARM, MVE] Add the vrev16q, vrev32q, vrev64q family.

Author: Simon Tatham Date: 2020-02-18T09:34:50Z New Revision: b6236e94799e43fad1f024e84ed56a85d9a3623f URL: https://github.com/llvm/llvm-project/commit/b6236e94799e43fad1f024e84ed56a85d9a3623f DIFF: https://github.com/llvm/llvm-project/commit/b6236e94799e43fad1f024e84ed56a85d9a3623f.diff LOG:

[clang] c8b3196 - [ARM, MVE] Add intrinsics for FP rounding operations.

Author: Simon Tatham Date: 2020-02-18T09:34:50Z New Revision: c8b3196e54308b0113d2a0888d13ccc92e3b7ccc URL: https://github.com/llvm/llvm-project/commit/c8b3196e54308b0113d2a0888d13ccc92e3b7ccc DIFF: https://github.com/llvm/llvm-project/commit/c8b3196e54308b0113d2a0888d13ccc92e3b7ccc.diff LOG:

[clang] df3ed6c - [ARM, MVE] Add intrinsics for int <-> float conversion.

Author: Simon Tatham Date: 2020-02-18T09:34:50Z New Revision: df3ed6c0fe31094941e4cd814cdf924b63993c4e URL: https://github.com/llvm/llvm-project/commit/df3ed6c0fe31094941e4cd814cdf924b63993c4e DIFF: https://github.com/llvm/llvm-project/commit/df3ed6c0fe31094941e4cd814cdf924b63993c4e.diff LOG:

[clang] 68b49f7 - [ARM,MVE] Add intrinsics vclzq and vclsq.

Author: Simon Tatham Date: 2020-02-18T09:34:50Z New Revision: 68b49f7ef49eec068b7ddcf86c868e2a193e64e1 URL: https://github.com/llvm/llvm-project/commit/68b49f7ef49eec068b7ddcf86c868e2a193e64e1 DIFF: https://github.com/llvm/llvm-project/commit/68b49f7ef49eec068b7ddcf86c868e2a193e64e1.diff LOG:

[PATCH] D74331: [ARM,MVE] Add intrinsics for abs, neg and not operations.

This revision was automatically updated to reflect the committed changes. Closed by commit rG90dc78bc6278: [ARM,MVE] Add intrinsics for abs, neg and not operations. (authored by simon_tatham). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74331/new/

[clang] 5e97940 - [ARM, MVE] Add the vmovlbq, vmovltq intrinsic family.

Author: Simon Tatham Date: 2020-02-18T09:34:50Z New Revision: 5e97940cd27961a0b872ff551fc98135507288b3 URL: https://github.com/llvm/llvm-project/commit/5e97940cd27961a0b872ff551fc98135507288b3 DIFF: https://github.com/llvm/llvm-project/commit/5e97940cd27961a0b872ff551fc98135507288b3.diff LOG:

[clang] c32af44 - [ARM, MVE] Add the vmovnbq, vmovntq intrinsic family.

Author: Simon Tatham Date: 2020-02-18T09:34:50Z New Revision: c32af4447f79f5e7f246917fe1c3f58b2f6fc2a6 URL: https://github.com/llvm/llvm-project/commit/c32af4447f79f5e7f246917fe1c3f58b2f6fc2a6 DIFF: https://github.com/llvm/llvm-project/commit/c32af4447f79f5e7f246917fe1c3f58b2f6fc2a6.diff LOG:

[PATCH] D74334: [ARM,MVE] Add the vrev16q, vrev32q, vrev64q family.

This revision was automatically updated to reflect the committed changes. Closed by commit rGb6236e94799e: [ARM,MVE] Add the vrev16q, vrev32q, vrev64q family. (authored by simon_tatham). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74334/new/ https

[PATCH] D74332: [ARM,MVE] Add intrinsics for int <-> float conversion.

This revision was automatically updated to reflect the committed changes. Closed by commit rGdf3ed6c0fe31: [ARM,MVE] Add intrinsics for int <-> float conversion. (authored by simon_tatham). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74332/new/ ht

[PATCH] D74335: [ARM,MVE] Add intrinsics vclzq and vclsq.

This revision was automatically updated to reflect the committed changes. Closed by commit rG68b49f7ef49e: [ARM,MVE] Add intrinsics vclzq and vclsq. (authored by simon_tatham). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74335/new/ https://reviews

[PATCH] D74333: [ARM,MVE] Add intrinsics for FP rounding operations.

This revision was automatically updated to reflect the committed changes. Closed by commit rGc8b3196e5430: [ARM,MVE] Add intrinsics for FP rounding operations. (authored by simon_tatham). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74333/new/ http

[PATCH] D74337: [ARM,MVE] Add the vmovnbq,vmovntq intrinsic family.

This revision was automatically updated to reflect the committed changes. Closed by commit rGc32af4447f79: [ARM,MVE] Add the vmovnbq,vmovntq intrinsic family. (authored by simon_tatham). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74337/new/ https

[PATCH] D74336: [ARM,MVE] Add the vmovlbq,vmovltq intrinsic family.

This revision was automatically updated to reflect the committed changes. Closed by commit rG5e97940cd279: [ARM,MVE] Add the vmovlbq,vmovltq intrinsic family. (authored by simon_tatham). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74336/new/ https

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

Naghasan added inline comments. Comment at: clang/include/clang/Basic/LangOptions.def:206 LANGOPT(OpenCLCPlusPlusVersion , 32, 0, "C++ for OpenCL version") +ENUM_LANGOPT(SYCLVersion, SYCLVersionList, 4, SYCLVersionList::undefined, "Version of the SYCL standard used") LANGO

[PATCH] D69782: Summary: Instead of dropping all the ranges associated with a Diagnostic when converting them to a ClangTidy error, instead attach them to the ClangTidyError, so they can be consumed b

alexfh added a comment. Thanks for the update! Please upload patches with full context. That makes navigating the code much easier during reviews. See https://llvm.org/docs/Phabricator.html A few more comments inline. Comment at: include/clang/Tooling/Core/Diagnostic.h:62-70

[clang] 8b65f79 - [OpenCL] Add Arm dot product builtin functions

Author: Sven van Haastregt Date: 2020-02-18T10:02:06Z New Revision: 8b65f792a0a96a091c24fdacf4ce04686e0eefb2 URL: https://github.com/llvm/llvm-project/commit/8b65f792a0a96a091c24fdacf4ce04686e0eefb2 DIFF: https://github.com/llvm/llvm-project/commit/8b65f792a0a96a091c24fdacf4ce04686e0eefb2.diff

[PATCH] D73903: [AArch64][SVE] Add remaining SVE2 intrinsics for widening DSP operations

sdesmalen accepted this revision. sdesmalen added a comment. This revision is now accepted and ready to land. LGTM! Comment at: llvm/include/llvm/IR/IntrinsicsAArch64.td:1100 [IntrNoMem]>; + class SVE2_2VectorArg_Narrowing_Intrinsic nit: unn

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

bader marked 3 inline comments as done. bader added inline comments. Comment at: clang/include/clang/Basic/LangOptions.def:206 LANGOPT(OpenCLCPlusPlusVersion , 32, 0, "C++ for OpenCL version") +ENUM_LANGOPT(SYCLVersion, SYCLVersionList, 4, SYCLVersionList::undefined, "Versi

[PATCH] D72523: [remark][diagnostics] Using clang diagnostic handler for IR input files

jeroen.dobbelaere added a comment. This change triggers a crash in a release build of llvm: See https://bugs.llvm.org/show_bug.cgi?id=44896 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72523/new/ https://reviews.llvm.org/D72523

[PATCH] D73462: [dwarf-5] Support DebugInfo for Defaulted parameters for C++ templates

awpandey added a comment. Hi @aprantl, I have included all of your suggestions. Can I merge this? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73462/new/ https://reviews.llvm.org/D73462 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[clang] 58f66f8 - [ARM,CDE] Cosmetic changes, additonal driver tests

Author: Mikhail Maltsev Date: 2020-02-18T10:23:09Z New Revision: 58f66f8af01db7f7f349654793a2b88376644122 URL: https://github.com/llvm/llvm-project/commit/58f66f8af01db7f7f349654793a2b88376644122 DIFF: https://github.com/llvm/llvm-project/commit/58f66f8af01db7f7f349654793a2b88376644122.diff LO

[PATCH] D74757: Fix compiler extension in standalone mode

serge-sans-paille added a comment. I still need to test many configurations, I'll report here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74757/new/ https://reviews.llvm.org/D74757 ___ cfe-commits m

[PATCH] D74757: Fix compiler extension in standalone mode

serge-sans-paille created this revision. serge-sans-paille added reviewers: Meinersbur, Keruspe. Herald added subscribers: llvm-commits, cfe-commits, mgorny. Herald added projects: clang, LLVM. serge-sans-paille added a comment. I still need to test many configurations, I'll report here. Use a d

[PATCH] D74704: Support -fuse-ld=lld for riscv

This revision was automatically updated to reflect the committed changes. Closed by commit rGdd230142d8a0: Support -fuse-ld=lld for riscv (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74704/new/ https://reviews.llvm.

[PATCH] D74732: [ARM,CDE] Cosmetic changes, additonal driver tests

This revision was automatically updated to reflect the committed changes. Closed by commit rG58f66f8af01d: [ARM,CDE] Cosmetic changes, additonal driver tests (authored by miyuki). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74732/new/ https://revi

[clang] dd23014 - Support -fuse-ld=lld for riscv

Author: serge-sans-paille Date: 2020-02-18T11:24:09+01:00 New Revision: dd230142d8a00f5f30c3930a2407000e845dcfbf URL: https://github.com/llvm/llvm-project/commit/dd230142d8a00f5f30c3930a2407000e845dcfbf DIFF: https://github.com/llvm/llvm-project/commit/dd230142d8a00f5f30c3930a2407000e845dcfbf.d

[PATCH] D70876: [clang-tidy] Add spuriously-wake-up-functions check

abelkocsis updated this revision to Diff 245113. abelkocsis added a comment. Test cases adding, checker modifying to pass new cases. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70876/new/ https://reviews.llvm.org/D70876 Files: clang-tools-extra

[PATCH] D74564: libclang: Add static build support for Windows

cristian.adam added a comment. I do not have commit rights, I need help to submit this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74564/new/ https://reviews.llvm.org/D74564 ___ cfe-commits ma

[PATCH] D73903: [AArch64][SVE] Add remaining SVE2 intrinsics for widening DSP operations

This revision was automatically updated to reflect the committed changes. Closed by commit rGd4576080da72: [AArch64][SVE] Add remaining SVE2 intrinsics for widening DSP operations (authored by kmclaughlin). Changed prior to commit: https://reviews.llvm.org/D73903?vs=244367&id=245114#toc Reposi

[PATCH] D74689: [clang-tidy] Better custom class support for performance-inefficient-vector-operation

njames93 updated this revision to Diff 245115. njames93 added a comment. - Added support for converting loops over c style arrays Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74689/new/ https://reviews.llvm.org/D74689 Files: clang-tools-extra/c

[PATCH] D74735: [analyzer] Add support for CXXInheritedCtorInitExpr.

martong added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h:872 +/// +/// Example: \c class T : public S { using S::S; }; T(1); +class CXXInheritedConstructorCall : public AnyFunctionCall { Perhaps the example cou

[PATCH] D74689: [clang-tidy] Better custom class support for performance-inefficient-vector-operation

njames93 updated this revision to Diff 245116. njames93 added a comment. - Small nit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74689/new/ https://reviews.llvm.org/D74689 Files: clang-tools-extra/clang-tidy/performance/InefficientVectorOperat

[clang] cc7a197 - Fix riscv/lld test interaction

Author: serge-sans-paille Date: 2020-02-18T12:34:07+01:00 New Revision: cc7a197f9f1039e36625249199aa652f84506802 URL: https://github.com/llvm/llvm-project/commit/cc7a197f9f1039e36625249199aa652f84506802 DIFF: https://github.com/llvm/llvm-project/commit/cc7a197f9f1039e36625249199aa652f84506802.d

[PATCH] D74735: [analyzer] Add support for CXXInheritedCtorInitExpr.

xazax.hun added a comment. If the AST is hard to work with would it make sense to try to change the AST a bit? Comment at: clang/lib/StaticAnalyzer/Core/CallEvent.cpp:944 + if (Data) { +loc::MemRegionVal MV(static_cast(Data)); +if (SymbolRef Sym = MV.getAsSymbol(true)

[PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

djtodoro updated this revision to Diff 245123. djtodoro added a comment. -Addressing the latest comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73534/new/ https://reviews.llvm.org/D73534 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Driver/CC1Option

[PATCH] D74760: [Analyzer] Fix for iterator modeling and checkers: handle negative numbers correctly

baloghadamsoftware created this revision. baloghadamsoftware added reviewers: NoQ, Szelethus. baloghadamsoftware added a project: clang. Herald added subscribers: steakhal, Charusso, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, whisperity. Currently, using negative numbers in iterato

[PATCH] D74724: [AArch64][SVE] CodeGen of ACLE Builtin Types

sdesmalen updated this revision to Diff 245127. sdesmalen added a comment. - Inlined function into switch statement - Removed changes to IRTranslator.cpp from this patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74724/new/ https://reviews.llvm.org/D74724 Files: clang/lib/CodeGen

[PATCH] D71433: [analyzer] CERT: POS34-C

Szelethus added a comment. Herald added a subscriber: martong. I think for an alpha checker this is ready to land if you're ready -- do you have commit access or need assistance? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71433/new/ https://reviews.llvm.org/D71433 ___

[clang] a82d3e8 - Reland "[DebugInfo] Enable the debug entry values feature by default"

Author: Djordje Todorovic Date: 2020-02-18T14:41:08+01:00 New Revision: a82d3e8a6e67473c94a5ce6345372748e9b61718 URL: https://github.com/llvm/llvm-project/commit/a82d3e8a6e67473c94a5ce6345372748e9b61718 DIFF: https://github.com/llvm/llvm-project/commit/a82d3e8a6e67473c94a5ce6345372748e9b61718.d

[PATCH] D74763: [libTooling] Add option for `buildAST` to report diagnostics.

ymandel created this revision. ymandel added a reviewer: gribozavr. Herald added a project: clang. Currently, `buildAST[WithArgs]` either succeeds or fails. This patch adds support for the caller to pass a `DiagnosticConsumer` to receive all relevant diagnostics. Repository: rG LLVM Github Mo

[clang] 523cae3 - [libTooling] Add option for `buildAST` to report diagnostics.

Author: Yitzhak Mandelbaum Date: 2020-02-18T09:11:51-05:00 New Revision: 523cae324d79d2e532d2be797058a94e8214ec45 URL: https://github.com/llvm/llvm-project/commit/523cae324d79d2e532d2be797058a94e8214ec45 DIFF: https://github.com/llvm/llvm-project/commit/523cae324d79d2e532d2be797058a94e8214ec45.

[PATCH] D74015: [AIX][Frontend] C++ ABI customizations for AIX boilerplate

Xiangling_L marked an inline comment as done. Xiangling_L added a comment. ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74015/new/ https://reviews.llvm.org/D74015 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[PATCH] D74763: [libTooling] Add option for `buildAST` to report diagnostics.

This revision was automatically updated to reflect the committed changes. Closed by commit rG523cae324d79: [libTooling] Add option for `buildAST` to report diagnostics. (authored by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74763/new/

[PATCH] D74765: [compiler-rt] Addd FreeBSD arm64 sanitizer support

andrew created this revision. andrew added a reviewer: Sanitizers. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, kristof.beyls, krytarowski, arichardson, dberris, emaste. Herald added projects: clang, Sanitizers, LLVM. Add support for asan, msan, and tsan on FreeBSD on aarch64.

[PATCH] D74766: [ARM] Fixing range checks for Neon's vqdmulhq_lane and vqrdmulhq_lane intrinsics

pratlucas created this revision. Herald added subscribers: cfe-commits, kristof.beyls. Herald added a project: clang. The range checks performed for the vqrdmulh_lane and vqrdmulh_lane Neon intrinsics were incorrectly using their return type as the base type for the range check performed on their

[PATCH] D74562: [OpenMP][OMPIRBuilder] Introducing the `OMPBuilderCBHelpers` helper class

fghanim updated this revision to Diff 245151. fghanim added a comment. addressing review comments - Adding a comment to explain minor change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74562/new/ https://reviews.llvm.org/D74562 Files: clang/l

[PATCH] D74765: [compiler-rt] Addd FreeBSD arm64 sanitizer support

andrew marked an inline comment as done. andrew added inline comments. Comment at: compiler-rt/lib/sanitizer_common/sanitizer_linux_libcdep.cpp:451-463 +# if defined(__aarch64__) || defined(__mips__) +// Variant I +// +// dtv = segbase[0]; +// dtv[2] = base of TLS

[PATCH] D74765: [compiler-rt] Addd FreeBSD arm64 sanitizer support

andrew updated this revision to Diff 245152. andrew marked an inline comment as done. andrew added a comment. Remove unintended changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74765/new/ https://reviews.llvm.org/D74765 Files: compiler-rt/l

[clang] cd2c5af - Reland D74436 "Change clang option -ffp-model=precise to select ffp-contract=on""

Author: Melanie Blower Date: 2020-02-18T06:55:36-08:00 New Revision: cd2c5af6dfd6e32ee7043894bcb42981ce99e8ac URL: https://github.com/llvm/llvm-project/commit/cd2c5af6dfd6e32ee7043894bcb42981ce99e8ac DIFF: https://github.com/llvm/llvm-project/commit/cd2c5af6dfd6e32ee7043894bcb42981ce99e8ac.diff

[clang] 4518aab - [AArch64] Add Cortex-A34 Support for clang and llvm

Author: Luke Geeson Date: 2020-02-18T14:56:16Z New Revision: 4518aab289a090a668af0ca4ecde976e18fb2b1e URL: https://github.com/llvm/llvm-project/commit/4518aab289a090a668af0ca4ecde976e18fb2b1e DIFF: https://github.com/llvm/llvm-project/commit/4518aab289a090a668af0ca4ecde976e18fb2b1e.diff LOG: [

[PATCH] D74483: [AArch64] Add Cortex-A34 Support for clang and llvm

LukeGeeson closed this revision. LukeGeeson marked an inline comment as not done. LukeGeeson added inline comments. Comment at: llvm/unittests/Support/TargetParserTest.cpp:784 EXPECT_TRUE(testAArch64CPU( + "cortex-a34", "armv8-a", "crypto-neon-fp-armv8", + AArch64::A

[PATCH] D74606: [clangd] Add add commit characters to the server capabilities

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:562 llvm::json::Object{ + {"allCommitCharacters", " \t()[]{}<>:;,+-/*%^&#?.=\

[PATCH] D74735: [analyzer] Add support for CXXInheritedCtorInitExpr.

baloghadamsoftware added a comment. In D74735#1880390 , @xazax.hun wrote: > If the AST is hard to work with would it make sense to try to change the AST > a bit? Hmm, you mean making `CXXConstructExpr` an abstract base with subclasses `CXXSimpleConstru

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

ABataev added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:2549 + Opts.SYCLIsDevice = Opts.SYCL && Args.hasArg(options::OPT_fsycl_is_device); + if (Opts.SYCL || Opts.SYCLIsDevice) { +// -sycl-std applies to any SYCL source, not only those containin

[PATCH] D74769: [AArch64][SVE] Add SVE2 intrinsics for polynomial arithmetic

kmclaughlin created this revision. kmclaughlin added reviewers: sdesmalen, c-rhodes, dancgr, cameron.mcinally, efriedma. Herald added subscribers: psnobl, rkruppe, hiraditya, kristof.beyls, tschuett. Herald added a reviewer: rengolin. Herald added a project: LLVM. Implements the following intrins

[PATCH] D73186: [AST] Add fixed-point multiplication constant evaluation.

ebevhan added inline comments. Comment at: clang/lib/Basic/FixedPoint.cpp:242 + } else +Overflowed = Result < Min || Result > Max; + rjmccall wrote: > leonardchan wrote: > > ebevhan wrote: > > > rjmccall wrote: > > > > ebevhan wrote: > > > > > ebevhan wrote:

[clang] 2bf44d1 - Revert "Reland "[DebugInfo] Enable the debug entry values feature by default""

Author: Djordje Todorovic Date: 2020-02-18T16:38:11+01:00 New Revision: 2bf44d11cb42a952bdeb778210d8b3e737f0b96e URL: https://github.com/llvm/llvm-project/commit/2bf44d11cb42a952bdeb778210d8b3e737f0b96e DIFF: https://github.com/llvm/llvm-project/commit/2bf44d11cb42a952bdeb778210d8b3e737f0b96e.d

[PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

stella.stamenova added a comment. It looks like this broke the windows lldb bot: lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/13902 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73534/new/ https://reviews.llvm.org/D73534 ___ cf

[PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

djtodoro added a comment. Thanks for reporting that, are you sure this was the cause of the failure? I'll revert this while investigate, but it does not seem to me this is related to this patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73534/new/ https://reviews.llvm.org/D73534

[PATCH] D74116: [Sema][C++] Propagate conversion type in order to specialize the diagnostics

Anastasia updated this revision to Diff 245164. Anastasia retitled this revision from "[Sema][C++] Strawman patch to propagate conversion type in order to specialize the diagnostics" to "[Sema][C++] Propagate conversion type in order to specialize the diagnostics". Anastasia added a comment. - U

[PATCH] D74631: [clang][XCOFF] Indicate that XCOFF does not support COMDATs

daltenty added a comment. In D74631#1876995 , @sfertile wrote: > 1. We should probably update the COMDAT section of the lang ref to mention > XCOFF doesn't support COMDATS. I will update the langref as suggested. > 2. Will we report an error somewhere

[PATCH] D74735: [analyzer] Add support for CXXInheritedCtorInitExpr.

martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/ExprEngineCXX.cpp:436 case CXXConstructExpr::CK_Complete: { +assert(CE && "Complete constructors cannot be inherited!"); std::tie(State, Target) = baloghadamsoftware wrote: > mar

[PATCH] D73186: [AST] Add fixed-point multiplication constant evaluation.

rjmccall added inline comments. Comment at: clang/lib/Basic/FixedPoint.cpp:242 + } else +Overflowed = Result < Min || Result > Max; + ebevhan wrote: > rjmccall wrote: > > leonardchan wrote: > > > ebevhan wrote: > > > > rjmccall wrote: > > > > > ebevhan wrote

[PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

stella.stamenova added a comment. I am not sure this was the cause of the failure, but other than your patches, there was only one other change in the first failing build. I have not had time to fully investigate yet. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73534/new/ https://re

[clang] 260b91f - Use getLocation() in "too few/too many arguments" diagnostic

Author: John Marshall Date: 2020-02-18T11:23:17-05:00 New Revision: 260b91f379c8f86d3d6008648b3f2a945a007888 URL: https://github.com/llvm/llvm-project/commit/260b91f379c8f86d3d6008648b3f2a945a007888 DIFF: https://github.com/llvm/llvm-project/commit/260b91f379c8f86d3d6008648b3f2a945a007888.diff

Re: patch via mailing list: Use getLocation() in too few/many arguments diagnostic

I've commit on your behalf in 260b91f379c8f86d3d6008648b3f2a945a007888, thank you for the patch! ~Aaron On Mon, Feb 10, 2020 at 12:42 PM Aaron Ballman wrote: > > On Mon, Feb 10, 2020 at 10:06 AM John Marshall > wrote: > > > > Thanks Aaron (and Hubert). > > > > I've attached an updated patch tha

[PATCH] D74735: [analyzer] Add support for CXXInheritedCtorInitExpr.

NoQ marked 2 inline comments as done. NoQ added a comment. In D74735#1880617 , @baloghadamsoftware wrote: > In D74735#1880390 , @xazax.hun wrote: > > > If the AST is hard to work with would it make sense to try to

Re: patch via mailing list: Use getLocation() in too few/many arguments diagnostic

On 18 Feb 2020, at 16:24, Aaron Ballman wrote: > > I've commit on your behalf in > 260b91f379c8f86d3d6008648b3f2a945a007888, thank you for the patch! Thanks very much, Aaron. I regret to report that this appears to have broken an additional test [1] that I didn't see when running the test suit

[clang] 66c0162 - Hopefully fixing a failing build bot.

Author: Aaron Ballman Date: 2020-02-18T11:39:23-05:00 New Revision: 66c01627719f088bff9a0d09655a8ca0842b2c82 URL: https://github.com/llvm/llvm-project/commit/66c01627719f088bff9a0d09655a8ca0842b2c82 DIFF: https://github.com/llvm/llvm-project/commit/66c01627719f088bff9a0d09655a8ca0842b2c82.diff

  1   2   3   >