[PATCH] D74411: [clangd] Query constructors in the index during rename.

hokein added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:326 + // When querying references for a class, clangd's own index will also return + // references of the corresponding class constructors, but this is not true + // for all index backends,

[PATCH] D69950: Reapply "Fix crash on switch conditions of non-integer types in templates"

smeenai added a comment. Similar to the case @mstorsjo mentioned, this also causes the following code to fail now: struct S { unsigned size; }; template struct U { S s; unsigned size() { return s.size(); } }; This is obviously invalid, and I personally prefer get

[PATCH] D72242: Fix crash on value dependent bitfields in if conditions in templates

hans added a comment. In D72242#1872827 , @smeenai wrote: > CC @hans for the 10.0 branch. Cherry-picked to 10.x as 808f8a632f8bc12830157c57461ae8f848c566a3 . Please let me know if the

[PATCH] D74411: [clangd] Query constructors in the index during rename.

hokein updated this revision to Diff 244345. hokein marked 3 inline comments as done. hokein added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74411/new/ https://reviews.llvm.org/D74411 Files: clang-tools-extra/cla

[PATCH] D74372: [OpenMP][IRBuilder] Perform finalization (incl. outlining) late

plotfi added a comment. In D74372#1873665 , @jdoerfert wrote: > In D74372#1873623 , @plotfi wrote: > > > Could this be reverted for the time being so that bots can go green? There > > appear to be an awful lot of c

[PATCH] D74411: [clangd] Query constructors in the index during rename.

kbobyrev accepted this revision. kbobyrev added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74411/new/ https://reviews.llvm.org/D74411

[PATCH] D74395: [clangd] Add tracer to the rename workflow, NFC

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:345 + +SPAN_ATTACH(Tracer, FileAndOccurrences.first(), +static_cast(Ranges.size())); A tracer message here would be helpful! Comment at

[PATCH] D74464: Fix integration of pass plugins with llvm dylib

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. Looks reasonable to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74464/new/ https://reviews.llvm.org/D74464

[PATCH] D74529: [clang-tidy] Added a case to UnconventionalAssignOperatorCheck.

balazske created this revision. Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp, xazax.hun. Herald added a project: clang. The check accepts now a `return (*this = something);` as return statement too (beneath of `*this`). Repository: rG LLVM Github Monorepo https://review

[PATCH] D73637: Fix handling of OO_Spaceship in DecodeOperatorCall

sberg added a comment. ping^2 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73637/new/ https://reviews.llvm.org/D73637 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] c1394af - Don't call memcpy(p, 0, 0).

Author: Richard Smith Date: 2020-02-13T00:51:12-08:00 New Revision: c1394afb8df6445b46f42546588f59668bd39ac6 URL: https://github.com/llvm/llvm-project/commit/c1394afb8df6445b46f42546588f59668bd39ac6 DIFF: https://github.com/llvm/llvm-project/commit/c1394afb8df6445b46f42546588f59668bd39ac6.diff

Re: [clang] 0e3a487 - PR12350: Handle remaining cases permitted by CWG DR 244.

Thanks, yes, fixed in llvmorg-11-init-3043-gc1394afb8df. On Thu, 13 Feb 2020 at 02:58, Kostya Serebryany via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Could this have caused a new ubsan failure? > > clang/lib/AST/NestedNameSpecifier.cpp:485:23: runtime error: null pointer > passed as ar

[PATCH] D73637: Fix handling of OO_Spaceship in DecodeOperatorCall

rsmith added a comment. An equivalent patch was landed as llvmorg-11-init-2132-gb96c6b65b93 to fix PR44786. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73637/new/ https://reviews.llvm.org/D73637 ___ cfe-commits mailing list cfe-c

[PATCH] D72362: [clang-tidy] misc-no-recursion: a new check

lebedev.ri updated this revision to Diff 244354. lebedev.ri marked 16 inline comments as done and an inline comment as not done. lebedev.ri added a comment. Ping. @aaron.ballman thank you for taking a look! Addressed review notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

mstorsjo added a comment. FYI this caused failed builds for aarch64 (when building with `-fno-signed-zeros`), hitting unreachable statements in TargetLowering::getNegatedExpression - see https://bugs.llvm.org/show_bug.cgi?id=44892. I guess that's a bug in the aarch64 backend and not with this

[PATCH] D72362: [clang-tidy] misc-no-recursion: a new check

lebedev.ri added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/NoRecursionCheck.cpp:28 +// 2. it is immutable, the way it was constructed it will stay. +template class ImmutableSmartSet { + ArrayRef Vector; aaron.ballman wrote: > "Smart" is not

[clang-tools-extra] 2c5ee78 - [clangd] Query constructors in the index during rename.

Author: Haojian Wu Date: 2020-02-13T10:10:12+01:00 New Revision: 2c5ee78de113484978450b834498e1b0e2aab5c4 URL: https://github.com/llvm/llvm-project/commit/2c5ee78de113484978450b834498e1b0e2aab5c4 DIFF: https://github.com/llvm/llvm-project/commit/2c5ee78de113484978450b834498e1b0e2aab5c4.diff LO

[PATCH] D74473: [analyzer] StdLibraryFunctionsChecker: Use platform dependent EOF and UCharMax

Szelethus added inline comments. Comment at: clang/test/Analysis/std-c-library-functions-eof.c:11 +// Unorthodox EOF value. +#define EOF (-2) + Maybe you could throw in a test where the definition isn't surrounded by parentheses? Repository: rG LLVM Github

[PATCH] D74473: [analyzer] StdLibraryFunctionsChecker: Use platform dependent EOF and UCharMax

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. LGTM! Very nice! I think you can commit as you please, granted you add core checkers to the test `RUN:` lines. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibrar

[PATCH] D74411: [clangd] Query constructors in the index during rename.

This revision was automatically updated to reflect the committed changes. Closed by commit rG2c5ee78de113: [clangd] Query constructors in the index during rename. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74411/new/ https:/

Re: [clang] 0130b6c - Don't assume a reference refers to at least sizeof(T) bytes.

Unless there's demand for it, I'd be inclined to pass on merging since it doesn't seem entirely trivial. On Wed, Feb 12, 2020 at 1:56 PM Richard Smith via cfe-commits wrote: > > It's a wrong-code bugfix, but we've had the bug since Clang 3.5, so it > doesn't seem urgent. > > Hans, what do you th

[PATCH] D74490: [Clang] Limit -fintegrated-cc1 to only one TU

hans added a comment. Cherry-picked to 10.x as 9c9e46d786d0581079e5018e550cbe187a1ec219 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74490/new/ https://reviews.llvm.org/D74490

[PATCH] D57054: [MachineOutliner][ARM][RFC] Add Machine Outliner support for ARM

samparker added a comment. How about removing Thumb-1 support until it's properly handled? I also suggest that this gets broken down a bit too, by handling the different types of function call in different patches, like getting tail-call support in first or something. Also, is this currently se

[PATCH] D73903: [AArch64][SVE] Add remaining SVE2 intrinsics for widening DSP operations

kmclaughlin updated this revision to Diff 244367. kmclaughlin added a comment. - Rebased & moved new intrinsics under the existing headers in IntrinsicsAArch64.td CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73903/new/ https://reviews.llvm.org/D73903 Files: llvm/include/llvm/IR/Int

[PATCH] D73775: [clang-tidy] Cover cases like (b && c && b) in the redundant expression check

alexeyr updated this revision to Diff 244369. alexeyr added a comment. @aaron.ballman Updated. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73775/new/ https://reviews.llvm.org/D73775 Files: clang-tools-extra/clang-tidy/misc/RedundantExpressionCheck.cpp clang-tools-extra/test/clang

[PATCH] D74513: [OpenMP][NFCI] Use the libFrontend DefaultKind in Clang

JonChesterfield added a comment. Nice. Thank you Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74513/new/ https://reviews.llvm.org/D74513 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[PATCH] D73775: [clang-tidy] Cover cases like (b && c && b) in the redundant expression check

alexeyr updated this revision to Diff 244370. alexeyr added a comment. Actually updated. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73775/new/ https://reviews.llvm.org/D73775 Files: clang-tools-extra/clang-tidy/misc/RedundantExpressionCheck.cpp clang-tools-extra/test/clang-tidy/

[PATCH] D74222: [AArch64][SVE] Add mul/mla/mls lane & dup intrinsics

This revision was automatically updated to reflect the committed changes. Closed by commit rG671cbc1fbba0: [AArch64][SVE] Add mul/mla/mls lane & dup intrinsics (authored by kmclaughlin). Changed prior to commit: https://reviews.llvm.org/D74222?vs=243164&id=244372#toc Repository: rG LLVM Gith

[PATCH] D74473: [analyzer] StdLibraryFunctionsChecker: Use platform dependent EOF and UCharMax

martong updated this revision to Diff 244376. martong marked 6 inline comments as done. martong added a comment. - Enable core checkers explicitly in test - Add ASCII art to depict a range list example Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7

[PATCH] D74473: [analyzer] StdLibraryFunctionsChecker: Use platform dependent EOF and UCharMax

martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:313-321 for (size_t I = 1; I != E; ++I) { const llvm::APSInt &Min = BVF.getValue(R[I - 1].second + 1ULL, T); const llvm::APSInt &Max = BVF.getValue(R[I]

[PATCH] D74411: [clangd] Query constructors in the index during rename.

thakis added a comment. Doesn't build on Mac: http://45.33.8.238/mac/7949/step_4.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74411/new/ https://reviews.llvm.org/D74411 ___ cfe-commits mailing lis

[PATCH] D73462: [dwarf-5] Support DebugInfo for Defaulted parameters for C++ templates

awpandey added a comment. Hi @aprantl , can you please inform me what extra changes should I make in this patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73462/new/ https://reviews.llvm.org/D73462 ___ cfe-commits mailing list cfe-comm

[PATCH] D74483: [AArch64] Add Cortex-A34 Support for clang and llvm

LukeGeeson updated this revision to Diff 244377. LukeGeeson marked an inline comment as done. LukeGeeson added a comment. - Added MIDR to Host.cpp - Fixed a clang test I missed (copy/paste error) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74483/new/ https://reviews.llvm.org/D74483 F

[PATCH] D73904: [clang] stop baremetal driver to append .a to lib

This revision was automatically updated to reflect the committed changes. Closed by commit rGc49866acceb1: [clang] stop baremetal driver to append .a to lib (authored by christof). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73904/new/ https://rev

[clang] c49866a - [clang] stop baremetal driver to append .a to lib

Author: Christof Douma Date: 2020-02-13T11:08:46Z New Revision: c49866acceb1ffbcc0f723993648f0678e92a91c URL: https://github.com/llvm/llvm-project/commit/c49866acceb1ffbcc0f723993648f0678e92a91c DIFF: https://github.com/llvm/llvm-project/commit/c49866acceb1ffbcc0f723993648f0678e92a91c.diff LOG

[clang-tools-extra] 9f63255 - Fix the mac buildbot failure.

Author: Haojian Wu Date: 2020-02-13T12:39:55+01:00 New Revision: 9f63255a742d7ec542f94e0265eac5147213d9f8 URL: https://github.com/llvm/llvm-project/commit/9f63255a742d7ec542f94e0265eac5147213d9f8 DIFF: https://github.com/llvm/llvm-project/commit/9f63255a742d7ec542f94e0265eac5147213d9f8.diff LO

[PATCH] D73720: [Analyzer] Use note tags to track container begin and and changes

baloghadamsoftware updated this revision to Diff 244380. baloghadamsoftware added a comment. In case of multiple container-related bugs only mark the container interesting on the correct bug path. Also a typo fixed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73720/new/ https://revie

[PATCH] D74411: [clangd] Query constructors in the index during rename.

hokein added a comment. In D74411#1873996 , @thakis wrote: > Doesn't build on Mac: http://45.33.8.238/mac/7949/step_4.txt sorry, it should be fixed in 9f63255a742d7ec542f94e0265eac5147213d9f8

[PATCH] D74483: [AArch64] Add Cortex-A34 Support for clang and llvm

SjoerdMeijer added a comment. Cheers, LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74483/new/ https://reviews.llvm.org/D74483 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-

[PATCH] D74395: [clangd] Add tracer to the rename workflow, NFC

hokein updated this revision to Diff 244384. hokein marked 3 inline comments as done. hokein added a comment. address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74395/new/ https://reviews.llvm.org/D74395 Files: clang-tools-ex

[PATCH] D74395: [clangd] Add tracer to the rename workflow, NFC

hokein added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:345 + +SPAN_ATTACH(Tracer, FileAndOccurrences.first(), +static_cast(Ranges.size())); kbobyrev wrote: > A tracer message here would be helpful! the message n

[PATCH] D74542: [ASTImporter] Prevent the ASTImporter from creating multiple main FileIDs.

teemperor created this revision. teemperor added reviewers: martong, a_sidorin. Herald added subscribers: cfe-commits, rnkovacs. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: clang. When importing the main FileID the ASTImporter currently gives it no

[clang-tools-extra] b1309a1 - [clangd] Print the Spelled RefKind.

Author: Haojian Wu Date: 2020-02-13T13:28:11+01:00 New Revision: b1309a18ba7314332cf05a40f48db4d42a51f214 URL: https://github.com/llvm/llvm-project/commit/b1309a18ba7314332cf05a40f48db4d42a51f214 DIFF: https://github.com/llvm/llvm-project/commit/b1309a18ba7314332cf05a40f48db4d42a51f214.diff LO

[PATCH] D57054: [MachineOutliner][ARM][RFC] Add Machine Outliner support for ARM

yroux marked 2 inline comments as done. yroux added a comment. Thanks for the comments Sam, Thumb1 is disabled in this version (see inline comment). The is to bundle Machine Outliner to -Oz like it was done for AArch64, but here it just run when the flags are used (-moutline for clang or -enab

[clang] 536456a - [analyzer] StdLibraryFunctionsChecker: Use platform dependent EOF and UCharMax

Author: Gabor Marton Date: 2020-02-13T13:51:51+01:00 New Revision: 536456a7e93d73b9ff4e92f3e51d1aa1c72628fe URL: https://github.com/llvm/llvm-project/commit/536456a7e93d73b9ff4e92f3e51d1aa1c72628fe DIFF: https://github.com/llvm/llvm-project/commit/536456a7e93d73b9ff4e92f3e51d1aa1c72628fe.diff

[PATCH] D74473: [analyzer] StdLibraryFunctionsChecker: Use platform dependent EOF and UCharMax

This revision was automatically updated to reflect the committed changes. Closed by commit rG536456a7e93d: [analyzer] StdLibraryFunctionsChecker: Use platform dependent EOF and UCharMax (authored by martong). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D74547: [clangd] Expose Code Completion score to the client

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Make it possible for the client to adjust the ranking by using the score Clangd calculates fo

[clang] d21664c - Fix integration of pass plugins with llvm dylib

Author: serge-sans-paille Date: 2020-02-13T14:18:08+01:00 New Revision: d21664cce1db8debe2528f36b1fbd2b8af9c9401 URL: https://github.com/llvm/llvm-project/commit/d21664cce1db8debe2528f36b1fbd2b8af9c9401 DIFF: https://github.com/llvm/llvm-project/commit/d21664cce1db8debe2528f36b1fbd2b8af9c9401.d

[PATCH] D74464: Fix integration of pass plugins with llvm dylib

This revision was automatically updated to reflect the committed changes. Closed by commit rGd21664cce1db: Fix integration of pass plugins with llvm dylib (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74464/new/ http

[PATCH] D73904: [clang] stop baremetal driver to append .a to lib

thakis added a comment. This breaks tests on Windows: http://45.33.8.238/win/8249/step_7.txt Please take a look and if it takes a while to fix, please revert while you investigate. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73904/new/ https://r

[PATCH] D74547: [clangd] Expose Code Completion score to the client

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/Protocol.h:1100 + /// NOTE: This excludes fuzzy matching score which is typically calculated on + /// the client side. + flo

[PATCH] D74547: [clangd] Expose Code Completion score to the client

sammccall added inline comments. Comment at: clang-tools-extra/clangd/test/protocol.test:42 # CHECK-NEXT:"label": " a", +# CHECK-NEXT:"score": 13.20762939453, # CHECK-NEXT:"sortText": "{{.*}}" oops, raced with you... you missed some

[PATCH] D73951: [Clang] [Driver]Add logic to search for flang frontend

DavidTruby accepted this revision. DavidTruby marked an inline comment as done. DavidTruby added a comment. LGTM but wait for someone else to approve Comment at: clang/lib/Driver/Driver.cpp:131 CCLogDiagnostics(false), CCGenDiagnostics(false), - TargetTriple(TargetT

[PATCH] D74547: [clangd] Expose Code Completion score to the client

kbobyrev updated this revision to Diff 244402. kbobyrev added a comment. Replace actual scores with regex for stability. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74547/new/ https://reviews.llvm.org/D74547 Files: clang-tools-extra/clangd/Cod

[PATCH] D74547: [clangd] Expose Code Completion score to the client

kbobyrev updated this revision to Diff 244403. kbobyrev added a comment. Replace one instance of hardcoded score missed in the previous update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74547/new/ https://reviews.llvm.org/D74547 Files: clang

[PATCH] D57054: [MachineOutliner][ARM][RFC] Add Machine Outliner support for ARM

yroux marked an inline comment as done. yroux added inline comments. Comment at: llvm/lib/CodeGen/MachineOutliner.cpp:1159 + MF.getProperties().reset(MachineFunctionProperties::Property::IsSSA); + MF.getProperties().set(MachineFunctionProperties::Property::NoPHIs); + MF.getPro

[PATCH] D74542: [ASTImporter] Prevent the ASTImporter from creating multiple main FileIDs.

martong accepted this revision. martong added a reviewer: balazske. martong added a subscriber: balazske. martong added a comment. This revision is now accepted and ready to land. Looks good to me! Thanks! Adding @balazske as another reviewer though. He worked on something related to this, where

[PATCH] D74550: [AArch64][SVE] Add SVE index intrinsic

kmclaughlin created this revision. kmclaughlin added reviewers: sdesmalen, andwar, efriedma, dancgr, cameron.mcinally. Herald added subscribers: psnobl, arphaman, rkruppe, hiraditya, kristof.beyls, tschuett. Herald added a reviewer: rengolin. Herald added a project: LLVM. Implements the @llvm.aa

[PATCH] D74542: [ASTImporter] Prevent the ASTImporter from creating multiple main FileIDs.

teemperor added a comment. In D74542#1874201 , @martong wrote: > Looks good to me! Thanks! > Adding @balazske as another reviewer though. He worked on something related > to this, where we also experienced an assert in `isBeforeInTranslationUnit`. IIRC

[PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

xbolva00 added a comment. Looks like this patch regressed the test-suite: https://lnt.llvm.org/db_default/v4/nts/recent_activity Now 45min+ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74436/new/ https://reviews.llvm.org/D74436 ___

[PATCH] D74547: [clangd] Expose Code Completion score to the client

kbobyrev updated this revision to Diff 244412. kbobyrev marked 3 inline comments as done. kbobyrev added a comment. Make a note that score is Clangd extension. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74547/new/ https://reviews.llvm.org/D74547

[clang-tools-extra] ff7b5ba - [clangd] Expose Code Completion score to the client

Author: Kirill Bobyrev Date: 2020-02-13T15:05:18+01:00 New Revision: ff7b5bac04fa4946935ea45214e29f267d6c1d7b URL: https://github.com/llvm/llvm-project/commit/ff7b5bac04fa4946935ea45214e29f267d6c1d7b DIFF: https://github.com/llvm/llvm-project/commit/ff7b5bac04fa4946935ea45214e29f267d6c1d7b.diff

[PATCH] D74547: [clangd] Expose Code Completion score to the client

This revision was automatically updated to reflect the committed changes. Closed by commit rGff7b5bac04fa: [clangd] Expose Code Completion score to the client (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74547/new/ https://r

[clang] a41550c - attempt to fix check-clang on windows after c49866ac

Author: Nico Weber Date: 2020-02-13T09:32:11-05:00 New Revision: a41550cff91b7fb2b56bf0e19ccb341bfd3e37b4 URL: https://github.com/llvm/llvm-project/commit/a41550cff91b7fb2b56bf0e19ccb341bfd3e37b4 DIFF: https://github.com/llvm/llvm-project/commit/a41550cff91b7fb2b56bf0e19ccb341bfd3e37b4.diff LO

[PATCH] D74542: [ASTImporter] Prevent the ASTImporter from creating multiple main FileIDs.

martong added a comment. In D74542#1874221 , @teemperor wrote: > In D74542#1874201 , @martong wrote: > > > Looks good to me! Thanks! > > Adding @balazske as another reviewer though. He worked on something > > rela

[PATCH] D73904: [clang] stop baremetal driver to append .a to lib

thakis added a comment. I fixed windows tests in a41550cff91b7fb2b56bf0e19ccb341bfd3e37b4 . Please watch bots after landing patches next time. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D74554: [ASTImporter] Added visibility check for scoped enums.

balazske created this revision. Herald added subscribers: cfe-commits, teemperor, gamesh411, Szelethus, dkrupp. Herald added a reviewer: martong. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: clang. ASTImporter makes now difference between C++11 scope

[PATCH] D74555: [clangd] Add a flag for setting isIncomplete flag true in all responses

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. To simplify re-ranking the code completion results, some clients might want to mimic receivin

[PATCH] D74447: [Clang] After integrated-cc1, ignore -disable-free when there are more than one job in the queue

thakis added a comment. I forgot another reason why "only do cc1 with a single TU" might be a good idea: In case crash recovery turns out to not work in all cases with in-process cc1, we could add a signal handler that on crash make the driver exec() itself with -fno-integrated-cc1 added, so th

[PATCH] D74550: [AArch64][SVE] Add SVE index intrinsic

cameron.mcinally accepted this revision. cameron.mcinally added a comment. This revision is now accepted and ready to land. Herald added a subscriber: tatyana-krasnukha. LGTM Comment at: llvm/include/llvm/IR/IntrinsicsAArch64.td:804 +[IntrNoMem]>; + class Adv

[PATCH] D73898: [analyzer] StdLibraryFunctionsChecker: Add argument constraints

martong updated this revision to Diff 244430. martong added a comment. - Rebase to master Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73898/new/ https://reviews.llvm.org/D73898 Files: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecke

[PATCH] D74262: [clang-offload-bundler] Enable handling of partially-linked fat objects

jdoerfert added inline comments. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:84 " o - object\n" + " oo - object; output file is a list of unbundled objects\n" " gch - precompile

[clang] 18789bf - [OPENMP50]Fix handling of clauses in parallel master taskloop directive.

Author: Alexey Bataev Date: 2020-02-13T11:00:01-05:00 New Revision: 18789bfe3a39f69f6cfe6490a24a61ea2ff0b5af URL: https://github.com/llvm/llvm-project/commit/18789bfe3a39f69f6cfe6490a24a61ea2ff0b5af DIFF: https://github.com/llvm/llvm-project/commit/18789bfe3a39f69f6cfe6490a24a61ea2ff0b5af.diff

[PATCH] D71734: [Modules] Handle tag types and complain about bad merges in C/Objective-C mode

bruno marked 3 inline comments as done. bruno added a comment. Thanks for taking a look Richard, comments inline. Comment at: clang/include/clang/AST/Decl.h:4009-4010 + + /// Store the ODR hash for this decl. + unsigned ODRHash; }; rsmith wrote: > We shouldn

[PATCH] D71734: [Modules] Handle tag types and complain about bad merges in C/Objective-C mode

bruno updated this revision to Diff 244435. bruno added a comment. Address Richard's review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71734/new/ https://reviews.llvm.org/D71734 Files: clang/include/clang/AST/Decl.h clang/include/clang/AST

[PATCH] D74562: [OpenMP][OMPIRBuilder] Introducing the `OMPBuilderCBHelpers` helper class

fghanim created this revision. fghanim added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, guansong. Herald added a project: clang. This patch introduces a new helper class `OMPBuilderCBHelpers`, which will contain all reusable C/C++ language specific function- alities required by

[PATCH] D74564: libclang: Add static build support for Windows

cristian.adam created this revision. cristian.adam added reviewers: chapuni, yvvan. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. On Linux and macOS it was possible to build libclang statically by configuring CMake with: -D LIBCLANG_BUILD_STATIC=ON -D LLVM_ENABLE_

[PATCH] D74555: [clangd] Add a flag for setting isIncomplete flag true in all responses

kadircet added a comment. some drive-by comments: if this is a client-specific option, wouldn't it be equally hard for client to just set this in the LSP layer, instead of telling clangd to do that? by looking at the current patch, it rather seems like a user-specific option, which will help u

[PATCH] D72281: [Matrix] Add matrix type to Clang (WIP).

fhahn added subscribers: jwakely, jfb. fhahn added a comment. @jwakely it would be great if you could have a brief look at our recent proposal for matrix support in Clang and could let us know if you have any concerns? The original proposal is being discussed on cfe-dev (http://lists.llvm.org/p

[PATCH] D73696: [clang][Index] Introduce a TemplateParm SymbolKind

kadircet added a comment. ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73696/new/ https://reviews.llvm.org/D73696 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D74387: [SYCL] Do not diagnose use of __float128

Fznamznon added a comment. > In D74387#1869845 , @rjmccall wrote: > >> The right approach here is probably what we do in ObjC ARC when we see types >> that are illegal in ARC: in system headers, we allow the code but add a >> special `UnavailableAttr` to

[PATCH] D73369: [clangd] Simplify "preferred" vs "definition" logic a bit in XRefs AST code.

kadircet added a comment. ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73369/new/ https://reviews.llvm.org/D73369 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[clang] e0ca479 - [OPENMP50]Add cancellation support in taskloop-based directives.

Author: Alexey Bataev Date: 2020-02-13T12:03:43-05:00 New Revision: e0ca4792fa4598359dc5364bcc466f7e78616113 URL: https://github.com/llvm/llvm-project/commit/e0ca4792fa4598359dc5364bcc466f7e78616113 DIFF: https://github.com/llvm/llvm-project/commit/e0ca4792fa4598359dc5364bcc466f7e78616113.diff

[PATCH] D71830: [OpenMP][Part 2] Use reusable OpenMP context/traits handling

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:185 +// An argument of type \p type with name \p name. +class GenericPointerArgument : Argument { + string Type = type; jdoerfert wrote: > aaron.ballman wrote: > > The name seems

[clang] 43b98ff - [OPENMP][DOCS]Update status of support constructs, NFC.

Author: Alexey Bataev Date: 2020-02-13T12:28:17-05:00 New Revision: 43b98ffed08a5691dd2d8275b8952569f55f015d URL: https://github.com/llvm/llvm-project/commit/43b98ffed08a5691dd2d8275b8952569f55f015d DIFF: https://github.com/llvm/llvm-project/commit/43b98ffed08a5691dd2d8275b8952569f55f015d.diff

[PATCH] D73775: [clang-tidy] Cover cases like (b && c && b) in the redundant expression check

aaron.ballman accepted this revision. aaron.ballman added a comment. Still LGTM, thank you! If you need me to commit this on your behalf, I'm happy to do so, just let me know. It'll have to wait until next week, though (unless someone else does it first). CHANGES SINCE LAST ACTION https://re

[PATCH] D72362: [clang-tidy] misc-no-recursion: a new check

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from some nits. Comment at: clang-tools-extra/clang-tidy/misc/NoRecursionCheck.cpp:70 + +template class SmartSmallSetVector { +public: -

[PATCH] D74473: [analyzer] StdLibraryFunctionsChecker: Use platform dependent EOF and UCharMax

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/CheckerHelpers.cpp:114-117 + const auto MacroIt = llvm::find_if( + PP.macros(), [&](const auto &K) { return K.first->getName() == Macro; }); + if (MacroIt == PP.macro_end()) +return llvm::None; --

[PATCH] D74214: [clang-tidy] Fix PR#34798 'readability-braces-around-statements breaks statements containing braces.'

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/BracesAroundStatementsCheck.cpp:76-77 + + // We need to check that it is not 'InitListExpr' which ends with + // the tokens '};' because it will break the following analysis + tok::Toke

[PATCH] D74564: libclang: Add static build support for Windows

cristian.adam added a comment. Build with this patch being built on GitHub Actions on Windows MSVC, Windows MinGW, Linux, macOS: https://github.com/cristianadam/llvm-project/actions/runs/38838989 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74564

[PATCH] D74473: [analyzer] StdLibraryFunctionsChecker: Use platform dependent EOF and UCharMax

Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/CheckerHelpers.cpp:114-117 + const auto MacroIt = llvm::find_if( + PP.macros(), [&](const auto &K) { return K.first->getName() == Macro; }); + if (MacroIt == PP.macro_end()) +return llvm::None;

[PATCH] D74550: [AArch64][SVE] Add SVE index intrinsic

andwar added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:10923 +static SDValue LowerSVEIntrinsicIndex(SDNode *N, SelectionDAG &DAG) { + SDLoc dl(N); + SDValue Op1 = N->getOperand(1); [nit] This should be `DL`: https://llvm.org/

[PATCH] D74417: [clang][ARC] Remove invalid assertion that can crash clangd

dgoldman added a comment. In D74417#1873287 , @erik.pilkington wrote: > This looks good, but please add a testcase. Added but it's still failing due to a different assertion failure, do you think this could be because the abbreviation is different for

[PATCH] D74554: [ASTImporter] Added visibility check for scoped enums.

shafik added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:2600 + EnumDecl *FoundDef = FoundEnum->getDefinition(); + if (D->isThisDeclarationADefinition() && FoundDef) +return Importer.MapImported(D, FoundDef); Can you e

[PATCH] D74417: [clang][ARC] Remove invalid assertion that can crash clangd

dgoldman updated this revision to Diff 244467. dgoldman added a comment. - Add test (fails due to different assertion) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74417/new/ https://reviews.llvm.org/D74417 Files: clang/lib/Serialization/ASTWri

LLVM buildmaster will be updated and restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 5PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D73775: [clang-tidy] Cover cases like (b && c && b) in the redundant expression check

alexeyr added a comment. Yes, I do. Thank you (and @Eugene.Zelenko) for your help making this better! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73775/new/ https://reviews.llvm.org/D73775 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D74569: [clang-scan-deps] Switch to using a ThreadPool

aganea updated this revision to Diff 244475. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74569/new/ https://reviews.llvm.org/D74569 Files: clang/tools/clang-scan-deps/ClangScanDeps.cpp Index: clang/tools/clang-scan-deps/ClangScanDeps.cpp

[PATCH] D74569: [clang-scan-deps] Switch to using a ThreadPool

aganea created this revision. aganea added reviewers: arphaman, dexonsmith, Bigcheese. Herald added subscribers: llvm-commits, cfe-commits, tschuett, hiraditya. Herald added projects: clang, LLVM. aganea updated this revision to Diff 244475. This was already reviewed as part of D71775

[clang] 2fb6268 - [OPENMP50]Add support for hint clause in atomic directive.

Author: Alexey Bataev Date: 2020-02-13T13:28:43-05:00 New Revision: 2fb6268854f178609e974002e4781dbdb1074b90 URL: https://github.com/llvm/llvm-project/commit/2fb6268854f178609e974002e4781dbdb1074b90 DIFF: https://github.com/llvm/llvm-project/commit/2fb6268854f178609e974002e4781dbdb1074b90.diff

  1   2   >