jdoerfert added inline comments.
================
Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:84
" o - object\n"
+ " oo - object; output file is a list of unbundled
objects\n"
" gch - precompiled-header\n"
----------------
ABataev wrote:
> Hmm, are you going to introduce a new kind of output? It really requires RFC.
This is the offload-bundler tool, right? Who is using that except OpenMP (and
SYCL)?
Is there a reason for `oo`? `uo` (=unboundled object), or `do` (=device object)?
================
Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:160
+ }
+
/// Write the header of the bundled file to \a OS based on the information
----------------
I don't understand the comment. If \p FileName is a list of outputs, how does
this work?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74262/new/
https://reviews.llvm.org/D74262
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
