[PATCH] D73052: [clang-tidy] RenamerClangTidy now renames dependent member expr when the member can be resolved

njames93 updated this revision to Diff 241515. njames93 added a comment. - Streamline memberExpr matchers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73052/new/ https://reviews.llvm.org/D73052 Files: clang-tools-extra/clang-tidy/bugprone/Reser

[clang] af3e884 - Speed up compilation of ASTImporter

Author: Reid Kleckner Date: 2020-01-30T11:01:24-08:00 New Revision: af3e88495627c9b150814ff13e5749e1ed31c5d3 URL: https://github.com/llvm/llvm-project/commit/af3e88495627c9b150814ff13e5749e1ed31c5d3 DIFF: https://github.com/llvm/llvm-project/commit/af3e88495627c9b150814ff13e5749e1ed31c5d3.diff

[PATCH] D73667: Speed up compilation of ASTImporter

This revision was automatically updated to reflect the committed changes. Closed by commit rGaf3e88495627: Speed up compilation of ASTImporter (authored by rnk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73667/new/ https://reviews.llvm.org/D7366

[PATCH] D73052: [clang-tidy] RenamerClangTidy now renames dependent member expr when the member can be resolved

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 62347 tests passed, 1 failed and 839 were skipped. failed: libc++.std/containers/sequences/array/array_creation/to_array.fail.cpp {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green

[PATCH] D73242: [WPD/LowerTypeTests] Delay lowering/removal of type tests until after ICP

tejohnson added a comment. In D73242#1849484 , @tejohnson wrote: > Both of these approaches need the type tests to determine the correct address > point offset (the offset in the type test) to use in the compare sequence. I typed this too fast - the off

[PATCH] D73675: Avoid many std::tie/tuple instantiations in ASTImporter

rnk planned changes to this revision. rnk marked an inline comment as done. rnk added a comment. In D73675#1849182 , @martong wrote: > Thanks for this patch too! > However, I have a minor concern with this new approach: > If `importSeq` fails then a `ToS

Re: Getting started

Hi Anshil, take a look at this: https://clang.llvm.org/docs/InternalsManual.html cxx1x is probably done already, but cxx2a has some outstanding features ;) In general, please use 'cfe-dev' instead of 'cfe-commits'. There is the normal discussion and questions/answers for developers. Regards Jon

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

JonasToth added a comment. In D54943#1841086 , @AlexanderLanin wrote: > In D54943#1815772 , @0x8000- > wrote: > > > This generated 56 "const const" declarations, of which 25 were triple const! > This could b

[PATCH] D73734: [Fuchsia] Never link in implicit "system dependencies" of sanitizer runtimes

mcgrathr created this revision. mcgrathr added a reviewer: phosek. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is never appropriate on Fuchsia and any future needs for system library dependencies of compiler-supplied runtimes will be addressed via `.deplibs` instead

[PATCH] D73734: [Fuchsia] Never link in implicit "system dependencies" of sanitizer runtimes

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM % nit Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:586 ArgStringList &CmdArgs) { + if (Triple.isOSFuchsia()) { +// F

[PATCH] D73354: clang-format: insert trailing commas into containers.

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. I'm happy if you are, I think given that you've really been one of the main contributors of clang-format [JS] for the last number of years you are the best person to probably assess the impact on Javascript code. Thanks for

[PATCH] D73354: clang-format: insert trailing commas into containers.

MyDeveloperDay added a comment. Nit: don't forget the ClangFormatStyleOption.rst and ReleaseNote.rst changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73354/new/ https://reviews.llvm.org/D73354 ___

[PATCH] D73282: Fix debug-info generation for block invocations so that we set the LinkageName instead of the Name

dblaikie added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:3659 // Use llvm function name. -Name = Fn->getName(); +if (Fn->getName().startswith("___Z")) + LinkageName = Fn->getName(); shafik wrote: > dblaikie wrote: > > shafik

[PATCH] D73738: [Clang][Bundler][NFC] Replace SmallString<...> with StringRef

sdmitriev created this revision. sdmitriev added a reviewer: ABataev. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D73738 Files: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp Index: clang/too

[PATCH] D73738: [Clang][Bundler][NFC] Replace SmallString<...> with StringRef

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73738/new/ https://reviews.llvm.org/D73738 ___

[clang] 5be2ca2 - [Clang][Bundler][NFC] Replace SmallString<...> with StringRef

Author: Sergey Dmitriev Date: 2020-01-30T12:50:04-08:00 New Revision: 5be2ca29217ad977f2479bfc530127c7fb418963 URL: https://github.com/llvm/llvm-project/commit/5be2ca29217ad977f2479bfc530127c7fb418963 DIFF: https://github.com/llvm/llvm-project/commit/5be2ca29217ad977f2479bfc530127c7fb418963.dif

[PATCH] D73675: Avoid many std::tie/tuple instantiations in ASTImporter

rnk updated this revision to Diff 241552. rnk added a comment. - Rewrite with importChecked, no importSeq Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73675/new/ https://reviews.llvm.org/D73675 Files: clang/lib/AST/ASTImporter.cpp Index: clang

[PATCH] D73738: [Clang][Bundler][NFC] Replace SmallString<...> with StringRef

This revision was automatically updated to reflect the committed changes. Closed by commit rG5be2ca29217a: [Clang][Bundler][NFC] Replace SmallString<...> with StringRef (authored by sdmitriev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73738/new/

[PATCH] D73208: [objc_direct] fix codegen for mismatched Decl/Impl return types

dexonsmith added a comment. In D73208#1837909 , @MadCoder wrote: > In D73208#1836789 , @dexonsmith > wrote: > > > I think we're talking across each other. The idea is check the type when > > generating the implem

[PATCH] D73675: Avoid many std::tie/tuple instantiations in ASTImporter

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 62352 tests passed, 1 failed and 839 were skipped. failed: libc++.std/containers/sequences/array/array_creation/to_array.fail.cpp {icon times-circle color=red} clang-tidy: fail. clang-tidy found 0 errors and 14

[PATCH] D73734: [Fuchsia] Never link in implicit "system dependencies" of sanitizer runtimes

mcgrathr updated this revision to Diff 241560. mcgrathr added a comment. builds now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73734/new/ https://reviews.llvm.org/D73734 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp Index: clang/lib/Dr

[PATCH] D73734: [Fuchsia] Never link in implicit "system dependencies" of sanitizer runtimes

mcgrathr updated this revision to Diff 241561. mcgrathr added a comment. style nit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73734/new/ https://reviews.llvm.org/D73734 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp Index: clang/lib/Driv

[PATCH] D73052: [clang-tidy] RenamerClangTidy now renames dependent member expr when the member can be resolved

njames93 added a comment. I toyed with the idea of checking the access specifier for the dependent base classes, but I'm pretty sure it doesn't matter. If the compile finds 2 look ups in one base class it will pick the later dependancy regardless of whether its private or not. And if the compil

[PATCH] D73363: Verify that clang's max alignment is <= LLVM's max alignment

rnk added inline comments. Comment at: clang/lib/CodeGen/CGValue.h:18 #include "clang/AST/ASTContext.h" +#include "clang/Sema/Sema.h" #include "clang/AST/Type.h" This includes Sema.h into every codegen file that uses CGValue.h (most of them). That seems bad fo

[clang] 01943a5 - Move verification of Sema::MaximumAlignment to a .cpp file

Author: Reid Kleckner Date: 2020-01-30T13:37:52-08:00 New Revision: 01943a59f51d8b5ede062305941c1f864b8a6a13 URL: https://github.com/llvm/llvm-project/commit/01943a59f51d8b5ede062305941c1f864b8a6a13 DIFF: https://github.com/llvm/llvm-project/commit/01943a59f51d8b5ede062305941c1f864b8a6a13.diff

[PATCH] D73687: [AArch64][SVE] Add SVE2 intrinsics for complex integer dot product

efriedma added inline comments. Comment at: llvm/include/llvm/IR/IntrinsicsAArch64.td: + LLVMSubdivide4VectorType<0>, + llvm_i32_ty], +[IntrNoMem]>; Missing ImmArg? Comment at: llvm/include/ll

[PATCH] D73363: Verify that clang's max alignment is <= LLVM's max alignment

rnk added a comment. I moved this include in rG01943a59f51d8b5ede062305941c1f864b8a6a13 . I meant to paste this in the message, but I'll put it here, since the results were significant: $ diff -u deps-before.txt deps-after.

[PATCH] D72876: Create a clang-tidy check to warn when -dealloc is implemented inside an ObjC class category.

mwyman updated this revision to Diff 241573. mwyman marked 9 inline comments as done. mwyman added a comment. Implemented review feedback. Updated diagnostic message to mention the category name. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72876/

[PATCH] D72876: Create a clang-tidy check to warn when -dealloc is implemented inside an ObjC class category.

mwyman added inline comments. Comment at: clang-tools-extra/clang-tidy/objc/DeallocInCategoryCheck.cpp:34 + +void DeallocInCategoryCheck::check(const MatchFinder::MatchResult &Result) { + const auto *MatchedDecl = Result.Nodes.getNodeAs("dealloc"); stephanemoore

[PATCH] D73742: [Clang][Driver] After default -fintegrated-cc1, fix report_fatal_error no longer generates preprocessed source + reproducer.sh

aganea created this revision. aganea added reviewers: arichardson, rnk, hans. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added projects: clang, LLVM. As reported by @arichardson , this patch now makes `llvm::report_fatal_error()` to generate a preprocessed source + rep

[clang] fdf31ae - [Fuchsia] Never link in implicit "system dependencies" of sanitizer runtimes

Author: Roland McGrath Date: 2020-01-30T14:21:23-08:00 New Revision: fdf31ae32dd2bddd9cc72ee7108f0c69bb2e637f URL: https://github.com/llvm/llvm-project/commit/fdf31ae32dd2bddd9cc72ee7108f0c69bb2e637f DIFF: https://github.com/llvm/llvm-project/commit/fdf31ae32dd2bddd9cc72ee7108f0c69bb2e637f.diff

[PATCH] D73734: [Fuchsia] Never link in implicit "system dependencies" of sanitizer runtimes

This revision was automatically updated to reflect the committed changes. Closed by commit rGfdf31ae32dd2: [Fuchsia] Never link in implicit "system dependencies" of sanitizer runtimes (authored by mcgrathr, committed by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D73208: [objc_direct] fix codegen for mismatched Decl/Impl return types

MadCoder updated this revision to Diff 241599. MadCoder added a comment. @dexonsmith here, I still hook the same method but do it in a more LLVM-approved way ;) It works with minimap perf impect because the only case we call GenerateDirectMethod with an Implementation is if we're about to codeg

[PATCH] D73208: [objc_direct] fix codegen for mismatched Decl/Impl return types

MadCoder updated this revision to Diff 241601. MadCoder added a comment. damn you tabs! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73208/new/ https://reviews.llvm.org/D73208 Files: clang/lib/CodeGen/CGObjCMac.cpp clang/test/CodeGenObjC/direct-method-ret-mismatch.m Index: clang

[PATCH] D73282: Fix debug-info generation for block invocations so that we set the LinkageName instead of the Name

shafik marked an inline comment as done. shafik added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:3659 // Use llvm function name. -Name = Fn->getName(); +if (Fn->getName().startswith("___Z")) + LinkageName = Fn->getName(); dbl

[PATCH] D73282: Fix debug-info generation for block invocations so that we set the LinkageName instead of the Name

dblaikie added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:3659 // Use llvm function name. -Name = Fn->getName(); +if (Fn->getName().startswith("___Z")) + LinkageName = Fn->getName(); shafik wrote: > dblaikie wrote: > > shafik

[PATCH] D70950: Add ProcName to TimeTraceProfiler

rnk added a comment. This broke ClangBuildAnalyzer on Windows because it has a very naive check for "clang": https://github.com/aras-p/ClangBuildAnalyzer/blob/master/src/main.cpp#L148 I was wondering why this wasn't working on Windows anymore. =/ Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D73543: [clang] Add support for __builtin_memcpy_inline

efriedma added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:1653 +llvm::APSInt I(64); +if (!TheCall->getArg(2)->isIntegerConstantExpr(I, Context)) + Diag(TheCall->getBeginLoc(), diag::err_expr_not_ice) SemaBuiltinConstantArg. Or actu

[PATCH] D73245: Don't define std::max_align_t if not used in C++03 mode

joerg added a comment. Let me clarify the situation for a moment: (1) libc++ does try to work in C++03 mode. See the separate implementation of for pre-C++11. It is also desirable to support. This is completely beside the question of TR1 support. (2) The only reason why max_align_t is currently

[clang] d28763c - Replace 'AllowExplicit' bool with an enum. No functionality change.

Author: Richard Smith Date: 2020-01-30T17:16:50-08:00 New Revision: d28763cad06e66651e1936756d3e28126b055abf URL: https://github.com/llvm/llvm-project/commit/d28763cad06e66651e1936756d3e28126b055abf DIFF: https://github.com/llvm/llvm-project/commit/d28763cad06e66651e1936756d3e28126b055abf.diff

[clang] 1f3f8c3 - PR44721: Don't consider overloaded operators for built-in comparisons

Author: Richard Smith Date: 2020-01-30T17:16:50-08:00 New Revision: 1f3f8c369a5067a132c871f33a955a7feaea8534 URL: https://github.com/llvm/llvm-project/commit/1f3f8c369a5067a132c871f33a955a7feaea8534 DIFF: https://github.com/llvm/llvm-project/commit/1f3f8c369a5067a132c871f33a955a7feaea8534.diff

[PATCH] D73208: [objc_direct] fix codegen for mismatched Decl/Impl return types

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM, with one style nitpick. Comment at: clang/lib/CodeGen/CGObjCMac.cpp:4049-4051 +if (!OMD->getBody() || COMD->getReturnType() == OMD->getReturnType()) { +

[PATCH] D73208: [objc_direct] fix codegen for mismatched Decl/Impl return types

MadCoder updated this revision to Diff 241613. MadCoder marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73208/new/ https://reviews.llvm.org/D73208 Files: clang/lib/CodeGen/CGObjCMac.cpp clang/test/CodeGenObjC/direct-method-ret-mismatch.m Index: clang

Re: [clang] 1f3f8c3 - PR44721: Don't consider overloaded operators for built-in comparisons

Hi Hans, This is a pretty safe bugfix for a new feature in Clang 10. OK for branch? On Thu, 30 Jan 2020 at 17:17, Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: Richard Smith > Date: 2020-01-30T17:16:50-08:00 > New Revision: 1f3f8c369a5067a132c871f33a955a7feaea853

[PATCH] D73755: [objc_direct] Small updates to help with adoption.

MadCoder created this revision. MadCoder added reviewers: ahatanak, dexonsmith, arphaman, erik.pilkington. MadCoder added a project: clang. Herald added subscribers: cfe-commits, jfb. Add fixits for messaging self in MRR or using super, as the intent is clear, and it turns out people do that a lot

[clang] 5ae6554 - PR41991: Accept attributes on defaulted and deleted friends.

Author: Richard Smith Date: 2020-01-30T17:42:17-08:00 New Revision: 5ae6554a1dcd2e39346030c06d364492901c9e8d URL: https://github.com/llvm/llvm-project/commit/5ae6554a1dcd2e39346030c06d364492901c9e8d DIFF: https://github.com/llvm/llvm-project/commit/5ae6554a1dcd2e39346030c06d364492901c9e8d.diff

[PATCH] D73245: Don't define std::max_align_t if not used in C++03 mode

rsmith added a comment. libc++ intentionally provides all the C++11 library functionality that it can, even when used from C++03 mode. So on the face of it, providing this name in C++03 mode seems appropriate. However... the implementation currently used by libc++ **doesn't work** in that mode

[clang] 980517b - [Concepts] Check function constraints before deducing auto return type

Author: Saar Raz Date: 2020-01-31T03:51:26+02:00 New Revision: 980517b3530ffb7faa1a23fdc007d78f5b45ae3c URL: https://github.com/llvm/llvm-project/commit/980517b3530ffb7faa1a23fdc007d78f5b45ae3c DIFF: https://github.com/llvm/llvm-project/commit/980517b3530ffb7faa1a23fdc007d78f5b45ae3c.diff LOG:

[clang] bebb8e2 - [objc_direct] Small updates to help with adoption.

Author: Pierre Habouzit Date: 2020-01-30T18:17:45-08:00 New Revision: bebb8e2596af8fe97f9b6356ff06e4e80580cf32 URL: https://github.com/llvm/llvm-project/commit/bebb8e2596af8fe97f9b6356ff06e4e80580cf32 DIFF: https://github.com/llvm/llvm-project/commit/bebb8e2596af8fe97f9b6356ff06e4e80580cf32.dif

[clang] 6eb969b - [objc_direct] fix codegen for mismatched Decl/Impl return types

Author: Pierre Habouzit Date: 2020-01-30T18:17:45-08:00 New Revision: 6eb969b7c5b5195d7f85b70e2e060eb2989cdc3c URL: https://github.com/llvm/llvm-project/commit/6eb969b7c5b5195d7f85b70e2e060eb2989cdc3c DIFF: https://github.com/llvm/llvm-project/commit/6eb969b7c5b5195d7f85b70e2e060eb2989cdc3c.dif

[clang] c6cf360 - Revert "[objc_direct] Small updates to help with adoption."

Author: Pierre Habouzit Date: 2020-01-30T18:21:25-08:00 New Revision: c6cf3602e27b76669f785f5fd34b928a889b9db5 URL: https://github.com/llvm/llvm-project/commit/c6cf3602e27b76669f785f5fd34b928a889b9db5 DIFF: https://github.com/llvm/llvm-project/commit/c6cf3602e27b76669f785f5fd34b928a889b9db5.dif

[PATCH] D73208: [objc_direct] fix codegen for mismatched Decl/Impl return types

This revision was automatically updated to reflect the committed changes. Closed by commit rG6eb969b7c5b5: [objc_direct] fix codegen for mismatched Decl/Impl return types (authored by MadCoder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73208/new

[PATCH] D73701: [clang] fix linkage of nested lambda

rsmith added a comment. This is effectively reverting https://reviews.llvm.org/D1783. If we don't need that any more for whatever reason, can we also get rid of the check for whether the outermost lambda has a mangling number a few lines above? (Please also check if we can remove `getOutermostE

[PATCH] D73762: New warning for for-loops where the iteration does not match the loop condition

rtrieu created this revision. This is a warning for when the increment/decrement in a for loop does not match the condition in the loop. If the condition has a relational operator, one operand can be deduced to be the larger value and the other operand the smaller value when the loop is run.

[clang] 1db66e7 - PR44627: Consider reversing == and <=> candidates found by ADL.

Author: Richard Smith Date: 2020-01-30T18:41:54-08:00 New Revision: 1db66e705f4dbe7dbe17edac804289ef59d5f616 URL: https://github.com/llvm/llvm-project/commit/1db66e705f4dbe7dbe17edac804289ef59d5f616 DIFF: https://github.com/llvm/llvm-project/commit/1db66e705f4dbe7dbe17edac804289ef59d5f616.diff

[PATCH] D71227: [cuda][hip] Fix function overload resolution in the global initiailizer.

hliao added a comment. In D71227#1831445 , @hliao wrote: > Sorry for the late reply. Really appreciate your feedback. Thanks! @rsmith Have you chance to review the revised change? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D73762: [clang] New warning for for-loops where the iteration does not match the loop condition

Eugene.Zelenko added a comment. It's good question where this check belongs. There are two loop related checks in CLang-tidy: bugprone-infinite-loop and bugprone-too-small-loop-variable. Comment at: clang/lib/Sema/SemaStmt.cpp:1754 +if (!Cond->isRelationalOp()) return; +

[PATCH] D72841: [RFC] Add support for pragma float_control, to control precision and exception behavior at the source level

sepavloff added a comment. You could check the scope where the pragma appears is the same way as `pragma clang fp` does. The code case tok::annot_pragma_fp: ProhibitAttributes(Attrs); Diag(Tok, diag::err_pragma_fp_scope); ConsumeAnnotationToken(); return StmtError(); is put in

[PATCH] D73462: [dwarf-5] Support DebugInfo for Defaulted parameters for C++ templates

awpandey marked an inline comment as not done. awpandey added a comment. @aprantl Thanks for your valuable feedback. I have a doubt. You need a .ll file its corresponding llvm bytecode generated by current llvm (without my patch). Doest this ll file includes any checks? In the round trip test c

[PATCH] D73282: Fix debug-info generation for block invocations so that we set the LinkageName instead of the Name

shafik updated this revision to Diff 241638. shafik added a comment. Using a more targeted approach. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73282/new/ https://reviews.llvm.org/D73282 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/test/CodeGenCXX/debug-info-block-invocation-l

[PATCH] D73282: Fix debug-info generation for block invocations so that we set the LinkageName instead of the Name

shafik marked an inline comment as done. shafik added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:3659 // Use llvm function name. -Name = Fn->getName(); +if (Fn->getName().startswith("___Z")) + LinkageName = Fn->getName(); dbl

<    1   2