JonasToth added a comment. In D54943#1841086 <https://reviews.llvm.org/D54943#1841086>, @AlexanderLanin wrote:
> In D54943#1815772 <https://reviews.llvm.org/D54943#1815772>, @0x8000-0000 > wrote: > > > This generated 56 "const const" declarations, of which 25 were triple const! > This could be due to multiple instantiations of a template, that each created a fix. this is an issue I have to work on. Otherwise it could come from header files and the fix is not deduplicated in `clang-apply-replacements` (which should deduplicate, I believe). The path issues come most likely from there and should be fixed there. > This surfaces here simply due to the shire number of files with fixes. Overall the check is almost done, but the last bit I am struggling with. I want no false positives, because I assume it will be used more often and creates so many fixes that fixing false positives is very cumbersome. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54943/new/ https://reviews.llvm.org/D54943 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
