[PATCH] D73610: [clangd] Replace raw lexer code with token buffer in prepare rename.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. there is a slight behavior change in this patch: - before: `in^t a;`, returns our internal error message (no

[clang] 757bdc6 - Fix clang unnittest build with GCC 5

Author: Benjamin Kramer Date: 2020-01-29T10:30:36+01:00 New Revision: 757bdc64d33df61467a7122f22ea76cf163c8dca URL: https://github.com/llvm/llvm-project/commit/757bdc64d33df61467a7122f22ea76cf163c8dca DIFF: https://github.com/llvm/llvm-project/commit/757bdc64d33df61467a7122f22ea76cf163c8dca.dif

[clang-tools-extra] 0d893fd - [clangd] Add a symbol-name-based blacklist for rename.

Author: Haojian Wu Date: 2020-01-29T10:32:40+01:00 New Revision: 0d893fda4305f19be18bc60f56839f2143c78b38 URL: https://github.com/llvm/llvm-project/commit/0d893fda4305f19be18bc60f56839f2143c78b38 DIFF: https://github.com/llvm/llvm-project/commit/0d893fda4305f19be18bc60f56839f2143c78b38.diff LO

[PATCH] D73450: [clangd] Add a symbol-name-based blacklist for rename.

This revision was automatically updated to reflect the committed changes. hokein marked an inline comment as done. Closed by commit rG0d893fda4305: [clangd] Add a symbol-name-based blacklist for rename. (authored by hokein). Changed prior to commit: https://reviews.llvm.org/D73450?vs=240853&id=

[clang-tools-extra] 4e3f4f0 - [ASTMatchers] StringRef'ify hasName

Author: Benjamin Kramer Date: 2020-01-29T10:53:08+01:00 New Revision: 4e3f4f03f3e4dccfac6212a66d54d584fea328a2 URL: https://github.com/llvm/llvm-project/commit/4e3f4f03f3e4dccfac6212a66d54d584fea328a2 DIFF: https://github.com/llvm/llvm-project/commit/4e3f4f03f3e4dccfac6212a66d54d584fea328a2.dif

[PATCH] D73610: [clangd] Replace raw lexer code with token buffer in prepare rename.

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62257 tests passed, 0 failed and 827 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D72829: Implement -fsemantic-interposition

arichardson added a comment. In D72829#1846157 , @serge-sans-paille wrote: > @arichardson doc updated, any other advice? No comments on the code just wondering if the documentation should be expanded. I just came across this review by chance and it was

[PATCH] D73457: [Clang] Warn about 'z' printf modifier in old MSVC.

simon_tatham added a comment. I now realise that my previous comment was nonsense: looking at @thakis's link more carefully, there are actually 5 failing tests that are nothing to do with the one I modified, and a lot of them don't even have any obvious `-fms-extension` option in the cc1 comman

[PATCH] D73610: [clangd] Replace raw lexer code with token buffer in prepare rename.

sammccall added a comment. Nice, thanks! Comment at: clang-tools-extra/clangd/ClangdServer.cpp:322 +if (!TouchingIdentifier) + return CB(llvm::None); // no rename on non-identifiers. + Agree that this behavior is OK per the spec, but do we actually pre

[PATCH] D73612: [clangd] Update lsp dependencies to pickup the progress support in LSP 3.15

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D73612 Files: clang-tools-extra/clangd/clie

[PATCH] D73613: [clangd][Hover] Make tests hermetic by setting target triplet

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Fixes https://bugs.llvm.org/show_bug.cgi?id=44696 Repository: rG LLVM Github Monorepo https://revi

[PATCH] D73613: [clangd][Hover] Make tests hermetic by setting target triplet

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/unittests/HoverTests.cpp:583 TU.ExtraArgs.push_back("-std=c++17"); TU.ExtraArgs.push_back("-fno-delayed-template-pars

[PATCH] D73612: [clangd] Update lsp dependencies to pickup the progress support in LSP 3.15

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62283 tests passed, 0 failed and 827 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D73613: [clangd][Hover] Make tests hermetic by setting target triplet

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62269 tests passed, 0 failed and 827 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D73347: [AArch64][SVE] Add SVE2 intrinsics for pairwise arithmetic

This revision was automatically updated to reflect the committed changes. Closed by commit rGbd33a46213d3: [AArch64][SVE] Add SVE2 intrinsics for pairwise arithmetic (authored by kmclaughlin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73347/new/

[clang] ac21535 - [ARM] Add documentation for -march= and -mfpu= command line options

Author: Momchil Velikov Date: 2020-01-29T10:39:01Z New Revision: ac215354607450191b9d63be72c00efe36b53a1c URL: https://github.com/llvm/llvm-project/commit/ac215354607450191b9d63be72c00efe36b53a1c DIFF: https://github.com/llvm/llvm-project/commit/ac215354607450191b9d63be72c00efe36b53a1c.diff LO

[PATCH] D73548: [clang-tidy] Added option for disabling const qualifiers in readability-qualified-auto

njames93 marked 4 inline comments as done. njames93 added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/readability-qualified-auto.rst:41 + auto *const Bar = cast(Baz2); + auto *volatile FooBar = cast(Baz3); + aaron.ballman wrote: > n

[PATCH] D73459: [ARM] Add documentation for -march= and -mfpu= command line options

This revision was automatically updated to reflect the committed changes. Closed by commit rGac2153546074: [ARM] Add documentation for -march= and -mfpu= command line options (authored by chill). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github M

[PATCH] D73548: [clang-tidy] Added option for disabling const qualifiers in readability-qualified-auto

njames93 updated this revision to Diff 241082. njames93 added a comment. - Always add const to `auto` typed variable. This update adds const to variables just typed with `auto`, but wont enforce checking on `auto *` or `auto &` unless `AddConstToQualified` is set. Repository: rG LLVM Github

[PATCH] D73613: [clangd][Hover] Make tests hermetic by setting target triplet

kadircet added inline comments. Comment at: clang-tools-extra/clangd/unittests/HoverTests.cpp:583 TU.ExtraArgs.push_back("-std=c++17"); TU.ExtraArgs.push_back("-fno-delayed-template-parsing"); +// Types might be different depending on the target triplet, we chose a

[PATCH] D73613: [clangd][Hover] Make tests hermetic by setting target triplet

kadircet updated this revision to Diff 241085. kadircet marked 4 inline comments as done. kadircet added a comment. - Add fixme for delayed-template-parsing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73613/new/ https://reviews.llvm.org/D73613 F

[PATCH] D73548: [clang-tidy] Added option for disabling const qualifiers in readability-qualified-auto

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 62275 tests passed, 1 failed and 827 were skipped. failed: Clang.CodeGenOpenCL/amdgpu-features.cl {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build art

[clang-tools-extra] 0ee4b02 - Fix an implicit conversion in clang-tidy. GCC 5 complains about it.

Author: Benjamin Kramer Date: 2020-01-29T12:05:35+01:00 New Revision: 0ee4b027d37e45391bdd872911c61756d0958722 URL: https://github.com/llvm/llvm-project/commit/0ee4b027d37e45391bdd872911c61756d0958722 DIFF: https://github.com/llvm/llvm-project/commit/0ee4b027d37e45391bdd872911c61756d0958722.dif

[PATCH] D73615: [clangd] Get rid of delayed template parsing

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. No need to pass fno-delayed-template-parsing as the opposite flag is only passed to cc1 when abi is set

[PATCH] D73612: [clangd] Update lsp dependencies to pickup the progress support in LSP 3.15

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. LG. (The internal google mirror of VSCode is stuck at 1.38, but this should just fail to update the extension I think) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D73615: [clangd] Get rid of delayed template parsing

merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon question-circle color=gray} clang-tidy: unknown. {icon question-circle color=gray} clang-format: unknown. Build artifacts : diff

[PATCH] D73613: [clangd][Hover] Make tests hermetic by setting target triplet

sammccall added inline comments. Comment at: clang-tools-extra/clangd/unittests/HoverTests.cpp:586 +// fixed one to make sure tests passes on different platform. +TU.ExtraArgs.push_back("--target=x86_64-pc-linux-gnu"); auto AST = TU.build(); kadircet

[clang-tools-extra] 7830c2d - [clangd] Get rid of delayed template parsing

Author: Kadir Cetinkaya Date: 2020-01-29T12:12:45+01:00 New Revision: 7830c2d44f531bbe09f997436b6608a140db46fb URL: https://github.com/llvm/llvm-project/commit/7830c2d44f531bbe09f997436b6608a140db46fb DIFF: https://github.com/llvm/llvm-project/commit/7830c2d44f531bbe09f997436b6608a140db46fb.dif

[clang-tools-extra] 55b0e9c - [clangd][Hover] Make tests hermetic by setting target triplet

Author: Kadir Cetinkaya Date: 2020-01-29T12:12:45+01:00 New Revision: 55b0e9c9d5de7c5d70552ac9ca9ffc14097e983b URL: https://github.com/llvm/llvm-project/commit/55b0e9c9d5de7c5d70552ac9ca9ffc14097e983b DIFF: https://github.com/llvm/llvm-project/commit/55b0e9c9d5de7c5d70552ac9ca9ffc14097e983b.dif

[PATCH] D73613: [clangd][Hover] Make tests hermetic by setting target triplet

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62269 tests passed, 0 failed and 827 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D73613: [clangd][Hover] Make tests hermetic by setting target triplet

This revision was automatically updated to reflect the committed changes. Closed by commit rG55b0e9c9d5de: [clangd][Hover] Make tests hermetic by setting target triplet (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73613/new/

[PATCH] D73615: [clangd] Get rid of delayed template parsing

This revision was automatically updated to reflect the committed changes. Closed by commit rG7830c2d44f53: [clangd] Get rid of delayed template parsing (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73615/new/ https://reviews.

[PATCH] D73617: [clangd] Don't mmap source files on all platforms --> don't crash on git checkout

sammccall created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. sammccall added reviewers: ilya-biryukov, kadircet. sammccall edited the summary of this revision. Previously we mmapped on unix a

[PATCH] D73610: [clangd] Replace raw lexer code with token buffer in prepare rename.

hokein updated this revision to Diff 241095. hokein marked 4 inline comments as done. hokein added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73610/new/ https://reviews.llvm.org/D73610 Files: clang-tools-extra/clan

[PATCH] D73610: [clangd] Replace raw lexer code with token buffer in prepare rename.

hokein added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:322 +if (!TouchingIdentifier) + return CB(llvm::None); // no rename on non-identifiers. + sammccall wrote: > Agree that this behavior is OK per the spec, but do we actual

[PATCH] D73610: [clangd] Replace raw lexer code with token buffer in prepare rename.

hokein updated this revision to Diff 241096. hokein added a comment. revert an accident change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73610/new/ https://reviews.llvm.org/D73610 Files: clang-tools-extra/clangd/ClangdServer.cpp clang-too

[PATCH] D73610: [clangd] Replace raw lexer code with token buffer in prepare rename.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:322 +if (!TouchingIdentifier) + return CB(llvm::None); // no rename on non-identifiers. + ---

[PATCH] D73617: [clangd] Don't mmap source files on all platforms --> don't crash on git checkout

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62284 tests passed, 0 failed and 831 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D73612: [clangd] Update lsp dependencies to pickup the progress support in LSP 3.15

hokein updated this revision to Diff 241097. hokein added a comment. update the required minimal vscode version. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73612/new/ https://reviews.llvm.org/D73612 Files: clang-tools-extra/clangd/clients/cla

[PATCH] D73537: [clangd] add CODE_OWNERS

This revision was automatically updated to reflect the committed changes. Closed by commit rG6f6952780ba9: [clangd] add CODE_OWNERS (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73537/new/ https://reviews.llvm.org/D73537 Fi

[clang-tools-extra] 6f69527 - [clangd] add CODE_OWNERS

Author: Sam McCall Date: 2020-01-29T12:43:19+01:00 New Revision: 6f6952780ba92782c38b37b7bf65a079c1d1215f URL: https://github.com/llvm/llvm-project/commit/6f6952780ba92782c38b37b7bf65a079c1d1215f DIFF: https://github.com/llvm/llvm-project/commit/6f6952780ba92782c38b37b7bf65a079c1d1215f.diff LO

[clang-tools-extra] bcb3e42 - [clangd] Go-to-definition on 'override' jumps to overridden method(s)

Author: Sam McCall Date: 2020-01-29T12:43:52+01:00 New Revision: bcb3e42fdfb30f516fefd56609a969059b60a982 URL: https://github.com/llvm/llvm-project/commit/bcb3e42fdfb30f516fefd56609a969059b60a982 DIFF: https://github.com/llvm/llvm-project/commit/bcb3e42fdfb30f516fefd56609a969059b60a982.diff LO

[PATCH] D73354: clang-format: insert trailing commas into containers.

mprobst marked 2 inline comments as done. mprobst added inline comments. Comment at: clang/lib/Format/Format.cpp:2531 +}); + auto Env = MyDeveloperDay wrote: > Ok, this comment is more a discussion point rather than a review comment. Was > there a reason

[PATCH] D73619: [clangd] Remove the temporary alias for clangd::DiagnosticConsumer.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. hokein added a comment. We have updated our internal code to use the new name. Repository: rG LLVM Github

[PATCH] D73367: [clangd] Go-to-definition on 'override' jumps to overridden method(s)

This revision was automatically updated to reflect the committed changes. Closed by commit rGbcb3e42fdfb3: [clangd] Go-to-definition on 'override' jumps to overridden method(s) (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73

[PATCH] D73619: [clangd] Remove the temporary alias for clangd::DiagnosticConsumer.

hokein added a comment. We have updated our internal code to use the new name. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73619/new/ https://reviews.llvm.org/D73619 ___ cfe-commits mailing list cfe-

[clang-tools-extra] e864f93 - [clangd] Replace raw lexer code with token buffer in prepare rename.

Author: Haojian Wu Date: 2020-01-29T12:57:18+01:00 New Revision: e864f937669c996b4dc15db7d0ebe4073527c165 URL: https://github.com/llvm/llvm-project/commit/e864f937669c996b4dc15db7d0ebe4073527c165 DIFF: https://github.com/llvm/llvm-project/commit/e864f937669c996b4dc15db7d0ebe4073527c165.diff LO

[clang-tools-extra] 17fadef - [clangd][vscode] Update lsp dependencies to pickup the progress support in LSP 3.15

Author: Haojian Wu Date: 2020-01-29T12:58:53+01:00 New Revision: 17fadeffcce97d79f5f132dacb143364622b6428 URL: https://github.com/llvm/llvm-project/commit/17fadeffcce97d79f5f132dacb143364622b6428 DIFF: https://github.com/llvm/llvm-project/commit/17fadeffcce97d79f5f132dacb143364622b6428.diff LO

[PATCH] D73610: [clangd] Replace raw lexer code with token buffer in prepare rename.

This revision was automatically updated to reflect the committed changes. Closed by commit rGe864f937669c: [clangd] Replace raw lexer code with token buffer in prepare rename. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73610/

[PATCH] D73610: [clangd] Replace raw lexer code with token buffer in prepare rename.

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62257 tests passed, 0 failed and 827 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D73612: [clangd] Update lsp dependencies to pickup the progress support in LSP 3.15

This revision was automatically updated to reflect the committed changes. Closed by commit rG17fadeffcce9: [clangd][vscode] Update lsp dependencies to pickup the progress support in LSP… (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D73612: [clangd] Update lsp dependencies to pickup the progress support in LSP 3.15

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62283 tests passed, 0 failed and 827 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D73610: [clangd] Replace raw lexer code with token buffer in prepare rename.

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62257 tests passed, 0 failed and 827 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D73493: [AArch64][SVE] Add SVE2 intrinsics for uniform DSP operations

This revision was automatically updated to reflect the committed changes. Closed by commit rG3cf80822a906: [AArch64][SVE] Add SVE2 intrinsics for uniform DSP operations (authored by kmclaughlin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73493/ne

[PATCH] D73619: [clangd] Remove the temporary alias for clangd::DiagnosticConsumer.

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62283 tests passed, 0 failed and 827 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D73354: clang-format: insert trailing commas into containers.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. (Maybe we should have a basic test for C++, but I'm not sure how this usually goes) BTW it occurs to me that turning this on by default may be a surprising breakage for: - people who u

[clang] a324fcf - clang-format: insert trailing commas into containers.

Author: Martin Probst Date: 2020-01-29T13:23:54+01:00 New Revision: a324fcf1ae62d065b957e66a9d2f5c18b6259d27 URL: https://github.com/llvm/llvm-project/commit/a324fcf1ae62d065b957e66a9d2f5c18b6259d27 DIFF: https://github.com/llvm/llvm-project/commit/a324fcf1ae62d065b957e66a9d2f5c18b6259d27.diff

[PATCH] D73354: clang-format: insert trailing commas into containers.

mprobst marked 4 inline comments as done. mprobst added inline comments. Comment at: clang/include/clang/Format/Format.h:42 + Unsuitable, + BinBackTrailingCommaConflict +}; sammccall wrote: > Back->Pack? That's what you get when you fix my auto-complete: consis

[PATCH] D73617: [clangd] Don't mmap source files on all platforms --> don't crash on git checkout

sammccall added a comment. Also I'd like to put this onto the 10 release branch because this is a big crasher, fix seems safe, we've run this code on windows for a while. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73617/new/ https://reviews.llv

[clang] d5dfd13 - Add TagDecl AST matcher

Author: Karasev Nikita Date: 2020-01-29T07:58:31-05:00 New Revision: d5dfd1350efb80f9674db322999dd883fb36a6ad URL: https://github.com/llvm/llvm-project/commit/d5dfd1350efb80f9674db322999dd883fb36a6ad DIFF: https://github.com/llvm/llvm-project/commit/d5dfd1350efb80f9674db322999dd883fb36a6ad.diff

[clang] 4ec2a26 - Fix clang test build

Author: Sanne Wouda Date: 2020-01-29T13:03:27Z New Revision: 4ec2a267321124a7fe8efe794ce40da67ce1d6bd URL: https://github.com/llvm/llvm-project/commit/4ec2a267321124a7fe8efe794ce40da67ce1d6bd DIFF: https://github.com/llvm/llvm-project/commit/4ec2a267321124a7fe8efe794ce40da67ce1d6bd.diff LOG: F

[PATCH] D73548: [clang-tidy] Added option for disabling const qualifiers in readability-qualified-auto

aaron.ballman added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/readability-qualified-auto.rst:41 + auto *const Bar = cast(Baz2); + auto *volatile FooBar = cast(Baz3); + njames93 wrote: > aaron.ballman wrote: > > njames93 wrote: > >

[PATCH] D73464: [clang] Add TagDecl AST matcher

aaron.ballman closed this revision. aaron.ballman added a comment. I've committed on your behalf in d5dfd1350efb80f9674db322999dd883fb36a6ad , thank you for the patch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D73562: [ASTMatchers] Add hasPlacementArg and hasAnyPlacementArg traversal matcher for CXXNewExpr

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73562/new/ https://reviews.llvm.org/D73562

[PATCH] D73619: [clangd] Remove the temporary alias for clangd::DiagnosticConsumer.

hokein updated this revision to Diff 241122. hokein added a comment. remove the deprecated contructor as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73619/new/ https://reviews.llvm.org/D73619 Files: clang-tools-extra/clangd/ClangdServer.

[PATCH] D73360: [OpenCL] Restrict address space conversions in nested pointers

jeroen.dobbelaere accepted this revision. jeroen.dobbelaere added a comment. This patch looks good to me. I do agree with John that it would be good to add the warning to a warning group. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73360/new/ https://reviews.llvm.org/D73360 _

[PATCH] D73619: [clangd] Remove the temporary alias for clangd::DiagnosticConsumer.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks for the cleanup! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73619/new/ https://reviews.llvm.org/D73619 __

[clang] 2939fc1 - [AArch64] Add IR intrinsics for sq(r)dmulh_lane(q)

Author: Sanne Wouda Date: 2020-01-29T13:25:23Z New Revision: 2939fc13c8f6a5dbd1be77c1d19dc2720253b8c5 URL: https://github.com/llvm/llvm-project/commit/2939fc13c8f6a5dbd1be77c1d19dc2720253b8c5 DIFF: https://github.com/llvm/llvm-project/commit/2939fc13c8f6a5dbd1be77c1d19dc2720253b8c5.diff LOG: [

[PATCH] D73619: [clangd] Remove the temporary alias for clangd::DiagnosticConsumer.

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62283 tests passed, 0 failed and 827 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D72153: [libTooling] Add function to determine associated text of a declaration.

ymandel updated this revision to Diff 241124. ymandel marked 4 inline comments as done. ymandel added a comment. addressed comments, with significant reworking of tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72153/new/ https://reviews.llvm.

[PATCH] D71469: [AArch64] Add IR intrinsics for sq(r)dmulh_lane(q)

This revision was automatically updated to reflect the committed changes. Closed by commit rG2939fc13c8f6: [AArch64] Add IR intrinsics for sq(r)dmulh_lane(q) (authored by sanwou01). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71469/new/ https://re

[PATCH] D73570: [FPEnv][X86] Platform-specific builtin constrained FP enablement

kpn marked 2 inline comments as done. kpn added inline comments. Comment at: clang/test/CodeGen/fma-builtins-constrained.c:4 +// RUN: %clang_cc1 -ffreestanding %s -triple=x86_64-apple-darwin -target-feature +fma -S -o - | FileCheck --check-prefix=COMMON --check-prefix=CHECK-ASM

[PATCH] D72153: [libTooling] Add function to determine associated text of a declaration.

ymandel updated this revision to Diff 241127. ymandel marked 12 inline comments as done. ymandel added a comment. tweaks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72153/new/ https://reviews.llvm.org/D72153 Files: clang/include/clang/Tooling/

[clang-tools-extra] fce8983 - [clangd] Remove the temporary alias for clangd::DiagnosticConsumer.

Author: Haojian Wu Date: 2020-01-29T14:50:58+01:00 New Revision: fce8983a3c03b41c3ba4bdaef72e64e29ff9ecc0 URL: https://github.com/llvm/llvm-project/commit/fce8983a3c03b41c3ba4bdaef72e64e29ff9ecc0 DIFF: https://github.com/llvm/llvm-project/commit/fce8983a3c03b41c3ba4bdaef72e64e29ff9ecc0.diff LO

[PATCH] D73619: [clangd] Remove the temporary alias for clangd::DiagnosticConsumer.

This revision was automatically updated to reflect the committed changes. Closed by commit rGfce8983a3c03: [clangd] Remove the temporary alias for clangd::DiagnosticConsumer. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73619/n

[PATCH] D72153: [libTooling] Add function to determine associated text of a declaration.

ymandel marked an inline comment as done. ymandel added a comment. Thank you for the detailed review. I've significantly expanded and refactored the tests. I also lifted `validateEditRange` into its own function and added corresponding tests. Comment at: clang/lib/Tooling/Tra

[PATCH] D72829: Implement -fsemantic-interposition

sfertile added a comment. Aewsome, thanks for implementing this. I was on vacation for a bit and somehow missed this review in my queue when I cam back but having a look at it now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72829/new/ https://r

[PATCH] D73285: [OpenMP][OMPIRBuilder][BugFix] Handle Unreachable Finalization blocks in `parallel` generation

fghanim marked an inline comment as done. fghanim added inline comments. Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:661 +AfterIP = InsertPointTy(ForkBB, ForkBB->end()); + } jdoerfert wrote: > fghanim wrote: > > jdoerfert wrote: > > > Why do we n

[PATCH] D72222: [Driver][CodeGen] Add -fpatchable-function-entry=N[,0]

mrutland added a comment. In D7#1839207 , @MaskRay wrote: > When -mbranch-protection=bti is used, due to > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=92424 (existing GCC releases > have the issue), Linux/arch/arm64 has to make more checks to detect

[PATCH] D73624: [clangd][vscode] Get rid of the deprecated vscode module in the extension.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov, dschuff. Herald added a project: clang. hokein updated this revision to Diff 241144. hokein added a comment. add trailing blank line. The v

[PATCH] D73462: [dwarf-5] Support DebugInfo for Defaulted parameters for C++ templates

awpandey updated this revision to Diff 241141. awpandey added a comment. Thanks @dblaikie for figuring out the missing feature. I have added support for the non-type template parameter too. Please let me know if further modifications are required. I will happily address them. CHANGES SINCE LAS

[PATCH] D73624: [clangd][vscode] Get rid of the deprecated vscode module in the extension.

hokein updated this revision to Diff 241144. hokein added a comment. add trailing blank line. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73624/new/ https://reviews.llvm.org/D73624 Files: clang-tools-extra/clangd/clients/clangd-vscode/package-

[PATCH] D72829: Implement -fsemantic-interposition

serge-sans-paille updated this revision to Diff 241152. serge-sans-paille added a comment. Update user-level documentation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72829/new/ https://reviews.llvm.org/D72829 Files: clang/docs/ClangCommandLi

[PATCH] D72829: Implement -fsemantic-interposition

serge-sans-paille added a comment. > As this is user-facing documentation I feel like there should be a slightly > longer explaning what the option does. done! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72829/new/ https://reviews.llvm.org/D728

[PATCH] D73624: [clangd][vscode] Get rid of the deprecated vscode module in the extension.

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62287 tests passed, 0 failed and 831 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D73543: [clang] Add support for __builtin_memcpy_inline

gchatelet updated this revision to Diff 241158. gchatelet marked 4 inline comments as done. gchatelet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73543/new/ https://reviews.llvm.org/D73543 Files: clang/docs/

[PATCH] D73543: [clang] Add support for __builtin_memcpy_inline

gchatelet added inline comments. Comment at: clang/docs/LanguageExtensions.rst:2259 +``__builtin_memcpy_inline(dst, src, size)`` is identical to +``__builtin_memcpy(dst, src, size)`` expect that the generated code is +guaranteed not to call any external functions. See [LLVM IR ‘

[PATCH] D72326: [clang-format] Rebased on master: Add option to specify explicit config file

tnorth updated this revision to Diff 241155. tnorth added a comment. - Add release notes - Update ClangFormat.rst and ClangFormatStyleOption.rst Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72326/new/ https://reviews.llvm.org/D72326 Files: docs/ClangFormat.rs

[PATCH] D72326: [clang-format] Rebased on master: Add option to specify explicit config file

tnorth added a comment. In D72326#1845342 , @MyDeveloperDay wrote: > Nit: please add a release note and regenerate the ClangFormatStyleOptions.rst > (if there are any changes because you modified Format.h). Hmm, I tried to run docs/tools/dump_format_st

[PATCH] D73628: [clangd] Log directory when a CDB is loaded

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Fixes https://github.com/clangd/clangd/issues/268 Repository: rG LLVM Github Monorepo https://revi

[PATCH] D73629: [analyzer] vfork checker: allow execve after vfork

janvcelak created this revision. janvcelak added a reviewer: dcoughlin. Herald added subscribers: cfe-commits, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. `execve` is missing in the list of functions th

[PATCH] D73624: [clangd][vscode] Get rid of the deprecated vscode module in the extension.

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 62285 tests passed, 2 failed and 831 were skipped. failed: libc++.std/thread/thread_mutex/thread_mutex_requirements/thread_mutex_requirements_mutex/thread_mutex_recursive/lock.pass.cpp failed: libc++.std/thre

[clang-tools-extra] 01213f9 - [clang-tidy] Initialize token before handing it to the lexer

Author: Benjamin Kramer Date: 2020-01-29T16:48:57+01:00 New Revision: 01213f90700dbb98a0dbcc01da8fdb89f6db5617 URL: https://github.com/llvm/llvm-project/commit/01213f90700dbb98a0dbcc01da8fdb89f6db5617 DIFF: https://github.com/llvm/llvm-project/commit/01213f90700dbb98a0dbcc01da8fdb89f6db5617.dif

[PATCH] D73628: [clangd] Log directory when a CDB is loaded

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/GlobalCompilationDatabase.cpp:122 +if (Entry.CDB) + vlog("Loaded CDB from {0}", Dir); } consider "

[PATCH] D73242: [WPD/LowerTypeTests] Delay lowering/removal of type tests until after ICP

evgeny777 added a comment. > This is an enabler for upcoming enhancements to indirect call promotion, for > example streamlined promotion guard sequences that compare against vtable > address instead of the target function Can you please describe the whole approach in more detail? At the moment

[PATCH] D72829: Implement -fsemantic-interposition

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62300 tests passed, 0 failed and 837 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D73300: [clang-tidy] Add library for clang-tidy main function

DmitryPolukhin added a comment. @thakis I'm sorry sorry if it was not clear. Please let me know if you still prefer to have separate directory for clangTidyMain to have only one target per CMakeLists.txt. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D73408: [Clang][Bundler] Add 'exclude' flag to target objects sections

sdmitriev added a comment. Any additional comments? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73408/new/ https://reviews.llvm.org/D73408 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/list

[PATCH] D72829: Implement -fsemantic-interposition

sfertile added a comment. In D72829#1846353 , @arichardson wrote: > As this is user-facing documentation I feel like there should be a slightly > longer explaning what the option does. +1 on this, otherwise LGTM. Thanks for implementing this! ===

[PATCH] D73408: [Clang][Bundler] Add 'exclude' flag to target objects sections

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73408/new/ https://reviews.llvm.org/D73408 ___ cfe-commits mailing list cfe-commits@l

  1   2   >