[PATCH] D73619: [clangd] Remove the temporary alias for clangd::DiagnosticConsumer.

[Haojian Wu via Phabricator via cfe-commits]

hokein updated this revision to Diff 241122.
hokein added a comment.

remove the deprecated contructor as well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73619/new/

https://reviews.llvm.org/D73619

Files:
  clang-tools-extra/clangd/ClangdServer.h


Index: clang-tools-extra/clangd/ClangdServer.h
===================================================================
--- clang-tools-extra/clangd/ClangdServer.h
+++ clang-tools-extra/clangd/ClangdServer.h
@@ -165,12 +165,6 @@
                const FileSystemProvider &FSProvider, const Options &Opts,
                Callbacks *Callbacks = nullptr);
 
-  // FIXME: remove this compatibility alias.
-  ClangdServer(const GlobalCompilationDatabase &CDB,
-               const FileSystemProvider &FSProvider, Callbacks &Callbacks,
-               const Options &Opts)
-      : ClangdServer(CDB, FSProvider, Opts, &Callbacks) {}
-
   /// Add a \p File to the list of tracked C++ files or update the contents if
   /// \p File is already tracked. Also schedules parsing of the AST for it on a
   /// separate thread. When the parsing is complete, DiagConsumer passed in
@@ -359,9 +353,6 @@
   TUScheduler WorkScheduler;
 };
 
-// FIXME: Remove this compatibility alias.
-using DiagnosticsConsumer = ClangdServer::Callbacks;
-
 } // namespace clangd
 } // namespace clang
 



Index: clang-tools-extra/clangd/ClangdServer.h
===================================================================
--- clang-tools-extra/clangd/ClangdServer.h
+++ clang-tools-extra/clangd/ClangdServer.h
@@ -165,12 +165,6 @@
                const FileSystemProvider &FSProvider, const Options &Opts,
                Callbacks *Callbacks = nullptr);
 
-  // FIXME: remove this compatibility alias.
-  ClangdServer(const GlobalCompilationDatabase &CDB,
-               const FileSystemProvider &FSProvider, Callbacks &Callbacks,
-               const Options &Opts)
-      : ClangdServer(CDB, FSProvider, Opts, &Callbacks) {}
-
   /// Add a \p File to the list of tracked C++ files or update the contents if
   /// \p File is already tracked. Also schedules parsing of the AST for it on a
   /// separate thread. When the parsing is complete, DiagConsumer passed in
@@ -359,9 +353,6 @@
   TUScheduler WorkScheduler;
 };
 
-// FIXME: Remove this compatibility alias.
-using DiagnosticsConsumer = ClangdServer::Callbacks;
-
 } // namespace clangd
 } // namespace clang
 

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits