Buildbot numbers for the last week of 12/29/2019 - 01/04/2020

Hello everyone, Below are some buildbot numbers for the last week of 12/29/2019 - 01/04/2020. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from gre

[PATCH] D72467: [WIP] Remove "mask" operand from shufflevector.

efriedma marked an inline comment as done. efriedma added inline comments. Comment at: llvm/lib/Analysis/InstructionSimplify.cpp:4413 unsigned MaxRecurse) { - if (isa(Mask)) + if (all_of(Mask, [](int Elem) { return Elem == -1; })) r

[clang] 1d2cd2c - [Driver] Fix OptionClass of -fconvergent-functions and -fms-volatile (Joined -> Flag)

Author: Fangrui Song Date: 2020-01-10T17:06:40-08:00 New Revision: 1d2cd2c0b7d978e22a50e918af708ba67e87c2c1 URL: https://github.com/llvm/llvm-project/commit/1d2cd2c0b7d978e22a50e918af708ba67e87c2c1 DIFF: https://github.com/llvm/llvm-project/commit/1d2cd2c0b7d978e22a50e918af708ba67e87c2c1.diff

[PATCH] D72467: [WIP] Remove "mask" operand from shufflevector.

efriedma updated this revision to Diff 237463. efriedma added a comment. Figured out the changes necessary to get bitcode reading/writing working. ninja check now passes. Not sure what parts I should split off to get reviewed separately. Probably the GlobalISel changes could be split off with

[clang] 9b23407 - [Concepts] Fix MarkUsedTemplateParameters for exprs

Author: Saar Raz Date: 2020-01-11T03:16:57+02:00 New Revision: 9b23407063ca41901e9e272bacf8b33eee8251c4 URL: https://github.com/llvm/llvm-project/commit/9b23407063ca41901e9e272bacf8b33eee8251c4 DIFF: https://github.com/llvm/llvm-project/commit/9b23407063ca41901e9e272bacf8b33eee8251c4.diff LOG:

[PATCH] D72547: [llvm] Make new pass manager's OptimizationLevel a class

mtrofin updated this revision to Diff 237464. mtrofin added a comment. Speedup level is actually '2' for Os and Oz Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72547/new/ https://reviews.llvm.org/D72547 Files: clang/lib/CodeGen/BackendUtil.cpp

[PATCH] D72547: [llvm] Make new pass manager's OptimizationLevel a class

tejohnson added a comment. I just have a few high level comments from looking through it just now. The summary needs a fix since Os/Oz are in fact O2 so OptLevel > 1 was not doing the wrong thing. Comment at: llvm/include/llvm/Pas

[PATCH] D69825: [Clang][Driver] Re-use the calling process instead of creating a new process for the cc1 invocation

aganea updated this revision to Diff 237465. aganea marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69825/new/ https://reviews.llvm.org/D69825 Files: clang/CMakeLists.txt clang/include/clang/Config/config.h.cmake clang/include/clang/Driver/Driver.h

[PATCH] D69825: [Clang][Driver] Re-use the calling process instead of creating a new process for the cc1 invocation

aganea added inline comments. Comment at: clang/tools/driver/driver.cpp:267 + + StringRef SpawnCC1Str = ::getenv("CLANG_SPAWN_CC1"); + if (!SpawnCC1Str.empty()) { hans wrote: > aganea wrote: > > hans wrote: > > > Maybe just do the "!!" thing like for the enviro

[PATCH] D71607: [clang-tidy] Add unsigned subtraction warning, with suggestion to convert to unsigned literals.

sorenj updated this revision to Diff 237466. sorenj added a comment. - Address documentation comments. - Address documentation comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71607/new/ https://reviews.llvm.org/D71607 Files: clang-tools-

[clang] de0a224 - Remove umask tests

Author: Alexandre Ganea Date: 2020-01-10T21:05:59-05:00 New Revision: de0a2247115729eade8249267a47f96f070a7666 URL: https://github.com/llvm/llvm-project/commit/de0a2247115729eade8249267a47f96f070a7666 DIFF: https://github.com/llvm/llvm-project/commit/de0a2247115729eade8249267a47f96f070a7666.dif

[PATCH] D70854: [Clang] In tests, do not always assume others permissions are set

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGde0a22471157: Remove umask tests (authored by aganea). Changed prior to commit: https://reviews.llvm.org/D70854?vs=23340

[PATCH] D71607: [clang-tidy] Add unsigned subtraction warning, with suggestion to convert to unsigned literals.

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone-unsigned-subtraction.rst:17 +constants, thus making the implict cast explicit and signals that +the the code was intended. In cases where the second argument is +not a constant,

[PATCH] D71734: [Modules] Handle tag types and complain about bad merges in C/Objective-C mode

rtrieu added inline comments. Comment at: clang/lib/Serialization/ASTReader.cpp:11007 + // Issue any pending ODR-failure diagnostics. + for (auto &Merge : RecordOdrMergeFailures) { bruno wrote: > rtrieu wrote: > > Is this just a copy of the other loop? That'

[PATCH] D71607: [clang-tidy] Add unsigned subtraction warning, with suggestion to convert to unsigned literals.

sorenj updated this revision to Diff 237471. sorenj added a comment. - Remove double space. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71607/new/ https://reviews.llvm.org/D71607 Files: clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.

[PATCH] D72551: Warn when a string literal is used in a range-based for-loop

rtrieu created this revision. String literals used in ranged-based for-loops will actually process the terminating null character as part of the loop, which may be unexpected. // This runs three times, once for c = 'h', then c = 'i', and finally as c = '\0' for (char c : "hi") This patch

[PATCH] D72523: [remark][diagnostics] Using clang diagnostic handler for IR input files

tejohnson added a comment. Thanks for fixing this missing -Rpass support! Comment at: clang/lib/CodeGen/CodeGenAction.cpp:594 + // SourceLoc. + if (Context == nullptr) { +return FullSourceLoc(); Does this only happen with IR input? Does it always happen w

[PATCH] D72552: [Concepts] Constraint Satisfaction Caching

saar.raz created this revision. saar.raz added a reviewer: rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add a simple cache for constraint satisfaction results. This results in a major speedup (cjdb measured x2 faster than gcc with this caching, compared to being '

[PATCH] D72463: [Driver][X86] Add -malign-branch* and -malign-branch-within-32B-boundaries

MaskRay updated this revision to Diff 237476. MaskRay edited the summary of this revision. MaskRay added a comment. Delete -mno-branches-within-32B-boundaries (GNU as does not support it) Use comma joined list instead of +. CommaJoined is more conventional. For example, `-mrecip=` and `-fsanitize

[PATCH] D72463: [Driver][X86] Add -malign-branch* and -malign-branch-within-32B-boundaries

MaskRay marked 5 inline comments as done. MaskRay added inline comments. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:254 +def err_drv_invalid_malign_branch_EQ : Error< + "invalid argument '%0' to -malign-branch=; must be one of: %1">; + skan w

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

0x8000- added a comment. Here is a minimal example that shows the problem: #include template struct DoGooder { DoGooder(void* accessor, SomeValue value) { } }; struct Bingus { static constexpr auto someRandomConstant = 99; }; template s

[PATCH] D72538: [ThinLTO] Add additional ThinLTO pipeline testing with new PM

wmi accepted this revision. wmi added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72538/new/ https://reviews.llvm.org/D72538 ___ cfe-

[PATCH] D72498: [clangd] Print underlying type for decltypes in hover

lh123 added a comment. > what do you think about unwrapping decltype only when it's a return value > (optional: of a function whose leading return type is auto) to narrowly catch > this idiom? I think it's worth fixing in the declarations too. int &bar(int a, int b); template auto ca

[PATCH] D72463: [Driver][X86] Add -malign-branch* and -malign-branch-within-32B-boundaries

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61771 tests passed, 0 failed and 780 were skipped. {icon times-circle color=red} clang-tidy: fail. Please fix clang-tidy findings

[PATCH] D72553: [clang-tidy] Add llvm-prefer-preincrement check

njames93 created this revision. njames93 added reviewers: aaron.ballman, alexfh, hokein. njames93 added projects: clang, clang-tools-extra. Herald added subscribers: xazax.hun, mgorny. Adds a new clang-tidy check that detects postfix increments and decrements that can be swapped for their prefix

[PATCH] D72553: [clang-tidy] Add llvm-prefer-preincrement check

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/llvm-prefer-preincrement.rst:30 + both the prefix and postfix operator ``++`` or ``--``. + Default value is 1. + Please highlight default value with single back-ticks.

[PATCH] D72553: [clang-tidy] Add llvm-prefer-preincrement check

Eugene.Zelenko added a comment. It'll be reasonable to submit patches generated by check into trunk. May be after branching release. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72553/new/ https://reviews.llvm.org/D72553 __

<    1   2   3