rtrieu added inline comments.
================
Comment at: clang/lib/Serialization/ASTReader.cpp:11007
+ // Issue any pending ODR-failure diagnostics.
+ for (auto &Merge : RecordOdrMergeFailures) {
----------------
bruno wrote:
> rtrieu wrote:
> > Is this just a copy of the other loop? That's a lot of code duplication.
> There's a lot of copy but a lot of CXXRecord specific logic got trimmed out
> and there are small differences in the approach, so a direct refactor of it
> won't work, but there's certainly more small pieces that can be factored out,
> will follow up with that.
I like this refactoring much better. Probably more refactoring could be done
to this function since it's so long, but that's an issue for another time.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71734/new/
https://reviews.llvm.org/D71734
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
