[PATCH] D72438: [clang-tidy] For checker `readability-misleading-indentation` update tests.

Abpostelnicu created this revision. Abpostelnicu added a reviewer: JonasToth. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. Abpostelnicu edited the summary of this revision. Abpostelnicu added a project: clang-tools-extra. In D72333

[PATCH] D72401: Fixes for spaces around C# object initializers

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM, thanks once again for the C# patch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72401/new/ https://reviews.llvm.org/D724

[PATCH] D72395: [clangd] Publish xref for macros from Index and AST.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, LGTM! Comment at: clang-tools-extra/clangd/unittests/XRefsTests.cpp:1093 + + // If the main file is in the index, we don't return duplicates. + // (even if the

[PATCH] D72227: Add options for clang to align branches within 32B boundary

MaskRay added inline comments. Comment at: clang/include/clang/Driver/Options.td:2196 +: Joined<["-"], "malign-branch-boundary=">, + Group, + Flags<[DriverOption, HelpHidden]>, `Group` Comment at: clang/include/clang/Driver/Option

[PATCH] D57054: [MachineOutliner][ARM][RFC] Add Machine Outliner support for ARM

samparker added a comment. > It might be possible to rearrange Low Overhead Loops to run before > ConstantIslands, but you'd probably need to do more to make it work properly. > I don't think ConstantIslands knows how to handle the branches generated by > LowOverheadLoop. This, and the fact th

[PATCH] D69770: [APFloat] Add recoverable string parsing errors to APFloat

ekatz marked an inline comment as done. ekatz added inline comments. Comment at: llvm/lib/MC/MCParser/AsmParser.cpp:3133 return TokError("invalid floating point literal"); - } else if (Value.convertFromString(IDVal, APFloat::rmNearestTiesToEven) == - APFloat::

[PATCH] D70568: [Support] Possibly use exception handler in the Crash Recovery Context in the same way as global exceptions

hans added a comment. In D70568#1789722 , @hans wrote: > > The way `Enable()/Disable()` is currently implemented will not work when > > the tool executes jobs in parallel (ie. llvm-buildozer > > I presented a

[PATCH] D71555: [clangd] Refurbish HoverInfo::present

kadircet added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:466 + markup::Paragraph &P = Output.addParagraph(); + P.appendText(beautify(index::getSymbolKindString(Kind))); + if (!Name.empty()) { sammccall wrote: > kadircet wrote: > > sammcca

[PATCH] D71555: [clangd] Refurbish HoverInfo::present

kadircet updated this revision to Diff 236976. kadircet marked 10 inline comments as done. kadircet added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71555/new/ https://reviews.llvm.org/D71555 Files: clang-tools-ext

[PATCH] D72438: [clang-tidy] For checker `readability-misleading-indentation` update tests.

lebedev.ri added subscribers: Tyker, lebedev.ri. lebedev.ri added a comment. Hm, didn't clang gain such a diagnostic itself recently? https://godbolt.org/z/MYJTvw Wouldn't it make sense to migrate everything into it, and drop this now-duplicating check? Repository: rG LLVM Github Monorepo C

[PATCH] D71555: [clangd] Refurbish HoverInfo::present

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61307 tests passed, 0 failed and 736 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D72438: [clang-tidy] For checker `readability-misleading-indentation` update tests.

Abpostelnicu added a comment. In D72438#1811512 , @lebedev.ri wrote: > Hm, didn't clang gain such a diagnostic itself recently? > https://godbolt.org/z/MYJTvw > Wouldn't it make sense to migrate everything into it, and drop this > now-duplicating check?

[PATCH] D71555: [clangd] Refurbish HoverInfo::present

sammccall accepted this revision. sammccall added a comment. still LG, go ahead and we can iterate Comment at: clang-tools-extra/clangd/Hover.cpp:495 +markup::Paragraph &P = Output.addParagraph(); +P.appendText("Value: "); +P.appendCode(*Value); kad

[PATCH] D72421: [clang-tidy] Refresh the add_new_check.py now that we use a table + autofix

sylvestre.ledru added a comment. It finds some stuff that I missed in the list :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72421/new/ https://reviews.llvm.org/D72421 ___ cfe-commits mailing list c

[PATCH] D72421: [clang-tidy] Refresh the add_new_check.py now that we use a table + autofix

sylvestre.ledru added a comment. > Thanks for this, Also how would you feel about adding a parameter to the > script that could create alias definitions in much the same way? Do you have more details about your expectation? I could have a look but in a separate commit :) Repository: rG LLVM

[PATCH] D71555: [clangd] Refurbish HoverInfo::present

kadircet updated this revision to Diff 236993. kadircet added a comment. - Change `Value:` to `Value =` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71555/new/ https://reviews.llvm.org/D71555 Files: clang-tools-extra/clangd/Hover.cpp clang-to

[PATCH] D72438: [clang-tidy] For checker `readability-misleading-indentation` update tests.

JonasToth accepted this revision. JonasToth added a comment. This revision is now accepted and ready to land. LGTM. This check already existed in clang-tidy and had a bug. So we should fix that (thank you for that) and probably even backport (release coming soon). So even though clang itself migh

[PATCH] D72271: [Clang] Handle target-specific builtins returning aggregates.

simon_tatham updated this revision to Diff 236994. simon_tatham marked 2 inline comments as done. simon_tatham added a comment. Moved the `llvm_unreachable`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72271/new/ https://reviews.llvm.org/D72271

[PATCH] D71555: [clangd] Refurbish HoverInfo::present

This revision was automatically updated to reflect the committed changes. Closed by commit rG287a874d1c46: [clangd] Refurbish HoverInfo::present (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71555/new/ https://reviews.llvm.or

[PATCH] D71555: [clangd] Refurbish HoverInfo::present

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61307 tests passed, 0 failed and 736 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[clang] 0d54079 - Fix MSVC unhandled enum warning. NFCI.

Author: Simon Pilgrim Date: 2020-01-09T11:11:01Z New Revision: 0d5407987a36445f21f122656edccbb0d9234f62 URL: https://github.com/llvm/llvm-project/commit/0d5407987a36445f21f122656edccbb0d9234f62 DIFF: https://github.com/llvm/llvm-project/commit/0d5407987a36445f21f122656edccbb0d9234f62.diff LOG:

[PATCH] D57054: [MachineOutliner][ARM][RFC] Add Machine Outliner support for ARM

yroux added a comment. In D57054#1811486 , @samparker wrote: > This, and the fact that LowOverheadLoops is dependent upon block sizes and > placement (I need to add a comment in the header on that pass). So, > ConstantIslands would have to guarantee

[PATCH] D72442: [Sema] Store deduced type in TypeLoc

ilya-biryukov created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet. Herald added a project: clang. This greatly simplifies source-level tools that need to know what 'auto' deduced to, e.g. clangd. Also change default presentation of such types to print 'auto' instead

[PATCH] D72442: [Sema] Store deduced type in TypeLoc

ilya-biryukov planned changes to this revision. ilya-biryukov added a comment. This produces the following test failures after running `check-clang`: Failing Tests (4):

[PATCH] D72119: [clangd] Handle DeducedTemplateSpecializationType in TargetFinder

ilya-biryukov added a comment. Here's my attempt at storing the deduced type in `TypeLoc`s: D72442 . It almost worked, but still needs an update to fix some test failures. The change proves it's possible to do this in principle, although it does require a few ha

[clang-tools-extra] 795c38e - [clang-tidy] For checker `readability-misleading-indentation` update tests.

Author: Andi-Bogdan Postelnicu Date: 2020-01-09T13:52:26+02:00 New Revision: 795c38eb4df636d434a9821efecbfeb41ecba843 URL: https://github.com/llvm/llvm-project/commit/795c38eb4df636d434a9821efecbfeb41ecba843 DIFF: https://github.com/llvm/llvm-project/commit/795c38eb4df636d434a9821efecbfeb41ecba

[PATCH] D72438: [clang-tidy] For checker `readability-misleading-indentation` update tests.

This revision was automatically updated to reflect the committed changes. Closed by commit rG795c38eb4df6: [clang-tidy] For checker `readability-misleading-indentation` update tests. (authored by Andi-Bogdan Postelnicu ). Changed prior to commit: https://reviews.llvm.org/D

[PATCH] D61634: [clang/llvm] Allow efficient implementation of libc's memory functions in C/C++

gchatelet added a comment. Thx for the summary @tejohnson. In D61634#1808265 , @tejohnson wrote: > >> 3. Propagate/merge the `no-builtin` IR attribute for LTO by "updating > >> `AttributeFuncs::areInlineCompatible` and/or > >> `AttributeFuncs::mergeAttr

[clang] e315ce2 - Fix "pointer is null" static analyzer warnings. NFCI.

Author: Simon Pilgrim Date: 2020-01-09T12:05:48Z New Revision: e315ce2bd3a5347ab58d50fab2d449e8a4e60e00 URL: https://github.com/llvm/llvm-project/commit/e315ce2bd3a5347ab58d50fab2d449e8a4e60e00 DIFF: https://github.com/llvm/llvm-project/commit/e315ce2bd3a5347ab58d50fab2d449e8a4e60e00.diff LOG:

[clang] e3e72a2 - Fix "pointer is null" static analyzer warnings. NFCI.

Author: Simon Pilgrim Date: 2020-01-09T12:05:47Z New Revision: e3e72a2619ccec9654ef9ad45e1e926841fbaa58 URL: https://github.com/llvm/llvm-project/commit/e3e72a2619ccec9654ef9ad45e1e926841fbaa58 DIFF: https://github.com/llvm/llvm-project/commit/e3e72a2619ccec9654ef9ad45e1e926841fbaa58.diff LOG:

[PATCH] D57054: [MachineOutliner][ARM][RFC] Add Machine Outliner support for ARM

samparker added a comment. > I can add liveness info into the outlined function, but we will need to do > the same on AArch64 even if is not necessary. Hmm, would it be possible to pass a bool to the pass which will control whether liveness is updated? The other, suboptimal, option would be to

[PATCH] D72442: [Sema] Store deduced type in TypeLoc

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 61166 tests passed, 9 failed and 729 were skipped. failed: Clang.CXX/dcl_dcl/dcl_spec/dcl_type/dcl_type_class_deduct/p1.cpp failed: Clang.SemaCXX/cxx1z-class-template-argument-deduction.cpp failed: Clang-Uni

[PATCH] D72438: [clang-tidy] For checker `readability-misleading-indentation` update tests.

thakis added a comment. I'll point out that with this approach we lose all test coverage of the checker with delayed template parsing on, even though most of the test works in that mode and delayed template parsing is the default when targeting windows. Repository: rG LLVM Github Monorepo C

[clang] d462185 - Fix "pointer is null" static analyzer warning. NFCI.

Author: Simon Pilgrim Date: 2020-01-09T12:37:38Z New Revision: d462185e8daa49889c31c8f5568749e379a5ddf9 URL: https://github.com/llvm/llvm-project/commit/d462185e8daa49889c31c8f5568749e379a5ddf9 DIFF: https://github.com/llvm/llvm-project/commit/d462185e8daa49889c31c8f5568749e379a5ddf9.diff LOG:

[PATCH] D72227: Add options for clang to align branches within 32B boundary

skan updated this revision to Diff 237019. skan marked 5 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72227/new/ https://reviews.llvm.org/D72227 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains/Clang.cpp clang/test/Driver/intel-alig

[PATCH] D72444: [ARM,MVE] Fix valid immediate range for vsliq_n.

simon_tatham created this revision. simon_tatham added reviewers: dmgreen, MarkMurrayARM, miyuki, ostannard. Herald added subscribers: cfe-commits, kristof.beyls. Herald added a project: clang. In common with most MVE immediate shift instructions, the left shift takes an immediate in the range [0,

[PATCH] D72421: [clang-tidy] Refresh the add_new_check.py now that we use a table + autofix

njames93 added a comment. In D72421#1811544 , @sylvestre.ledru wrote: > > Thanks for this, Also how would you feel about adding a parameter to the > > script that could create alias definitions in much the same way? > > Do you have more details about you

[PATCH] D72438: [clang-tidy] For checker `readability-misleading-indentation` update tests.

JonasToth added a comment. In D72438#1811776 , @thakis wrote: > I'll point out that with this approach we lose all test coverage of the > checker with delayed template parsing on, even though most of the test works > in that mode and delayed template par

[PATCH] D72217: [clang-tidy] Added readability-qualified-auto check

njames93 updated this revision to Diff 237034. njames93 added a comment. small nits CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72217/new/ https://reviews.llvm.org/D72217 Files: clang-tools-extra/clang-tidy/llvm/LLVMTidyModule.cpp clang-tools-extra/clang-tidy/readability/CMakeLis

[PATCH] D72446: [Syntax] Build mapping from AST to syntax tree nodes

ilya-biryukov created this revision. ilya-biryukov added a reviewer: gribozavr2. Herald added a project: clang. ilya-biryukov updated this revision to Diff 237039. ilya-biryukov added a comment. ilya-biryukov added a parent revision: D72334: [Syntax] Build nodes for template declarations.. Remove

[PATCH] D70568: [Support] Possibly use exception handler in the Crash Recovery Context in the same way as global exceptions

aganea added inline comments. Comment at: llvm/include/llvm/Support/Signals.h:115 + /// - create a core/mini dump of the exception context whenever possible + void CleanupOnSignal(uintptr_t ExceptContext); } // End sys namespace hans wrote: > What is ExceptCon

[PATCH] D70568: [Support] Possibly use exception handler in the Crash Recovery Context in the same way as global exceptions

aganea updated this revision to Diff 237038. aganea marked 16 inline comments as done. aganea added a comment. Changes as suggested by @hans. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70568/new/ https://reviews.llvm.org/D70568 Files: llvm/include/llvm/Support/CrashRecoveryContext

[PATCH] D72444: [ARM,MVE] Fix valid immediate range for vsliq_n.

dmgreen accepted this revision. dmgreen added a comment. This revision is now accepted and ready to land. Nice test. LGTM Comment at: clang/test/Sema/arm-mve-immediates.c:182 + + vshrq(vb, 0); // expected-error {{argument value 0 is outside the valid range [1, 8]}} + vshrq(v

[PATCH] D72446: [Syntax] Build mapping from AST to syntax tree nodes

ilya-biryukov updated this revision to Diff 237039. ilya-biryukov added a comment. Remove the (now redundant) NodeAndRole class Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72446/new/ https://reviews.llvm.org/D72446 Files: clang/include/clang/T

[PATCH] D43357: [Concepts] Function trailing requires clauses

thakis added a comment. This breaks tests on Windows: http://45.33.8.238/win/5368/step_7.txt Please take a look and revert if it takes a while to investigate. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D43357/new/ https://reviews.llvm.org/D43357

[PATCH] D72446: [Syntax] Build mapping from AST to syntax tree nodes

merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon question-circle color=gray} clang-tidy: unknown. {icon question-circle color=gray} clang-format: unknown. Build artifacts : diff.

[PATCH] D72446: [Syntax] Build mapping from AST to syntax tree nodes

merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon question-circle color=gray} clang-tidy: unknown. {icon question-circle color=gray} clang-format: unknown. Build artifacts : diff.

[PATCH] D72446: [Syntax] Build mapping from AST to syntax tree nodes

ilya-biryukov updated this revision to Diff 237042. ilya-biryukov added a comment. - Remove debug logs - Cosmetics Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72446/new/ https://reviews.llvm.org/D72446 Files: clang/include/clang/Tooling/Syntax

[PATCH] D72153: [libTooling] Add function to determine associated text of a declaration.

ymandel updated this revision to Diff 237044. ymandel added a comment. tweaked test organization Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72153/new/ https://reviews.llvm.org/D72153 Files: clang/include/clang/Tooling/Transformer/SourceCode.h

[PATCH] D69825: [Clang][Driver] Re-use the calling process instead of creating a new process for the cc1 invocation

aganea updated this revision to Diff 237043. aganea marked 4 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69825/new/ https://reviews.llvm.org/D69825 Files: clang/CMakeLists.txt clang/include/clang/Config/config.h.cmake clang/include/clang/Driver/Driver.h

[PATCH] D69825: [Clang][Driver] Re-use the calling process instead of creating a new process for the cc1 invocation

aganea added inline comments. Comment at: clang/lib/Driver/Job.cpp:394 + + llvm::CrashRecoveryContext::Enable(); + hans wrote: > Do we need to disable afterwards? I moved this line to `clang/tools/driver/driver.cpp` like discussed previously.

[clang] 173b711 - [ARM][MVE] MVE-I should not be disabled by -mfpu=none

Author: Momchil Velikov Date: 2020-01-09T14:03:25Z New Revision: 173b711e83d7b61a46f55eb44f03ea98f69a1dd6 URL: https://github.com/llvm/llvm-project/commit/173b711e83d7b61a46f55eb44f03ea98f69a1dd6 DIFF: https://github.com/llvm/llvm-project/commit/173b711e83d7b61a46f55eb44f03ea98f69a1dd6.diff LO

[PATCH] D71843: [ARM][MVE] MVE-I should not be disabled by -mfpu=none

This revision was automatically updated to reflect the committed changes. Closed by commit rG173b711e83d7: [ARM][MVE] MVE-I should not be disabled by -mfpu=none (authored by chill). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANG

[PATCH] D72446: [Syntax] Build mapping from AST to syntax tree nodes

merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon question-circle color=gray} clang-tidy: unknown. {icon question-circle color=gray} clang-format: unknown. Build artifacts : diff.

[PATCH] D72153: [libTooling] Add function to determine associated text of a declaration.

ymandel updated this revision to Diff 237051. ymandel added a comment. fold initLexer into the callsite, because it's only called once. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72153/new/ https://reviews.llvm.org/D72153 Files: clang/include

[clang] 84ce462 - [Concepts] Fix failing test on Windows

Author: Saar Raz Date: 2020-01-09T16:13:46+02:00 New Revision: 84ce46269cfda8800346706251ac3587b2d1c9f5 URL: https://github.com/llvm/llvm-project/commit/84ce46269cfda8800346706251ac3587b2d1c9f5 DIFF: https://github.com/llvm/llvm-project/commit/84ce46269cfda8800346706251ac3587b2d1c9f5.diff LOG:

[PATCH] D72448: [clang-tidy] readability-redundant-string-init now flags redundant initialisation in Field Decls and Constructor Initialisers

njames93 created this revision. njames93 added reviewers: aaron.ballman, alexfh, hokein. njames93 added projects: clang, clang-tools-extra. Herald added a subscriber: xazax.hun. njames93 marked an inline comment as done. njames93 added inline comments. Comment at: clang-tools-ex

[PATCH] D71510: [clang][checkers] Added new checker 'error-return-checker'. (WIP)

balazske updated this revision to Diff 237053. balazske added a comment. - Prevent warning if call is in a return statement. - Prevent warning if call is casted to void. - Added documentation. - Fixed the tests. - Some other fixes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D72414: Add new AST matchers `hasAnyCapture` and `capturesThis`

aaron.ballman added a comment. Thank you for this patch! You should also register the matcher(s) in Registry.cpp so that they'll work from clang-query. Also, you need to regenerate the documentation by running `clang\docs\tools\dump_ast_matchers.py` Comment at: clang/include/

[PATCH] D72448: [clang-tidy] readability-redundant-string-init now flags redundant initialisation in Field Decls and Constructor Initialisers

njames93 marked an inline comment as done. njames93 added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/readability-redundant-string-init.cpp:244 + // CHECK-MESSAGES: [[@LINE-1]]:11: warning: redundant string initialization + // CHECK-FIXES: Foo() {

[PATCH] D71082: Allow system header to provide their own implementation of some builtin

sylvestre.ledru added a comment. @serge-sans-paille any blocker for this to land? Would be great to have it in version 10. Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71082/new/ https://reviews.llvm.org/D71082 _

[PATCH] D72449: [PATCH] [llvm-ranlib] Take in consideration UTC offset for D-flag.test

zatrazz created this revision. zatrazz added reviewers: arichardson, emaste, rupprecht. Herald added a subscriber: kristof.beyls. Herald added a project: LLVM. The llvm-ar uses localtime to print the object timestamp and it is subject to UTC offset (daylight for instance). The patch changes the t

[PATCH] D72167: Add support for __declspec(guard(nocf))

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/include/clang/Basic/Attr.td:2914 + let Spellings = [Declspec<"guard">]; + let Subjects = SubjectList<[Function]>; + let Args = [EnumA

[PATCH] D57054: [MachineOutliner][ARM][RFC] Add Machine Outliner support for ARM

yroux added a comment. > ! In D57054#1811740 , @samparker > wrote: > Hmm, would it be possible to pass a bool to the pass which will control > whether liveness is updated? The other, suboptimal, option would be to not do > outlining when we have the LOB

[PATCH] D72450: [clangd] Improve type printing in hover

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Do not include tag keywords when printing types for symbol names, as it will come from SymbolKind. Also

[PATCH] D71510: [clang][checkers] Added new checker 'error-return-checker'.

balazske updated this revision to Diff 237061. balazske added a comment. - More fixes in test files. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71510/new/ https://reviews.llvm.org/D71510 Files: clang/docs/analyzer/checkers.rst clang/include

[PATCH] D71612: [analyzer] Add PlacementNewChecker

martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/CheckPlacementNew.cpp:91 + SVal SizeOfPlace = getExtentSizeOfPlace(C, Place, State); + const auto SizeOfTargetCI = SizeOfTarget.getAs(); + if (!SizeOfTargetCI) xazax.hun wrote: > Here

[PATCH] D71612: [analyzer] Add PlacementNewChecker

martong updated this revision to Diff 237059. martong marked 11 inline comments as done. martong added a comment. - Add documentation to checkers.rst - Pass CheckerContext as last param - Use BugType and default member initializer Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D71612: [analyzer] Add PlacementNewChecker

martong added a comment. In D71612#1790045 , @NoQ wrote: > I wonder if this checker will find any misuses of placement into > `llvm::TrailingObjects`. I've evaluated this checker on LLVM/Clang source and it did not find any results, though there are ma

[clang] 4c11703 - [OPENMP]Remove unused code, NFC.

Author: Alexey Bataev Date: 2020-01-09T09:50:46-05:00 New Revision: 4c11703b3d9d936214b8ced70bd6475974c317d8 URL: https://github.com/llvm/llvm-project/commit/4c11703b3d9d936214b8ced70bd6475974c317d8 DIFF: https://github.com/llvm/llvm-project/commit/4c11703b3d9d936214b8ced70bd6475974c317d8.diff

[PATCH] D72448: [clang-tidy] readability-redundant-string-init now flags redundant initialisation in Field Decls and Constructor Initialisers

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/RedundantStringInitCheck.cpp:24 +namespace { +const CXXConstructExpr *getConstructExpr(const CXXCtorInitializer &CtorInit) { + Expr *InitExpr = CtorInit.getInit(); Please

[PATCH] D72449: [PATCH] [llvm-ranlib] Take in consideration UTC offset for D-flag.test

kristof.beyls added inline comments. Comment at: llvm/test/tools/llvm-ranlib/D-flag.test:13 # RUN: cp %t-no-index.a %t.a && llvm-ranlib -D %t.a -# RUN: env TZ=UTC llvm-ar tv %t.a | FileCheck %s --check-prefix=DETERMINISTIC-VALUES +# RUN: (env TZ=UTC date -d '@0' +%H:%M; env TZ=

[clang] d857e11 - [ARM,MVE] Fix valid immediate range for vsliq_n.

Author: Simon Tatham Date: 2020-01-09T15:04:47Z New Revision: d857e114b5e04f5143485a5aea7ad9b283768692 URL: https://github.com/llvm/llvm-project/commit/d857e114b5e04f5143485a5aea7ad9b283768692 DIFF: https://github.com/llvm/llvm-project/commit/d857e114b5e04f5143485a5aea7ad9b283768692.diff LOG:

[PATCH] D72450: [clangd] Improve type printing in hover

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61327 tests passed, 0 failed and 738 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D72448: [clang-tidy] readability-redundant-string-init now flags redundant initialisation in Field Decls and Constructor Initialisers

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/RedundantStringInitCheck.cpp:143 + Result.Nodes.getNodeAs("ctorInit")) { +if (auto *Member = CtorInit->getMember()) { + if (!Member->hasInClassInitializer() ||

[PATCH] D72448: [clang-tidy] readability-redundant-string-init now flags redundant initialisation in Field Decls and Constructor Initialisers

njames93 updated this revision to Diff 237077. njames93 marked 5 inline comments as done. njames93 added a comment. Address nits CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72448/new/ https://reviews.llvm.org/D72448 Files: clang-tools-extra/clang-tidy/readability/RedundantStringIni

[PATCH] D72449: [PATCH] [llvm-ranlib] Take in consideration UTC offset for D-flag.test

arichardson added a comment. I was careful in the test to use `TZ=UTC` for all commands printing dates and it works fine for me in UTC+1 and in the UK which is currently UTC. Does the bot in question ignore the TZ variable? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72449/new/ http

[PATCH] D72449: [PATCH] [llvm-ranlib] Take in consideration UTC offset for D-flag.test

arichardson added inline comments. Comment at: llvm/test/tools/llvm-ranlib/D-flag.test:23 # RUN: cp %t-no-index.a %t.a && llvm-ranlib -UUD %t.a # RUN: env TZ=UTC llvm-ar tv %t.a | FileCheck %s --check-prefix=DETERMINISTIC-VALUES Wouldn't this line also have

[PATCH] D71374: Improve support of GNU mempcpy

serge-sans-paille added a comment. @xbolva00 : gentle reminder :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71374/new/ https://reviews.llvm.org/D71374 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D71082: Allow system header to provide their own implementation of some builtin

serge-sans-paille added a comment. @sylvestre.ledru : I'd like a confirmation from @efriedma first! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71082/new/ https://reviews.llvm.org/D71082 ___ cfe-comm

[PATCH] D71374: Improve support of GNU mempcpy

xbolva00 accepted this revision. xbolva00 added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71374/new/ https://reviews.llvm.org/D71374 _

[PATCH] D72444: [ARM,MVE] Fix valid immediate range for vsliq_n.

simon_tatham closed this revision. simon_tatham marked an inline comment as done. simon_tatham added a comment. Closed by rGd857e114b5e04f5143485a5aea7ad9b283768692 . (I managed to leave off the commit message footer, sorry.)

[PATCH] D72421: [clang-tidy] Refresh the add_new_check.py now that we use a table + autofix

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Awesome! Thanks for updating the script! A few nits, otherwise LG, if this works. Comment at: clang-tools-extra/clang-tidy/add_new_check.py:308 + +checkerCode = os.path.

[PATCH] D72245: [PoC][RISCV][LTO] Pass target-abi via module flag metadata

khchen updated this revision to Diff 237084. khchen edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72245/new/ https://reviews.llvm.org/D72245 Files: clang/lib/CodeGen/CodeGenModule.cpp clang/lib/Driver/ToolChains/RISCVToolchain.cpp clang/lib/Driv

[clang-tools-extra] ea9888b - [clangd] Respect `--sysroot` argument if it is set

Author: David Goldman Date: 2020-01-09T11:02:58-05:00 New Revision: ea9888b8f6f20887647b77ebf5864d647fd2ea44 URL: https://github.com/llvm/llvm-project/commit/ea9888b8f6f20887647b77ebf5864d647fd2ea44 DIFF: https://github.com/llvm/llvm-project/commit/ea9888b8f6f20887647b77ebf5864d647fd2ea44.diff

[PATCH] D72458: [clangd] Adjust diagnostic range to be inside main file

kadircet created this revision. kadircet added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay. Herald added a project: clang. LSP requires diagnostics to lay inside main file. In clangd we keep diagnostics in three different cases: - alread

[PATCH] D72415: [clangd] Respect `--sysroot` argument if it is set

This revision was automatically updated to reflect the committed changes. Closed by commit rGea9888b8f6f2: [clangd] Respect `--sysroot` argument if it is set (authored by dgoldman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72415/new/ https://re

[PATCH] D72458: [clangd] Adjust diagnostic range to be inside main file

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61663 tests passed, 0 failed and 779 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D72459: [CMake] Support running libc++abi tests in CrossWinToARMLinux cache file

broadwaylamb created this revision. Herald added subscribers: cfe-commits, ldionne, kristof.beyls, mgorny. Herald added a reviewer: EricWF. Herald added a project: clang. broadwaylamb edited the summary of this revision. broadwaylamb edited reviewers, added: andreil99, vvereschaka, aorlov; removed:

[PATCH] D71374: Improve support of GNU mempcpy

This revision was automatically updated to reflect the committed changes. Closed by commit rGcee4a1c95742: Improve support of GNU mempcpy (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71374/new/ https://reviews.llvm.

[PATCH] D72227: Add options for clang to align branches within 32B boundary

craig.topper added inline comments. Comment at: clang/include/clang/Driver/Options.td:2196 +: Joined<["-"], "malign-branch-boundary=">, + Group, + Flags<[DriverOption, HelpHidden]>, MaskRay wrote: > `Group` Doesn't m_x86_Features_Group make things g

[clang] cee4a1c - Improve support of GNU mempcpy

Author: serge-sans-paille Date: 2020-01-09T17:31:00+01:00 New Revision: cee4a1c957426e9477c8579ff960c8c2bd4af9e2 URL: https://github.com/llvm/llvm-project/commit/cee4a1c957426e9477c8579ff960c8c2bd4af9e2 DIFF: https://github.com/llvm/llvm-project/commit/cee4a1c957426e9477c8579ff960c8c2bd4af9e2.d

[clang] 241f335 - [OpenCL][Docs] Rename C++ for OpenCL label

Author: Sven van Haastregt Date: 2020-01-09T16:31:45Z New Revision: 241f335b268dc19a0dfb85686a7c82fb339421a8 URL: https://github.com/llvm/llvm-project/commit/241f335b268dc19a0dfb85686a7c82fb339421a8 DIFF: https://github.com/llvm/llvm-project/commit/241f335b268dc19a0dfb85686a7c82fb339421a8.diff

[PATCH] D71612: [analyzer] Add PlacementNewChecker

xazax.hun added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/CheckPlacementNew.cpp:91 + SVal SizeOfPlace = getExtentSizeOfPlace(C, Place, State); + const auto SizeOfTargetCI = SizeOfTarget.getAs(); + if (!SizeOfTargetCI) martong wrote: > xaza

[PATCH] D72458: [clangd] Adjust diagnostic range to be inside main file

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang-tools-extra/clangd/Diagnostics.cpp:342 +llvm::Optional NoteInsideMainFile; +for (auto &N : D.Notes) { + if (!N.InsideMainFil

[PATCH] D72245: [PoC][RISCV][LTO] Pass target-abi via module flag metadata

kito-cheng added a comment. Seems like this patch mixed with LTO related changes? Could you clean it up? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72245/new/ https://reviews.llvm.org/D72245 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D72304: Summary: Add OpenMP Directives (master and critical) to OMPBuilder, and use them in clang.

jdoerfert added inline comments. Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:845 + default: + assert(false && "unknown OMP directive"); + While I hope this code goes away, I should mention that we don't write `assert(false && "...")

[PATCH] D72462: [clangd] Fix markdown rendering in VSCode

kadircet created this revision. kadircet added reviewers: sammccall, ilya-biryukov. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay. Herald added a project: clang. Eventough it is OK to have a new line without any preceding spaces in some markdown specifications, VSCod

[PATCH] D72271: [Clang] Handle target-specific builtins returning aggregates.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Thanks, LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72271/new/ https://reviews.llvm.org/D72271 __

[clang-tools-extra] 189aa5b - [clangd] Adjust diagnostic range to be inside main file

Author: Kadir Cetinkaya Date: 2020-01-09T18:02:33+01:00 New Revision: 189aa5b7a4584677ad628ecc2c369db61d4d2515 URL: https://github.com/llvm/llvm-project/commit/189aa5b7a4584677ad628ecc2c369db61d4d2515 DIFF: https://github.com/llvm/llvm-project/commit/189aa5b7a4584677ad628ecc2c369db61d4d2515.dif

  1   2   3   >