[PATCH] D71499: Add builtins for aligning and checking alignment of pointers and integers

lebedev.ri added a comment. In D71499#1800636 , @arichardson wrote: > Address feedback: Avoid inttoptr by using ptrtoint + GEP instead. > > Using two GEPs for align_up seems to generate better code than select + a > single GEP. > See https://godbolt.org/

[PATCH] D72066: [clangd] Assert that the testcases in LocateSymbol.All have no diagnostics

kadircet added a reviewer: kadircet. kadircet added a comment. thanks for taking a look at this! Comment at: clang-tools-extra/clangd/unittests/XRefsTests.cpp:447 struct X { - X& [[operator]]++() {} + X& [[operator]]++() { return *this; } };

[PATCH] D71920: [AST] Refactor propagation of dependency bits. NFC

ilya-biryukov updated this revision to Diff 235837. ilya-biryukov added a comment. - Use DependencyFlagsBits for computing NumExprBits - Reformat Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71920/new/ https://reviews.llvm.org/D71920 Files: cla

[PATCH] D71920: [AST] Refactor propagation of dependency bits. NFC

ilya-biryukov marked 4 inline comments as done. ilya-biryukov added inline comments. Comment at: clang/include/clang/AST/Expr.h:126 +if (TD) + D = D | DependencyFlags::Type; +if (VD) Mordante wrote: > Just curious why do you prefer `D = D | Dependenc

[PATCH] D71499: Add builtins for aligning and checking alignment of pointers and integers

lebedev.ri added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:14318 + } + // Negate the mask to only clear the lower bits. + llvm::Value *Result; But this isn't what we are doing, negation != inversion. Repository: rG LLVM Github Monorepo

[PATCH] D54395: [clang-tidy] implement utility-function to add 'const' to variables

JonasToth marked an inline comment as done. JonasToth added inline comments. Comment at: clang-tools-extra/unittests/clang-tidy/AddConstTest.cpp:66 + StringRef S = "MyInt target = 0;"; + auto Cat = [&T](StringRef S) { return (T + S).str(); }; + aaron.ballman wr

[PATCH] D54395: [clang-tidy] implement utility-function to add 'const' to variables

JonasToth updated this revision to Diff 235838. JonasToth marked 3 inline comments as done. JonasToth added a comment. - address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54395/new/ https://reviews.llvm.org/D54395 Files: clan

[PATCH] D72071: [clangd] Add correctness checks for index-based rename

kbobyrev created this revision. kbobyrev added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay. Herald added a project: clang. In some cases the candidate ranges for rename final stage (textual replacements) are invalid and do not contain referenc

[PATCH] D71920: [AST] Refactor propagation of dependency bits. NFC

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61158 tests passed, 0 failed and 728 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D72072: [AST] Respect shouldTraversePostOrder when traversing type locs

ilya-biryukov created this revision. ilya-biryukov added a reviewer: gribozavr2. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D72072 Files: clang/include/clang/AST/RecursiveASTVisitor.h Index: clang/include/clang/AST/RecursiveASTVisitor.h

[PATCH] D72072: [AST] Respect shouldTraversePostOrder when traversing type locs

ilya-biryukov added a comment. Would be nice to write a test too, but didn't get to it yet... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72072/new/ https://reviews.llvm.org/D72072 ___ cfe-commits ma

[PATCH] D72071: [clangd] Add correctness checks for index-based rename

kbobyrev updated this revision to Diff 235841. kbobyrev added a comment. Improve wording in the comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72071/new/ https://reviews.llvm.org/D72071 Files: clang-tools-extra/clangd/refactor/Rename.cpp

[PATCH] D72071: [clangd] Add correctness checks for index-based rename

kbobyrev added a comment. @sammccall `Indexed.size() > Lexed.size()` is one of the assumptions that I think might not hold in real-world scenarios. I was reading patch heuristics code a lot and trying to understand whether anything breaks when this check is not in place, but I couldn't come up

[PATCH] D72071: [clangd] Add correctness checks for index-based rename

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61168 tests passed, 0 failed and 728 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D72072: [AST] Respect shouldTraversePostOrder when traversing type locs

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61158 tests passed, 0 failed and 728 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D72071: [clangd] Add correctness checks for index-based rename

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61168 tests passed, 0 failed and 728 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D72073: [Sema] Fix location of star ('*') inside MemberPointerTypeLoc

ilya-biryukov created this revision. ilya-biryukov added a reviewer: gribozavr2. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D72073 Files: clang/include/clang/Sema/DeclSpec.h clang/lib/Parse/ParseDecl.cpp clang/lib/Sema/SemaType.cpp Index

[PATCH] D72073: [Sema] Fix location of star ('*') inside MemberPointerTypeLoc

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61158 tests passed, 0 failed and 728 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by running `gi

[PATCH] D71982: [docs] Update path to clang-tools-extra

AlexanderLanin added a comment. @Jim `git commit --amend --author="Alexander Lanin "` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71982/new/ https://reviews.llvm.org/D71982 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[clang-tools-extra] 8188c99 - [docs] Update path to clang-tools-extra

Author: Alexander Lanin Date: 2020-01-02T19:30:29+08:00 New Revision: 8188c998ffa4d20253444b257402907d2aa74dc2 URL: https://github.com/llvm/llvm-project/commit/8188c998ffa4d20253444b257402907d2aa74dc2 DIFF: https://github.com/llvm/llvm-project/commit/8188c998ffa4d20253444b257402907d2aa74dc2.dif

[PATCH] D71982: [docs] Update path to clang-tools-extra

This revision was automatically updated to reflect the committed changes. Closed by commit rG8188c998ffa4: [docs] Update path to clang-tools-extra (authored by AlexanderLanin, committed by Jim). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71982/new

[PATCH] D72071: [clangd] Add correctness checks for index-based rename

kadircet added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:378 +buildRenameEdit(FilePath, *AffectedFileCode, *RenameRanges, NewName, +RenameDecl.getNameAsString()); if (!RenameEdit) { nit: move bo

[PATCH] D72076: [OpenCL] Add link to C++ for OpenCL documentation

Anastasia created this revision. Anastasia added a reviewer: svenvh. Herald added subscribers: ebevhan, yaxunl. Remove description of language mode from the language extensions and add a link to pdf document. https://reviews.llvm.org/D72076 Files: clang/docs/LanguageExtensions.rst clang/do

[PATCH] D72076: [OpenCL] Add link to C++ for OpenCL documentation

svenvh accepted this revision. svenvh added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72076/new/ https://reviews.llvm.org/D72076 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D71499: Add builtins for aligning and checking alignment of pointers and integers

arichardson updated this revision to Diff 235848. arichardson marked an inline comment as done. arichardson added a comment. Improved code generation with a single GEP The pointer case of align_up is now generates the expected add+mask assembly even without the llvm.ptrmask intrinsic. Reposito

[PATCH] D71554: [llvm-ranlib] Handle -D and -U command line flag

This revision was automatically updated to reflect the committed changes. Closed by commit rG535b3c6b2f1c: [llvm-ranlib] Handle -D and -U command line flag (authored by arichardson). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71554/new/ https://r

[PATCH] D71499: Add builtins for aligning and checking alignment of pointers and integers

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61172 tests passed, 0 failed and 728 were skipped. {icon times-circle color=red} clang-tidy: fail. Please fix clang-tidy findings

[PATCH] D72076: [OpenCL] Add link to C++ for OpenCL documentation

Anastasia updated this revision to Diff 235854. Anastasia added a comment. Recovered lost bit of information. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72076/new/ https://reviews.llvm.org/D72076 Files: clang/docs/LanguageExtensions.rst clang/docs/UsersManual.rst Index: clang/d

[PATCH] D71499: Add builtins for aligning and checking alignment of pointers and integers

lebedev.ri accepted this revision. lebedev.ri marked an inline comment as done. lebedev.ri added a comment. This revision is now accepted and ready to land. Looks ok to me now in principle. I have one more question about pointer variants though (see inline) Comment at: clang/li

[PATCH] D71499: Add builtins for aligning and checking alignment of pointers and integers

arichardson added a comment. In D71499#1801104 , @lebedev.ri wrote: > Looks ok to me now in principle. > I have one more question about pointer variants though (see inline) I am not sure the GEP can be inbounds since I have seen some cases where aligni

[PATCH] D72071: [clangd] Add correctness checks for index-based rename

sammccall requested changes to this revision. sammccall added a comment. This revision now requires changes to proceed. Postfiltering non-textual references won't work for the index-based rename, as the whole adjust-the-ranges algorithm relies on the index references being a subset of textual ma

[PATCH] D71652: [clangd] Replace shortenNamespace with getQualification

kadircet added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71652/new/ https://reviews.llvm.org/D71652 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D71652: [clangd] Replace shortenNamespace with getQualification

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang-tools-extra/clangd/AST.cpp:307 + llvm::raw_string_ostream OS(Result); + auto Decls = explicitReferenceTargets( + ast_type_traits::

[PATCH] D71698: [AArch64][SVE] Add intrinsic for non-faulting loads

andwar added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:9998 + // GLD1* instructions perform an implicit zero-extend, which makes them // perfect candidates for combining. Could you replace `GLD1*` with `Load`? I believe th

[PATCH] D71499: Add builtins for aligning and checking alignment of pointers and integers

lebedev.ri added reviewers: nlopes, aqjune. lebedev.ri added a subscriber: nlopes. lebedev.ri added a comment. (would be good for @nlopes to comment, maybe i'm overweighting this..) In D71499#1801119 , @arichardson wrote: > In D71499#1801104

[PATCH] D71554: [llvm-ranlib] Handle -D and -U command line flag

thakis added a comment. The test fails on Windows: http://45.33.8.238/win/4948/step_11.txt Please take a look, and if takes a while to fix, revert in the meantime. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71554/new/ https://reviews.llvm.org/D

[PATCH] D71554: [llvm-ranlib] Handle -D and -U command line flag

arichardson added a comment. In D71554#1801203 , @thakis wrote: > The test fails on Windows: http://45.33.8.238/win/4948/step_11.txt > > Please take a look, and if takes a while to fix, revert in the meantime. I'll just relax the permissions check. We on

[PATCH] D71554: [llvm-ranlib] Handle -D and -U command line flag

arichardson added a comment. Should be fixed in https://github.com/llvm/llvm-project/commit/a4f3847f3d5742cfab7acdc614e7ca54643e0c85 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71554/new/ https://reviews.llvm.org/D71554 __

[clang] 87a004d - [OpenMP] Fix formatting of OpenMP error message, by Wang Tianqing.

Author: Alexey Bataev Date: 2020-01-02T10:07:04-05:00 New Revision: 87a004d0f8c2fe5c4577d81b4306c35e77f21f9a URL: https://github.com/llvm/llvm-project/commit/87a004d0f8c2fe5c4577d81b4306c35e77f21f9a DIFF: https://github.com/llvm/llvm-project/commit/87a004d0f8c2fe5c4577d81b4306c35e77f21f9a.diff

[PATCH] D72085: [clangd] Fix hover for functions inside templated classes

kadircet created this revision. kadircet added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay. Herald added a project: clang. Fixes https://github.com/clangd/clangd/issues/235 Repository: rG LLVM Github Monorepo https://reviews.llvm.org

[PATCH] D71884: [OpenMP] Fix formatting of OpenMP error message.

This revision was automatically updated to reflect the committed changes. Closed by commit rG87a004d0f8c2: [OpenMP] Fix formatting of OpenMP error message, by Wang Tianqing. (authored by ABataev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71884/n

[clang-tools-extra] 8d7ecc1 - Revert "Revert "[clangd] Implement "textDocument/documentLink" protocol support""

Author: Sam McCall Date: 2020-01-02T16:36:21+01:00 New Revision: 8d7ecc16291ff415da0d5bfccb6363590a1310ad URL: https://github.com/llvm/llvm-project/commit/8d7ecc16291ff415da0d5bfccb6363590a1310ad DIFF: https://github.com/llvm/llvm-project/commit/8d7ecc16291ff415da0d5bfccb6363590a1310ad.diff LO

[PATCH] D71499: Add builtins for aligning and checking alignment of pointers and integers

arichardson added a subscriber: brooks. arichardson added a comment. > What i'm asking is: > > - Are these builtins designed (as per `clang/docs/LanguageExtensions.rst`) to > only be passed pointers in-bounds to the allocated memory chunk (`Logical > pointer`*), or any random bag of bits casted

[PATCH] D71920: [AST] Refactor propagation of dependency bits. NFC

riccibruno added inline comments. Comment at: clang/include/clang/AST/Expr.h:126 +if (TD) + D = D | DependencyFlags::Type; +if (VD) ilya-biryukov wrote: > Mordante wrote: > > Just curious why do you prefer `D = D | DependencyFlags::Type;` over `D |=

[PATCH] D72085: [clangd] Fix hover for functions inside templated classes

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61043 tests passed, 0 failed and 728 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[clang] 24ab9b5 - Generalize the pass registration mechanism used by Polly to any third-party tool

Author: serge_sans_paille Date: 2020-01-02T16:45:31+01:00 New Revision: 24ab9b537e61b3fe5e6a1019492ff6530d82a3ee URL: https://github.com/llvm/llvm-project/commit/24ab9b537e61b3fe5e6a1019492ff6530d82a3ee DIFF: https://github.com/llvm/llvm-project/commit/24ab9b537e61b3fe5e6a1019492ff6530d82a3ee.d

[PATCH] D71726: Let clang atomic builtins fetch add/sub support floating point types

arsenm added inline comments. Comment at: clang/lib/CodeGen/CGAtomic.cpp:597-598 case AtomicExpr::AO__atomic_add_fetch: -PostOp = llvm::Instruction::Add; +PostOp = E->getValueType()->isFloatingType() ? llvm::Instruction::FAdd +

[PATCH] D61446: Generalize the pass registration mechanism used by Polly to any third-party tool

This revision was automatically updated to reflect the committed changes. Closed by commit rG24ab9b537e61: Generalize the pass registration mechanism used by Polly to any third-party tool (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[clang] e406cca - Revert "build: reduce CMake handling for zlib"

Author: James Henderson Date: 2020-01-02T16:02:10Z New Revision: e406cca5f9a6477c9861717f81c156aa83feeaca URL: https://github.com/llvm/llvm-project/commit/e406cca5f9a6477c9861717f81c156aa83feeaca DIFF: https://github.com/llvm/llvm-project/commit/e406cca5f9a6477c9861717f81c156aa83feeaca.diff LO

[PATCH] D71854: [SystemZ] Use FNeg in s390x clang builtins

kpn updated this revision to Diff 235880. kpn added a comment. Update now-failing tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71854/new/ https://reviews.llvm.org/D71854 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/test/CodeGen/builtins-systemz-vector.c clang/test/CodeGen

[PATCH] D71499: Add builtins for aligning and checking alignment of pointers and integers

jrtc27 added inline comments. Comment at: clang/docs/LanguageExtensions.rst:2844 +The builtins ``__builtin_align_up``, ``__builtin_align_down``, return their +first argument aligned up/down to the next multiple of the second argument. +The builtin ``__builtin_is_aligned`` returns

[PATCH] D72085: [clangd] Fix hover for functions inside templated classes

ilya-biryukov added a comment. I landed a patch that does exactly this a few days ago: 14e11005d1a6ac1fecb230c470e9011d6956b8e4 Did you pull the latest changes? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D72087: NFC: Fix trivial typos in comments

kiszk created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous. Herald added a project: clang. "the the" -> "the" "an" -> "a" Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D72087 Files: clang-tools-extra/clang-tidy/bugprone/NotNull

[PATCH] D61446: Generalize the pass registration mechanism used by Polly to any third-party tool

thakis added inline comments. Comment at: llvm/test/lit.site.cfg.py.in:6 +def cmake_bool(val): +return val.lower() in (1, "on", "yes", "true", "y",) + FYI, this is a now-discouraged pattern. It's better to use llvm_canonicalize_cmake_booleans in the cmake fi

[PATCH] D71726: Let clang atomic builtins fetch add/sub support floating point types

__simt__ added a comment. In D71726#1792852 , @yaxunl wrote: > In D71726#1791904 , @jfb wrote: > > > This generally seems fine. Does it work on most backends? I want to make > > sure it doesn't fail in backends :)

[PATCH] D71920: [AST] Refactor propagation of dependency bits. NFC

ilya-biryukov marked 4 inline comments as done. ilya-biryukov added inline comments. Comment at: clang/include/clang/AST/Expr.h:126 +if (TD) + D = D | DependencyFlags::Type; +if (VD) riccibruno wrote: > ilya-biryukov wrote: > > Mordante wrote: > > >

[PATCH] D32199: [TySan] A Type Sanitizer (Clang)

CJ-Johnson commandeered this revision. CJ-Johnson added a reviewer: hfinkel. CJ-Johnson added a comment. After discussing things with Hal, I'm going to take over these diffs and try to update them to the new pass manager :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D32199/new/ https

[PATCH] D72087: [clang-tools-extra] NFC: Fix trivial typos in comments

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61171 tests passed, 0 failed and 729 were skipped. {icon times-circle color=red} clang-tidy: fail. Please fix clang-tidy findings

[PATCH] D72089: [Syntax] Build declarator nodes

ilya-biryukov created this revision. ilya-biryukov added a reviewer: gribozavr2. Herald added a project: clang. ilya-biryukov added a parent revision: D72072: [AST] Respect shouldTraversePostOrder when traversing type locs. They cover part of types and names for some declarations, including commo

[PATCH] D69878: Consoldiate internal denormal flushing controls

arsenm added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69878/new/ https://reviews.llvm.org/D69878 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D71854: [SystemZ] Use FNeg in s390x clang builtins

uweigand accepted this revision. uweigand added a comment. This revision is now accepted and ready to land. LGTM, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71854/new/ https://reviews.llvm.org/D71854 ___ cfe-commits mailing list

[PATCH] D72089: [Syntax] Build declarator nodes

merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon question-circle color=gray} clang-tidy: unknown. {icon question-circle color=gray} clang-format: unknown. Build artifacts : diff.

[PATCH] D61446: Generalize the pass registration mechanism used by Polly to any third-party tool

serge-sans-paille marked an inline comment as done. serge-sans-paille added a comment. serge-sans-paille added inline comments. Comment at: llvm/test/lit.site.cfg.py.in:6 +def cmake_bool(val): +return val.lower() in (1, "on", "yes", "true", "y",) + thakis wro

[PATCH] D71596: [clangd] Improve documentation for auto and implicit specs

sammccall added inline comments. Comment at: clang-tools-extra/clangd/FindTarget.h:194 +llvm::SmallVector +explicitReferenceTargets(ast_type_traits::DynTypedNode N, + DeclRelationSet Mask = {}); ilya-biryukov wrote: > No need to fix this.

[PATCH] D71554: [llvm-ranlib] Handle -D and -U command line flag

thakis added a comment. In D71554#1801246 , @arichardson wrote: > Should be fixed in > https://github.com/llvm/llvm-project/commit/a4f3847f3d5742cfab7acdc614e7ca54643e0c85 Thanks! Now it fails with a different error: http://45.33.8.238/win/4962/step_11

[PATCH] D71499: Add builtins for aligning and checking alignment of pointers and integers

lebedev.ri requested changes to this revision. lebedev.ri added a comment. This revision now requires changes to proceed. (temporarily undoing my review since it looks like things may change) In D71499#1801302 , @arichardson wrote: > ... Aha! :) In D71

[clang-tools-extra] acc4ffb - [clangd] Reorder FindTarget.h - group targetDecl() stuff and findExplicitReferences(). NFC

Author: Sam McCall Date: 2020-01-02T18:01:29+01:00 New Revision: acc4ffbb4733ec716d6ca3ad4d1e4605b9a2bcea URL: https://github.com/llvm/llvm-project/commit/acc4ffbb4733ec716d6ca3ad4d1e4605b9a2bcea DIFF: https://github.com/llvm/llvm-project/commit/acc4ffbb4733ec716d6ca3ad4d1e4605b9a2bcea.diff LO

[clang] 89d6c28 - [SystemZ] Use FNeg in s390x clang builtins

Author: Kevin P. Neal Date: 2020-01-02T12:14:43-05:00 New Revision: 89d6c288ba5adb20d92142e9425f7ab79b8f159e URL: https://github.com/llvm/llvm-project/commit/89d6c288ba5adb20d92142e9425f7ab79b8f159e DIFF: https://github.com/llvm/llvm-project/commit/89d6c288ba5adb20d92142e9425f7ab79b8f159e.diff

[PATCH] D71854: [SystemZ] Use FNeg in s390x clang builtins

kpn closed this revision. kpn added a comment. My pleasure! Closed with commit 89d6c288ba5adb20d92142e9425f7ab79b8f159e . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71854/new/ https://reviews.llvm.org/D71854 __

[PATCH] D72018: [attributes] [analyzer] Add an attribute to prevent checkers from modeling a function

xazax.hun added a comment. In D72018#1800018 , @aaron.ballman wrote: > This seems like a very specialized attribute for the static analyzer and I'm > not certain how much utility it adds, but that may be because I don't > understand the analyzer require

[PATCH] D71969: [OpenMP] diagnose zero-length array section in the depend clause

kkwli0 updated this revision to Diff 235894. kkwli0 added a comment. Update based on suggestion to simply the check and rebase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71969/new/ https://reviews.llvm.org/D71969 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib

[PATCH] D69878: Consoldiate internal denormal flushing controls

cameron.mcinally added a comment. This is looking pretty good to me, but I'm ignoring some of the target specific code that I'm not familiar with. Is `denormal-fp-math` influenced by `-Ofast`? Or are there plans for that? Seems like `-Ofast` should imply DAZ and FTZ (if supported by target). I

[PATCH] D72087: [clang-tools-extra] NFC: Fix trivial typos in comments

kiszk added a comment. I do not have commit rights to the repository. Could someone commit this change? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72087/new/ https://reviews.llvm.org/D72087 ___ cfe-

[PATCH] D71969: [OpenMP] diagnose zero-length array section in the depend clause

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71969/new/ https://reviews.llvm.org/D71969 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D54395: [clang-tidy] implement utility-function to add 'const' to variables

aaron.ballman added inline comments. Comment at: clang-tools-extra/unittests/clang-tidy/AddConstTest.cpp:66 + StringRef S = "MyInt target = 0;"; + auto Cat = [&T](StringRef S) { return (T + S).str(); }; + JonasToth wrote: > aaron.ballman wrote: > > I don't thin

[PATCH] D72057: [docs] Update dead anchor in hacking page

aaron.ballman added inline comments. Comment at: clang/www/hacking.html:301 - It is also possible to https://llvm.org/docs/GettingStarted.html#sending-patches-with-git";>use git to contribute to Clang. + It is also possible to https://llvm.org/docs/GettingStarted.html#checko

[PATCH] D71463: Implement VectorType conditional operator GNU extension.

erichkeane added a comment. Ping? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71463/new/ https://reviews.llvm.org/D71463 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D71499: Add builtins for aligning and checking alignment of pointers and integers

arichardson updated this revision to Diff 235899. arichardson marked 2 inline comments as done. arichardson added a comment. - Generate inbounds GEP. Also mention that values must point to the same allocation in the documentation. - Clarify that correctly aligned values do not change. Repositor

[PATCH] D71973: [clang-tidy] Add bugprone-suspicious-memory-comparison check

gbencze marked 18 inline comments as done. gbencze added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone-suspicious-memory-comparison.cpp:1 +// RUN: %check_clang_tidy %s bugprone-suspicious-memory-comparison %t + JonasToth wrote:

[PATCH] D71973: [clang-tidy] Add bugprone-suspicious-memory-comparison check

gbencze updated this revision to Diff 235900. gbencze added a comment. Coding guide and better diagnostic message for padding comparison CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71973/new/ https://reviews.llvm.org/D71973 Files: clang-tools-extra/clang-tidy/bugprone/BugproneTidyM

[PATCH] D71499: Add builtins for aligning and checking alignment of pointers and integers

arichardson added a comment. In D71499#1801421 , @lebedev.ri wrote: > (temporarily undoing my review since it looks like things may change) > > In D71499#1801302 , @arichardson > wrote: > > > ... > > > Aha! :) > >

[PATCH] D71499: Add builtins for aligning and checking alignment of pointers and integers

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61176 tests passed, 0 failed and 729 were skipped. {icon times-circle color=red} clang-tidy: fail. Please fix clang-tidy findings

[PATCH] D71499: Add builtins for aligning and checking alignment of pointers and integers

arichardson updated this revision to Diff 235903. arichardson added a comment. - Fix typos caused by dodgy n key on my keyboard. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71499/new/ https://reviews.llvm.org/D71499 Files: clang/docs/LanguageE

[PATCH] D71499: Add builtins for aligning and checking alignment of pointers and integers

lebedev.ri added a comment. Hmm, i keep coming up with things here, sorry :/ I think we should take one more step - explicitly call out that the result of `__builtin_align_*` is, well, aligned :) For that, we need to add `__attribute__((alloc_align(2)))` attribute. Despite the name, it does not

[PATCH] D71499: Add builtins for aligning and checking alignment of pointers and integers

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61176 tests passed, 0 failed and 729 were skipped. {icon times-circle color=red} clang-tidy: fail. Please fix clang-tidy findings

[PATCH] D71973: [clang-tidy] Add bugprone-suspicious-memory-comparison check

JonasToth added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone-suspicious-memory-comparison.cpp:1 +// RUN: %check_clang_tidy %s bugprone-suspicious-memory-comparison %t + gbencze wrote: > JonasToth wrote: > > We should explicitl

[clang-tools-extra] ec3d8e6 - Handle init statements in readability-else-after-return

Author: Nathan James Date: 2020-01-02T13:39:27-05:00 New Revision: ec3d8e61b527c6312f77a4dab095ffc34e954927 URL: https://github.com/llvm/llvm-project/commit/ec3d8e61b527c6312f77a4dab095ffc34e954927 DIFF: https://github.com/llvm/llvm-project/commit/ec3d8e61b527c6312f77a4dab095ffc34e954927.diff

[clang-tools-extra] 7ab9acd - Fix trivial typos in comments; NFC

Author: Kazuaki Ishizaki Date: 2020-01-02T13:41:43-05:00 New Revision: 7ab9acd8f414161b784b61a1633a7c241b82be85 URL: https://github.com/llvm/llvm-project/commit/7ab9acd8f414161b784b61a1633a7c241b82be85 DIFF: https://github.com/llvm/llvm-project/commit/7ab9acd8f414161b784b61a1633a7c241b82be85.di

[PATCH] D72087: [clang-tools-extra] NFC: Fix trivial typos in comments

aaron.ballman closed this revision. aaron.ballman added a comment. Thank you for the patch! I've commit on your behalf in 7ab9acd8f414161b784b61a1633a7c241b82be85 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D71846: [ASTMatchers] Fix for https://bugs.llvm.org/show_bug.cgi?id=44364

aaron.ballman closed this revision. aaron.ballman added a comment. Thank you for the patch, I've committed on your behalf in ec3d8e61b527c6312f77a4dab095ffc34e954927 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7184

[PATCH] D71991: Fix external-names.c test when separator is \\

amccarth added a comment. It would surprise me if the different test config is cause here. The path is assembled entirely in the code, so it should be consistent. If you had a systemic problem introduced by test config, I'd expect more of the VFS tests to fail. Anyway, if you're back in busi

[clang] abb0075 - build: reduce CMake handling for zlib

Author: Saleem Abdulrasool Date: 2020-01-02T11:19:12-08:00 New Revision: abb00753069554c538f3d850897373d093389945 URL: https://github.com/llvm/llvm-project/commit/abb00753069554c538f3d850897373d093389945 DIFF: https://github.com/llvm/llvm-project/commit/abb00753069554c538f3d850897373d093389945.

[PATCH] D71857: [NFC] Fixes -Wrange-loop-analysis warnings

Mordante added a comment. In D71857#1800663 , @MaskRay wrote: > However, I am afraid I don't like some of the fixes here. You can replace > `const auto` with `const auto &` and call that a fix... IMHO if the type is > not obvious, `const ConcreteType &`

[PATCH] D72018: [attributes] [analyzer] Add an attribute to prevent checkers from modeling a function

aaron.ballman added a comment. In D72018#1801450 , @xazax.hun wrote: > In D72018#1800018 , @aaron.ballman > wrote: > > > This seems like a very specialized attribute for the static analyzer and > > I'm not certain

[PATCH] D71554: [llvm-ranlib] Handle -D and -U command line flag

rupprecht added a comment. In D71554#1789360 , @arichardson wrote: > Also handle -h/-v as short options. Does the adjusted test look okay? Sorry, didn't have time to take a second look before the holiday break -- yep, looks good, I didn't anticipate so

[PATCH] D72018: [attributes] [analyzer] Add an attribute to prevent checkers from modeling a function

xazax.hun added a comment. In D72018#1801725 , @aaron.ballman wrote: > Thank you for the explanation, that makes sense, but I'm still a bit > uncomfortable. In this case, it seems like the author of the API needs to 1) > know that users will be analyzin

[PATCH] D71973: [clang-tidy] Add bugprone-suspicious-memory-comparison check

gbencze updated this revision to Diff 235915. gbencze added a comment. Tests: Split C/C++ tests and add 32/64bit specific test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71973/new/ https://reviews.llvm.org/D71973 Files: clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.cpp

[PATCH] D72097: [LifetimeAnalysis] Do not forbid void deref type in gsl::Pointer/gsl::Owner annotations

xazax.hun created this revision. xazax.hun added reviewers: aaron.ballman, gribozavr2, mgehre. xazax.hun added a project: clang. Herald added subscribers: Szelethus, Charusso, gamesh411, dkrupp, rnkovacs. It turns out it is useful to be able to define the deref type as void. In case we have a typ

[PATCH] D71227: [cuda][hip] Fix function overload resolution in the global initiailizer.

hliao marked 6 inline comments as done. hliao added a comment. refinements are made after comments from reviewers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71227/new/ https://reviews.llvm.org/D71227 _

[PATCH] D71227: [cuda][hip] Fix function overload resolution in the global initiailizer.

hliao updated this revision to Diff 235921. hliao added a comment. code refinement after reviewers' comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71227/new/ https://reviews.llvm.org/D71227 Files: clang/include/clang/Sema/Sema.h clang

  1   2   >