[PATCH] D70157: Align branches within 32-Byte boundary(NOP padding)

MaskRay added inline comments. Comment at: llvm/lib/MC/MCAssembler.cpp:1003 + // exists) also marks the end of the branch. + for (auto i = 0U, N = BF.isFused() ? 2U : 1U; + i != N && !isa(F); ++i, F = F->getNextNode()) { skan wrote: > MaskRay wrote: > > u

[clang] e8efac4 - [clang] Fix the canonicalization of paths in -fdiagnostics-absolute-paths

Author: Karl-Johan Karlsson Date: 2019-12-20T09:16:33+01:00 New Revision: e8efac4b15303932581c128dc3976f4359388338 URL: https://github.com/llvm/llvm-project/commit/e8efac4b15303932581c128dc3976f4359388338 DIFF: https://github.com/llvm/llvm-project/commit/e8efac4b15303932581c128dc3976f4359388338

[PATCH] D70527: [clang] Fix the canonicalization of paths in -fdiagnostics-absolute-paths

This revision was automatically updated to reflect the committed changes. Ka-Ka marked 2 inline comments as done. Closed by commit rGe8efac4b1530: [clang] Fix the canonicalization of paths in -fdiagnostics-absolute-paths (authored by Ka-Ka). Changed prior to commit: https://reviews.llvm.org/D70

[PATCH] D70157: Align branches within 32-Byte boundary(NOP padding)

skan added a comment. Do you think this patch is ready to land? @MaskRay CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70157/new/ https://reviews.llvm.org/D70157 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D70157: Align branches within 32-Byte boundary(NOP padding)

MaskRay added a comment. In D70157#1792262 , @skan wrote: > Do you think this patch is ready to land? @MaskRay It is 00:35 here and I should confess that I haven't read through this yet. There are some minor things like (1) pervasive `auto` (2) `report_

[PATCH] D70258: [OpenMP][IR-Builder] Introduce the finalization stack

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70258/new/ https://reviews.llvm.org/D70258 ___

[PATCH] D71745: clang-tidy doc: Move from a long list of checkers to tables

sylvestre.ledru abandoned this revision. sylvestre.ledru added a comment. Done here: https://reviews.llvm.org/D36051 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71745/new/ https://reviews.llvm.org/D71745 ___

[PATCH] D71745: clang-tidy doc: Move from a long list of checkers to tables

sylvestre.ledru created this revision. Herald added subscribers: cfe-commits, whisperity. Herald added a reviewer: jdoerfert. Herald added a project: clang. sylvestre.ledru abandoned this revision. sylvestre.ledru added a comment. Done here: https://reviews.llvm.org/D36051 Currently, the list is

[PATCH] D71727: [clang][Tooling] Prefer -x over -std when interpolating

kbobyrev accepted this revision. kbobyrev added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71727/new/ https://reviews.llvm.org/D71727 ___

[PATCH] D36051: [clang-tidy] List the checkers with autofix

sylvestre.ledru updated this revision to Diff 234841. sylvestre.ledru edited the summary of this revision. sylvestre.ledru added a comment. Herald added a reviewer: jdoerfert. Herald added a project: clang. Move to the table idea... Two years after :) Repository: rG LLVM Github Monorepo CHANG

[PATCH] D71694: [objc_direct] Tigthen checks for direct methods

teemperor added inline comments. Comment at: clang/test/CodeGenObjC/direct-method.m:196 +@implementation Foo (Cat) +// CHECK-LABEL: define hidden i32 @"\01-[Foo(Cat) directMethodInCategory]"( +- (int)directMethodInCategory { MadCoder wrote: > aprantl wrote: > > M

[PATCH] D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls

lewis-revill updated this revision to Diff 234842. lewis-revill added a comment. Fixed existing .cfi_offset offsets. Since these are frame-pointer based they also need to account for the libcall stack adjustment. Currently working on adding .cfi_offset instructions for the registers saved by th

[clang] c2377ea - [clang][Tooling] Prefer -x over -std when interpolating

Author: Kadir Cetinkaya Date: 2019-12-20T11:10:36+01:00 New Revision: c2377eae286bbe616267bef772ee736b030dd007 URL: https://github.com/llvm/llvm-project/commit/c2377eae286bbe616267bef772ee736b030dd007 DIFF: https://github.com/llvm/llvm-project/commit/c2377eae286bbe616267bef772ee736b030dd007.dif

[PATCH] D71727: [clang][Tooling] Prefer -x over -std when interpolating

This revision was automatically updated to reflect the committed changes. Closed by commit rGc2377eae286b: [clang][Tooling] Prefer -x over -std when interpolating (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71727/new/ https

[PATCH] D71734: [Modules] Handle tag types and complain about bad merges in C/Objective-C mode

martong added inline comments. Comment at: clang/lib/Serialization/ASTReader.cpp:9286 + false /*UseCanonicalDecls*/); + (void)Ctx.IsEquivalent(D, Canon); +} Would it be possible to check the structural non-equivalency with `ODRHash`? I wonder if

[PATCH] D70157: Align branches within 32-Byte boundary(NOP padding)

skan updated this revision to Diff 234846. skan added a comment. 1. Add more tests for `!VK_NONE` cases. 2. Reduce pervasive `auto` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70157/new/ https://reviews.llvm.org/D70157 Files: llvm/include/llvm/MC/MCAsmBackend.h llvm/include/llvm/

[PATCH] D71746: Fix the "TypeError: a bytes-like object is required, not 'str'" in exploded-graph-rewriter.py on Python 3.5+

psamolysov created this revision. psamolysov added reviewers: dergachev.a, clang. psamolysov added a project: clang. Herald added a subscriber: cfe-commits. When I run the 'exploded-graph-rewriter.py' tool on Windows using Python 3.5 and above, the following error and stack trace occurs: Trace

[PATCH] D69876: Allow output constraints on "asm goto"

void updated this revision to Diff 234852. void marked 5 inline comments as done. void added a comment. - Improve the asm goto note in the language extensions doc. - Include another testcase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69876/new/

[PATCH] D69876: Allow output constraints on "asm goto"

void added inline comments. Comment at: clang/docs/LanguageExtensions.rst:1275 +It's important to note that outputs are valid only on the "fallthrough" branch. +For example, the value assigned to `y` is not valid in the above `err` block. + nickdesaulniers wrote:

[PATCH] D64573: [Syntax] Allow to mutate syntax trees

Ka-Ka added inline comments. Comment at: clang/lib/Tooling/Syntax/Mutations.cpp:74 + + if (auto *Parent = llvm::dyn_cast(S->parent())) { +// A child of CompoundStatement can just be safely removed. This line introduce a buildbot fail: /home/buildbots/ppc64b

[PATCH] D36051: [clang-tidy] List the checkers with autofix

sylvestre.ledru added a comment. F0342: Screenshot_2019-12-20 clang-tidy - Clang-Tidy Checks — Extra Clang Tools 10 documentation.png here is the result Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D36051/n

[PATCH] D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls

lewis-revill updated this revision to Diff 234853. lewis-revill added a comment. Added .cfi_offset directives for registers saved by libcalls. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62686/new/ https://reviews.llvm.org/D62686 Files: clang/

[PATCH] D71553: [RISCV] Add Clang frontend support for Bitmanip extension

lenary accepted this revision. lenary added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71553/new/ https://reviews.llvm.org/D71553 __

[PATCH] D67661: [RISCV] Headers: Add Bitmanip extension Clang header files and rvintrin.h

lenary added a comment. Selfishly, I would like to see the addition of `rvintrin.h` separated from the bit-manipulation-specific headers. I'm looking at landing some additions to clang/LLVM that include builtins, and don't want to cause merge issues with this PR. I haven't yet had time to full

[PATCH] D71612: [analyzer] Add PlacementNewChecker

martong marked 22 inline comments as done. martong added a comment. Thank you guys for the assiduous review! Comment at: clang/lib/StaticAnalyzer/Checkers/CheckPlacementNew.cpp:22 +ProgramStateRef State) const; + mutable std::unique_ptr BT_Placement

[PATCH] D71612: [analyzer] Add PlacementNewChecker

martong updated this revision to Diff 234857. martong marked 8 inline comments as done. martong added a comment. - Bugtype by value - Decompose Place to base region and offset - Add test for type hierarchy - Remove State check - Return directly with the size of the type in case of non-array new -

[PATCH] D71727: [clang][Tooling] Prefer -x over -std when interpolating

sammccall added a comment. Thanks for taking care of this! Comment at: clang/lib/Tooling/InterpolatingCompilationDatabase.cpp:194 -if (Std != LangStandard::lang_unspecified) // -std take precedence over -x +// Make use of -std iff -x was missing. +if (Type == type

[PATCH] D70265: [clang-tidy] Add clang tidy check I.2 to cppcoreguidelines

vingeldal updated this revision to Diff 234863. vingeldal marked 5 inline comments as done. vingeldal added a comment. Updating D70265 : [clang-tidy] Add clang tidy check I.2 to cppcoreguidelines Adressed all comments: - Extended teseting - Updated documentation

[PATCH] D70265: [clang-tidy] Add clang tidy check I.2 to cppcoreguidelines

vingeldal added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/AvoidNonConstGlobalVariablesCheck.cpp:20 +namespace { +AST_MATCHER(VarDecl, isLocalVarDecl) { return Node.isLocalVarDecl(); } +} // namespace JonasToth wrote: > This matc

[PATCH] D71612: [analyzer] Add PlacementNewChecker

martong marked an inline comment as done. martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/CheckPlacementNew.cpp:32 + const MemRegion *BaseRegion = MRegion->getBaseRegion(); + assert(BaseRegion == Offset.getRegion()); + This assertio

[PATCH] D36051: [clang-tidy] List the checkers with autofix

whisperity added a comment. In D36051#1792432 , @sylvestre.ledru wrote: > F0342: Screenshot_2019-12-20 clang-tidy - Clang-Tidy Checks — Extra Clang > Tools 10 documentation.png > here is the result Thank you t

[clang] 9caf12e - Use isa instead of dyn_cast

Author: Dmitri Gribenko Date: 2019-12-20T14:36:21+01:00 New Revision: 9caf12e8495c1106dd3d1079892ce4f39f91b7d2 URL: https://github.com/llvm/llvm-project/commit/9caf12e8495c1106dd3d1079892ce4f39f91b7d2 DIFF: https://github.com/llvm/llvm-project/commit/9caf12e8495c1106dd3d1079892ce4f39f91b7d2.dif

[clang] 73f423e - Parenthesized a logical expression.

Author: Dmitri Gribenko Date: 2019-12-20T14:36:21+01:00 New Revision: 73f423e739bcb9bee7b73f05d4bcd50782013a8c URL: https://github.com/llvm/llvm-project/commit/73f423e739bcb9bee7b73f05d4bcd50782013a8c DIFF: https://github.com/llvm/llvm-project/commit/73f423e739bcb9bee7b73f05d4bcd50782013a8c.dif

[PATCH] D64573: [Syntax] Allow to mutate syntax trees

gribozavr2 added a comment. @Ka-Ka Thanks for bringing it to our attention! I fixed these warnings in: https://github.com/llvm/llvm-project/commit/9caf12e8495c1106dd3d1079892ce4f39f91b7d2 https://github.com/llvm/llvm-project/commit/73f423e739bcb9bee7b73f05d4bcd50782013a8c Repository: rG LLVM

[PATCH] D71221: [HIP] Add option --gpu-max-threads-per-block=n

yaxunl marked 2 inline comments as done. yaxunl added a comment. In D71221#1791802 , @tra wrote: > What's the use case for this flag? If a kernel is launched with a block size greater than the default max block size, explicit launch bound is required.

[PATCH] D71758: [Lexer] Allow UCN for dollar symbol '\u0024' in identifiers when using -fdollars-in-identifiers flag.

s.egerton created this revision. Herald added subscribers: cfe-commits, simoncook. Herald added a project: clang. s.egerton added reviewers: rsmith, akyrtzi, jordan_rose. Herald added a subscriber: dexonsmith. Previously, the -fdollars-in-identifiers flag allows the '$' symbol to be used in an ide

[PATCH] D36051: [clang-tidy] List the checkers with autofix

Eugene.Zelenko added a comment. May be also split table by checks groups? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D36051/new/ https://reviews.llvm.org/D36051 ___ cfe-commits mailing list cfe-commi

[PATCH] D36051: [clang-tidy] List the checkers with autofix

sylvestre.ledru added a comment. In D36051#1792684 , @Eugene.Zelenko wrote: > May be also split table by checks groups? Maybe? I would like to see this patch land first and iterate then on it. :) This patch is already a significant improvement over the

[PATCH] D36051: [clang-tidy] List the checkers with autofix

sylvestre.ledru updated this revision to Diff 234890. sylvestre.ledru added a comment. Remove artifacts Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D36051/new/ https://reviews.llvm.org/D36051 Files: clang-tools-extra/docs/clang-tidy/checks/list

[PATCH] D36051: [clang-tidy] List the checkers with autofix

sylvestre.ledru added a comment. > But please, let's make that table heading nice. `Severity` is capitalised, > `name` is not, "has an autofix" sounds weird... Maybe "offers fixes" instead? Good point, thanks :) Done! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D71708: [OPENMP50]Codegen for nontemporal clause.

ABataev marked 3 inline comments as done. ABataev added inline comments. Comment at: clang/lib/AST/StmtProfile.cpp:777 +if (E) + Profiler->VisitStmt(E); + } rjmccall wrote: > Can `E` actually be null here? No, remnants of the initial version.

[PATCH] D71769: [clang-format] C# formatting a class with inheritance followed by an attribute specifier assume its a braces initializer

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: mitchell-stellar, klimek, sammccall. MyDeveloperDay added a project: clang-format. Herald added a project: clang. MyDeveloperDay edited the summary of this revision. https://bugs.llvm.org/show_bug.cgi?id=44340 The rule that pre

[PATCH] D71726: Let clang atomic builtins fetch add/sub support floating point types

yaxunl added a comment. In D71726#1791904 , @jfb wrote: > This generally seems fine. Does it work on most backends? I want to make sure > it doesn't fail in backends :) For x86_64, amdgcn, aarch64, armv7, mips64, it is translated to cmpxchg by AtomicEx

[PATCH] D69272: Restricted variant of '#pragma STDC FENV_ACCESS'

mibintc added a comment. In D69272#1717021 , @kpn wrote: > Is there a way forward to support having the #pragma at the start of any > block inside a function? The effect won't be restricted to that block, true, > but the standard does say the #pragma is

[PATCH] D71612: [analyzer] Add PlacementNewChecker

martong updated this revision to Diff 234901. martong added a comment. - Better handling of unknown values Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71612/new/ https://reviews.llvm.org/D71612 Files: clang/include/clang/StaticAnalyzer/Checker

[PATCH] D71769: [clang-format] C# formatting a class with inheritance followed by an attribute specifier assume its a braces initializer

mitchell-stellar accepted this revision. mitchell-stellar added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71769/new/ https://reviews.llvm.org/D71769 __

[PATCH] D71708: [OPENMP50]Codegen for nontemporal clause.

ABataev updated this revision to Diff 234902. ABataev added a comment. Fix + rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71708/new/ https://reviews.llvm.org/D71708 Files: clang/include/clang/AST/OpenMPClause.h clang/include/clang/AST

[PATCH] D71708: [OPENMP50]Codegen for nontemporal clause.

ABataev marked an inline comment as done. ABataev added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:3952 + CGM.getOpenMPRuntime().isNontemporalDecl(Field)) || + (!E->isArrow() && BaseLV.isNontemporal())) +LV.setNontemporal(/*Value=*/true);

[PATCH] D69272: Restricted variant of '#pragma STDC FENV_ACCESS'

kpn added a comment. In D69272#1792856 , @mibintc wrote: > In D69272#1717021 , @kpn wrote: > > > Is there a way forward to support having the #pragma at the start of any > > block inside a function? The effect won'

[clang] ff92c56 - [OPENMP]Remove unused OPENMP_MATCH_KIND, NFC.

Author: Alexey Bataev Date: 2019-12-20T11:17:55-05:00 New Revision: ff92c56ef97c62e6350531fd45ec1ad36ed25a3c URL: https://github.com/llvm/llvm-project/commit/ff92c56ef97c62e6350531fd45ec1ad36ed25a3c DIFF: https://github.com/llvm/llvm-project/commit/ff92c56ef97c62e6350531fd45ec1ad36ed25a3c.diff

[PATCH] D71708: [OPENMP50]Codegen for nontemporal clause.

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61052 tests passed, 0 failed and 728 were skipped. {icon times-circle color=red} clang-tidy: fail. Please fix clang-tidy findings

[PATCH] D36051: [clang-tidy] List the checkers with autofix

whisperity added a comment. I am a little bit conflicted about the //Severity// column. While I know our people put a great deal of effort into keeping this classification sane, what was put into CodeChecker is, at the end of the day, a pretty arbitrary classification. I think RSTs support com

[PATCH] D71612: [analyzer] Add PlacementNewChecker

xazax.hun added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td:472 +def PlacementNewChecker : Checker<"PlacementNew">, + HelpText<"Check if default placement new is provided with pointers to " + "sufficient storage capacity">,

[PATCH] D69272: Restricted variant of '#pragma STDC FENV_ACCESS'

sepavloff added a comment. In D69272#1792877 , @kpn wrote: > My understanding of this patch is that it only allows the #pragma at the top > of each function. It doesn't allow it in blocks inside the function. So if a > function has a block inside it that

[PATCH] D36051: [clang-tidy] List the checkers with autofix

sylvestre.ledru updated this revision to Diff 234911. sylvestre.ledru added a comment. Add a comment about codechecker Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D36051/new/ https://reviews.llvm.org/D36051 Files: clang-tools-extra/docs/clang-t

[PATCH] D71513: [compiler-rt] [test] Disable MPROTECT on two builtin tests

This revision was automatically updated to reflect the committed changes. Closed by commit rG190b9110c23c: [compiler-rt] [test] Disable MPROTECT on two builtin tests (authored by mgorny). Herald added a project: Sanitizers. Herald added a subscriber: Sanitizers. Repository: rG LLVM Github Monor

[clang] 2f209cc - [clang-format] C# formatting a class with inheritance followed by an attribute specifier assume its a braces initializer

Author: mydeveloperday Date: 2019-12-20T17:07:00Z New Revision: 2f209ccfbe5e6b33088763b1e022ba876fb0f35c URL: https://github.com/llvm/llvm-project/commit/2f209ccfbe5e6b33088763b1e022ba876fb0f35c DIFF: https://github.com/llvm/llvm-project/commit/2f209ccfbe5e6b33088763b1e022ba876fb0f35c.diff LOG

[PATCH] D70073: [ConstExprPreter] Implemented function calls and if statements

nand added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70073/new/ https://reviews.llvm.org/D70073 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[PATCH] D36051: [clang-tidy] List the checkers with autofix

sylvestre.ledru added a comment. In D36051#1792909 , @whisperity wrote: > I am a little bit conflicted about the //Severity// column. While I know our > people put a great deal of effort into keeping this classification sane, what > was put into CodeChec

[PATCH] D71769: [clang-format] C# formatting a class with inheritance followed by an attribute specifier assume its a braces initializer

This revision was automatically updated to reflect the committed changes. Closed by commit rG2f209ccfbe5e: [clang-format] C# formatting a class with inheritance followed by an attribute… (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D71698: [AArch64][SVE] Add intrinsic for non-faulting loads

kmclaughlin added inline comments. Comment at: llvm/lib/Target/AArch64/SVEInstrFormats.td:5333 + // We need a layer of indirection because early machine code passes balk at + // physical register (i.e. FFR) uses that have no previous definition. + let hasSideEffects = 1, hasNo

[PATCH] D71775: [ThreadPool] On Windows, extend usage to all CPU sockets and all NUMA groups

aganea created this revision. aganea added reviewers: mehdi_amini, rnk, tejohnson, russell.gallop, dexonsmith. Herald added subscribers: llvm-commits, cfe-commits, usaxena95, dang, jfb, kadircet, arphaman, steven_wu, jkorous, MaskRay, javed.absar, hiraditya, kristof.beyls, arichardson, emaste. He

[PATCH] D36051: [clang-tidy] List the checkers with autofix

sylvestre.ledru updated this revision to Diff 234918. sylvestre.ledru added a comment. Fix a rst warning + update the clang link "Clang Static Analyzer" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D36051/new/ https://reviews.llvm.org/D36051 Files

[PATCH] D71775: [ThreadPool] On Windows, extend usage to all CPU sockets and all NUMA groups

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61057 tests passed, 0 failed and 728 were skipped. {icon times-circle color=red} clang-tidy: fail. Please fix clang-tidy findings

[PATCH] D36051: [clang-tidy] List the checkers with autofix

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/list.rst:291 + +.. csv-table:: Alias.. + :header: "Name", "Redirect", "Offers fixes", "Severity" Aliases? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D71499: Add builtins for aligning and checking alignment of pointers and integers

arichardson updated this revision to Diff 234921. arichardson added a comment. - Add documentation for the new alignment builtins Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71499/new/ https://reviews.llvm.org/D71499 Files: clang/docs/Language

[PATCH] D71221: [HIP] Add option --gpu-max-threads-per-block=n

tra added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:8067 +unsigned MaxThreadsPerBlock = +IsHIPKernel ? M.getLangOpts().GPUMaxThreadsPerBlock : 256; +std::string AttrVal = std::string("1,") + llvm::utostr(MaxThreadsPerBlock); ya

[PATCH] D70973: [OPENMP50]Treat context selectors as expressions, not just strings.

jdoerfert added a comment. I haven't forgotten about this! With the other two changes to the declare variant going to happen now,as well, I figured we should look at this again from a high-level. My plan now is: 1. Move all of the declare variant context stuff out of clang into the libFronten

[PATCH] D71499: Add builtins for aligning and checking alignment of pointers and integers

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61055 tests passed, 0 failed and 728 were skipped. {icon times-circle color=red} clang-tidy: fail. Please fix clang-tidy findings

[PATCH] D70469: [attributes] [analyzer] Add handle related attributes

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:3475 + +def AcquireHandle : DeclOrTypeAttr { + let Spellings = [Clang<"acquire_handle">]; I have no idea whether this is a problem or not (and I'm not certain if you know either)

[PATCH] D69876: Allow output constraints on "asm goto"

nickdesaulniers added inline comments. Comment at: clang/test/CodeGen/asm-goto.c:91 + return 1; +} Thanks for adding this test. I think it doesn't test that `addr` is *clobbered* though? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[clang] 42f9d0c - [objc_direct] Tigthen checks for direct methods

Author: Pierre Habouzit Date: 2019-12-20T10:57:36-08:00 New Revision: 42f9d0c0bee32a1a48a45c039988d27115f30da9 URL: https://github.com/llvm/llvm-project/commit/42f9d0c0bee32a1a48a45c039988d27115f30da9 DIFF: https://github.com/llvm/llvm-project/commit/42f9d0c0bee32a1a48a45c039988d27115f30da9.dif

[PATCH] D71708: [OPENMP50]Codegen for nontemporal clause.

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:3952 + CGM.getOpenMPRuntime().isNontemporalDecl(Field)) || + (!E->isArrow() && BaseLV.isNontemporal())) +LV.setNontemporal(/*Value=*/true); ABataev wrote: > ABatae

[PATCH] D71694: [objc_direct] Tigthen checks for direct methods

This revision was automatically updated to reflect the committed changes. Closed by commit rG42f9d0c0bee3: [objc_direct] Tigthen checks for direct methods (authored by MadCoder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71694/new/ https://revie

[PATCH] D71778: [RISCV] Add Clang Builtins for Accessing CSRs

lenary created this revision. lenary added reviewers: asb, luismarques. Herald added subscribers: llvm-commits, cfe-commits, apazos, sameer.abuasal, pzheng, s.egerton, benna, psnobl, jocewei, PkmX, rkruppe, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, MaskRay, jrtc27, shiva02

[PATCH] D71612: [analyzer] Add PlacementNewChecker

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/CheckPlacementNew.cpp:32 + const MemRegion *BaseRegion = MRegion->getBaseRegion(); + assert(BaseRegion == Offset.getRegion()); + martong wrote: > This assertion fails on real code quite of

[PATCH] D71666: [clang-tidy] Fix readability-const-return-type identifying the wrong `const` token

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM with a commenting request. Comment at: clang-tools-extra/clang-tidy/utils/LexerUtils.h:95-97 +/// Assuming that ``Range`` spans a CVR-qualified type, retur

[PATCH] D70469: [attributes] [analyzer] Add handle related attributes

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM with the nits fixed, thank you! Comment at: clang/include/clang/Basic/Attr.td:3475 + +def AcquireHandle : DeclOrTypeAttr { + let Spellings = [Clang<"acqui

[PATCH] D71746: Fix the "TypeError: a bytes-like object is required, not 'str'" in exploded-graph-rewriter.py on Python 3.5+

NoQ accepted this revision. NoQ edited reviewers, added: NoQ; removed: dergachev.a. NoQ added a comment. Yay, thanks! It does seem to work on python2 after the fix. Do you have commit access or should i commit it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[clang] 03512b2 - [NFC][Driver] Add dummy compiler-rt sanitizer dylibs for Darwin.

Author: Dan Liew Date: 2019-12-20T11:32:21-08:00 New Revision: 03512b267d9abd054d56c6d5fa118e78184cf015 URL: https://github.com/llvm/llvm-project/commit/03512b267d9abd054d56c6d5fa118e78184cf015 DIFF: https://github.com/llvm/llvm-project/commit/03512b267d9abd054d56c6d5fa118e78184cf015.diff LOG:

[PATCH] D71680: Customize simplified dumping and matching of LambdaExpr

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from some nits. Comment at: clang/include/clang/AST/ASTNodeTraverser.h:134 + + if (isa(S) && Traversal == ast_type_traits::TK_IgnoreUnlessSpell

[PATCH] D65591: [AST] Add a flag indicating if any subexpression had errors

aaron.ballman added a comment. In D65591#1791876 , @rsmith wrote: > Summary of an off-line discussion with Ilya: I think that summary sounds very sensible. Thank you both for working on this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D70157: Align branches within 32-Byte boundary(NOP padding)

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG14fc20ca6282: Align branches within 32-Byte boundary (NOP padding) (authored by reames). Repository: rG LLVM Github Mon

[clang] 304d130 - Apply the alignment specifier attribute to anonymous unions and structs.

Author: Kamlesh Kumar Date: 2019-12-20T14:42:37-05:00 New Revision: 304d1304b7bac190b6c9733eb07be284bfc17030 URL: https://github.com/llvm/llvm-project/commit/304d1304b7bac190b6c9733eb07be284bfc17030 DIFF: https://github.com/llvm/llvm-project/commit/304d1304b7bac190b6c9733eb07be284bfc17030.diff

[PATCH] D71619: [CLANG] Alignment specifier not applied to anonymous structure or union

aaron.ballman closed this revision. aaron.ballman added a comment. In D71619#1791961 , @kamleshbhalui wrote: > removed c++11 from the test. > I do not have commit access, Can someone commit this for me? Thank you for the patch! I've commit on your beha

[clang] fe17b30 - [attributes][analyzer] Add annotations for handles.

Author: Gabor Horvath Date: 2019-12-20T11:47:55-08:00 New Revision: fe17b30a79572f0d50fe78f6a07d5194cbf90860 URL: https://github.com/llvm/llvm-project/commit/fe17b30a79572f0d50fe78f6a07d5194cbf90860 DIFF: https://github.com/llvm/llvm-project/commit/fe17b30a79572f0d50fe78f6a07d5194cbf90860.diff

[PATCH] D70469: [attributes] [analyzer] Add handle related attributes

This revision was automatically updated to reflect the committed changes. Closed by commit rGfe17b30a7957: [attributes][analyzer] Add annotations for handles. (authored by xazax.hun). Changed prior to commit: https://reviews.llvm.org/D70469?vs=234341&id=234940#toc Repository: rG LLVM Github

[PATCH] D70469: [attributes] [analyzer] Add handle related attributes

xazax.hun marked an inline comment as done. xazax.hun added a comment. Thanks for the review! :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70469/new/ https://reviews.llvm.org/D70469 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D71709: Give frontend dump flags consistent names (*-dump instead of dump-*)

herzka added a comment. I worry that repeating all those names in those tests might be noisy. I think I'll switch those to use the new name, but add another test that makes sure both names still work. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D71708: [OPENMP50]Codegen for nontemporal clause.

ABataev marked an inline comment as done. ABataev added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:3952 + CGM.getOpenMPRuntime().isNontemporalDecl(Field)) || + (!E->isArrow() && BaseLV.isNontemporal())) +LV.setNontemporal(/*Value=*/true);

[PATCH] D70470: [analyzer] Add FuchsiaHandleCheck to catch handle leaks, use after frees and double frees

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. LGTM! Yeah, please update the ASCII-art, it's great and every checker should have it. Comment at: clang/docs/analyzer/checkers.rst:1341 + +Fuchsia Checkers. + May

[PATCH] D69272: Restricted variant of '#pragma STDC FENV_ACCESS'

rjmccall added a comment. In D69272#1792928 , @sepavloff wrote: > In D69272#1792877 , @kpn wrote: > > > My understanding of this patch is that it only allows the #pragma at the > > top of each function. It doesn't

[PATCH] D70700: [WebAssembly] Mangle the argc/argv `main` as `__wasm_argc_argv`

sunfish updated this revision to Diff 234942. sunfish added a comment. To support a transition to the new system, temporarily define a `__main_void` alias for no-argument `main`. This allows libc to detect whether it's calling old-style or new-style main and do the right thing. Repository: r

[PATCH] D71708: [OPENMP50]Codegen for nontemporal clause.

ABataev updated this revision to Diff 234943. ABataev added a comment. Fix + rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71708/new/ https://reviews.llvm.org/D71708 Files: clang/include/clang/AST/OpenMPClause.h clang/include/clang/AST

[PATCH] D71708: [OPENMP50]Codegen for nontemporal clause.

merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon question-circle color=gray} clang-tidy: unknown. {icon question-circle color=gray} clang-format: unknown. Build artifacts : conso

[clang] d567b0b - Avoid unsupported LLD options

Author: Sid Manning Date: 2019-12-20T14:18:10-06:00 New Revision: d567b0ba841d4b6f4b0d906da350a3bb2b2f769f URL: https://github.com/llvm/llvm-project/commit/d567b0ba841d4b6f4b0d906da350a3bb2b2f769f DIFF: https://github.com/llvm/llvm-project/commit/d567b0ba841d4b6f4b0d906da350a3bb2b2f769f.diff L

[PATCH] D71708: [OPENMP50]Codegen for nontemporal clause.

rjmccall added a comment. Thanks. Could you add some tests that `nontemporal` directives aren't disturbed by either (1) nested `nontemporal` directives or (2) nested directives of some other kind? Comment at: clang/lib/CodeGen/CGExpr.cpp:3952 + CGM.getOpenMPRuntime

[PATCH] D71708: [OPENMP50]Codegen for nontemporal clause.

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:3952 + CGM.getOpenMPRuntime().isNontemporalDecl(Field)) || + (!E->isArrow() && BaseLV.isNontemporal())) +LV.setNontemporal(/*Value=*/true); rjmccall wrote: > ABata

[PATCH] D70919: [Hexagon] Avoid passing unsupported options to lld when -fuse-ld=lld is used

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGd567b0ba841d: Avoid unsupported LLD options (authored by sidneym). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D70700: [WebAssembly] Mangle the argc/argv `main` as `__wasm_argc_argv`

sbc100 added a comment. __wasm_argc_argv -> __main_argc_argv in the title? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70700/new/ https://reviews.llvm.org/D70700 ___ cfe-commits mailing list cfe-comm

  1   2   >