[PATCH] D71248: [clangd] Introduce paragraph, the first part of new rendering structs

sammccall added a comment. Design question around newlines :-) Otherwise looks good. Comment at: clang-tools-extra/clangd/FormattedString.cpp:95 +// Concatanates whitespace blocks into a single ` `. +std::string canonicalizeSpaces(std::string Input) { + // Goes over the string

[PATCH] D71397: [clang] Improve LLVM-style RTTI support in ExternalASTSource/ExternalSemaSource

teemperor created this revision. teemperor added reviewers: aprantl, dblaikie, rjmccall. Herald added a project: clang. Herald added a subscriber: cfe-commits. We currently have some very basic LLVM-style RTTI support in the ExternalASTSource class hierarchy based on the `SemaSource` bool( to dis

[PATCH] D71345: [clangd] Fall back to selecting token-before-cursor if token-after-cursor fails.

sammccall added a comment. In D71345#1780632 , @nridge wrote: > I tried to do a less general version of this (for go-to-definition only) in > D70727 :) Ah, I hadn't seen that. After thinking about this a bit, I think th

[PATCH] D71197: llvm premerge: clang format test

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 60624 tests passed, 0 failed and 726 were skipped. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by running `git-clang-format HEAD^` or apply this patch

[PATCH] D70799: [OpenMP] Lower taskyield using OpenMP IR Builder

rogfer01 updated this revision to Diff 233524. rogfer01 added a comment. ChangeLog: - Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70799/new/ https://reviews.llvm.org/D70799 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/test/OpenMP/taskyield_codegen.cpp llvm/include

[PATCH] D71374: Improve support of GNU mempcpy

serge-sans-paille added a comment. In D71374#1780402 , @serge-sans-paille wrote: > On going validation: > https://github.com/serge-sans-paille/llvm-project/pull/5/checks Validation succeeded, waiting for review! Repository: rG LLVM Github Monorepo

[PATCH] D71397: [clang] Improve LLVM-style RTTI support in ExternalASTSource/ExternalSemaSource

teemperor added a comment. I didn't add specific ID's to all of the subclasses in clang/clang-tools-extra because we never actually check for these specific classes anywhere from what I can see. But if anyone thinks that would be useful to have then I can update the patch. Repository: rC Cl

[PATCH] D71397: [clang] Improve LLVM-style RTTI support in ExternalASTSource/ExternalSemaSource

teemperor added a comment. See D71398 for the LLDB removal of our own RTTI workaround. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71397/new/ https://reviews.llvm.org/D71397 ___ c

[PATCH] D71197: llvm premerge: clang format test

merge_guards_bot added a comment. {icon check-circle color=green} clang-format: pass. Build artifacts : console-log.txt , CMakeCache.txt <

[PATCH] D71197: llvm premerge: clang format test

goncharov updated this revision to Diff 233530. goncharov added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71197/new/ https://reviews.llvm.org/D71197 Files: clang-tools-extra/clangd/Function.h clang/include/clang/Analysis/

[PATCH] D71374: Improve support of GNU mempcpy

Jim added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:2524 +else + return RValue::get(Builder.CreateGEP(Dest.getPointer(), SizeVal)); } Is it an error here? It should be: ``` if (BuiltinID == Builtin::BImempcpy || BuiltinID == B

[PATCH] D71197: llvm premerge: clang format test

merge_guards_bot added a comment. {icon check-circle color=green} clang-format: pass. Build artifacts : console-log.txt , CMakeCache.txt <

[PATCH] D71247: [clangd] Rename constructors and destructors in cross-file case

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:91 + DeclRelation::Alias | DeclRelation::TemplatePattern)) { +// If the cursor is at the underlying CXXRecordDecl of the +// ClassTemplateDecl, ND will be the CXXReco

[PATCH] D71356: [Tooling/Syntax] Helpers to find spelled tokens touching a location.

kbobyrev marked an inline comment as done. kbobyrev added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Tokens.h:320 +const syntax::Token * +spelledIdentifierTouching(SourceLocation Loc, + const syntax::TokenBuffer &Tokens);

[PATCH] D71247: [clangd] Rename constructors and destructors in cross-file case

kbobyrev updated this revision to Diff 233533. kbobyrev marked 5 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71247/new/ https://reviews.llvm.org/D71247 Files: clang-tools-extra/clangd/refactor/Rename.cpp clang-tools-extra/clangd/unittests/RenameTests.cpp I

[PATCH] D71400: [RFC] [MinGW] Implicitly add .exe suffix if not provided

mstorsjo created this revision. mstorsjo added a reviewer: rnk. Herald added a project: clang. GCC implicitly adds an .exe suffix if it is given an output file name, but the file name doesn't contain a suffix, and there are certain users of GCC that rely on this behaviour (and run into issues wh

[PATCH] D71356: [Tooling/Syntax] Helpers to find spelled tokens touching a location.

ilya-biryukov added inline comments. Comment at: clang/lib/Tooling/Syntax/Tokens.cpp:270 + for (const syntax::Token &Tok : spelledTokensTouching(Loc, Tokens)) +if (Tok.kind() == tok::identifier) + return &Tok; NIT: add braces around `if` statement Rep

Re: [PATCH] D71186: Reland "[AST] Traverse the class type loc inside the member type loc.""

On Tue, 10 Dec 2019 at 10:24, Ilya Biryukov wrote: > > Ah, some older gcc versions can't handle raw string literals inside macro > arguments. > +Haojian Wu, could you fix this? When do you plan to fix this, bots are now broken for a while... (I don't have my SVN/Github access in place to revert

[PATCH] D71403: [clangd] Fix hover crashing on null types

kadircet created this revision. kadircet added reviewers: sammccall, ilya-biryukov. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay. Herald added a project: clang. Fixes https://github.com/clangd/clangd/issues/225 Repository: rG LLVM Github Monorepo https://review

[PATCH] D71356: [Tooling/Syntax] Helpers to find spelled tokens touching a location.

ilya-biryukov added inline comments. Comment at: clang/lib/Tooling/Syntax/Tokens.cpp:260 + All, [&](const syntax::Token &Tok) { return Tok.location() < Loc; }); + bool AcceptRight = Right != All.end() && !(Loc < Right->location()); + bool AcceptLeft = Right != All.begin()

Re: [PATCH] D71186: Reland "[AST] Traverse the class type loc inside the member type loc.""

Will fix right away, sorry for the delay. On Thu, Dec 12, 2019 at 12:42 PM Yvan Roux wrote: > On Tue, 10 Dec 2019 at 10:24, Ilya Biryukov wrote: > > > > Ah, some older gcc versions can't handle raw string literals inside > macro arguments. > > +Haojian Wu, could you fix this? > > When do you pl

[clang] 7d77898 - [Tooling] Move raw string literal out of a macro call. NFC

Author: Ilya Biryukov Date: 2019-12-12T10:53:20+01:00 New Revision: 7d7789899f4d4684dac51f265a47b049db4d09f2 URL: https://github.com/llvm/llvm-project/commit/7d7789899f4d4684dac51f265a47b049db4d09f2 DIFF: https://github.com/llvm/llvm-project/commit/7d7789899f4d4684dac51f265a47b049db4d09f2.diff

Re: [PATCH] D71186: Reland "[AST] Traverse the class type loc inside the member type loc.""

Should be fixed in 7d7789899f4. On Thu, Dec 12, 2019 at 12:50 PM Ilya Biryukov wrote: > Will fix right away, sorry for the delay. > > On Thu, Dec 12, 2019 at 12:42 PM Yvan Roux wrote: > >> On Tue, 10 Dec 2019 at 10:24, Ilya Biryukov wrote: >> > >> > Ah, some older gcc versions can't handle raw

[PATCH] D71403: [clangd] Fix hover crashing on null types

ilya-biryukov added a comment. Wow, `ParenListExpr` is a really weird construct... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71403/new/ https://reviews.llvm.org/D71403 ___ cfe-commits mailing list

[PATCH] D71403: [clangd] Fix hover crashing on null types

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71403/new/ https://reviews.llvm.org/D71403 _

[PATCH] D71403: [clangd] Fix hover crashing on null types

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:251 QualType T = E->getType(); - if (T->isFunctionType() || T->isFunctionPointerType() || + if (T.isNull() || T->isFunctionType() || T->isFunctionPointerType() || T->isFunctionReferenc

Re: [PATCH] D71186: Reland "[AST] Traverse the class type loc inside the member type loc.""

On Thu, 12 Dec 2019 at 10:54, Ilya Biryukov wrote: > > Should be fixed in 7d7789899f4. Thanks a lot Ilya > On Thu, Dec 12, 2019 at 12:50 PM Ilya Biryukov wrote: >> >> Will fix right away, sorry for the delay. >> >> On Thu, Dec 12, 2019 at 12:42 PM Yvan Roux wrote: >>> >>> On Tue, 10 Dec 2019 a

[PATCH] D71403: [clangd] Fix hover crashing on null types

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 60654 tests passed, 1 failed and 726 were skipped. failed: lld.ELF/linkerscript/provide-empty-section.s {icon check-circle color=green} clang-format: pass. Build artifacts

[clang] 5f62087 - [DataLayout] Fix occurrences that size and range of pointers are assumed to be the same.

Author: Nicola Zaghen Date: 2019-12-12T10:07:01Z New Revision: 5f6208778ff92567c57d7c1e2e740c284d7e69a5 URL: https://github.com/llvm/llvm-project/commit/5f6208778ff92567c57d7c1e2e740c284d7e69a5 DIFF: https://github.com/llvm/llvm-project/commit/5f6208778ff92567c57d7c1e2e740c284d7e69a5.diff LOG:

[PATCH] D68328: Fix occurrences that size and range of pointers are assumed to be the same.

This revision was automatically updated to reflect the committed changes. Closed by commit rG5f6208778ff9: [DataLayout] Fix occurrences that size and range of pointers are assumed to be… (authored by Nicola). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to

[PATCH] D71213: [Alignment][NFC] CreateMemSet use MaybeAlign

gchatelet added a comment. @foad do you have any insights on how to go with the deprecation? LLVM has this `LLVM_ATTRIBUTE_DEPRECATED` macro, it's convenient to get a warning but it only works when building without `-Wall`. Bots and in-tree users have it set by default, it's fine as I'll be fixi

[PATCH] D71356: [Tooling/Syntax] Helpers to find spelled tokens touching a location.

kbobyrev added inline comments. Comment at: clang/lib/Tooling/Syntax/Tokens.cpp:260 + All, [&](const syntax::Token &Tok) { return Tok.location() < Loc; }); + bool AcceptRight = Right != All.end() && !(Loc < Right->location()); + bool AcceptLeft = Right != All.begin() && !(

[clang] 9c48c2f - [NFC] - Typo fix in test/CodeGenCXX/runtime-dllstorage.cpp

Author: Gabor Buella Date: 2019-12-12T11:26:54+01:00 New Revision: 9c48c2f9c477007234c5bdad0bc8c0969afa0724 URL: https://github.com/llvm/llvm-project/commit/9c48c2f9c477007234c5bdad0bc8c0969afa0724 DIFF: https://github.com/llvm/llvm-project/commit/9c48c2f9c477007234c5bdad0bc8c0969afa0724.diff

[PATCH] D48921: NFC - Typo fix in test/CodeGenCXX/runtime-dllstorage.cpp

This revision was automatically updated to reflect the committed changes. Closed by commit rG9c48c2f9c477: [NFC] - Typo fix in test/CodeGenCXX/runtime-dllstorage.cpp (authored by GBuella). Changed prior to commit: https://reviews.llvm.org/D48921?vs=154067&id=233543#toc Repository: rG LLVM Gi

[clang] f798eb2 - Temporarily Revert "[DataLayout] Fix occurrences that size and range of pointers are assumed to be the same."

Author: Nicola Zaghen Date: 2019-12-12T10:29:54Z New Revision: f798eb21eca97dc44ed40da52ece22780fb74230 URL: https://github.com/llvm/llvm-project/commit/f798eb21eca97dc44ed40da52ece22780fb74230 DIFF: https://github.com/llvm/llvm-project/commit/f798eb21eca97dc44ed40da52ece22780fb74230.diff LOG:

[PATCH] D71193: [clang] Turn -fno-builtin flag into an IR Attribute

gchatelet marked an inline comment as done. gchatelet added inline comments. Comment at: clang/test/CodeGen/libcalls-fno-builtin.c:163 -// CHECK: [[ATTR]] = { nobuiltin } +// GLOBAL: #2 = { nobuiltin "no-builtins" } +// INDIVIDUAL: #2 = { nobuiltin "no-builtin-ceil" "no-builtin

[PATCH] D68328: Fix occurrences that size and range of pointers are assumed to be the same.

Nicola added a comment. Reverted in f798eb21eca97dc44ed40da52ece22780fb74230 as it was causing failures in http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-debian/builds/443/steps/test-check-all/logs/stdio

[PATCH] D71403: [clangd] Fix hover crashing on null types

kadircet marked 3 inline comments as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:251 QualType T = E->getType(); - if (T->isFunctionType() || T->isFunctionPointerType() || + if (T.isNull() || T->isFunctionType() || T->isFunctionPointer

[clang-tools-extra] 75b04c7 - [clangd] Fix hover crashing on null types

Author: Kadir Cetinkaya Date: 2019-12-12T11:40:56+01:00 New Revision: 75b04c7af9e7c48e0128a602f2edb17272e3bfaa URL: https://github.com/llvm/llvm-project/commit/75b04c7af9e7c48e0128a602f2edb17272e3bfaa DIFF: https://github.com/llvm/llvm-project/commit/75b04c7af9e7c48e0128a602f2edb17272e3bfaa.dif

[PATCH] D71403: [clangd] Fix hover crashing on null types

This revision was automatically updated to reflect the committed changes. kadircet marked an inline comment as done. Closed by commit rG75b04c7af9e7: [clangd] Fix hover crashing on null types (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D68213: [LTO] Support for embedding bitcode section during LTO

zapster updated this revision to Diff 233548. zapster added a comment. Addressed suggestions from @tejohnson CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68213/new/ https://reviews.llvm.org/D68213 Files: clang/lib/CodeGen/BackendUtil.cpp clang/test/Frontend/x86-embed-bitcode.ll

[PATCH] D71356: [Tooling/Syntax] Helpers to find spelled tokens touching a location.

sammccall updated this revision to Diff 233550. sammccall added a comment. Add overloads for SourceLocation comparison, and document when they're meaningful. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71356/new/ https://reviews.llvm.org/D71356

[PATCH] D20689: [clang-tidy] Suspicious Call Argument checker

whisperity added a comment. I have developed a related check in D69560 . That one considers types, but is an //interface rule// checker, and does not consider (any) potential call sites. Moreover, it does not consider "swaps" that happen across a function call,

[PATCH] D71197: llvm premerge: clang format test

goncharov updated this revision to Diff 233554. goncharov added a comment. add header guards back Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71197/new/ https://reviews.llvm.org/D71197 Files: clang-tools-extra/clangd/Function.h clang/include

[PATCH] D68213: [LTO] Support for embedding bitcode section during LTO

zapster added a comment. Thanks again for you reviews! Since I do not have commit rights, I would be grateful if someone could push it for me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68213/new/ https://reviews.llvm.org/D68213 ___ cfe

[PATCH] D57732: Correct inf typo

Jim added a comment. Do you need someone to commit this change for you? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57732/new/ https://reviews.llvm.org/D57732 ___ cfe-commits mailing list cfe-commits

[PATCH] D71197: llvm premerge: clang format test

merge_guards_bot added a comment. {icon check-circle color=green} clang-format: pass. Build artifacts : console-log.txt Repository: rG

[PATCH] D48921: NFC - Typo fix in test/CodeGenCXX/runtime-dllstorage.cpp

thakis added a comment. This breaks the test everywhere, e.g. http://45.33.8.238/linux/5543/step_7.txt Can you revert this while you investigate if the test was broken since it landed or if something broke it later, while it wasn't really testing what it was supposed to test? Repository: rG

[PATCH] D71356: [Tooling/Syntax] Helpers to find spelled tokens touching a location.

sammccall added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Tokens.h:320 +const syntax::Token * +spelledIdentifierTouching(SourceLocation Loc, + const syntax::TokenBuffer &Tokens); kbobyrev wrote: > sammccall wrote: >

[PATCH] D71356: [Tooling/Syntax] Helpers to find spelled tokens touching a location.

sammccall updated this revision to Diff 233557. sammccall marked 10 inline comments as done. sammccall added a comment. braces Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71356/new/ https://reviews.llvm.org/D71356 Files: clang/include/clang/Ba

[PATCH] D71356: [Tooling/Syntax] Helpers to find spelled tokens touching a location.

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 60699 tests passed, 0 failed and 726 were skipped. {icon check-circle color=green} clang-format: pass. Build artifacts : console-log.txt

[PATCH] D71197: llvm premerge: clang format test

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 60748 tests passed, 0 failed and 726 were skipped. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by running `git-clang-format HEAD^` or apply this patch

[PATCH] D71356: [Tooling/Syntax] Helpers to find spelled tokens touching a location.

kbobyrev added inline comments. Comment at: clang/lib/Tooling/Syntax/Tokens.cpp:270 + for (const syntax::Token &Tok : spelledTokensTouching(Loc, Tokens)) +if (Tok.kind() == tok::identifier) + return &Tok; ilya-biryukov wrote: > sammccall wrote: > > ilya

[PATCH] D71247: [clangd] Rename constructors and destructors in cross-file case

sammccall added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:91 + DeclRelation::Alias | DeclRelation::TemplatePattern)) { +// If the cursor is at the underlying CXXRecordDecl of the +// ClassTemplateDecl, ND will be the CXXRec

[PATCH] D71406: [clangd] Add xref for macros to FileIndex.

usaxena95 created this revision. usaxena95 added a reviewer: hokein. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Adds macro references to the dynamic index. Tests added. Also exposed a new API to convert path to URI i

[PATCH] D71356: [Tooling/Syntax] Helpers to find spelled tokens touching a location.

ilya-biryukov marked an inline comment as done. ilya-biryukov added inline comments. Comment at: clang/lib/Tooling/Syntax/Tokens.cpp:261 + bool AcceptRight = Right != All.end() && !(Loc < Right->location()); + bool AcceptLeft = Right != All.begin() && !((Right - 1)->endLocation

[PATCH] D71356: [Tooling/Syntax] Helpers to find spelled tokens touching a location.

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 60699 tests passed, 0 failed and 726 were skipped. {icon check-circle color=green} clang-format: pass. Build artifacts : console-log.txt

[PATCH] D71356: [Tooling/Syntax] Helpers to find spelled tokens touching a location.

ilya-biryukov added inline comments. Comment at: clang/lib/Tooling/Syntax/Tokens.cpp:270 + for (const syntax::Token &Tok : spelledTokensTouching(Loc, Tokens)) +if (Tok.kind() == tok::identifier) + return &Tok; kbobyrev wrote: > ilya-biryukov wrote: > >

[PATCH] D71247: [clangd] Rename constructors and destructors in cross-file case

kbobyrev updated this revision to Diff 233563. kbobyrev marked 3 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71247/new/ https://reviews.llvm.org/D71247 Files: clang-tools-extra/clangd/refactor/Rename.cpp clang-tools-extra/clangd/unittests/RenameTests.cpp I

[PATCH] D71356: [Tooling/Syntax] Helpers to find spelled tokens touching a location.

sammccall marked 6 inline comments as done. sammccall added inline comments. Comment at: clang/lib/Tooling/Syntax/Tokens.cpp:261 + bool AcceptRight = Right != All.end() && !(Loc < Right->location()); + bool AcceptLeft = Right != All.begin() && !((Right - 1)->endLocation() < Lo

[clang] d8f4991 - [NFC] - Partially revert 9c48c2f9c477007234c

Author: Gabor Buella Date: 2019-12-12T12:46:17+01:00 New Revision: d8f49912847dd8a589e992e2e07d79ac77e61408 URL: https://github.com/llvm/llvm-project/commit/d8f49912847dd8a589e992e2e07d79ac77e61408 DIFF: https://github.com/llvm/llvm-project/commit/d8f49912847dd8a589e992e2e07d79ac77e61408.diff

[PATCH] D71248: [clangd] Introduce paragraph, the first part of new rendering structs

kadircet updated this revision to Diff 233566. kadircet marked 4 inline comments as done. kadircet added a comment. - Move separation logic from container to blocks - Add two concrete APIs to block for getting strings and update tests to use those. - Rename methods Repository: rG LLVM Github

[PATCH] D71248: [clangd] Introduce paragraph, the first part of new rendering structs

kadircet marked 12 inline comments as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/FormattedString.cpp:122 +}; +std::string renderBlocks(llvm::ArrayRef> Children, + RenderType RT) { sammccall wrote: > I'm not

[PATCH] D48921: NFC - Typo fix in test/CodeGenCXX/runtime-dllstorage.cpp

GBuella added a comment. In D48921#1781447 , @thakis wrote: > This breaks the test everywhere, e.g. http://45.33.8.238/linux/5543/step_7.txt > > Can you revert this while you investigate if the test was broken since it > landed or if something broke it la

[PATCH] D71247: [clangd] Rename constructors and destructors in cross-file case

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. LG but the cast needs to be fixed CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71247/new/ https://reviews.llvm.org/D71247 ___ cfe

[PATCH] D71406: [clangd] Add xref for macros to FileIndex.

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 60496 tests passed, 0 failed and 726 were skipped. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by running `git-clang-format HEAD^` or apply this patch

[PATCH] D71247: [clangd] Rename constructors and destructors in cross-file case

sammccall added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:92 + DeclRelation::Alias | DeclRelation::TemplatePattern)) { +const auto *ND = llvm::cast(D); +// Get to CXXRecordDecl from constructor or destructor. --

[clang-tools-extra] 471d9f3 - [clangd] Fix windows tests

Author: Kadir Cetinkaya Date: 2019-12-12T12:54:08+01:00 New Revision: 471d9f3e698108da096bfcd85ac96e2eacda509b URL: https://github.com/llvm/llvm-project/commit/471d9f3e698108da096bfcd85ac96e2eacda509b DIFF: https://github.com/llvm/llvm-project/commit/471d9f3e698108da096bfcd85ac96e2eacda509b.dif

[PATCH] D57732: Correct inf typo

gaul added a comment. In D57732#1781437 , @Jim wrote: > Do you need someone to commit this change for you? I assume so -- this is my first PR for clang and don't know what the procedure is. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D71248: [clangd] Introduce paragraph, the first part of new rendering structs

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 60762 tests passed, 1 failed and 726 were skipped. failed: Clang.CodeGenCXX/runtime-dllstorage.cpp {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D71248: [clangd] Introduce paragraph, the first part of new rendering structs

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/FormattedString.cpp:164 } - return R; + OS << '\n'; } this is worth a comment - we translate Paragraphs

[clang] 3f8da5d - [Tooling/Syntax] Helpers to find spelled tokens touching a location.

Author: Sam McCall Date: 2019-12-12T12:59:50+01:00 New Revision: 3f8da5d0910772dc1f6198916a9141bf1d5be885 URL: https://github.com/llvm/llvm-project/commit/3f8da5d0910772dc1f6198916a9141bf1d5be885 DIFF: https://github.com/llvm/llvm-project/commit/3f8da5d0910772dc1f6198916a9141bf1d5be885.diff LO

[PATCH] D71247: [clangd] Rename constructors and destructors in cross-file case

kbobyrev updated this revision to Diff 233571. kbobyrev marked 4 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71247/new/ https://reviews.llvm.org/D71247 Files: clang-tools-extra/clangd/refactor/Rename.cpp clang-tools-extra/clangd/unittests/RenameTests.cpp I

[PATCH] D71356: [Tooling/Syntax] Helpers to find spelled tokens touching a location.

This revision was automatically updated to reflect the committed changes. sammccall marked 2 inline comments as done. Closed by commit rG3f8da5d09107: [Tooling/Syntax] Helpers to find spelled tokens touching a location. (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang-tools-extra] ec61882 - [clangd] Rename constructors and destructors in cross-file case

Author: Kirill Bobyrev Date: 2019-12-12T13:10:59+01:00 New Revision: ec618826dfb91c5413353ebcc54f360e43df10a0 URL: https://github.com/llvm/llvm-project/commit/ec618826dfb91c5413353ebcc54f360e43df10a0 DIFF: https://github.com/llvm/llvm-project/commit/ec618826dfb91c5413353ebcc54f360e43df10a0.diff

[PATCH] D71133: [OpenCL] Add ExtVectorElementExpr constant evaluation (PR42387)

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! Comment at: clang/lib/AST/ExprConstant.cpp:7057 + +if (Val.isVector()) { + SmallVector Indices; svenvh wrote: > Anastasia wrote:

[PATCH] D71248: [clangd] Introduce paragraph, the first part of new rendering structs

kadircet added inline comments. Comment at: clang-tools-extra/clangd/unittests/FormattedStringTests.cpp:79 + { + Test::PlainText, + "after", sammccall wrote: > I'd consider writing this as > `[&] { Para.appendText("after"); }` to make it cl

[PATCH] D71247: [clangd] Rename constructors and destructors in cross-file case

This revision was automatically updated to reflect the committed changes. Closed by commit rGec618826dfb9: [clangd] Rename constructors and destructors in cross-file case (authored by kbobyrev). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D71248: [clangd] Introduce paragraph, the first part of new rendering structs

kadircet updated this revision to Diff 233576. kadircet marked 5 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71248/new/ https://reviews.llvm.org/D71248 Files: clang-tools-ex

[PATCH] D71199: [clang-tidy][WIP] New check readability-prefer-initialization-list

baloghadamsoftware added a comment. In D71199#1777887 , @aaron.ballman wrote: > In D71199#1775083 , @whisperity > wrote: > > > Can you refresh my memory on whether a rule for "if init expr is constant, > > initia

[PATCH] D71111: [Sema] Improve diagnostic about addr spaces for overload candidates

Anastasia updated this revision to Diff 233579. Anastasia marked an inline comment as done. Anastasia added a comment. - Moved "address space" printing into diagnostic engine - Moved `LangAS::Default` into switch/case statement. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7/new/ h

[PATCH] D71248: [clangd] Introduce paragraph, the first part of new rendering structs

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 60763 tests passed, 0 failed and 726 were skipped. {icon check-circle color=green} clang-format: pass. Build artifacts : console-log.txt

[PATCH] D71378: Modifying ImportDeclContext(...) to ensure that we complete each FieldDecl of a RecordDecl when we are importing the definiton

teemperor added a comment. I wonder if we have a way to fix this from with LLDB. Having Clang code that is only tested in LLDB is always a bit weird. Otherwise the idea itself LGTM, thanks for working on this (and reducing the test case to that!) Comment at: clang/lib/AST/AS

[PATCH] D71197: llvm premerge: clang format test

goncharov added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by running `git-clang-format HEAD^` or applying this patch .

[PATCH] D71197: llvm premerge: clang format test

goncharov added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon check-circle color=green} clang-format: pass. {icon times-circle color=red} clang-tidy: fail. Please fix clang-tidy findings . Build artifacts

[PATCH] D71356: [Tooling/Syntax] Helpers to find spelled tokens touching a location.

ilya-biryukov marked an inline comment as done. ilya-biryukov added inline comments. Comment at: clang/lib/Tooling/Syntax/Tokens.cpp:270 + for (const syntax::Token &Tok : spelledTokensTouching(Loc, Tokens)) +if (Tok.kind() == tok::identifier) + return &Tok;

[PATCH] D71413: [OpenMP][Test] Add check for aux-triple predefined macros

bader created this revision. bader added a reviewer: ABataev. Herald added subscribers: cfe-commits, ebevhan, guansong. Herald added a reviewer: jdoerfert. Herald added a project: clang. Make sure that auxiliary target specific macros are defined in OpenMP mode. Repository: rG LLVM Github Mono

[PATCH] D71378: Modifying ImportDeclContext(...) to ensure that we complete each FieldDecl of a RecordDecl when we are importing the definiton

martong added a comment. Thanks for the patch! It look almost good to me, but I have a comment about the error handling. Comment at: clang/lib/AST/ASTImporter.cpp:1707 +if (Err) + return Err; +} Rather than just simply retu

[PATCH] D71197: llvm premerge: clang format test

goncharov added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by running `git-clang-format HEAD^` or applying this patch .

[PATCH] D71082: Allow system header to provide their own implementation of some builtin

serge-sans-paille updated this revision to Diff 233585. serge-sans-paille added a comment. @george.burgess.iv : take into account reviews, extra testing and function renaming. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71082/new/ https://review

[PATCH] D57747: [Sema] SequenceChecker: Fix handling of operator ||, && and ?:

riccibruno added a comment. In D57747#1774848 , @xbolva00 wrote: > Does the whole stack of patch need to be commited at once or maybe you can > land them individually? Hi, thanks for looking at this patch series ! If I remember correctly (it has been a

[PATCH] D71378: Modifying ImportDeclContext(...) to ensure that we complete each FieldDecl of a RecordDecl when we are importing the definiton

martong added a comment. Just one more thing, maybe that is too overkill, but I think on a long term we could benefit from a unittest for this case. You could create a test similar to `LLDBLookupTest` in ASTImporterTest.cpp. In that Fixture we use Minimal import and the regular lookup (that is

[PATCH] D71197: llvm premerge: clang format test

goncharov added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by running `git-clang-format HEAD^` or applying this patch .

[PATCH] D57660: [Sema] SequenceChecker: Handle references, members and structured bindings.

riccibruno added a comment. In D57660#1764337 , @Mordante wrote: > I like this improvement. However I'm not a reviewer. Thanks for looking at the patch! > You can land some NFC changes in separate commit. Yep, indeed. Will do when I rebase it. Reposi

[PATCH] D70819: [ASTImporter] Support functions with placeholder return types ...

martong added a comment. In D70819#170 , @shafik wrote: > Apologies for wacky C++ code that follows but will this also work for the > following cases: > > auto f2() { > auto l = []() { > struct X{}; > return X(); > }; >r

[PATCH] D71197: llvm premerge: clang format test

goncharov added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon times-circle color=red} clang-tidy: fail. Please fix clang-tidy findings . {icon times-circle color=red} clang-format: fail. Please format your changes

[PATCH] D71413: [OpenMP][Test] Add check for aux-triple predefined macros

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 60761 tests passed, 1 failed and 726 were skipped. failed: Clang.CodeGenCXX/runtime-dllstorage.cpp {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D71374: Improve support of GNU mempcpy

serge-sans-paille updated this revision to Diff 233587. serge-sans-paille added a comment. @Jim obviously :-) Thanks for spotting that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71374/new/ https://reviews.llvm.org/D71374 Files: clang/include

[PATCH] D71320: [IR] Split out target specific intrinsic enums into separate headers

This revision was automatically updated to reflect the committed changes. Closed by commit rG5d986953c8b9: [IR] Split out target specific intrinsic enums into separate headers (authored by rnk). Changed prior to commit: https://reviews.llvm.org/D71320?vs=233231&id=233480#toc Repository: rG L

RE: [clang] f978ea4 - [clang][clang-scan-deps] Aggregate the full dependency information.

Hi Michael, We are happy to help troubleshoot the issue this caused on our bot. Unfortunately, this bot is not one where we can give you access so we'll have to try and work together to debug this. Can you provide the link to the failing build so we can see which test case it was that caused the pr

  1   2   3   >