martong added a comment.

Just one more thing, maybe that is too overkill, but I think on a long term we 
could benefit from a unittest for this case. You could create a test similar to 
`LLDBLookupTest` in ASTImporterTest.cpp. In that Fixture we use Minimal import 
and the regular lookup (that is the exact case in LLDB).
In the test itself we could call ImportDefinition on a struct that has fields 
with record types. And then we could assert that all field's type's have 
complete types.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71378/new/

https://reviews.llvm.org/D71378



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to