[PATCH] D71208: CodeGen: Allow annotations on globals in non-zero address space

nhaehnle added a comment. > My concern is that there's something that's going to blow up or miscompile if > we start passing in constants that aren't in a regular address space. Aren't > there kinds of annotations which get persisted into the emitted code? Annotations don't seem to be used for

[PATCH] D71197: llvm premerge: clang format test

goncharov added a comment. Build result: fail - 60594 tests passed, 30 failed and 726 were skipped. failed: libc++.std/input_output/filesystems/class_directory_entry/directory_entry_cons/path.pass.cpp failed: libc++.std/input_output/filesystems/class_directory_entry/directory_entry_mods/ass

[PATCH] D71197: llvm premerge: clang format test

goncharov added a comment. Build result: fail - 60594 tests passed, 30 failed and 726 were skipped. failed: libc++.std/input_output/filesystems/class_directory_entry/directory_entry_cons/path.pass.cpp failed: libc++.std/input_output/filesystems/class_directory_entry/directory_entry_mods/ass

[PATCH] D71197: llvm premerge: clang format test

goncharov added a comment. Build result: fail - 60594 tests passed, 30 failed and 726 were skipped. failed: libc++.std/input_output/filesystems/class_directory_entry/directory_entry_cons/path.pass.cpp failed: libc++.std/input_output/filesystems/class_directory_entry/directory_entry_mods/ass

[PATCH] D71197: llvm premerge: clang format test

goncharov added a comment. Build result: fail - 60594 tests passed, 30 failed and 726 were skipped. failed: libc++.std/input_output/filesystems/class_directory_entry/directory_entry_cons/path.pass.cpp failed: libc++.std/input_output/filesystems/class_directory_entry/directory_entry_mods/ass

[PATCH] D71197: llvm premerge: clang format test

goncharov added a comment. Build result: fail - 60594 tests passed, 30 failed and 726 were skipped. failed: libc++.std/input_output/filesystems/class_directory_entry/directory_entry_cons/path.pass.cpp failed: libc++.std/input_output/filesystems/class_directory_entry/directory_entry_mods/ass

[PATCH] D71197: llvm premerge: clang format test

goncharov added a comment. Build result: fail - 60594 tests passed, 30 failed and 726 were skipped. failed: libc++.std/input_output/filesystems/class_directory_entry/directory_entry_cons/path.pass.cpp failed: libc++.std/input_output/filesystems/class_directory_entry/directory_entry_mods/ass

[PATCH] D71082: Allow system header to provide their own implementation of some builtin

serge-sans-paille added a comment. Validation OK: https://github.com/serge-sans-paille/llvm-project/pull/4/checks Comment at: clang/lib/AST/Decl.cpp:3006 +bool FunctionDecl::isReplaceableSystemFunction() const { + FunctionDecl const *Definition; Note to revi

[PATCH] D70245: [OPENMP50]Add device/kind context selector support.

jdoerfert added a comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70245/new/ https://reviews.llvm.org/D70245 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/

[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

jdoerfert created this revision. jdoerfert added reviewers: kiranchandramohan, ABataev, RaviNarayanaswamy, gtbercea, grokos, sdmitriev, JonChesterfield, hfinkel, fghanim. Herald added subscribers: s.egerton, guansong, bollu, simoncook, fedor.sergeev, aheejin, rampitec, jholewinski. Herald added a

[PATCH] D71179: [OpenMP][WIP] Initial support for `begin/end declare variant`

jdoerfert added a comment. So, D71241 shows how declare variant (5.0) would look like if we implement it through SemaLookup. I will actually revisit this patch tomorrow as I might be able to make it even simpler. (D71241 is sav

[PATCH] D71016: [SYCL] Implement OpenCL kernel function generation

Fznamznon updated this revision to Diff 233013. Fznamznon added a comment. Updated tests using address space attributes added by D71005 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71016/new/ https://reviews.llvm

Re: [PATCH] D71186: Reland "[AST] Traverse the class type loc inside the member type loc.""

Hi Haojian, AArch64 bots are broken after this commit, logs are available here: http://lab.llvm.org:8011/builders/clang-cmake-aarch64-quick/builds/21125/steps/ninja%20check%201/logs/stdio Thanks Yvan On Mon, 9 Dec 2019 at 11:30, pre-merge checks [bot] via Phabricator via cfe-commits wrote: > >

[clang-tools-extra] b63c35e - [clangd] Simplify code using findName. NFC

Author: Ilya Biryukov Date: 2019-12-10T10:22:43+01:00 New Revision: b63c35ebf76ca0ac89405aeadee2b98a0e91e05e URL: https://github.com/llvm/llvm-project/commit/b63c35ebf76ca0ac89405aeadee2b98a0e91e05e DIFF: https://github.com/llvm/llvm-project/commit/b63c35ebf76ca0ac89405aeadee2b98a0e91e05e.diff

Re: [PATCH] D71186: Reland "[AST] Traverse the class type loc inside the member type loc.""

Ah, some older gcc versions can't handle raw string literals inside macro arguments. +Haojian Wu , could you fix this? On Tue, Dec 10, 2019 at 12:22 PM Yvan Roux wrote: > Hi Haojian, > > AArch64 bots are broken after this commit, logs are available here: > > > http://lab.llvm.org:8011/builders/c

[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

merge_guards_bot added a comment. Build result: fail - 60666 tests passed, 1 failed and 726 were skipped. failed: Clang.OpenMP/declare_variant_ast_print.cpp Log files: console-log.txt , CMakeCache.txt

[PATCH] D71179: [OpenMP][WIP] Initial support for `begin/end declare variant`

ABataev added a comment. In D71179#1776528 , @hfinkel wrote: > In D71179#1776491 , @ABataev wrote: > > > In D71179#1776487 , @hfinkel wrote: > > > > > In D71179#1776467

[PATCH] D69764: [clang-format] Add Left/Right Const (East/West , Before/After) fixer capability

MyDeveloperDay added a comment. > But I don't know if this can be (easily) supported in a .clang-format file, > since the style options are defined as (static) enums. I realize my proposal > might be out of the scope of this patch, but I wanted to get some opinions > from the community. just t

[PATCH] D71213: [Alignment][NFC] CreateMemSet use MaybeAlign

courbet added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/MemorySanitizer.cpp:1092 const DataLayout &DL = F.getParent()->getDataLayout(); -unsigned IntptrAlignment = DL.getABITypeAlignment(MS.IntptrTy); +Align IntptrAlignment = Align(DL.getABITyp

[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

ABataev added a comment. You're merging different functions as multiversiin variants. I don't think this right to overcomplicate the semantics of multiversion functions just because you want to do it. Comment at: clang/lib/Sema/SemaOverload.cpp:9725 + + // TODO: Handle temp

[PATCH] D71197: llvm premerge: clang format test

goncharov updated this revision to Diff 233020. goncharov added a comment. more files Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71197/new/ https://reviews.llvm.org/D71197 Files: clang/tools/clang-diff/ClangDiff.cpp clang/tools/clang-fuzzer

[PATCH] D71197: llvm premerge: clang format test

merge_guards_bot added a comment. Build result: pass - 60624 tests passed, 0 failed and 726 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D71197: llvm premerge: clang format test

goncharov added a comment. Build result: pass - 0 tests passed, 0 failed and 0 were skipped. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71197/new/ https://reviews.llvm.org/D71197 ___ cfe-commits mai

[PATCH] D71065: [ARM][MVE] Add intrinsics for immediate shifts.

simon_tatham updated this revision to Diff 233025. simon_tatham added a comment. Changes from previous version: - minor cleanup: removed check of `hasIntegerConstantValue` in `IRBuilderResult::more_prerequisites`, which was causing the generated codegen to perofrm a pointless call to `EmitScala

[PATCH] D71065: [ARM][MVE] Add intrinsics for immediate shifts.

simon_tatham reopened this revision. simon_tatham added a comment. This revision is now accepted and ready to land. Reopening to review a revised version of this patch. It was reverted yesterday because of a test failure in release builds, which looks like the result of a warning fix that moved

[PATCH] D71245: [ARM][MVE] Refactor complex vector intrinsics [NFCI]

miyuki created this revision. miyuki added reviewers: dmgreen, ostannard, simon_tatham, MarkMurrayARM. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, kristof.beyls. Herald added projects: clang, LLVM. This patch refactors instruction selection of the complex vector addition, multi

[PATCH] D71065: [ARM][MVE] Add intrinsics for immediate shifts.

simon_tatham added subscribers: rdhindsa, hokein, echristo. simon_tatham added a comment. @hokein , @rdhindsa , @echristo : you all pointed out test failures in the previous version. Any problems I haven't spotted with this one? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D71197: llvm premerge: clang format test

goncharov added a comment. Build result: pass - 0 tests passed, 0 failed and 0 were skipped. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71197/new/ https://reviews.llvm.org/D71197 ___ cfe-commits mai

[PATCH] D71197: llvm premerge: clang format test

goncharov added a comment. Build result: pass - 0 tests passed, 0 failed and 0 were skipped. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71197/new/ https://reviews.llvm.org/D71197 ___ cfe-commits mai

[PATCH] D71197: llvm premerge: clang format test

goncharov added a comment. Build result: pass - 0 tests passed, 0 failed and 0 were skipped. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71197/new/ https://reviews.llvm.org/D71197 ___ cfe-commits mai

[PATCH] D71197: llvm premerge: clang format test

goncharov added a comment. Build result: pass - 0 tests passed, 0 failed and 0 were skipped. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71197/new/ https://reviews.llvm.org/D71197 ___ cfe-commits mai

[PATCH] D71197: llvm premerge: clang format test

goncharov added a comment. Build result: pass - 0 tests passed, 0 failed and 0 were skipped. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71197/new/ https://reviews.llvm.org/D71197 ___ cfe-commits mai

[PATCH] D71245: [ARM][MVE] Refactor complex vector intrinsics [NFCI]

merge_guards_bot added a comment. Build result: pass - 60668 tests passed, 0 failed and 726 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D71197: llvm premerge: clang format test

goncharov updated this revision to Diff 233029. goncharov added a comment. update clang diff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71197/new/ https://reviews.llvm.org/D71197 Files: clang/tools/clang-diff/ClangDiff.cpp clang/tools/clang

[PATCH] D71197: llvm premerge: clang format test

goncharov added a comment. Build result: pass - 0 tests passed, 0 failed and 0 were skipped. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71197/new/ https://reviews.llvm.org/D71197 ___ cfe-commits mai

[PATCH] D71197: llvm premerge: clang format test

merge_guards_bot added a comment. Build result: pass - 60624 tests passed, 0 failed and 726 were skipped. Log files: console-log.txt , CMakeCache.txt

[clang] 9c39663 - Only Remove implicit conversion for the target that support fp16

Author: Jim Lin Date: 2019-12-10T19:15:11+08:00 New Revision: 9c3966379813c198129c57aa3ebecd68d6af1ebd URL: https://github.com/llvm/llvm-project/commit/9c3966379813c198129c57aa3ebecd68d6af1ebd DIFF: https://github.com/llvm/llvm-project/commit/9c3966379813c198129c57aa3ebecd68d6af1ebd.diff LOG:

Re: [clang] 9c39663 - Only Remove implicit conversion for the target that support fp16

Is there a test missing? On Tue, Dec 10, 2019 at 2:11 PM Jim Lin via cfe-commits wrote: > > > Author: Jim Lin > Date: 2019-12-10T19:15:11+08:00 > New Revision: 9c3966379813c198129c57aa3ebecd68d6af1ebd > > URL: > https://github.com/llvm/llvm-project/commit/9c3966379813c198129c57aa3ebecd68d6af1ebd

[PATCH] D71240: [clangd] Heuristically resolve dependent method calls

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Awesome, thanks, I'd been hoping to get around to this! LG with some naming/structure nits. This doesn't handle references into smart pointers (details below), but feel free to do that i

[PATCH] D71049: Remove implicit conversion that promotes half to other larger precision types for fp classification builtins

uweigand added a comment. This causes build bot failures on SystemZ due to a failed assertion in ConstantFP::getInfinity: http://lab.llvm.org:8011/builders/clang-s390x-linux/builds/28723/steps/ninja%20check%201/logs/FAIL%3A%20Clang%3A%3Abuiltins.c Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D71248: [clangd] Introduce paragraph, the first part of new rendering structs

kadircet created this revision. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Initial patch for new rendering structs in clangd. Splitting implementation into smaller chunks, for a full view of the API see D71063

[PATCH] D71247: [clangd] Rename constructors and destructors in cross-file case

kbobyrev updated this revision to Diff 233037. kbobyrev added a comment. Improve wording in the comment I moved. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71247/new/ https://reviews.llvm.org/D71247 Files: clang-tools-extra/clangd/refactor/Rename.cpp clang-tools-extra/clangd/uni

[PATCH] D71247: [clangd] Rename constructors and destructors in cross-file case

kadircet added inline comments. Comment at: clang-tools-extra/clangd/unittests/RenameTests.cpp:699 + [[Foo]](); + ^~[[Foo]](); +}; could you also add a case with `~^Foo()` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71247/new

[PATCH] D71248: [clangd] Introduce paragraph, the first part of new rendering structs

merge_guards_bot added a comment. Build result: pass - 60655 tests passed, 0 failed and 726 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D70615: Add an -fno-temp-file flag for compilation

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. I see. For some reason I thought the temporary files would be written elsewhere, like in /tmp, but I see that's not the case, and I guess it also makes sense to avoid having to copy it between fil

[PATCH] D71247: [clangd] Rename constructors and destructors in cross-file case

kbobyrev updated this revision to Diff 233048. kbobyrev marked an inline comment as done. kbobyrev added a comment. Add another test for `~^Foo` and rebase on top of master. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71247/new/ https://reviews.llvm.org/D71247 Files: clang-tools-ex

[PATCH] D71213: [Alignment][NFC] CreateMemSet use MaybeAlign

gchatelet marked 2 inline comments as done. gchatelet added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/MemorySanitizer.cpp:2910 +const Align Alignment = +assumeAligned(cast(I.getArgOperand(2))->getZExtValue()); Value *Mask = I.getArgOperand(

[PATCH] D69878: Consoldiate internal denormal flushing controls

arsenm updated this revision to Diff 233059. arsenm added a comment. Reword langref, fix name in langref CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69878/new/ https://reviews.llvm.org/D69878 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Basic/CodeGenOpt

[PATCH] D71124: [RISCV] support clang driver to select cpu

lenary added reviewers: lenary, asb. lenary added inline comments. Comment at: clang/lib/Basic/Targets/RISCV.cpp:164 + +static constexpr llvm::StringLiteral ValidRV32CPUNames[] = {{"generic-rv32"}, +{"rocket-rv32"}}; ---

[PATCH] D68213: [LTO] Support for embedding bitcode section during LTO

zapster added a comment. (Ping) Hi! I am still looking for reviews/reviewers for this change. Please let me know what I can do to make progress with this. Many thanks in advance! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68213/new/ https://reviews.llvm.org/D68213 __

[PATCH] D69979: clang: Guess at some platform FTZ/DAZ default settings

arsenm added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69979/new/ https://reviews.llvm.org/D69979 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D69782: Summary: Instead of dropping all the ranges associated with a Diagnostic when converting them to a ClangTidy error, instead attach them to the ClangTidyError, so they can be consumed b

alexfh requested changes to this revision. alexfh added inline comments. This revision now requires changes to proceed. Comment at: include/clang/Tooling/DiagnosticsYaml.h:75 std::string BuildDirectory; +ArrayRef Ranges; }; We should serialize the ran

[PATCH] D71245: [ARM][MVE] Refactor complex vector intrinsics [NFCI]

dmgreen accepted this revision. dmgreen added a comment. This revision is now accepted and ready to land. Nice one. Thanks. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71245/new/ https://reviews.llvm.org/D71245 __

[PATCH] D70157: Align branches within 32-Byte boundary

fedor.sergeev added a comment. In D70157#1776424 , @skan wrote: > > What if I insert explicit align(8) right *after* the sequence? > > If your insert explicit `.align 8` after the sequence, and the sequence > doesn't has any branch to be aligned, the curr

[PATCH] D70256: [FPEnv] clang support for constrained FP builtins

kpn updated this revision to Diff 233073. kpn added a comment. Update for review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70256/new/ https://reviews.llvm.org/D70256 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/test/CodeGen/constrained-math-builtins.c llvm/include/l

[PATCH] D71213: [Alignment][NFC] CreateMemSet use MaybeAlign

gchatelet updated this revision to Diff 233074. gchatelet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71213/new/ https://reviews.llvm.org/D71213 Files: clang/lib/CodeGen/CGAtomic.cpp clang/lib/CodeGen/CGBu

[PATCH] D71213: [Alignment][NFC] CreateMemSet use MaybeAlign

gchatelet added a comment. Thx for the review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71213/new/ https://reviews.llvm.org/D71213 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[clang] 1b2842b - [Alignment][NFC] CreateMemSet use MaybeAlign

Author: Guillaume Chatelet Date: 2019-12-10T15:17:44+01:00 New Revision: 1b2842bf902a8b52acbef2425120533b63be5ae3 URL: https://github.com/llvm/llvm-project/commit/1b2842bf902a8b52acbef2425120533b63be5ae3 DIFF: https://github.com/llvm/llvm-project/commit/1b2842bf902a8b52acbef2425120533b63be5ae3.

[PATCH] D71248: [clangd] Introduce paragraph, the first part of new rendering structs

kadircet updated this revision to Diff 233078. kadircet added a comment. - More comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71248/new/ https://reviews.llvm.org/D71248 Files: clang-tools-extra/clangd/FormattedString.cpp clang-tools-e

[PATCH] D71213: [Alignment][NFC] CreateMemSet use MaybeAlign

This revision was automatically updated to reflect the committed changes. Closed by commit rG1b2842bf902a: [Alignment][NFC] CreateMemSet use MaybeAlign (authored by gchatelet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71213/new/ https://reviews

[PATCH] D68213: [LTO] Support for embedding bitcode section during LTO

tejohnson added a comment. It seems reasonable to support this from LTO since it provides analogous support to what is available via clang without LTO. @pcc what do you think? I only just skimmed it for now, one question below. Comment at: llvm/lib/LTO/LTOBackend.cpp:335 +

[PATCH] D68261: [clangd] Add "inline" keyword to prevent ODR-violations in DefineInline

kadircet updated this revision to Diff 233081. kadircet added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68261/new/ https://reviews.llvm.org/D68261 Files: clang-tools-extra/clangd/refactor/tweaks/DefineInline.cpp clang-t

[PATCH] D71248: [clangd] Introduce paragraph, the first part of new rendering structs

merge_guards_bot added a comment. Build result: pass - 60655 tests passed, 0 failed and 726 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D70615: Add an -fno-temp-file flag for compilation

zahen added a comment. Thanks Hans! I'll need someone to do the actual submission since I don't have commit rights. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70615/new/ https://reviews.llvm.org/D70615 ___ cfe-commits mailing list cfe-

[PATCH] D71199: [clang-tidy][WIP] New check readability-prefer-initialization-list

baloghadamsoftware updated this revision to Diff 233087. baloghadamsoftware added a comment. Updated according to some comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71199/new/ https://reviews.llvm.org/D71199 Files: clang-tools-extra/clang-tidy/readability/CMakeLists.txt c

[PATCH] D68261: [clangd] Add "inline" keyword to prevent ODR-violations in DefineInline

merge_guards_bot added a comment. Build result: pass - 60656 tests passed, 0 failed and 726 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D71124: [RISCV] support clang driver to select cpu

khchen updated this revision to Diff 233082. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71124/new/ https://reviews.llvm.org/D71124 Files: clang/lib/Basic/Targets/RISCV.cpp clang/lib/Basic/Targets/RISCV.h clang/lib/Driver/ToolChains/CommonAr

[PATCH] D71124: [RISCV] support clang driver to select cpu

khchen marked 3 inline comments as done. khchen added inline comments. Comment at: clang/lib/Basic/Targets/RISCV.cpp:164 + +static constexpr llvm::StringLiteral ValidRV32CPUNames[] = {{"generic-rv32"}, +{"rocket-rv32"}};

[PATCH] D70973: [OPENMP50]Treat context selectors as expressions, not just strings.

ABataev updated this revision to Diff 233093. ABataev added a comment. Fixed misprint in the comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70973/new/ https://reviews.llvm.org/D70973 Files: clang/include/clang/Basic/Attr.td clang/inclu

[PATCH] D68213: [LTO] Support for embedding bitcode section during LTO

zapster added a comment. Thanks for your comment. I replied inline. Comment at: llvm/lib/LTO/LTOBackend.cpp:335 + .Case("bitcode", EmbedBitcodeKind::Embed_Bitcode) + .Case("marker", EmbedBitcodeKind::Embed_Marker) +

[PATCH] D71197: llvm premerge: clang format test

goncharov added a comment. Build result: SUCCESS - Build artifacts :clang-format.patch , CMakeCache.txt Repository: rG LLVM Github Monorepo

[PATCH] D70973: [OPENMP50]Treat context selectors as expressions, not just strings.

merge_guards_bot added a comment. Build result: pass - 60659 tests passed, 0 failed and 726 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D71197: llvm premerge: clang format test

goncharov added a comment. test `code` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71197/new/ https://reviews.llvm.org/D71197 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D71124: [RISCV] support clang driver to select cpu

lenary added inline comments. Comment at: clang/lib/Basic/Targets/RISCV.cpp:164 + +static constexpr llvm::StringLiteral ValidRV32CPUNames[] = {{"generic-rv32"}, +{"rocket-rv32"}}; khchen wrote: > lenary

[PATCH] D71197: llvm premerge: clang format test

goncharov added a comment. Build result: SUCCESS - Build artifacts : clang-format.patch , CMakeCache.txt Repository: rG LLVM Github Monorep

[clang] d77ae15 - [DebugInfo] Support to emit debugInfo for extern variables

Author: Yonghong Song Date: 2019-12-10T08:09:51-08:00 New Revision: d77ae1552fc21a9f3877f3ed7e13d631f517c825 URL: https://github.com/llvm/llvm-project/commit/d77ae1552fc21a9f3877f3ed7e13d631f517c825 DIFF: https://github.com/llvm/llvm-project/commit/d77ae1552fc21a9f3877f3ed7e13d631f517c825.diff

[PATCH] D70696: [DebugInfo] Support to emit debugInfo for extern variables

This revision was automatically updated to reflect the committed changes. Closed by commit rGd77ae1552fc2: [DebugInfo] Support to emit debugInfo for extern variables (authored by yonghong-song). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70696/new

[clang] e6d3261 - [ARM][MVE] Refactor complex vector intrinsics [NFCI]

Author: Mikhail Maltsev Date: 2019-12-10T16:21:52Z New Revision: e6d3261c67ecade5d959ee3094eb2bd1cd7ec447 URL: https://github.com/llvm/llvm-project/commit/e6d3261c67ecade5d959ee3094eb2bd1cd7ec447 DIFF: https://github.com/llvm/llvm-project/commit/e6d3261c67ecade5d959ee3094eb2bd1cd7ec447.diff LO

[PATCH] D71245: [ARM][MVE] Refactor complex vector intrinsics [NFCI]

This revision was automatically updated to reflect the committed changes. Closed by commit rGe6d3261c67ec: [ARM][MVE] Refactor complex vector intrinsics [NFCI] (authored by miyuki). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71245/new/ https://re

[PATCH] D71197: llvm premerge: clang format test

goncharov added a comment. Please format your changes with clang-format by running `git-clang-format HEAD^` or apply this patch . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71197/new/ h

[PATCH] D71197: llvm premerge: clang format test

goncharov added a comment. Build result: pass - 0 tests passed, 0 failed and 0 were skipped. Build artifacts : test-results.xml , clang-format.patch

[clang] f3a2820 - [analyzer] Keep track of escaped locals

Author: Gabor Horvath Date: 2019-12-10T08:51:33-08:00 New Revision: f3a28202ef58551db15818f8f51afd21e0f3e231 URL: https://github.com/llvm/llvm-project/commit/f3a28202ef58551db15818f8f51afd21e0f3e231 DIFF: https://github.com/llvm/llvm-project/commit/f3a28202ef58551db15818f8f51afd21e0f3e231.diff

[PATCH] D71133: [OpenCL] Add ExtVectorElementExpr constant evaluation (PR42387)

Anastasia added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:7057 + +if (Val.isVector()) { + SmallVector Indices; can Val not be vector at this point? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71133/new/ https://reviews.llvm

[PATCH] D71152: [analyzer] Keep track of escaped locals.

This revision was automatically updated to reflect the committed changes. Closed by commit rGf3a28202ef58: [analyzer] Keep track of escaped locals (authored by xazax.hun). Changed prior to commit: https://reviews.llvm.org/D71152?vs=232675&id=233124#toc Repository: rG LLVM Github Monorepo CH

[PATCH] D69878: Consoldiate internal denormal flushing controls

Anastasia added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:1775 -if (getLangOpts().OpenCL) - FuncAttrs.addAttribute("denorms-are-zero", - llvm::toStringRef(CodeGenOpts.FlushDenorm)); arsenm wrote: > Anastasia wr

[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

jdoerfert marked 2 inline comments as done. jdoerfert added a comment. In D71241#1776798 , @ABataev wrote: > You're merging different functions as multiversiin variants. I don't think > this right to overcomplicate the semantics of multiversion functions

[PATCH] D71282: Fix bug 44190 - wrong code with #pragma pack(1)

yaxunl created this revision. yaxunl added reviewers: rjmccall, efriedma, jnspaulsson. https://github.com/llvm/llvm-project/commit/5b330e8d6122c336d81dfd11c864e6c6240a381e caused a regression on s390: https://bugs.llvm.org/show_bug.cgi?id=44190 we need to copy if if either the argument is non-b

[PATCH] D71247: [clangd] Rename constructors and destructors in cross-file case

sammccall added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:91 if (const auto *D = SelectedNode->ASTNode.get()) { -if (D->getLocation() != TokenStartLoc) - return {}; +if (D->getLocation() != TokenStartLoc) { + // Destructor->get

[clang] da17a53 - [OPENMP50]Add if clause in target parallel for simd directive.

Author: Alexey Bataev Date: 2019-12-10T12:28:32-05:00 New Revision: da17a53173e0452c0a8a64a83f61a9d4af96eaa8 URL: https://github.com/llvm/llvm-project/commit/da17a53173e0452c0a8a64a83f61a9d4af96eaa8 DIFF: https://github.com/llvm/llvm-project/commit/da17a53173e0452c0a8a64a83f61a9d4af96eaa8.diff

[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

ABataev added a comment. In D71241#1777661 , @jdoerfert wrote: > In D71241#1776798 , @ABataev wrote: > > > You're merging different functions as multiversiin variants. I don't think > > this right to overcomplicat

[PATCH] D71284: [clangd] Consider () part of the FunctionDecl, not the FunctionTypeLoc

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. CODE: int foo(int); OLD: TTT FFFT NEW: TTT TTTF This works around targeting issues when the

[PATCH] D71282: Fix bug 44190 - wrong code with #pragma pack(1)

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:4008 + if ((!ArgInfo.getIndirectByVal() || + (LV.getAlignment() < getContext().getTypeAlignInChars(I->Ty { NeedCopy = true; Thanks for the fix. Plea

[PATCH] D69764: [clang-format] Add Left/Right Const (East/West , Before/After) fixer capability

ilya added a comment. > I think this would likely make everything much more complicated, but perhaps > we should think about this for the configuration at least now so we future > proof ourselves. What you've outlined looks good to me. Of course we will be happy to contribute, given there will

[PATCH] D70256: [FPEnv] clang support for constrained FP builtins

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Thanks, LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70256/new/ https://reviews.llvm.org/D70256 ___ cfe-commits mailing list

[clang] d62a151 - [OPENMP]Remove extra space from error message.

Author: Alexey Bataev Date: 2019-12-10T12:55:40-05:00 New Revision: d62a15116b68c1d1ce7e4f3d6a9cd891670b03c5 URL: https://github.com/llvm/llvm-project/commit/d62a15116b68c1d1ce7e4f3d6a9cd891670b03c5 DIFF: https://github.com/llvm/llvm-project/commit/d62a15116b68c1d1ce7e4f3d6a9cd891670b03c5.diff

[clang] 6515c52 - [FPEnv] clang support for constrained FP builtins

Author: Kevin P. Neal Date: 2019-12-10T13:09:12-05:00 New Revision: 6515c524b0ae50dd5bb052558afa8c81d3a75780 URL: https://github.com/llvm/llvm-project/commit/6515c524b0ae50dd5bb052558afa8c81d3a75780 DIFF: https://github.com/llvm/llvm-project/commit/6515c524b0ae50dd5bb052558afa8c81d3a75780.diff

[PATCH] D71282: Fix bug 44190 - wrong code with #pragma pack(1)

yaxunl marked 2 inline comments as done. yaxunl added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:4008 + if ((!ArgInfo.getIndirectByVal() || + (LV.getAlignment() < getContext().getTypeAlignInChars(I->Ty { NeedCopy = true; ---

[PATCH] D70819: [ASTImporter] Support functions with placeholder return types ...

shafik added a comment. Apologies for wacky C++ code that follows but will this also work for the following cases: auto f2() { auto l = []() { struct X{}; return X(); }; return l(); } auto f3() { if ( struct X{} x; true) return X(); else

[PATCH] D71284: [clangd] Consider () part of the FunctionDecl, not the FunctionTypeLoc

merge_guards_bot added a comment. Build result: pass - 60682 tests passed, 0 failed and 726 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D70256: [FPEnv] clang support for constrained FP builtins

This revision was automatically updated to reflect the committed changes. Closed by commit rG6515c524b0ae: [FPEnv] clang support for constrained FP builtins (authored by kpn). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70256/new/ https://reviews.

  1   2   3   >