[PATCH] D71282: Fix bug 44190 - wrong code with #pragma pack(1)

[Yaxun Liu via Phabricator via cfe-commits]

yaxunl marked 2 inline comments as done.
yaxunl added inline comments.


================
Comment at: clang/lib/CodeGen/CGCall.cpp:4008
+          if ((!ArgInfo.getIndirectByVal() ||
+               (LV.getAlignment() < getContext().getTypeAlignInChars(I->Ty)))) 
{
             NeedCopy = true;
----------------
rjmccall wrote:
> Thanks for the fix.  Please remove all the unnecessary parens, but otherwise 
> LGTM.
fixed


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71282/new/

https://reviews.llvm.org/D71282



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits