[PATCH] D70594: [clangd] Implement range patching heuristics for cross-file rename.

hokein added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:569 +// possible +llvm::Expected> +adjustRenameRanges(llvm::StringRef DraftCode, llvm::StringRef Identifier, sammccall wrote: > why returning Expected rather than Opti

[clang] 6626e5a - Fix compilation warning from GCC7. NFC.

Author: Michael Liao Date: 2019-12-09T10:11:27-05:00 New Revision: 6626e5a06a99b29b388f2dffde2c16f8eb5ded46 URL: https://github.com/llvm/llvm-project/commit/6626e5a06a99b29b388f2dffde2c16f8eb5ded46 DIFF: https://github.com/llvm/llvm-project/commit/6626e5a06a99b29b388f2dffde2c16f8eb5ded46.diff

[PATCH] D71187: [clangd] Delete default arguments while moving functions out-of-line

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/refactor/tweaks/DefineOutline.cpp:199 + // Find the last `=` before the default arg. + for (auto &Tok : llvm::reverse(Token

[PATCH] D70594: [clangd] Implement range patching heuristics for cross-file rename.

merge_guards_bot added a comment. Build result: pass - 60627 tests passed, 0 failed and 726 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D71174: [clang-tidy] new check: bugprone-signed-char-misuse

ztamas updated this revision to Diff 232851. ztamas added a comment. Remove anonymus namespace Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71174/new/ https://reviews.llvm.org/D71174 Files: clang-tools-extra/clang-tidy/bugprone/BugproneTidyModu

[PATCH] D70856: [Syntax] Build nodes for simple cases of top level declarations

merge_guards_bot added a comment. Build result: pass - 60626 tests passed, 0 failed and 726 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D71188: [clangd] Delete ctor initializers while moving functions out-of-line

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/refactor/tweaks/DefineOutline.cpp:269 + } + DeletionRange.setBegin(InitStart); +} kadircet wrote: > ho

[PATCH] D70480: [clangd] Use expansion location when the ref is inside macros.

hokein updated this revision to Diff 232853. hokein added a comment. add a fixme. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70480/new/ https://reviews.llvm.org/D70480 Files: clang-tools-extra/clangd/index/SymbolCollector.cpp clang-tools-ex

[clang-tools-extra] decdbc1 - [clangd] Use expansion location when the ref is inside macros.

Author: Haojian Wu Date: 2019-12-09T16:34:01+01:00 New Revision: decdbc1155f5120554269319b1c77675bac9151c URL: https://github.com/llvm/llvm-project/commit/decdbc1155f5120554269319b1c77675bac9151c DIFF: https://github.com/llvm/llvm-project/commit/decdbc1155f5120554269319b1c77675bac9151c.diff LO

[PATCH] D70568: [Support] Possibly use exception handler in the Crash Recovery Context in the same way as global exceptions

aganea updated this revision to Diff 232854. aganea marked 8 inline comments as done. aganea added a subscriber: vsk. aganea added a comment. Addressed comments, and: - Removed `CrashRecoveryContext::HandleCrash()` and `#pragma clang handle_crash` which wasn't covered by any test and most likely

[PATCH] D70568: [Support] Possibly use exception handler in the Crash Recovery Context in the same way as global exceptions

aganea added inline comments. Comment at: llvm/include/llvm/Support/CrashRecoveryContext.h:26 /// Clients make use of this code by first calling /// CrashRecoveryContext::Enable(), and then executing unsafe operations via a /// CrashRecoveryContext object. For example: ---

[PATCH] D70480: [clangd] Use expansion location when the ref is inside macros.

This revision was automatically updated to reflect the committed changes. Closed by commit rGdecdbc1155f5: [clangd] Use expansion location when the ref is inside macros. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70480/new/

[PATCH] D70480: [clangd] Use expansion location when the ref is inside macros.

merge_guards_bot added a comment. Build result: pass - 60625 tests passed, 0 failed and 726 were skipped. Log files: console-log.txt , CMakeCache.txt

[clang] d97b3e3 - [ARM][MVE] Add intrinsics for immediate shifts.

Author: Simon Tatham Date: 2019-12-09T15:44:09Z New Revision: d97b3e3e65cd77a81b39732af84a1a4229e95091 URL: https://github.com/llvm/llvm-project/commit/d97b3e3e65cd77a81b39732af84a1a4229e95091 DIFF: https://github.com/llvm/llvm-project/commit/d97b3e3e65cd77a81b39732af84a1a4229e95091.diff LOG:

[PATCH] D71065: [ARM][MVE] Add intrinsics for immediate shifts.

This revision was automatically updated to reflect the committed changes. Closed by commit rGd97b3e3e65cd: [ARM][MVE] Add intrinsics for immediate shifts. (authored by simon_tatham). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71065/new/ https://r

[PATCH] D69825: [Clang][Driver] Re-use the calling process instead of creating a new process for the cc1 invocation

aganea added inline comments. Comment at: clang/tools/driver/driver.cpp:313 + llvm::cl::ResetAllOptionOccurrences(); + StringRef Tool = argv[1] + 4; void *GetExecutablePathVP = (void *)(intptr_t) GetExecutablePath; hans wrote: > This feels a little risky to

[PATCH] D69825: [Clang][Driver] Re-use the calling process instead of creating a new process for the cc1 invocation

aganea updated this revision to Diff 232861. aganea marked 4 inline comments as done. aganea added a comment. Herald added a subscriber: mgorny. Herald added a reviewer: jdoerfert. Addressed all comments. Added `CLANG_SPAWN_CC1` cmake flag & environment variable to control whether we want a cc1 p

[PATCH] D71198: [ARM][MVE][Intrinsics] Add VQADDQ, VHADDQ, VRHADDQ, VQSUBQ, VHSUBQ, VQDMULHQ, VQRDMULHQ intrinsics.

dmgreen accepted this revision. dmgreen added a comment. This revision is now accepted and ready to land. Thanks. Looks good to me, if no one else has any comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71198/new/ https://reviews.llvm.org/D

[clang-tools-extra] 891f822 - [clangd] Implement range patching heuristics for cross-file rename.

Author: Haojian Wu Date: 2019-12-09T17:01:05+01:00 New Revision: 891f8bb8436bfd8db0acfbd5f3621fa53425 URL: https://github.com/llvm/llvm-project/commit/891f8bb8436bfd8db0acfbd5f3621fa53425 DIFF: https://github.com/llvm/llvm-project/commit/891f8bb8436bfd8db0acfbd5f3621fa53425.diff LO

[PATCH] D70594: [clangd] Implement range patching heuristics for cross-file rename.

This revision was automatically updated to reflect the committed changes. Closed by commit rG891f8bb8: [clangd] Implement range patching heuristics for cross-file rename. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70594/n

[PATCH] D71179: [OpenMP][WIP] Initial support for `begin/end declare variant`

jdoerfert marked 11 inline comments as done. jdoerfert added inline comments. Comment at: clang/lib/AST/StmtOpenMP.cpp:2243 } + +// TODO: We have various representations for the same data, it might help to ABataev wrote: > jdoerfert wrote: > > This code was basi

[clang] ff4dcee - Fix the compiler warnings: "-Winconsistent-missing-override", "-Wunused-variable"

Author: Haojian Wu Date: 2019-12-09T17:09:07+01:00 New Revision: ff4dceef9201c5ae3924e92f6955977f243ac71d URL: https://github.com/llvm/llvm-project/commit/ff4dceef9201c5ae3924e92f6955977f243ac71d DIFF: https://github.com/llvm/llvm-project/commit/ff4dceef9201c5ae3924e92f6955977f243ac71d.diff LO

[PATCH] D71179: [OpenMP][WIP] Initial support for `begin/end declare variant`

hfinkel added a comment. In D71179#1775157 , @ABataev wrote: > In D71179#1775066 , @hfinkel wrote: > > > In D71179#1774678 , @ABataev wrote: > > > > > In D71179#1774487

[PATCH] D71179: [OpenMP][WIP] Initial support for `begin/end declare variant`

jdoerfert marked 5 inline comments as done. jdoerfert added a comment. > @jdoerfert , how does the ".ompvariant" work with external functions? I see > the part of the spec which says, "The symbol name of a function definition > that appears between a begin declare variant...", but, if we append

[PATCH] D71179: [OpenMP][WIP] Initial support for `begin/end declare variant`

ABataev added a comment. In D71179#1775442 , @jdoerfert wrote: > > @jdoerfert , how does the ".ompvariant" work with external functions? I see > > the part of the spec which says, "The symbol name of a function definition > > that appears between a begin

[PATCH] D71213: [Alignment][NFC] CreateMemSet use MaybeAlign

gchatelet created this revision. gchatelet added a reviewer: courbet. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, nhaehnle, jvesely, arsenm. Herald added projects: clang, LLVM. This is patch is part of a series to introduce an Alignment type. See this thread for context: http

[PATCH] D71179: [OpenMP][WIP] Initial support for `begin/end declare variant`

hfinkel added a comment. In D71179#1775442 , @jdoerfert wrote: > > @jdoerfert , how does the ".ompvariant" work with external functions? I see > > the part of the spec which says, "The symbol name of a function definition > > that appears between a begin

[PATCH] D71000: [AArch64][SVE] Implement intrinsics for non-temporal loads & stores

kmclaughlin updated this revision to Diff 232870. kmclaughlin added a comment. - Set 'Size' to MemoryLocation::UnknownSize for scalable vectors in getMemIntrinsicNode - Ensure MLOAD zeroes inactive lanes by using a zero value for the PassThru in getMaskedLoad CHANGES SINCE LAST ACTION https:

[PATCH] D70157: Align branches within 32-Byte boundary

fedor.sergeev added a comment. In D70157#1775016 , @annita.zhang wrote: > > The point is that we have explicit requirement at the start and we have a > > lowering into 16-byte sequence that we need to be preserved exactly as it > > is. > > Essentially

[PATCH] D71000: [AArch64][SVE] Implement intrinsics for non-temporal loads & stores

kmclaughlin marked 2 inline comments as done. kmclaughlin added inline comments. Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp:6587 + else if (!Size) +Size = MemVT.getStoreSize().getKnownMinSize(); efriedma wrote: > In order for alias analysis

[PATCH] D71198: [ARM][MVE][Intrinsics] Add VQADDQ, VHADDQ, VRHADDQ, VQSUBQ, VHSUBQ, VQDMULHQ, VQRDMULHQ intrinsics.

MarkMurrayARM updated this revision to Diff 232872. MarkMurrayARM added a comment. Address review comment delivered out-of-band. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71198/new/ https://reviews.llvm.org/D71198 Files: clang/include/clang/

[PATCH] D70469: [attributes] [analyzer] Add handle related attributes

xazax.hun updated this revision to Diff 232873. xazax.hun marked 2 inline comments as done. xazax.hun added a comment. - Make sure typedefs are supported. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70469/new/ https://reviews.llvm.org/D70469 Files: clang/include/clang/Basic/Attr.td

[PATCH] D71041: [analyzer][discussion] Talk about escapes

xazax.hun added a comment. Just a cross reference, some of the discussed changes are implemented here: https://reviews.llvm.org/D71152 Hopefully, more will follow. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71041/new/ https://reviews.llvm.org/

[PATCH] D71152: [analyzer] Keep track of escaped locals.

xazax.hun marked an inline comment as done. xazax.hun added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/ProgramState.cpp:48-61 +namespace { +struct EscapedLocals{}; +} // namespace + +template <> +struct ProgramStateTrait : + public ProgramStatePartialTrait> { ---

[clang] 2eb61fa - [ARM][MVE][Intrinsics] Add VMULL[BT]Q_(INT|POLY) intrinsics.

Author: Mark Murray Date: 2019-12-09T17:41:47Z New Revision: 2eb61fa5d68567435c4d0f1dcc0620bd9956edca URL: https://github.com/llvm/llvm-project/commit/2eb61fa5d68567435c4d0f1dcc0620bd9956edca DIFF: https://github.com/llvm/llvm-project/commit/2eb61fa5d68567435c4d0f1dcc0620bd9956edca.diff LOG: [

[PATCH] D71188: [clangd] Delete ctor initializers while moving functions out-of-line

kadircet updated this revision to Diff 232877. kadircet marked an inline comment as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71188/new/ https://reviews.llvm.org/D71188 Files: clang-tools-ex

[PATCH] D71066: [ARM][MVE][Intrinsics] Add VMULL[BT]Q_(INT|POLY) intrinsics.

This revision was automatically updated to reflect the committed changes. Closed by commit rG2eb61fa5d685: [ARM][MVE][Intrinsics] Add VMULL[BT]Q_(INT|POLY) intrinsics. (authored by MarkMurrayARM). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71066/n

[PATCH] D71198: [ARM][MVE][Intrinsics] Add VQADDQ, VHADDQ, VRHADDQ, VQSUBQ, VHSUBQ, VQDMULHQ, VQRDMULHQ intrinsics.

This revision was automatically updated to reflect the committed changes. Closed by commit rGfc3417cb5a9d: [ARM][MVE][Intrinsics] Add VQADDQ, VHADDQ, VRHADDQ, VQSUBQ, VHSUBQ, VQDMULHQ… (authored by MarkMurrayARM). Changed prior to commit: https://reviews.llvm.org/D71198?vs=232872&id=232880#toc

[clang-tools-extra] 898d7a0 - [clangd] Delete default arguments while moving functions out-of-line

Author: Kadir Cetinkaya Date: 2019-12-09T18:52:57+01:00 New Revision: 898d7a0695c577b8cfe3b86b974b71f1ecb3e6c2 URL: https://github.com/llvm/llvm-project/commit/898d7a0695c577b8cfe3b86b974b71f1ecb3e6c2 DIFF: https://github.com/llvm/llvm-project/commit/898d7a0695c577b8cfe3b86b974b71f1ecb3e6c2.dif

[clang-tools-extra] a209a80 - [clangd] Delete ctor initializers while moving functions out-of-line

Author: Kadir Cetinkaya Date: 2019-12-09T18:52:57+01:00 New Revision: a209a8000e17ef3560598a44825747aab2f7914d URL: https://github.com/llvm/llvm-project/commit/a209a8000e17ef3560598a44825747aab2f7914d DIFF: https://github.com/llvm/llvm-project/commit/a209a8000e17ef3560598a44825747aab2f7914d.dif

[PATCH] D71187: [clangd] Delete default arguments while moving functions out-of-line

kadircet updated this revision to Diff 232886. kadircet marked an inline comment as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71187/new/ https://reviews.llvm.org/D71187 Files: clang-tools-ex

[PATCH] D71188: [clangd] Delete ctor initializers while moving functions out-of-line

This revision was automatically updated to reflect the committed changes. Closed by commit rGa209a8000e17: [clangd] Delete ctor initializers while moving functions out-of-line (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7118

[PATCH] D71187: [clangd] Delete default arguments while moving functions out-of-line

This revision was automatically updated to reflect the committed changes. Closed by commit rG898d7a0695c5: [clangd] Delete default arguments while moving functions out-of-line (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7118

[PATCH] D71154: Driver: Don't look for libc++ headers in the install directory on Android.

pcc reopened this revision. pcc added a comment. This revision is now accepted and ready to land. Relanding with a fix for the problem found by @davezarzycki. The test needed to be adjusted to set `--sysroot`, otherwise it will fail in the case where a directory named `/usr/include/c++/v1` or `/

[PATCH] D71187: [clangd] Delete default arguments while moving functions out-of-line

merge_guards_bot added a comment. Build result: pass - 60555 tests passed, 0 failed and 726 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D71185: [DWARF5] Start emitting DW_AT_dwo_name when -gdwarf-5 is specified.

probinson added a comment. Address the inline comments and LGTM. Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp:866 + ? dwarf::DW_AT_dwo_name + : dwarf::DW_AT_GNU_dwo_name; NewCU.addUInt(Di

[PATCH] D71188: [clangd] Delete ctor initializers while moving functions out-of-line

merge_guards_bot added a comment. Build result: pass - 60655 tests passed, 0 failed and 726 were skipped. Log files: console-log.txt , CMakeCache.txt

[clang] bab9849 - Reland 198fbcb8, "Driver: Don't look for libc++ headers in the install directory on Android.", which was reverted in b3249027.

Author: Peter Collingbourne Date: 2019-12-09T10:08:02-08:00 New Revision: bab9849963eb9b9f1fa03900e8c48a7c7d6fc305 URL: https://github.com/llvm/llvm-project/commit/bab9849963eb9b9f1fa03900e8c48a7c7d6fc305 DIFF: https://github.com/llvm/llvm-project/commit/bab9849963eb9b9f1fa03900e8c48a7c7d6fc305

[clang-tools-extra] be7d633 - Magic number checker shouldn't warn on user defined string literals

Author: Tibor Brunner Date: 2019-12-09T13:13:26-05:00 New Revision: be7d633a6fa6ddae6b7f455f5f336555d088c62d URL: https://github.com/llvm/llvm-project/commit/be7d633a6fa6ddae6b7f455f5f336555d088c62d DIFF: https://github.com/llvm/llvm-project/commit/be7d633a6fa6ddae6b7f455f5f336555d088c62d.diff

[PATCH] D67265: [clang-tidy] Magic number checker shouldn't warn on user defined string literals

aaron.ballman closed this revision. aaron.ballman added a comment. Thanks for the patch, I've commit in be7d633a6fa6ddae6b7f455f5f336555d088c62d Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://review

[PATCH] D71154: Driver: Don't look for libc++ headers in the install directory on Android.

This revision was automatically updated to reflect the committed changes. Closed by commit rGbab9849963eb: Reland 198fbcb8, "Driver: Don't look for libc++ headers in the install… (authored by pcc). Changed prior to commit: https://reviews.llvm.org/D71154?vs=232683&id=232892#toc Repository: r

[clang-tools-extra] d0ccd55 - [clangd] also filter out another possible diag from MS ASM syntax

Author: Sam McCall Date: 2019-12-09T19:21:58+01:00 New Revision: d0ccd55151f52992912dbc12d04a027cf5e06d2f URL: https://github.com/llvm/llvm-project/commit/d0ccd55151f52992912dbc12d04a027cf5e06d2f DIFF: https://github.com/llvm/llvm-project/commit/d0ccd55151f52992912dbc12d04a027cf5e06d2f.diff LO

[PATCH] D71082: Allow system header to provide their own implementation of some builtin

serge-sans-paille updated this revision to Diff 232894. serge-sans-paille added a comment. - Be less intrusive in the getBuiltinID() system, just hook inside CGExpr.cpp - Take into account @george.burgess.iv remark on builtins referencing themselves in an override. Add a test case for that scenar

[PATCH] D70052: [clang-tidy] Add misc-mutating-copy check

aaron.ballman accepted this revision. aaron.ballman added a comment. In D70052#1750664 , @gbencze wrote: > In D70052#1749730 , @JonasToth wrote: > > > There is a `ExprMutAnalyzer` that is able to find mutation of ex

[PATCH] D71049: Remove implicit conversion that promotes half to other larger precision types for fp classification builtins

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, insofar as I understand `__fp16` semantics. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71049/new/ https://reviews.llvm.or

[PATCH] D49091: Warn about usage of __has_include/__has_include_next in macro expansions

aaron.ballman added a comment. In D49091#1773190 , @torarnv wrote: > I'm picking this up on the Qt side and removing our wrapper macro. Does this > apply to other cases as well? The standard mentions > `_­_­has_­cpp_­attribute`, but what about `__has_bui

[PATCH] D71185: [DWARF5] Start emitting DW_AT_dwo_name when -gdwarf-5 is specified.

SouraVX updated this revision to Diff 232896. SouraVX added a comment. Thank you Paul, for reviewing this. I've addressed your comments in this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71185/new/ https://reviews.llvm.org/D71185 Files: clang/test/CodeGen/split-debug-ou

[PATCH] D70469: [attributes] [analyzer] Add handle related attributes

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:7424 + ParsedAttr &Attr) { + if (CurType->isFunctionType()) { +State.getSema().Diag(Attr.getLoc(), diag::warn_type_attribute_wrong_type) xazax.hun wrote:

[PATCH] D71179: [OpenMP][WIP] Initial support for `begin/end declare variant`

jdoerfert added a comment. > @jdoerfert , also, do we have tests that can go into the test suite / > libomptarget regression tests demonstrating the collection of problems people > have currently opened bugs on regarding math.h? I recall we still had > problems with host code needing the long-d

[PATCH] D71185: [DWARF5] Start emitting DW_AT_dwo_name when -gdwarf-5 is specified.

probinson accepted this revision. probinson added a comment. This revision is now accepted and ready to land. Yep LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71185/new/ https://reviews.llvm.org/D71185 ___ cfe-commits mailing list cf

[PATCH] D71179: [OpenMP][WIP] Initial support for `begin/end declare variant`

jdoerfert updated this revision to Diff 232902. jdoerfert added a comment. Add one more test sin(long double), and fix some rebase issues Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71179/new/ https://reviews.llvm.org/D71179 Files: clang/inclu

[PATCH] D70268: [clang][clang-scan-deps] Aggregate the full dependency information.

arphaman added inline comments. Comment at: clang/lib/Tooling/DependencyScanning/ModuleDepCollector.cpp:29 + + Ret.push_back("-fno-implicit-modules"); + Ret.push_back("-fno-implicit-module-maps"); @Bigcheese It looks like there's some duplication in argument lo

[PATCH] D71179: [OpenMP][WIP] Initial support for `begin/end declare variant`

hfinkel added a comment. In D71179#1775687 , @jdoerfert wrote: > ... > > >>> We restricted it for now to function definitions so we don't need to define >>> the mangling as you cannot expect linking. (I did this to get it in TR8 >>> while I figured

[PATCH] D71179: [OpenMP][WIP] Initial support for `begin/end declare variant`

merge_guards_bot added a comment. Build result: fail - 60637 tests passed, 24 failed and 726 were skipped. failed: Clang.CXX/dcl_dcl/basic_namespace/namespace_udecl/p11.cpp failed: Clang.CXX/drs/dr5xx.cpp failed: Clang.CXX/modules-ts/basic/basic_def_odr/p6/global-vs-module.cpp failed: Cla

[PATCH] D71179: [OpenMP][WIP] Initial support for `begin/end declare variant`

tra added inline comments. Comment at: clang/lib/Headers/__clang_cuda_cmath.h:72 -#ifndef _OPENMP -__DEVICE__ int fpclassify(float __x) { - return __builtin_fpclassify(FP_NAN, FP_INFINITE, FP_NORMAL, FP_SUBNORMAL, Please keep fpclassify in place. It's been avail

[clang] ec71238 - Fix clang -Wcovered-switch-default after llvmorg-10-init-11484-g6626e5a06a9

Author: Fangrui Song Date: 2019-12-09T11:32:22-08:00 New Revision: ec71238916dec90c2ef9435af5979a345a447575 URL: https://github.com/llvm/llvm-project/commit/ec71238916dec90c2ef9435af5979a345a447575 DIFF: https://github.com/llvm/llvm-project/commit/ec71238916dec90c2ef9435af5979a345a447575.diff

[PATCH] D71091: Make sure that the implicit arguments for direct methods have been setup

liuliu added a comment. We don't use PCH :) I arc patched the latest diff, still have that crash. More strangely, I tried this latest diff on previously simplistic test case and it crashes now: #import @interface SCTestMainEntity : NSObject @property (nonatomic, readonly, direct) i

[PATCH] D71179: [OpenMP][WIP] Initial support for `begin/end declare variant`

jdoerfert updated this revision to Diff 232906. jdoerfert added a comment. minor fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71179/new/ https://reviews.llvm.org/D71179 Files: clang/include/clang/AST/Decl.h clang/include/clang/AST/StmtOpe

[clang] d694594 - [clang][IFS] Allow 2 output files when using -o and -c with clang IFS stubs.

Author: Puyan Lotfi Date: 2019-12-09T14:47:17-05:00 New Revision: d694594d7650571dec40cc0ef9db6087963d62a0 URL: https://github.com/llvm/llvm-project/commit/d694594d7650571dec40cc0ef9db6087963d62a0 DIFF: https://github.com/llvm/llvm-project/commit/d694594d7650571dec40cc0ef9db6087963d62a0.diff L

[PATCH] D70763: [clang][IFS] Allow 2 output files when using -o and -c with clang IFS stubs.

This revision was automatically updated to reflect the committed changes. Closed by commit rGd694594d7650: [clang][IFS] Allow 2 output files when using -o and -c with clang IFS stubs. (authored by plotfi). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D70696: [DebugInfo] Support to emit debugInfo for extern variables

yonghong-song added a comment. @Jac1494 Based on early discussion, we cannot just issue debuginfo for externs when -g is specified as this may cause debuginfo (and final binary) size bloat. One possible way is to enable it when `-fstandalone-debug` is specified. @dblaikie can you comment on thi

[PATCH] D71179: [OpenMP][WIP] Initial support for `begin/end declare variant`

merge_guards_bot added a comment. Build result: fail - 60641 tests passed, 20 failed and 726 were skipped. failed: Clang.CXX/dcl_dcl/basic_namespace/namespace_udecl/p11.cpp failed: Clang.CXX/drs/dr5xx.cpp failed: Clang.CXX/modules-ts/basic/basic_def_odr/p6/global-vs-module.cpp failed: Cla

[PATCH] D71221: [HIP] Add option --gpu-max-threads-per-block=n

yaxunl created this revision. yaxunl added a reviewer: tra. Herald added subscribers: nhaehnle, jvesely. Add this option to change the default launch bounds. https://reviews.llvm.org/D71221 Files: clang/include/clang/Basic/LangOptions.def clang/include/clang/Driver/Options.td clang/lib/Co

[PATCH] D71179: [OpenMP][WIP] Initial support for `begin/end declare variant`

ABataev added a comment. In D71179#1775687 , @jdoerfert wrote: > > @jdoerfert , also, do we have tests that can go into the test suite / > > libomptarget regression tests demonstrating the collection of problems > > people have currently opened bugs on r

[clang] 56bba01 - [c++20] Fix incorrect assumptions in checks for comparison category types.

Author: Richard Smith Date: 2019-12-09T12:18:33-08:00 New Revision: 56bba012d9729af8ff4252dc860f1f7696942f1a URL: https://github.com/llvm/llvm-project/commit/56bba012d9729af8ff4252dc860f1f7696942f1a DIFF: https://github.com/llvm/llvm-project/commit/56bba012d9729af8ff4252dc860f1f7696942f1a.diff

[PATCH] D71179: [OpenMP][WIP] Initial support for `begin/end declare variant`

jdoerfert added inline comments. Comment at: clang/lib/Headers/__clang_cuda_cmath.h:72 -#ifndef _OPENMP -__DEVICE__ int fpclassify(float __x) { - return __builtin_fpclassify(FP_NAN, FP_INFINITE, FP_NORMAL, FP_SUBNORMAL, tra wrote: > Please keep fpclassify in pla

[PATCH] D71179: [OpenMP][WIP] Initial support for `begin/end declare variant`

jdoerfert updated this revision to Diff 232909. jdoerfert marked 6 inline comments as done. jdoerfert added a comment. Undo math function removal (fpclassify & scalblnf), reorder includes (host first) The latter is the "natural way" but also necessary because fpclassify uses macros and we did not

[PATCH] D71140: [Wdocumentation] Properly place deprecated attribute

Mordante marked 2 inline comments as done. Mordante added inline comments. Comment at: clang/test/Sema/warn-documentation-fixits.cpp:4 +// RUN: %clang_cc1 -std=c++14 -fsyntax-only -Wdocumentation -Wdocumentation-pedantic -fcomment-block-commands=foobar -fdiagnostics-parseable-f

[PATCH] D71091: Make sure that the implicit arguments for direct methods have been setup

MadCoder added a comment. In D71091#1775722 , @liuliu wrote: > We don't use PCH :) I arc patched the latest diff, still have that crash. > More strangely, I tried this latest diff on previously simplistic test case > and it crashes now: > > #import >

[PATCH] D71179: [OpenMP][WIP] Initial support for `begin/end declare variant`

jdoerfert added a comment. >> This is neither true, nor relevant. It is not true because OpenMP 5.0 >> declare variant is so broken it cannot be used for what it was intended for. >> That means people (as for example we for math) will inevitably use begin/end >> declare variant. > > I rather d

[PATCH] D69764: [clang-format] Add Left/Right Const (East/West , Before/After) fixer capability

ilya added a comment. In D69764#1732235 , @aaron.ballman wrote: > I like the functionality, but am slightly opposed to using "east/west" > terminology -- that's not a ubiquitous phrase and it takes a bit of thinking > before it makes sense. I think "lef

[PATCH] D71179: [OpenMP][WIP] Initial support for `begin/end declare variant`

merge_guards_bot added a comment. Build result: fail - 60639 tests passed, 24 failed and 726 were skipped. failed: Clang.CXX/dcl_dcl/basic_namespace/namespace_udecl/p11.cpp failed: Clang.CXX/drs/dr5xx.cpp failed: Clang.CXX/modules-ts/basic/basic_def_odr/p6/global-vs-module.cpp failed: Cla

[clang] 505aa24 - [Attr] Move ParsedTargetAttr out of the TargetAttr class

Author: Craig Topper Date: 2019-12-09T12:40:41-08:00 New Revision: 505aa2410db6d089279da1a271903ce2633764f6 URL: https://github.com/llvm/llvm-project/commit/505aa2410db6d089279da1a271903ce2633764f6 DIFF: https://github.com/llvm/llvm-project/commit/505aa2410db6d089279da1a271903ce2633764f6.diff

[PATCH] D71000: [AArch64][SVE] Implement intrinsics for non-temporal loads & stores

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:10800 +MINode->getOperand(3), DAG.getUNDEF(LoadVT), +

[PATCH] D69764: [clang-format] Add Left/Right Const (East/West , Before/After) fixer capability

MyDeveloperDay added a comment. In D69764#1775835 , @ilya wrote: > In D69764#1732235 , @aaron.ballman > wrote: > > > I like the functionality, but am slightly opposed to using "east/west" > > terminology -- that's

[PATCH] D71141: [Wdocumentation] Use C2x/C++14 deprecated attribute

Mordante marked 5 inline comments as done. Mordante added a comment. Thanks for your review of this set of patches! Comment at: clang/lib/AST/CommentSema.cpp:698 + // - In C2x/C++14 we prefer [[deprecated]] + // - If not found or an older C/C++ look for __attribute__(

[PATCH] D71159: [Attr] Move ParsedTargetAttr out of the TargetAttr class

This revision was automatically updated to reflect the committed changes. Closed by commit rG505aa2410db6: [Attr] Move ParsedTargetAttr out of the TargetAttr class (authored by craig.topper). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D71179: [OpenMP][WIP] Initial support for `begin/end declare variant`

ABataev added a comment. In D71179#1775834 , @jdoerfert wrote: > >> This is neither true, nor relevant. It is not true because OpenMP 5.0 > >> declare variant is so broken it cannot be used for what it was intended > >> for. That means people (as for exa

[PATCH] D70973: [OPENMP50]Treat context selectors as expressions, not just strings.

ABataev updated this revision to Diff 232917. ABataev added a comment. Herald added subscribers: s.egerton, simoncook, fedor.sergeev, aheejin, rampitec. Reworked attribute translationto try to reuse the context matching and scoring functionality with Sema. Repository: rG LLVM Github Monorepo

[clang] 1164d43 - Include Stmt.h where it seems to be necessary for modules builds

Author: Reid Kleckner Date: 2019-12-09T13:08:44-08:00 New Revision: 1164d43855fd5b58fde221445ab0e407c0bd92ee URL: https://github.com/llvm/llvm-project/commit/1164d43855fd5b58fde221445ab0e407c0bd92ee DIFF: https://github.com/llvm/llvm-project/commit/1164d43855fd5b58fde221445ab0e407c0bd92ee.diff

[PATCH] D71222: Include Stmt.h where it seems to be necessary for modules builds

rdhindsa accepted this revision. rdhindsa added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71222/new/ https://reviews.llvm.org/D71222 ___

[PATCH] D71222: Include Stmt.h where it seems to be necessary for modules builds

This revision was automatically updated to reflect the committed changes. Closed by commit rG1164d43855fd: Include Stmt.h where it seems to be necessary for modules builds (authored by rnk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71222/new/ h

[PATCH] D71222: Include Stmt.h where it seems to be necessary for modules builds

rnk created this revision. rnk added a reviewer: rdhindsa. Herald added a project: clang. rdhindsa accepted this revision. rdhindsa added a comment. This revision is now accepted and ready to land. LGTM After 60573ae6fe50 rem

[PATCH] D71224: [analyzer][WIP] Escape symbols stored into specific region after a conservative evalcall.

xazax.hun created this revision. xazax.hun added reviewers: NoQ, dcoughlin, Szelethus, baloghadamsoftware, haowei. xazax.hun added a project: clang. Herald added subscribers: Charusso, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet. xazax.hun marked an inline comment

[PATCH] D70973: [OPENMP50]Treat context selectors as expressions, not just strings.

merge_guards_bot added a comment. Build result: pass - 60659 tests passed, 0 failed and 726 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D71224: [analyzer][WIP] Escape symbols stored into specific region after a conservative evalcall.

xazax.hun marked an inline comment as done. xazax.hun added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/CheckerManager.h:402 + InvalidatedSymbols *IS, + RegionAndSymbolInvalidationTraits *ETraits, +

[PATCH] D71224: [analyzer][WIP] Escape symbols stored into specific region after a conservative evalcall.

xazax.hun marked an inline comment as done. xazax.hun added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/ExprEngineCallAndReturn.cpp:696 // And make the result node. Bldr.generateNode(Call.getProgramPoint(), State, Pred); } After some offline

[PATCH] D71227: [cuda][hip] Fix function overload resolution in the global initiailizer.

hliao updated this revision to Diff 232933. hliao added a comment. refine commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71227/new/ https://reviews.llvm.org/D71227 Files: clang/include/clang/Sema/Sema.h clang/lib/Parse/ParseDecl.

[PATCH] D71226: Also synthesize _cmd and self for properties

MadCoder added a comment. @liuliu that fixes your test case (which I reproduced in the CG test) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71226/new/ https://reviews.llvm.org/D71226 ___ cfe-commits

[PATCH] D71227: [cuda][hip] Fix function overload resolution in the global initiailizer.

hliao created this revision. hliao added reviewers: tra, jlebar, yaxunl. Herald added a project: clang. Herald added a subscriber: cfe-commits. hliao updated this revision to Diff 232933. hliao added a comment. hliao edited the summary of this revision. refine commit message - As global initiali

<    1   2   3   4   >