[PATCH] D70958: [compiler-rt] [test] Disable ASLR on ASAN/MSAN/TSAN tests on NetBSD

mgorny updated this revision to Diff 232270. mgorny added a comment. Updated to pass the 'prefix' via `config` object from common, and to use full path for paxctl. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70958/new/ https://reviews.llvm.org/D70958 Files: compiler-rt/test/asan/l

[PATCH] D71029: [clangd] (take 2) Try harder to find a plausible `clang` as argv0, particularly on Mac.

sammccall updated this revision to Diff 232274. sammccall marked 5 inline comments as done. sammccall added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71029/new/ https://reviews.llvm.org/D71029 Files: clang-

[PATCH] D71029: [clangd] (take 2) Try harder to find a plausible `clang` as argv0, particularly on Mac.

sammccall added a comment. Thanks for looking at this Jan, I should have put you on the reviewers in the first place... Comment at: clang-tools-extra/clangd/CompileCommands.cpp:53 + } + StringRef Path = Buf->get()->getBuffer().trim(); + if (Path.empty()) {

[PATCH] D71050: [clangd] More unittests for cross-file rename.

hokein created this revision. hokein added reviewers: ilya-biryukov, kbobyrev. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. The previous unittests for cross-file rename was kind of weak. With this patch, we should have more test coverage

[PATCH] D71029: [clangd] (take 2) Try harder to find a plausible `clang` as argv0, particularly on Mac.

merge_guards_bot added a comment. Build result: pass - 60480 tests passed, 0 failed and 726 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D71029: [clangd] (take 2) Try harder to find a plausible `clang` as argv0, particularly on Mac.

sammccall marked an inline comment as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/CompileCommands.cpp:65 + if (llvm::sys::fs::real_path(Path, Resolved)) +return Path; // On error; + return Resolved.str(); sammccall wrote: > j

[clang-tools-extra] 60d7e72 - [clangd] Fix an incorrect comment, NFC.

Author: Haojian Wu Date: 2019-12-05T10:43:29+01:00 New Revision: 60d7e723e3ac5223f1a2f6594a93a9fdfb3e69a7 URL: https://github.com/llvm/llvm-project/commit/60d7e723e3ac5223f1a2f6594a93a9fdfb3e69a7 DIFF: https://github.com/llvm/llvm-project/commit/60d7e723e3ac5223f1a2f6594a93a9fdfb3e69a7.diff LO

[PATCH] D70524: Support DebugInfo generation for auto return type for C++ functions.

awpandey updated this revision to Diff 232281. awpandey marked 5 inline comments as done. awpandey added a comment. Hi @aprantl, I used variable as shown by you for showing links between the node. @dblaikie I have shortened the test case based on your suggestions. There were no test case for che

[PATCH] D71050: [clangd] More unittests for cross-file rename.

merge_guards_bot added a comment. Build result: pass - 60480 tests passed, 0 failed and 726 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D69948: [Checkers] Added support for freopen to StreamChecker.

This revision was automatically updated to reflect the committed changes. Closed by commit rG7eafde981c69: [Checkers] Added support for freopen to StreamChecker. (authored by balazske). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69948/new/ https:

[PATCH] D70864: update trailing newline treatment in clang-format.py

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70864/new/ https://reviews.llvm.org/D70864 ___ cfe-commits mailing li

[PATCH] D70765: LTOVisibility.rst: fix up syntax in example

dankamongmen added a comment. Thanks, @pcc! Is there anything I need to do, or am I just waiting on someone to merge this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70765/new/ https://reviews.llvm.org/D70765

[PATCH] D34252: Add arbitrary file/path support to clang-format style file selection

MyDeveloperDay added a comment. I recently hit this issue where I was clang-formatting generated code out of a source tree, which was then copied into a source tree. This failed my post build clang-format validation check and I couldn't understand why. it was only later I realised that unless I

[PATCH] D71050: [clangd] More unittests for cross-file rename.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71050/new/ https://reviews.llvm.org/D71050 _

[clang] 41eeded - Fix the clang interpreter example which was broken by 4fc68b9b7f3e0.

Author: Lang Hames Date: 2019-12-05T02:42:35-08:00 New Revision: 41eeded804310df0719ecbc92a0e14b438213dbf URL: https://github.com/llvm/llvm-project/commit/41eeded804310df0719ecbc92a0e14b438213dbf DIFF: https://github.com/llvm/llvm-project/commit/41eeded804310df0719ecbc92a0e14b438213dbf.diff LO

[PATCH] D71029: [clangd] (take 2) Try harder to find a plausible `clang` as argv0, particularly on Mac.

kbobyrev added a comment. In D71029#1769416 , @sammccall wrote: > @kbobyrev would you mind verifying this version of the patch also works? > I don't expect changes vs the last one: it's been restructured a lot but the > logic should be the same. I can

[PATCH] D70524: Support DebugInfo generation for auto return type for C++ functions.

awpandey marked an inline comment as done. awpandey added a comment. > It looks to me like there are a few tests for unspecified_type already: > > $ grep -r unspecified_type llvm/test > llvm/test/Assembler/debug-info.ll:; CHECK-NEXT: !7 = !DIBasicType(tag: > DW_TAG_unspecified_type, name: "decl

[PATCH] D71005: [AST] Enable expression of OpenCL language address spaces an attribute

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! I presume OpenCL addr space logic won't apply in all cases in non-OpenCL compilations i.e. for example C++ because we enclose some of the logic under LangOpts checks. Re

[clang-tools-extra] 158356b - [clangd] More unittests for cross-file rename.

Author: Haojian Wu Date: 2019-12-05T12:11:52+01:00 New Revision: 158356b82b8a2fa8f1cb12a3735274f6a6c3c5f2 URL: https://github.com/llvm/llvm-project/commit/158356b82b8a2fa8f1cb12a3735274f6a6c3c5f2 DIFF: https://github.com/llvm/llvm-project/commit/158356b82b8a2fa8f1cb12a3735274f6a6c3c5f2.diff LO

[PATCH] D70974: [clang-tidy] Fix PR26274

alexfh updated this revision to Diff 232294. alexfh marked 2 inline comments as done. alexfh added a comment. - Added a test with an empty attribute list. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70974/new/ https://reviews.llvm.org/D70974 Fil

[PATCH] D70974: [clang-tidy] Fix PR26274

alexfh added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/NamespaceCommentCheck.cpp:79 + } else { // Any other kind of token is unexpected here. +return llvm::None; + } aaron.ballman wrote: > How well do these test case

[PATCH] D71005: [AST] Enable expression of OpenCL language address spaces an attribute

bader marked an inline comment as done. bader added a comment. In D71005#1770338 , @Anastasia wrote: > LGTM! Thanks! > > I presume OpenCL addr space logic won't apply in all cases in non-OpenCL > compilations i.e. for example C++ because we enclose some o

[PATCH] D71050: [clangd] More unittests for cross-file rename.

This revision was automatically updated to reflect the committed changes. Closed by commit rG158356b82b8a: [clangd] More unittests for cross-file rename. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71050/new/ https://reviews.

[PATCH] D70974: [clang-tidy] Fix PR26274

merge_guards_bot added a comment. Build result: pass - 60438 tests passed, 0 failed and 726 were skipped. Log files: console-log.txt , CMakeCache.txt

[clang] 7f9b513 - Reapply af57dbf12e54 "Add support for options -frounding-math, ftrapping-math, -ffp-model=, and -ffp-exception-behavior="

Author: Melanie Blower Date: 2019-12-05T03:48:04-08:00 New Revision: 7f9b5138470db1dc58f3bc05631284c653c9ed7a URL: https://github.com/llvm/llvm-project/commit/7f9b5138470db1dc58f3bc05631284c653c9ed7a DIFF: https://github.com/llvm/llvm-project/commit/7f9b5138470db1dc58f3bc05631284c653c9ed7a.diff

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

mibintc added a comment. I fixed the lit test problem and pushed it again commit 7f9b5138470db1dc58f3bc05631284c653c9ed7a Author: Melanie Blower Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D71015: [OpenCL] Handle address space conversions for constexpr (PR44177)

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71015/new/ https://reviews.llvm.org/D71015 ___

[PATCH] D71001: [clang-tidy] New check: bugprone-misplaced-pointer-arithmetic-in-alloc

MyDeveloperDay added a comment. Drive by comment: (I have no vested interested other than seeing cool new checkers) FWIW, I work on a system with a multi million line legacy 25+ years old C++ codebase, where we now have clang-tidy integrated into a CI system and we have > 100,000 firings of cl

[clang] 11a9bae - [AST] Enable expression of OpenCL language address spaces an attribute

Author: Victor Lomuller Date: 2019-12-05T12:24:06+03:00 New Revision: 11a9bae8f66986751078501988b4414f24dbe37e URL: https://github.com/llvm/llvm-project/commit/11a9bae8f66986751078501988b4414f24dbe37e DIFF: https://github.com/llvm/llvm-project/commit/11a9bae8f66986751078501988b4414f24dbe37e.dif

[PATCH] D71005: [AST] Enable expression of OpenCL language address spaces an attribute

This revision was automatically updated to reflect the committed changes. Closed by commit rG11a9bae8f669: [AST] Enable expression of OpenCL language address spaces an attribute (authored by Naghasan, committed by bader). Changed prior to commit: https://reviews.llvm.org/D71005?vs=232098&id=232

[PATCH] D70615: Add an -fno-temp-file flag for compilation

hans added a comment. Seems fine to me. I'm not sure how to test the actual "don't write to temp file" functionality, but at least there could be a test to check that the flag gets forwarded to cc1. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70

[PATCH] D70974: [clang-tidy] Fix PR26274

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM, thanks for the fixes! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70974/new/ https://reviews.llvm.org/D70974 ___ cfe-commits

[PATCH] D71005: [AST] Enable expression of OpenCL language address spaces an attribute

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1123 def OpenCLPrivateAddressSpace : TypeAttr { - let Spellings = [Keyword<"__private">, Keyword<"private">]; + let Spellings = [Keyword<"__private">, Keyword<"private">, Clang<"opencl_private"

[clang] 18b72d3 - Also check /Fo when deciding on the .gcna / .gcda filename (PR44208)

Author: Hans Wennborg Date: 2019-12-05T13:57:04+01:00 New Revision: 18b72d337ef31bc4f1b898ceb17796ffe12dd104 URL: https://github.com/llvm/llvm-project/commit/18b72d337ef31bc4f1b898ceb17796ffe12dd104 DIFF: https://github.com/llvm/llvm-project/commit/18b72d337ef31bc4f1b898ceb17796ffe12dd104.diff

[PATCH] D71012: Also check /Fo when deciding on the .gcna / .gcda filename (PR44208)

This revision was automatically updated to reflect the committed changes. Closed by commit rG18b72d337ef3: Also check /Fo when deciding on the .gcna / .gcda filename (PR44208) (authored by hans). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D71005: [AST] Enable expression of OpenCL language address spaces an attribute

bader marked an inline comment as done. bader added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1123 def OpenCLPrivateAddressSpace : TypeAttr { - let Spellings = [Keyword<"__private">, Keyword<"private">]; + let Spellings = [Keyword<"__private">, Keyword<"pr

[PATCH] D71005: [AST] Enable expression of OpenCL language address spaces an attribute

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1123 def OpenCLPrivateAddressSpace : TypeAttr { - let Spellings = [Keyword<"__private">, Keyword<"private">]; + let Spellings = [Keyword<"__private">, Keyword<"private">, Clang<"opencl_private"

[PATCH] D70849: [AST] Traverse the class type loc inside the member pointer type loc.

hokein updated this revision to Diff 232323. hokein added a comment. use the assertion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70849/new/ https://reviews.llvm.org/D70849 Files: clang-tools-extra/clangd/unittests/SemanticHighlightingTests.

[PATCH] D70849: [AST] Traverse the class type loc inside the member pointer type loc.

hokein marked an inline comment as done. hokein added inline comments. Comment at: clang/include/clang/AST/RecursiveASTVisitor.h:1168 DEF_TRAVERSE_TYPELOC(MemberPointerType, { - TRY_TO(TraverseType(QualType(TL.getTypePtr()->getClass(), 0))); + if (auto *TSI = TL.getClassTInfo(

[PATCH] D70849: [AST] Traverse the class type loc inside the member pointer type loc.

merge_guards_bot added a comment. Build result: pass - 60507 tests passed, 0 failed and 726 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D70849: [AST] Traverse the class type loc inside the member pointer type loc.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70849/new/ https://reviews.llvm.org/D70849 _

[PATCH] D70342: [Diagnostics] Put "deprecated copy" warnings into -Wdeprecated-copy

thakis added a comment. Why do we emit this before C++20? It's only deprecated in C++20 onwards, no? Shouldn't this be default-enabled based off language version instead of being in -Wextra? No other language deprecation warning so far (register etc) has worked like this warning does. (Also, t

[PATCH] D70342: [Diagnostics] Put "deprecated copy" warnings into -Wdeprecated-copy

thakis added a comment. Ah, Hans points out that the paper says that it's been deprecated in C++11, so this should either be on by default (and mention "C++11" somewhere), or it should be in -pedantic given that no other compiler diagnoses this and given that it fires heavily on existing code (

[PATCH] D70615: Add an -fno-temp-file flag for compilation

thakis added a comment. In D70615#1769751 , @rnk wrote: > +more reviewers > > This doesn't add any code complexity, we already have the boolean UseTempFile > flag, so I think we should do this. I would also point out that right now, in > my LLVM build di

[PATCH] D71063: [clangd] New rendering structs

kadircet added a comment. Note that I am planning to add more tests, sending out for review to get some initial feedback on the design. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71063/new/ https://reviews.llvm.org/D71063 ___

[PATCH] D71063: [clangd] New rendering structs

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. kadircet added a comment. kadircet added a parent revision: D70911: [clangd] Switch Hover.All to struct

[clang-tools-extra] 7f93cb6 - [AST] Traverse the class type loc inside the member type loc.

Author: Haojian Wu Date: 2019-12-05T15:03:30+01:00 New Revision: 7f93cb62280a73e3e899d49c45be8bfbac634b7d URL: https://github.com/llvm/llvm-project/commit/7f93cb62280a73e3e899d49c45be8bfbac634b7d DIFF: https://github.com/llvm/llvm-project/commit/7f93cb62280a73e3e899d49c45be8bfbac634b7d.diff LO

[PATCH] D71063: [clangd] New rendering structs

kadircet updated this revision to Diff 232332. kadircet added a comment. - Move function definitions to source file, via define out-of-line :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71063/new/ https://reviews.llvm.org/D71063 Files: clang-

[PATCH] D70849: [AST] Traverse the class type loc inside the member pointer type loc.

This revision was automatically updated to reflect the committed changes. Closed by commit rG7f93cb62280a: [AST] Traverse the class type loc inside the member type loc. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70849/new/ h

[PATCH] D71065: [ARM][MVE] Add intrinsics for immediate shifts.

simon_tatham created this revision. simon_tatham added reviewers: dmgreen, miyuki, MarkMurrayARM, ostannard. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, kristof.beyls. Herald added projects: clang, LLVM. This adds the family of `vshlq_n` and `vshrq_n` ACLE intrinsics, which shi

[PATCH] D71018: [ASTImporter] Improved import of TypeSourceInfo (TypeLoc)

martong updated this revision to Diff 232336. martong added a comment. IMPORT -> IMPORT_TYPE_LOC Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71018/new/ https://reviews.llvm.org/D71018 Files: clang/lib/AST/ASTImporter.cpp Index: clang/lib/AST/

[clang-tools-extra] 01e5290 - [clangd] Simplify the code, NFC.

Author: Haojian Wu Date: 2019-12-05T15:32:14+01:00 New Revision: 01e5290b49bd2a8753c685bb5f02596989a31754 URL: https://github.com/llvm/llvm-project/commit/01e5290b49bd2a8753c685bb5f02596989a31754 DIFF: https://github.com/llvm/llvm-project/commit/01e5290b49bd2a8753c685bb5f02596989a31754.diff LO

[PATCH] D71062: [ARM][MVE] Add vector reduction intrinsics with two vector operands

merge_guards_bot added a comment. Build result: pass - 60516 tests passed, 0 failed and 726 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D71063: [clangd] New rendering structs

merge_guards_bot added a comment. Build result: pass - 60511 tests passed, 0 failed and 726 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D70342: [Diagnostics] Put "deprecated copy" warnings into -Wdeprecated-copy

xbolva00 added a comment. No other compiler ? GCC 9 introduced it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70342/new/ https://reviews.llvm.org/D70342 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D70500: [WebAssembly] Enable use of wasm-opt and LTO-enabled system libraries

thakis added a comment. (sorry for the slow response here) >> If you need to run an external program, look for it next to the compiler, >> like we do for gas with -fno-integrated-as, linker, etc. People can use the >> existing -B flag to make clang look elsewhere if they need that. > > Unfortu

[PATCH] D71063: [clangd] New rendering structs

merge_guards_bot added a comment. Build result: pass - 60512 tests passed, 0 failed and 726 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D71005: [AST] Enable expression of OpenCL language address spaces an attribute

bader added a comment. >>> is there a reason this should be clang::opencl_private as opposed to >>> opencl::private? >> >> I'm okay with [[opencl::private]] as well. I have only one problem - >> currently OpenCL address spaces are exposed as keywords and using them in >> C++ breaks valid C++ c

[PATCH] D70524: Support DebugInfo generation for auto return type for C++ functions.

dblaikie added a comment. In D70524#1770330 , @awpandey wrote: > > It looks to me like there are a few tests for unspecified_type already: > > > > $ grep -r unspecified_type llvm/test > > llvm/test/Assembler/debug-info.ll:; CHECK-NEXT: !7 = !DIBasicType(

[PATCH] D70500: [WebAssembly] Enable use of wasm-opt and LTO-enabled system libraries

thakis added a comment. (ps: Thanks for the two changes landed so far!) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70500/new/ https://reviews.llvm.org/D70500 ___ cfe-commits mailing list cfe-commits

[PATCH] D71066: [ARM][MVE][Intrinsics] Add VMULH/VRMULH intrinsics.

MarkMurrayARM created this revision. MarkMurrayARM added reviewers: simon_tatham, ostannard, dmgreen. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, kristof.beyls. Herald added projects: clang, LLVM. Add VMULH/VRMULH intrinsics and unit tests. Repository: rG LLVM Github Monore

[PATCH] D70342: [Diagnostics] Put "deprecated copy" warnings into -Wdeprecated-copy

thakis added a comment. Re-re-reading http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2018/p0619r4.html#3.2, the recommendation is "We will consider again for C++23". So I think this should be enabled with -std=c++20 at the earliest, since that's where the idea is from. But even there it's

[clang] 853961f - [OPENMP50]Add support for if clause for simd part in master taskloop simd directive.

Author: Alexey Bataev Date: 2019-12-05T10:12:20-05:00 New Revision: 853961f21a6d07352204eb4820a93eab87ba0057 URL: https://github.com/llvm/llvm-project/commit/853961f21a6d07352204eb4820a93eab87ba0057 DIFF: https://github.com/llvm/llvm-project/commit/853961f21a6d07352204eb4820a93eab87ba0057.diff

[PATCH] D71029: [clangd] (take 2) Try harder to find a plausible `clang` as argv0, particularly on Mac.

sammccall added a comment. Thanks. Can someone approve the patch and I'll land it again :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71029/new/ https://reviews.llvm.org/D71029 ___ cfe-commits mail

[PATCH] D71029: [clangd] (take 2) Try harder to find a plausible `clang` as argv0, particularly on Mac.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71029/new/ https://reviews.llvm.org/D71029 _

[clang] 242649c - [Syntax] Show input code on tests failures. NFC

Author: Ilya Biryukov Date: 2019-12-05T16:25:35+01:00 New Revision: 242649c17c5b11bcc788b6f69bd3eed44cfd3d79 URL: https://github.com/llvm/llvm-project/commit/242649c17c5b11bcc788b6f69bd3eed44cfd3d79 DIFF: https://github.com/llvm/llvm-project/commit/242649c17c5b11bcc788b6f69bd3eed44cfd3d79.diff

[PATCH] D70763: [clang][IFS] Allow 2 output files when using -o and -c with clang IFS stubs.

cishida marked an inline comment as done. cishida added inline comments. Comment at: clang/test/InterfaceStubs/driver-test3.c:6 +// RUN: %clang -target x86_64-unknown-linux-gnu -c -emit-interface-stubs %s -o %t/driver-test3.o +// RUN: cat %t/driver-test3.ifs | FileCheck %s + ---

[PATCH] D45444: [clang-tidy] implement new check for const-correctness

JonasToth added a comment. > Are you going to keep updating it on > https://github.com/JonasToth/llvm-project/commits/feature_check_const ? Yup, thats my backup if something goes wrong and to synchronize my pcs. :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D70987: [AMDGPU][HIP] Improve opt-level handling

scott.linder updated this revision to Diff 232346. scott.linder added a comment. Update other toolchain tests I had missed, and address feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70987/new/ https://reviews.llvm.org/D70987 Files: cla

[PATCH] D70157: Align branches within 32-Byte boundary

skan added a comment. In D70157#1769932 , @MaskRay wrote: > I find another deficiency (infinite loop) with the current approach. > > Say, there is a `je 0` (0x0F 0x84 0x00 0x00 0x00 0x00) at byte 0x90. > (0x90+6)%32 == 0, so it ends on a 32-byte boundary.

[PATCH] D70638: [Diagnostic] add a warning which warns about misleading indentation

thakis added a comment. Hey, cool! I gave this a shot myself many years ago at http://llvm.org/bugs/show_bug.cgi?id=18938 That bug has a list of interesting test cases I had collected back then. Maybe you want to check and see how this does on those cases? Repository: rG LLVM Github Monorep

[clang] c3279be - [OPENMP][DOCS]Update list of the supported features, NFC.

Author: Alexey Bataev Date: 2019-12-05T10:44:37-05:00 New Revision: c3279beded97bbc00307b59f91a9a98e2ae417a7 URL: https://github.com/llvm/llvm-project/commit/c3279beded97bbc00307b59f91a9a98e2ae417a7 DIFF: https://github.com/llvm/llvm-project/commit/c3279beded97bbc00307b59f91a9a98e2ae417a7.diff

[PATCH] D70638: [Diagnostic] add a warning which warns about misleading indentation

thakis added a comment. Also, did you check if this has a measurable impact on compilation speed? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70638/new/ https://reviews.llvm.org/D70638 ___ cfe-commit

[PATCH] D71001: [clang-tidy] New check: bugprone-misplaced-pointer-arithmetic-in-alloc

whisperity added a comment. While I can't pitch in with actual findings of this check, @MyDeveloperDay, you're right in many aspects, including those specific examples //not// firing. But an example that actually fires this check indicates a very specific **undefined behaviour** case. So if suc

[PATCH] D70157: Align branches within 32-Byte boundary

skan marked 3 inline comments as done. skan added inline comments. Comment at: llvm/test/MC/X86/x86-64-align-branch-1b.s:10 +# CHECK: foo: +# CHECK-NEXT:0: 64 89 04 25 01 00 00 00 movl%eax, %fs:1 +# CHECK-NEXT:8: 2e 55

[PATCH] D71005: [AST] Enable expression of OpenCL language address spaces an attribute

aaron.ballman added a comment. In D71005#1770760 , @bader wrote: > >>> is there a reason this should be clang::opencl_private as opposed to > >>> opencl::private? > >> > >> I'm okay with [[opencl::private]] as well. I have only one problem - > >> curren

[PATCH] D70500: [WebAssembly] Enable use of wasm-opt and LTO-enabled system libraries

sbc100 added a comment. The first option seems reasonable to me. That is, adding a flag that controls whether the PATH is searched for all tools. Hermetic builds would then pass this flag to prevent PATH from playing any role. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] d96ea47 - [AMDGPU][HIP] Improve opt-level handling

Author: Scott Linder Date: 2019-12-05T11:27:12-05:00 New Revision: d96ea47c75fdf4a62358eae49a0026bcf031bde6 URL: https://github.com/llvm/llvm-project/commit/d96ea47c75fdf4a62358eae49a0026bcf031bde6 DIFF: https://github.com/llvm/llvm-project/commit/d96ea47c75fdf4a62358eae49a0026bcf031bde6.diff

[PATCH] D71062: [ARM][MVE] Add vector reduction intrinsics with two vector operands

MarkMurrayARM added inline comments. Comment at: clang/include/clang/Basic/arm_mve_defs.td:448 +// for example (u32 x) where x is 0 is transformed into (u32 { 0 }) by the +// Tablegen parser. +def V { See D71066; I just used the numbers bare, so 0 or 1 not (u32 0

[PATCH] D70987: [AMDGPU][HIP] Improve opt-level handling

This revision was automatically updated to reflect the committed changes. Closed by commit rGd96ea47c75fd: [AMDGPU][HIP] Improve opt-level handling (authored by scott.linder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70987/new/ https://reviews.

[PATCH] D71066: [ARM][MVE][Intrinsics] Add VMULL[BT]Q_(INT|POLY) intrinsics.

MarkMurrayARM updated this revision to Diff 232355. MarkMurrayARM added a comment. Correct name of intrinsics in commit message. D'oh! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71066/new/ https://reviews.llvm.org/D71066 Files: clang/include/

[clang] 5c517a6 - [OPENMP50]Add support for if clause for simd part in parallel master taskloop simd directive.

Author: Alexey Bataev Date: 2019-12-05T11:32:33-05:00 New Revision: 5c517a6b13bfee99e054128231ddf64e70e5a6ab URL: https://github.com/llvm/llvm-project/commit/5c517a6b13bfee99e054128231ddf64e70e5a6ab DIFF: https://github.com/llvm/llvm-project/commit/5c517a6b13bfee99e054128231ddf64e70e5a6ab.diff

[PATCH] D60499: [ASTImporter] Various source location and range import fixes.

This revision was automatically updated to reflect the committed changes. Closed by commit rGa9f10ebffaa2: [ASTImporter] Various source location and range import fixes. (authored by balazske). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60499/new/

[PATCH] D70726: [OpenMP50] Add parallel master construct

ABataev added inline comments. Comment at: clang/test/OpenMP/parallel_master_codegen.cpp:144 +// CK4: [[A_VAL:%.+]] = alloca i32 +// CK4: [[A_CASTED:%.+]] = alloca i{{32|64}} +// CK4: [[ZERO:%.+]] = load i32, i32* [[A_VAL]] I think it would be b

[clang] 8994d63 - [scan-build-py] Set of small fixes

Author: Gabor Horvath Date: 2019-12-05T09:00:16-08:00 New Revision: 8994d632c8d31d527490e8693b0881d9278464e6 URL: https://github.com/llvm/llvm-project/commit/8994d632c8d31d527490e8693b0881d9278464e6 DIFF: https://github.com/llvm/llvm-project/commit/8994d632c8d31d527490e8693b0881d9278464e6.diff

[PATCH] D70919: [Hexagon] Avoid passing unsupported options to lld when -fuse-ld=lld is used

bcain added inline comments. Comment at: clang/lib/Driver/ToolChains/Hexagon.cpp:212 bool UseG0 = false; + bool UseLLD = Args.getLastArgValue(options::OPT_fuse_ld_EQ).startswith("lld"); bool UseShared = IsShared && !IsStatic; Does this still work when `-f

[PATCH] D70693: [scan-build-py] Set of small fixes

This revision was automatically updated to reflect the committed changes. Closed by commit rG8994d632c8d3: [scan-build-py] Set of small fixes (authored by xazax.hun). Changed prior to commit: https://reviews.llvm.org/D70693?vs=230960&id=232364#toc Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D71042: WIP: [DebugInfo] Ensure fallback artificial location is available for cleanups

aprantl added a comment. This will definitely work; Once you got the testcase, it might be good to check whether there is a more targeted root cause that we could fix and assert on EndLoc here. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71042/new/ https://reviews.llvm.org/D71042

[PATCH] D71066: [ARM][MVE][Intrinsics] Add VMULL[BT]Q_(INT|POLY) intrinsics.

miyuki added inline comments. Comment at: llvm/lib/Target/ARM/ARMInstrMVE.td:286 + // The LLVM ValueType representing the vector double the size of Vec, + // so we can use it in ISel patterns. As I understand from the code below, the comment should say that t

[PATCH] D70500: [WebAssembly] Enable use of wasm-opt and LTO-enabled system libraries

dschuff added a comment. I do find it odd that there is a PATH fallback in the existing code in the first place. I agree that basically no compiler other than the "system" compiler should ever use it (and also even the concept of the "system" compiler really only makes much sense on systems lik

[PATCH] D71066: [ARM][MVE][Intrinsics] Add VMULL[BT]Q_(INT|POLY) intrinsics.

MarkMurrayARM updated this revision to Diff 232367. MarkMurrayARM added a comment. Address review comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71066/new/ https://reviews.llvm.org/D71066 Files: clang/include/clang/Basic/arm_mve.td cla

[PATCH] D70439: [Analyzer][Docs][NFC] Add CodeChecker to the command line tools

martong added inline comments. Comment at: clang/www/analyzer/codechecker.html:13 + + + NoQ wrote: > Note related to your patch, but SSI seem to be completely broken these days; > previously the dropdown menus header kept working on the front page but now > eve

[PATCH] D70439: [Analyzer][Docs][NFC] Add CodeChecker to the command line tools

martong updated this revision to Diff 232371. martong marked 15 inline comments as done. martong added a comment. Addressing Artem's review comments. Artem, thanks for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70439/new/ https://rev

[PATCH] D70726: [OpenMP50] Add parallel master construct

ABataev added inline comments. Comment at: clang/test/OpenMP/parallel_master_codegen.cpp:67 + +// CK2: define internal {{.*}}void [[OMP_OUTLINED]](i32* noalias %.global_tid., i32* noalias %.bound_tid.) +// CK2-NOT: __kmpc_global_thread_num Not the best i

[PATCH] D69950: Reapply "Fix crash on switch conditions of non-integer types in templates"

eandrews added a comment. In D69950#1770138 , @mstorsjo wrote: > This (when reapplied in > https://reviews.llvm.org/rG878a24ee244a24c39d1c57e9af2) broke compilation of > code that earlier built fine. A reduced example: > > namespace glslang { > class

[PATCH] D71042: [DebugInfo] Ensure fallback artificial location is available for cleanups

vsk updated this revision to Diff 232373. vsk retitled this revision from "WIP: [DebugInfo] Ensure fallback artificial location is available for cleanups" to "[DebugInfo] Ensure fallback artificial location is available for cleanups". vsk edited the summary of this revision. vsk added a comment.

[PATCH] D71042: [DebugInfo] Ensure fallback artificial location is available for cleanups

aprantl added a comment. Do we know why EndLoc is invalid? Comment at: clang/test/CodeGenObjCXX/property-object-cleanup.mm:3 +// RUN: %s -emit-llvm -o - | FileCheck %s + +@interface NSObject Add a comment `// Test that call in the cleanup block have a valid

[PATCH] D71042: [DebugInfo] Ensure fallback artificial location is available for cleanups

vsk added a comment. In D71042#1771040 , @aprantl wrote: > This will definitely work; Once you got the testcase, it might be good to > check whether there is a more targeted root cause that we could fix and > assert on EndLoc here. I believe the root c

[PATCH] D70823: [clang-tidy] Adding cert-pos34-c check

zukatsinadze marked an inline comment as done. zukatsinadze added inline comments. Comment at: clang-tools-extra/clang-tidy/cert/PutenvWithAutoCheck.cpp:27 + hasAutomaticStorageDuration(), + unless(hasDescendant(callExpr(callee(functionDecl(hasAn

[PATCH] D71042: [DebugInfo] Ensure fallback artificial location is available for cleanups

aprantl added a comment. Let me guess.. because setData: is synthesized? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71042/new/ https://reviews.llvm.org/D71042 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

  1   2   3   >